Re: [take12 0/3] kevent: Generic event handling mechanism.

2006-08-22 Thread Evgeniy Polyakov
On Wed, Aug 23, 2006 at 02:43:50AM +0200, Jari Sundell ([EMAIL PROTECTED]) wrote: > Actually, I didn't miss that, it is an orthogonal issue. A timespec > timeout parameter for the syscall does not imply the use of timespec > in any timer event, etc. Nor is there any timespec timer in kqueue's > st

Re: [take12 0/3] kevent: Generic event handling mechanism.

2006-08-22 Thread Evgeniy Polyakov
On Tue, Aug 22, 2006 at 04:46:19PM -0700, Ulrich Drepper ([EMAIL PROTECTED]) wrote: > DaveM says there are example programs for the current interfaces. I > must admit I haven't seen those either. So if possible, point the world > to them again. If you do that now I'll review everything and writ

Re: [PATCH] locking bug in fib_semantics.c

2006-08-22 Thread Jarek Poplawski
On Tue, Aug 22, 2006 at 12:35:56PM +0200, Jarek Poplawski wrote: ... > Hello, > I've found it at last but on that occasion I've got some > doubt according to rcu_read_lock and rcu_call treatment: ... Actually there is one more doubt (bug really, but not very probable): proc file reading is withou

Re: The Proposed Linux kevent API (was: Re: [take12 0/3] kevent: Generic event handling mechanism.)

2006-08-22 Thread Evgeniy Polyakov
On Tue, Aug 22, 2006 at 06:36:07PM -0700, Nicholas Miell ([EMAIL PROTECTED]) wrote: > == The Proposed Linux kevent API == > > The proposed Linux kevent API is a new unified event handling > interface, similar in spirit to Windows completion ports and Solaris > completion ports and similar in fac

Re: [take12 0/3] kevent: Generic event handling mechanism.

2006-08-22 Thread Albert Cahalan
Ulrich Drepper writes: I so far also haven't taken the time to look exactly at the interface. I plan to do it asap since this is IMO our big chance to get it right. I want to have a unifying interface which can handle all the different events we need and which come up today and tomorrow. We hav

Re: The Proposed Linux kevent API

2006-08-22 Thread Nicholas Miell
On Tue, 2006-08-22 at 20:47 -0700, Nicholas Miell wrote: > On Tue, 2006-08-22 at 20:31 -0700, David Miller wrote: > > From: Nicholas Miell <[EMAIL PROTECTED]> > > Date: Tue, 22 Aug 2006 18:36:07 -0700 > > > > > Dear DaveM, > > > > > > Go fuck yourself. > > > > I guess this is the bit that's su

Re: The Proposed Linux kevent API

2006-08-22 Thread Nicholas Miell
On Tue, 2006-08-22 at 20:31 -0700, David Miller wrote: > From: Nicholas Miell <[EMAIL PROTECTED]> > Date: Tue, 22 Aug 2006 18:36:07 -0700 > > > Dear DaveM, > > > > Go fuck yourself. > > I guess this is the bit that's supposed to make me take you seriously > :-) Of course. ^_^ -- Nicholas

Re: The Proposed Linux kevent API

2006-08-22 Thread David Miller
From: Nicholas Miell <[EMAIL PROTECTED]> Date: Tue, 22 Aug 2006 18:36:07 -0700 > Dear DaveM, > > Go fuck yourself. I guess this is the bit that's supposed to make me take you seriously :-) - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAI

Re: The Proposed Linux kevent API

2006-08-22 Thread Howard Chu
Nicholas Miell wrote: Having looked all this over to figure out what it actually does, I can make the following comments: - there's a distinct lack of any sort of commenting beyond brief descriptions of what the occasional function is supposed to do - the kevent interface is all the horror of t

Re: [take12 0/3] kevent: Generic event handling mechanism.

2006-08-22 Thread Nicholas Miell
On Tue, 2006-08-22 at 16:46 -0700, Ulrich Drepper wrote: > I so far also haven't taken the time to look exactly at the interface. > I plan to do it asap since this is IMO our big chance to get it right. > I want to have a unifying interface which can handle all the different > events we need and wh

The Proposed Linux kevent API (was: Re: [take12 0/3] kevent: Generic event handling mechanism.)

2006-08-22 Thread Nicholas Miell
On Tue, 2006-08-22 at 16:06 -0700, David Miller wrote: > With the time you spent writing this long email alone you could have > worked on either documenting Evgeniy's interfaces or trying to write > test applications against kevent to validate how useful the interfaces > are and if there are any pr

Re: [take12 0/3] kevent: Generic event handling mechanism.

2006-08-22 Thread Jari Sundell
On 8/23/06, David Miller <[EMAIL PROTECTED]> wrote: > There are system calls that take timespec, so I assume the magic is > already available for handling the timeout argument of kevent. System calls are one thing, they can be translated for these kinds of situations. But this doesn't help, and

ProxyARP and IPSec

2006-08-22 Thread H. Peter Anvin
Hello all, I am having a puzzlement combining ProxyARP and IPsec. Specificially, I want to take a single address from a local LAN and extend it via IPsec to another site. Unfortunately IPsec tunnels, unlike all other tunnels, don't have pseudo-devices associated with them. I understand thi

Re: [take12 0/3] kevent: Generic event handling mechanism.

2006-08-22 Thread David Miller
From: "Jari Sundell" <[EMAIL PROTECTED]> Date: Wed, 23 Aug 2006 02:28:32 +0200 > There are system calls that take timespec, so I assume the magic is > already available for handling the timeout argument of kevent. System calls are one thing, they can be translated for these kinds of situations.

Re: [take12 0/3] kevent: Generic event handling mechanism.

2006-08-22 Thread Jari Sundell
On 8/23/06, Alexey Kuznetsov <[EMAIL PROTECTED]> wrote: Let me explain, as a person who did this mistake and deeply regrets about this. F.e. in this case you just cannot use kevents in 32bit application on x86_64, unless you add the whole translation layer inside kevent core. Even when you deal

[PATCH] bridge-netfilter: don't overwrite memory outside of skb

2006-08-22 Thread Stephen Hemminger
The bridge netfilter code needs to check for space at the front of the skb before overwriting; otherwise if skb from device doesn't have headroom, then it will cause random memory corruption. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- linux-2.6.17.9.orig/include/linux/netfilter_brid

[PATCH 3/4] bridge-netfilter: simplify nf_bridge_pad

2006-08-22 Thread shemminger
Do some simple optimization on the nf_bridge_pad() function and don't use magic constants. Eliminate a double call and the #ifdef'd code for CONFIG_BRIDGE_NETFILTER. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- br-nf.orig/include/linux/netfilter_bridge.h 2006-08-22 16:46:47.0

[PATCH 4/4] bridge-netfilter: debug message fixes

2006-08-22 Thread shemminger
If CONFIG_NETFILTER_DEBUG is enabled, it shouldn't change the actions of the filtering. The message about skb->dst being NULL is commonly triggered by dhclient, so it is useless. Make sure all messages end in newline. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- br-nf.orig/net/bridge

[PATCH 2/4] bridge-netfilter: code rearrangement for clarity

2006-08-22 Thread shemminger
Cleanup and rearrangement for better style and clarity: Split the function nf_bridge_maybe_copy_header into two pieces Move copy portion out of line. Use Ethernet header size macros. Use header file to handle CONFIG_NETFILTER_BRIDGE differences Signed-off-by: Stephe

[PATCH 0/4] bridge-netfilter fixes

2006-08-22 Thread shemminger
This set of patches fixes issues with bridge netfilter code. First patch is for 2.6.18 and fixes a crash. Later patches could be deferred, they just cleanup the style, usage, etc. -- - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED]

[PATCH 1/4] bridge-netfilter: memory corruption fix

2006-08-22 Thread shemminger
The bridge-netfilter code will overwrite memory if there is not headroom in the skb to save the header. This first showed up when using Xen with sky2 driver that doesn't allocate the extra space. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- br-nf.orig/include/linux/netfilter_bridge.

[PATCH] bcm43xx-softmac - set correct value in mac_suspended for ifdown/ifup sequence

2006-08-22 Thread Larry Finger
John, Please apply this to wireless-2.6. Michael - bcm43xx-d80211 probably needs this as well. Larry --- When bcm43xx-softmac is given an ifdown/ifup sequence, the value for bcm->mac_suspended ends up wrong, which leads to a large number of ass

Re: Get rid of /proc/sys/net/unix/max_dgram_qlen

2006-08-22 Thread Indan Zupancic
On Wed, August 23, 2006 1:32, Alexey Kuznetsov said: >> Isn't a socket freed until all skb are handled? In which case the limit on >> the number of open >> files limits the total memory usage? (Same as with streaming sockets?) > > Alas. Number of closed sockets is not limited. Actually, it is lim

Re: [take12 0/3] kevent: Generic event handling mechanism.

2006-08-22 Thread Ulrich Drepper
I so far also haven't taken the time to look exactly at the interface. I plan to do it asap since this is IMO our big chance to get it right. I want to have a unifying interface which can handle all the different events we need and which come up today and tomorrow. We have to be able to handle not

Re: [take12 0/3] kevent: Generic event handling mechanism.

2006-08-22 Thread Andrew Morton
On Tue, 22 Aug 2006 15:17:47 -0700 (PDT) David Miller <[EMAIL PROTECTED]> wrote: > From: Andrew Morton <[EMAIL PROTECTED]> > Date: Tue, 22 Aug 2006 15:01:44 -0700 > > > If there _is_ something wrong with kqueue then let us identify those > > weaknesses and then diverge. > > Evgeniy already enume

Re: [PATCH] IP1000A: IC Plus update 2006-08-22

2006-08-22 Thread Francois Romieu
Jesse Huang <[EMAIL PROTECTED]> : > Dear All: > I had regenerate this patch from: > git://git.kernel.org/pub/scm/linux/kernel/git/penberg/netdev-ipg-2.6.git > > And, submit those modifications as one patch. The suggestion was probably to submit the whole driver as one patch to akpm for wider test

Re: Get rid of /proc/sys/net/unix/max_dgram_qlen

2006-08-22 Thread Alexey Kuznetsov
Hello! > Isn't a socket freed until all skb are handled? In which case the limit on > the number of open > files limits the total memory usage? (Same as with streaming sockets?) Alas. Number of closed sockets is not limited. Actually, it is limited by sk_max_ack_backlog*max_files, which is a lot

Re: [take12 0/3] kevent: Generic event handling mechanism.

2006-08-22 Thread Randy.Dunlap
On Tue, 22 Aug 2006 15:58:12 -0700 Nicholas Miell wrote: > On Tue, 2006-08-22 at 14:37 -0700, Randy.Dunlap wrote: > > On Tue, 22 Aug 2006 14:13:02 -0700 Nicholas Miell wrote: > > > > > On Wed, 2006-08-23 at 00:16 +0400, Evgeniy Polyakov wrote: > > > > On Tue, Aug 22, 2006 at 12:57:38PM -0700, Nic

Re: [take12 0/3] kevent: Generic event handling mechanism.

2006-08-22 Thread Alexey Kuznetsov
Hello! > >No way - timespec uses long. > > I must have missed that discussion. Please enlighten me in what regard > using an opaque type with lower resolution is preferable to a type > defined in POSIX for this sort of purpose. Let me explain, as a person who did this mistake and deeply regrets

Re: [take12 0/3] kevent: Generic event handling mechanism.

2006-08-22 Thread David Miller
From: Nicholas Miell <[EMAIL PROTECTED]> Date: Tue, 22 Aug 2006 15:58:12 -0700 > Honestly, somebody with enough clout to make it stick needs to write out > a spec describing what new kernel interfaces should look like and how > they should fit in with existing interfaces. With the time you spent

Re: [take12 0/3] kevent: Generic event handling mechanism.

2006-08-22 Thread Nicholas Miell
On Tue, 2006-08-22 at 14:25 -0700, David Miller wrote: > From: Nicholas Miell <[EMAIL PROTECTED]> > Date: Tue, 22 Aug 2006 14:13:40 -0700 > > > And how is the quality of the work to be judged if the work isn't > > commented, documented and explained, especially the userland-visible > > parts that

Re: [take12 0/3] kevent: Generic event handling mechanism.

2006-08-22 Thread Nicholas Miell
On Tue, 2006-08-22 at 14:37 -0700, Randy.Dunlap wrote: > On Tue, 22 Aug 2006 14:13:02 -0700 Nicholas Miell wrote: > > > On Wed, 2006-08-23 at 00:16 +0400, Evgeniy Polyakov wrote: > > > On Tue, Aug 22, 2006 at 12:57:38PM -0700, Nicholas Miell ([EMAIL > > > PROTECTED]) wrote: > > > > On Tue, 2006-0

Re: Get rid of /proc/sys/net/unix/max_dgram_qlen

2006-08-22 Thread Indan Zupancic
On Wed, August 23, 2006 0:34, Alexey Kuznetsov said: >> > It is the only protection of commiting infinite amount of memory to a >> > socket. >> >> Doesn't the "if (atomic_read(&sk->sk_wmem_alloc) < sk->sk_sndbuf)" check in >> sock_alloc_send_pskb() >> limit things already? > > Unfortunately, it do

Re: [take12 0/3] kevent: Generic event handling mechanism.

2006-08-22 Thread Jari Sundell
On 8/22/06, Evgeniy Polyakov <[EMAIL PROTECTED]> wrote: Word "polling" really confuses me here, but now I understand you. Such approach actually has unresolved issues - consider for example a situation when all provided events are ready immediately - what should be returned (as far as I recall th

[RFT] sky2: transmit complete alternative

2006-08-22 Thread Stephen Hemminger
Does the following get rid of the hang? Recode the transmit completion handling to avoid races between the hardware status report mechanism and the interrupt handler. Rather than relying on the index value in the status ring, read the chip register and cleanup all completed transmits. Re

Re: Get rid of /proc/sys/net/unix/max_dgram_qlen

2006-08-22 Thread Alexey Kuznetsov
Hello! > > It is the only protection of commiting infinite amount of memory to a > > socket. > > Doesn't the "if (atomic_read(&sk->sk_wmem_alloc) < sk->sk_sndbuf)" check in > sock_alloc_send_pskb() > limit things already? Unfortunately, it does not. You can open a socket, send something to a s

Re: [PATCH] wireless-dev: relax sysfs permissions

2006-08-22 Thread Greg KH
On Tue, Aug 22, 2006 at 04:47:40PM +0200, Jiri Benc wrote: > On Wed, 16 Aug 2006 15:49:45 +0200, Johannes Berg wrote: > > The sysfs attributes add_iface and remove_iface both check for > > CAP_NET_ADMIN whenever something is written. Hence, permissions for the > > files should be relaxed so that so

Re: Get rid of /proc/sys/net/unix/max_dgram_qlen

2006-08-22 Thread Indan Zupancic
On Tue, August 22, 2006 22:39, Alexey Kuznetsov said: > Feel free to do this correctly. :-) > Deleting "wrong" code rarely helps. > > It is the only protection of commiting infinite amount of memory to a socket. Doesn't the "if (atomic_read(&sk->sk_wmem_alloc) < sk->sk_sndbuf)" check in sock_allo

Re: [take12 0/3] kevent: Generic event handling mechanism.

2006-08-22 Thread David Miller
From: Andrew Morton <[EMAIL PROTECTED]> Date: Tue, 22 Aug 2006 15:01:44 -0700 > If there _is_ something wrong with kqueue then let us identify those > weaknesses and then diverge. Evgeniy already enumerated this, both on his web site and in the current thread. Unlike some people seem to imply, E

Re: [take12 0/3] kevent: Generic event handling mechanism.

2006-08-22 Thread Andrew Morton
On Tue, 22 Aug 2006 14:37:47 -0700 "Randy.Dunlap" <[EMAIL PROTECTED]> wrote: > On Tue, 22 Aug 2006 14:13:02 -0700 Nicholas Miell wrote: > > > On Wed, 2006-08-23 at 00:16 +0400, Evgeniy Polyakov wrote: > > > On Tue, Aug 22, 2006 at 12:57:38PM -0700, Nicholas Miell ([EMAIL > > > PROTECTED]) wrote:

Re: [PATCH 2.6.16.19 0/2] LARTC: trace control for netem

2006-08-22 Thread Stephen Hemminger
On Tue, 22 Aug 2006 16:32:33 +0200 Rainer Baumann <[EMAIL PROTECTED]> wrote: > This is the revised trace extension to the network emulator netem. > This extension provides emulation control based on pregenerated traces. > > We first submitted this patch on 2nd of August, in the mean time > we in

Re: [take12 0/3] kevent: Generic event handling mechanism.

2006-08-22 Thread Randy.Dunlap
On Tue, 22 Aug 2006 14:13:02 -0700 Nicholas Miell wrote: > On Wed, 2006-08-23 at 00:16 +0400, Evgeniy Polyakov wrote: > > On Tue, Aug 22, 2006 at 12:57:38PM -0700, Nicholas Miell ([EMAIL > > PROTECTED]) wrote: > > > On Tue, 2006-08-22 at 14:03 +0400, Evgeniy Polyakov wrote: > > > Of course, since

Re: [take12 0/3] kevent: Generic event handling mechanism.

2006-08-22 Thread David Miller
From: Nicholas Miell <[EMAIL PROTECTED]> Date: Tue, 22 Aug 2006 14:13:40 -0700 > And how is the quality of the work to be judged if the work isn't > commented, documented and explained, especially the userland-visible > parts that *cannot* *ever* *be* *changed* *or* *removed* once they're in > a s

Re: [take12 0/3] kevent: Generic event handling mechanism.

2006-08-22 Thread Nicholas Miell
On Wed, 2006-08-23 at 00:16 +0400, Evgeniy Polyakov wrote: > On Tue, Aug 22, 2006 at 12:57:38PM -0700, Nicholas Miell ([EMAIL PROTECTED]) > wrote: > > On Tue, 2006-08-22 at 14:03 +0400, Evgeniy Polyakov wrote: > > Of course, since you already know how all this stuff is supposed to > > work, you co

Re: [PATCH] Add wireless statics to bcm43xx-d80211

2006-08-22 Thread Larry Finger
Jiri Benc wrote: On Mon, 14 Aug 2006 08:29:08 -0500, Larry Finger wrote: This patch implements wireless statistics for bcm43xx using the d80211 stack.It also sets a framework for the implementation in other drivers that use the d80211 code. The component parts have been circulated on the netdev

Re: [take12 0/3] kevent: Generic event handling mechanism.

2006-08-22 Thread Nicholas Miell
On Tue, 2006-08-22 at 13:36 -0700, David Miller wrote: > From: Nicholas Miell <[EMAIL PROTECTED]> > Date: Tue, 22 Aug 2006 13:00:23 -0700 > > > I'm not the one proposing the new (potentially wrong) interface. The > > onus isn't on me. > > You can't demand a volunteer to do work, period. > > If i

Re: Get rid of /proc/sys/net/unix/max_dgram_qlen

2006-08-22 Thread Alexey Kuznetsov
Hello! > Either this, or it should be implemented correctly, which means poll needs > to be fixed to also check for max_dgram_qlen, Feel free to do this correctly. :-) Deleting "wrong" code rarely helps. It is the only protection of commiting infinite amount of memory to a socket. Alexey - To u

Re: [take12 0/3] kevent: Generic event handling mechanism.

2006-08-22 Thread David Miller
From: Nicholas Miell <[EMAIL PROTECTED]> Date: Tue, 22 Aug 2006 13:00:23 -0700 > I'm not the one proposing the new (potentially wrong) interface. The > onus isn't on me. You can't demand a volunteer to do work, period. If it matters to you, you have the option of doing the work. Otherwise you ca

Re: [Lksctp-developers] [PATCH 3/5][SCTP]: Remove multiple levels of msecs to jiffies conversions.

2006-08-22 Thread David Miller
From: Vlad Yasevich <[EMAIL PROTECTED]> Date: Tue, 22 Aug 2006 09:44:37 -0400 > Again, the variables exposed by the user interface have been and remain in > milliseconds. I misread the patch, sorry :) Thanks for clearing this up, I'll apply the patch. - To unsubscribe from this list: send the l

Re: [take12 0/3] kevent: Generic event handling mechanism.

2006-08-22 Thread Evgeniy Polyakov
On Tue, Aug 22, 2006 at 12:57:38PM -0700, Nicholas Miell ([EMAIL PROTECTED]) wrote: > On Tue, 2006-08-22 at 14:03 +0400, Evgeniy Polyakov wrote: > > On Tue, Aug 22, 2006 at 02:29:48AM -0700, Nicholas Miell ([EMAIL > > PROTECTED]) wrote: > > > > > Is any of this documented anywhere? I'd think that

Re: [take12 0/3] kevent: Generic event handling mechanism.

2006-08-22 Thread Nicholas Miell
On Tue, 2006-08-22 at 10:59 -0400, James Morris wrote: > On Tue, 22 Aug 2006, Nicholas Miell wrote: > > > In this brave new world of always stable kernel development, the time a > > new interface has for public testing before a new kernel release is > > drastically shorter than the old unstable de

Re: [take12 0/3] kevent: Generic event handling mechanism.

2006-08-22 Thread Nicholas Miell
On Tue, 2006-08-22 at 14:03 +0400, Evgeniy Polyakov wrote: > On Tue, Aug 22, 2006 at 02:29:48AM -0700, Nicholas Miell ([EMAIL PROTECTED]) > wrote: > > > > Is any of this documented anywhere? I'd think that any new userspace > > > > interfaces should have man pages explaining their use and some exa

Re: [take12 0/3] kevent: Generic event handling mechanism.

2006-08-22 Thread Evgeniy Polyakov
On Tue, Aug 22, 2006 at 09:14:30PM +0200, Jari Sundell ([EMAIL PROTECTED]) wrote: > Changing kevents are done with a separate system call from polling > afaics, thus every change requires a context switch. This in contrast > to BSD's kqueue which allows user-space to pass the changes when > kevent

Get rid of /proc/sys/net/unix/max_dgram_qlen

2006-08-22 Thread Indan Zupancic
Hello, Here's a patch to get rid of max_dgram_qlen proc option. All it does is slow down unix datagram packet sending, without giving the program any control over it. Applying it decreases code size, simplifies the code and makes poll behaviour more logical for connected datagram sockets in regar

Re: [take12 0/3] kevent: Generic event handling mechanism.

2006-08-22 Thread Jari Sundell
On 8/22/06, Evgeniy Polyakov <[EMAIL PROTECTED]> wrote: > Not to mention the name used causes (at least me) some confusion with BSD's > kqueue implementation. Skimming over the patches it actually looks somewhat > like kqueue with the more interesting features removed, like the ability to > pass

Re: [PATCH 16/18] d80211: get rid of MICHAEL_MIC_HWACCEL define

2006-08-22 Thread Jiri Benc
On Mon, 21 Aug 2006 09:41:23 +0200, Johannes Berg wrote: > The symbol MICHAEL_MIC_HWACCEL is always defined and hence > all the ifdefs using it are useless. This patch removes it. > > [...] > @@ -87,9 +84,7 @@ ieee80211_tx_h_michael_mic_add(struct ie > u16 fc; > struct sk_buff *skb = t

Re: [patch 4/5] d80211/bcm43xx: fix build for ARM

2006-08-22 Thread Michael Buesch
On Tuesday 22 August 2006 19:34, David Kimdon wrote: > ARM targets support udelay(N) where N <= 2000. > Use mdelay() when N >= 2000. > > Signed-off-by: David Kimdon <[EMAIL PROTECTED]> > > Index: wireless-dev/drivers/net/wireless/d80211/bcm43xx/bcm43xx_power.c > ==

Re: [PATCH 12/18] d80211: fix some sparse warnings

2006-08-22 Thread Jiri Benc
On Mon, 21 Aug 2006 09:41:19 +0200, Johannes Berg wrote: > This patch fixes some warnings from sparse in d80211. Also > fixes indentation in places near where the changes were. I can't say I like those nearby indentation fixes at this time, but I can live with it :-) Thanks, Jiri -- Jiri Benc

Re: [PATCH 01/18] d80211: LED triggers

2006-08-22 Thread Jiri Benc
On Tue, 22 Aug 2006 09:54:02 -0700, Jouni Malinen wrote: > Is someone using these or planning on using them? I have been open to > just removing all code due to lack of active use. I would apply the patch - it is an useful feature and it can be compiled out. Thanks, Jiri -- Jiri Benc SUSE Lab

Re: [PATCH 07/18] d80211: get rid of sta_aid in favour of keeping track of TIM

2006-08-22 Thread Jiri Benc
On Mon, 21 Aug 2006 09:41:14 +0200, Johannes Berg wrote: > I think this is not correct if a STA is removed for which packets > are buffered, but if it is still wrong then that case was never > correct to start with if the hw has a set_tim callback. You're right, good catch. Just minor things: >

Re: [take12 3/3] kevent: Timer notifications.

2006-08-22 Thread Evgeniy Polyakov
On Mon, Aug 21, 2006 at 04:25:49PM +0200, Thomas Gleixner ([EMAIL PROTECTED]) wrote: > > Not everymachine has them > > Every machine has hrtimers - not necessarily with high resolution timer > support, but the core code is there in any case and it is designed to > provide fine grained timers. >

Re: [take12 0/3] kevent: Generic event handling mechanism.

2006-08-22 Thread Evgeniy Polyakov
On Tue, Aug 22, 2006 at 06:57:05PM +0200, Jari Sundell ([EMAIL PROTECTED]) wrote: > On 8/22/06, Nicholas Miell <[EMAIL PROTECTED]> wrote: > > > > > >OK, so with literally a dozen different interfaces to queue events to > >userspace, all of which are apparently inadequate and in need of > >replacem

[patch 4/5] d80211/bcm43xx: fix build for ARM

2006-08-22 Thread David Kimdon
ARM targets support udelay(N) where N <= 2000. Use mdelay() when N >= 2000. Signed-off-by: David Kimdon <[EMAIL PROTECTED]> Index: wireless-dev/drivers/net/wireless/d80211/bcm43xx/bcm43xx_power.c === --- wireless-dev.orig/drivers/net

[patch 5/5] d80211: add ioctl to stop data frame tx

2006-08-22 Thread David Kimdon
This ioctl is used when radar is delected on a channel. Data frames must stop but management frames must be allowed to continue for some time to communicate the channel switch to stations. Signed-off-by: David Kimdon <[EMAIL PROTECTED]> Index: linux-2.6.16/net/d80211/hostapd_ioctl.h

[patch 1/5] d80211: allow for large scan results

2006-08-22 Thread David Kimdon
Fix a problem where incomplete scan results could be returned if the environment includes a large number of devices. Do not truncate the scan results and allow a result to contain more than IW_SCAN_MAX_DATA bytes. Signed-off-by: David Kimdon <[EMAIL PROTECTED]> Index: wireless-dev/net/d80211/iee

[patch 0/5] d80211 patches

2006-08-22 Thread David Kimdon
Hi, Here are some patches for d80211. Thanks, David -- - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

[patch 3/5] d80211: fix interface removal

2006-08-22 Thread David Kimdon
Calls to ieee80211_if_remove() should use the ieee80211 interface types. Convert interface type from hostapd to ieee80211 format. Signed-off-by: David Kimdon <[EMAIL PROTECTED]> Index: wireless-dev/net/d80211/ieee80211_ioctl.c === --

[patch 2/5] d80211: fix multiple device support

2006-08-22 Thread David Kimdon
Fix interpretation of dev_alloc_name() return value. dev_alloc_name() returns the number of the unit assigned or a negative errno code. Signed-off-by: David Kimdon <[EMAIL PROTECTED]> Index: wireless-dev/net/d80211/ieee80211_iface.c ===

[PATCH] pcnet32: break in 2.6.18-rc1 identified

2006-08-22 Thread Don Fry
A change I made for 2.6.17 and another for 2.6.18 do not work on older pcnet32 chips which I do not have access to. If the chip is a 79C970 or 79C965, do not try and suspend or check the link status. I have tested with a 79C970A, 79C971, 79C972, 79C973, 79C975, 79C976, and 79C978. Please apply to

Re: [take12 0/3] kevent: Generic event handling mechanism.

2006-08-22 Thread Jari Sundell
Not to mention the name used causes (at least me) some confusion with BSD's kqueue implementation. Skimming over the patches it actually looks somewhat like kqueue with the more interesting features removed, like the ability to pass the filter changes simultaneously with polling. Maybe this is a

Re: [take12 3/3] kevent: Timer notifications.

2006-08-22 Thread Thomas Gleixner
On Mon, 2006-08-21 at 15:18 +0400, Evgeniy Polyakov wrote: > On Mon, Aug 21, 2006 at 12:12:39PM +0100, Christoph Hellwig ([EMAIL > PROTECTED]) wrote: > > On Mon, Aug 21, 2006 at 02:19:49PM +0400, Evgeniy Polyakov wrote: > > > > > > > > > Timer notifications. > > > > > > Timer notifications can

Re: [PATCH 01/18] d80211: LED triggers

2006-08-22 Thread Jouni Malinen
On Mon, Aug 21, 2006 at 09:41:08AM +0200, Johannes Berg wrote: > This patch makes d80211 export LED triggers for rx/tx and introduces > functions to allow device drivers to query the trigger names for setting > default triggers. It also cleans up the Makefile LED related stuff. Is someone using th

Re: [PATCH 08/18] d80211: clean up exports

2006-08-22 Thread Jouni Malinen
On Mon, Aug 21, 2006 at 09:41:15AM +0200, Johannes Berg wrote: > This puts all EXPORT_SYMBOL() macros along with the function being exported, > and changes some exports that are only relevant to rate control modules > and to be GPL-only because they rate control modules need to be built against > t

Re: [PATCH 4/4] IP100A: Solve host error problem in low performance embedded system when continune down and up.

2006-08-22 Thread Randy.Dunlap
On Tue, 22 Aug 2006 14:31:32 -0400 Jesse Huang wrote: > From: Jesse Huang <[EMAIL PROTECTED]> > > Change Logs: >- Solve host error problem in low performance embedded > system when continune down and up. > > Signed-off-by: Jesse Huang <[EMAIL PROTECTED]> > > --- > > sundance.c | 3

Re: [RFC] add nl80211

2006-08-22 Thread Johannes Berg
On Tue, 2006-08-22 at 15:52 +0200, Johannes Berg wrote: > + /* make it complain if wiphy is set and is different or invalid */ > + if (info->attrs[NL80211_ATTR_IFINDEX]) { > + wiphy = nla_get_u32(info->attrs[NL80211_ATTR_IFINDEX]); That's what you get for writing code too quick

Re: [take12 0/3] kevent: Generic event handling mechanism.

2006-08-22 Thread James Morris
On Tue, 22 Aug 2006, Nicholas Miell wrote: > In this brave new world of always stable kernel development, the time a > new interface has for public testing before a new kernel release is > drastically shorter than the old unstable development series, and if > nobody is documenting how this stuff i

Re: [PATCH] wireless-dev: relax sysfs permissions

2006-08-22 Thread Jiri Benc
On Wed, 16 Aug 2006 15:49:45 +0200, Johannes Berg wrote: > The sysfs attributes add_iface and remove_iface both check for > CAP_NET_ADMIN whenever something is written. Hence, permissions for the > files should be relaxed so that someone who is not root but happens to > have CAP_NET_ADMIN can do th

[PATCH 2.6.16.19 2/2] LARTC: trace control for netem: kernelspace

2006-08-22 Thread Rainer Baumann
Trace Control for Netem: Emulate network properties such as long-dependency and self-similarity of cross-traffic. The delay, drop, duplication and corruption values are readout in user space and sent to kernel space via procfs. The kernel determines the time when new values should be sent by the u

[PATCH 2.6.16.19 1/2] LARTC: trace control for netem: userspace

2006-08-22 Thread Rainer Baumann
Trace Control for Netem: Emulate network properties such as long-dependency and self-similarity of cross-traffic. The directory tc/netem was split in two parts, one containing the original distributions and the other the tools to generate trace files as well as the program responsible for reading

[PATCH 2.6.16.19 0/2] LARTC: trace control for netem

2006-08-22 Thread Rainer Baumann
This is the revised trace extension to the network emulator netem. This extension provides emulation control based on pregenerated traces. We first submitted this patch on 2nd of August, in the mean time we integrated the comments from Stephen and fixed the listed things. Cheers, Rainer --

Re: [take9 2/2] kevent: poll/select() notifications. Timer notifications.

2006-08-22 Thread Davide Libenzi
On Wed, 16 Aug 2006, Christoph Hellwig wrote: On Mon, Aug 14, 2006 at 10:21:36AM +0400, Evgeniy Polyakov wrote: poll/select() notifications. Timer notifications. This patch includes generic poll/select and timer notifications. kevent_poll works simialr to epoll and has the same issues (callb

Re: [2.6.19 PATCH 3/7] ehea: queue management

2006-08-22 Thread Jan-Bernd Themann
Hi, On Tuesday 22 August 2006 16:01, Arnd Bergmann wrote: > > +   u64 rpage = 0; > > +   int ret; > > +   int cnt = 0; > > +   void *vpage = NULL; > > + > > +   ret = hw_queue_ctor(hw_queue, nr_pages, EHEA_PAGESIZE, wqe_size); > > +   if (ret) > > +   return ret

Re: [PATCH] Add wireless statics to bcm43xx-d80211

2006-08-22 Thread Jiri Benc
On Mon, 14 Aug 2006 08:29:08 -0500, Larry Finger wrote: > This patch implements wireless statistics for bcm43xx using the d80211 > stack.It > also sets a framework for the implementation in other drivers that use the > d80211 code. The component parts have been circulated on the netdev mailing

[RFC] make d80211 use nl80211

2006-08-22 Thread Johannes Berg
This patch makes d80211 partially configurable using the infrastructure that nl80211 provides. So far, it allows packet injection and adding/removing virtual interfaces. Signed-off-by: Johannes Berg <[EMAIL PROTECTED]> --- wireless-dev.orig/net/d80211/Kconfig2006-08-22 15:47:46.0

[RFC] add nl80211

2006-08-22 Thread Johannes Berg
This patch adds nl80211, a netlink based configuration system for wireless hardware. It currently features a few helper commands and commands to add and remove virtual interfaces and to inject packets. Support for nl80211 in d80211 is in a follow-up patch. It requires the patches in http://marc.t

Re: [Lksctp-developers] [PATCH 3/5][SCTP]: Remove multiple levels of msecs to jiffies conversions.

2006-08-22 Thread Vlad Yasevich
On Tue August 22 2006 03:22, David Miller wrote: > From: Sridhar Samudrala <[EMAIL PROTECTED]> > Date: Fri, 18 Aug 2006 11:22:37 -0700 > > > [SCTP]: Remove multiple levels of msecs to jiffies conversions. > > > > The SCTP sysctl entries are displayed in milliseconds, but stored > > internally in ji

Re: 800+ byte inlines in include/net/pkt_act.h

2006-08-22 Thread jamal
On Mon, 2006-21-08 at 16:38 -0700, David Miller wrote: > From: jamal <[EMAIL PROTECTED]> > Date: Mon, 21 Aug 2006 08:26:00 -0400 > > > As per last discussion, either Patrick McHardy or myself are going > > to work on it - at some point. Please be patient. The other > > alternative is: you fix it a

[2.6.19 PATCH 7/7] ehea: Makefile & Kconfig

2006-08-22 Thread Jan-Bernd Themann
Signed-off-by: Jan-Bernd Themann <[EMAIL PROTECTED]> drivers/net/Kconfig |9 + drivers/net/Makefile |1 + 2 files changed, 10 insertions(+) diff -Nurp -X dontdiff linux-2.6.18-rc4-git1/drivers/net/Kconfig patched_kernel/drivers/net/Kconfig --- linux-2.6.18-rc4-git1/drivers/

[RESEND 1/2] [NETLINK]: Improve string attribute validation

2006-08-22 Thread Thomas Graf
Searching for '\0' with strnchr() doesn't really work :-) Introduces a new attribute type NLA_NUL_STRING to support NUL terminated strings. Attributes of this kind require to carry a terminating NUL within the maximum specified in the policy. The `old' NLA_STRING which is not required to be NUL t

[2.6.19 PATCH 6/7] ehea: eHEA Makefile

2006-08-22 Thread Jan-Bernd Themann
Signed-off-by: Jan-Bernd Themann <[EMAIL PROTECTED]> drivers/net/ehea/Makefile |7 +++ 1 file changed, 7 insertions(+) --- linux-2.6.18-rc4-git1-orig/drivers/net/ehea/Makefile1969-12-31 16:00:00.0 -0800 +++ kernel/drivers/net/ehea/Makefile2006-08-22 06:05:26.9650

[2.6.19 PATCH 5/7] ehea: main header files

2006-08-22 Thread Jan-Bernd Themann
Signed-off-by: Jan-Bernd Themann <[EMAIL PROTECTED]> drivers/net/ehea/ehea.h| 437 + drivers/net/ehea/ehea_hw.h | 290 + 2 files changed, 727 insertions(+) --- linux-2.6.18-rc4-git1-orig/drivers/net/ehea/ehea.h 19

[2.6.19 PATCH 3/7] ehea: queue management

2006-08-22 Thread Jan-Bernd Themann
Signed-off-by: Jan-Bernd Themann <[EMAIL PROTECTED]> drivers/net/ehea/ehea_qmr.c | 634 drivers/net/ehea/ehea_qmr.h | 367 + 2 files changed, 1001 insertions(+) --- linux-2.6.18-rc4-git1-orig/drivers/net/ehea/ehea_qmr.c

[2.6.19 PATCH 2/7] ehea: pHYP interface

2006-08-22 Thread Jan-Bernd Themann
Signed-off-by: Jan-Bernd Themann <[EMAIL PROTECTED]> drivers/net/ehea/ehea_hcall.h | 51 ++ drivers/net/ehea/ehea_phyp.c | 834 ++ drivers/net/ehea/ehea_phyp.h | 479 3 files changed, 1364 insertions(+) --- linux-2.6.18-r

[2.6.19 PATCH 4/7] ehea: ethtool interface

2006-08-22 Thread Jan-Bernd Themann
Signed-off-by: Jan-Bernd Themann <[EMAIL PROTECTED]> drivers/net/ehea/ehea_ethtool.c | 244 1 file changed, 244 insertions(+) --- linux-2.6.18-rc4-git1-orig/drivers/net/ehea/ehea_ethtool.c 1969-12-31 16:00:00.0 -0800 +++ kernel/drivers/net/

[2.6.19 PATCH 0/7] ehea: IBM eHEA Ethernet Device Driver

2006-08-22 Thread Jan-Bernd Themann
Hi, this is our current version of the IBM eHEA Ethernet Device Driver. Thanks for the quick and helpful comments so far. Further comments are highly appreciated. Things we are currently working on: - Implementation of promiscious mode support Thanks, Jan-Bernd Signed-off-by: Jan-Bernd Themann

[PATCH 1/2] [NETLINK]: Improve string attribute validation

2006-08-22 Thread Thomas Graf
Introduces a new attribute type NLA_NUL_STRING to support NUL terminated strings. Attributes of this kind require to carry a terminating NUL within the maximum specified in the policy. The `old' NLA_STRING which is not required to be NUL terminated is extended to provide means to specify a maximum

[PATCHSET] Validation for netlink string attributes

2006-08-22 Thread Thomas Graf
Validation of netlink string attributes was weak, forcing everyone to use nla_strlcpy() to copy the attribute into a temporary buffer. This patchset implements length validation checks for existing NLA_STRING attributes and adds a new type NLA_NUL_STRING for NUL terminated strings. - To unsubscri

[PATCH][REPOST] WAN: fix C101 card carrier handling

2006-08-22 Thread Krzysztof Halasa
Hi, One of my recent changes broke C101 carrier handling, this patch fixes it. Also fixes an old TX underrun checking bug. 2.6.18 material. Please apply. Thanks. Signed-off-by: Krzysztof Halasa <[EMAIL PROTECTED]> diff --git a/drivers/net/wan/c101.c b/drivers/net/wan/c101.c index 435e91e..6b63b

[PATCH 2/2] [NETLINK]: Make use of NLA_STRING/NLA_NUL_STRING attribute validation

2006-08-22 Thread Thomas Graf
Converts existing NLA_STRING attributes to use the new validation features, saving a couple of temporary buffers. Signed-off-by: Thomas Graf <[EMAIL PROTECTED]> Index: net-2.6.19.git/net/core/rtnetlink.c === --- net-2.6.19.git.orig/n

Re: [PATCH] kevent_user: remove non-chardev interface

2006-08-22 Thread Evgeniy Polyakov
On Tue, Aug 22, 2006 at 01:27:31PM +0100, Christoph Hellwig ([EMAIL PROTECTED]) wrote: > On Tue, Aug 22, 2006 at 04:17:10PM +0400, Evgeniy Polyakov wrote: > > I personally do not have objections against it, but it introduces > > additional complexies - one needs to open /dev/kevent and then perfor

  1   2   >