Re: [RFC] d80211 LED handling

2006-08-17 Thread Johannes Berg
On Thu, 2006-08-17 at 17:30 +0200, Jiri Benc wrote: > How is the driver supposed to add its led handlers? The driver just adds an LED device. And then we only need to set the default trigger correctly. > Using generic led triggers is probably interesting for cases when system > has some separate

Re: [PATCH] net: restrict device names from having whitespace

2006-08-17 Thread David Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Thu, 17 Aug 2006 23:11:27 -0700 > Don't allow spaces in network device names because it makes > it difficult to provide text interfaces via sysfs. > > Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> I have a patch which does this in my tree

Re: [PATCH 2/7] ip1000: remove some default phy params

2006-08-17 Thread Jesse Huang
Hi David: Ok, I will add sign-off-by latter. Thanks for that. Jesse Huang - Original Message - From: "David Gomez" <[EMAIL PROTECTED]> To: "Jesse Huang" <[EMAIL PROTECTED]> Cc: <[EMAIL PROTECTED]>; <[EMAIL PROTECTED]>; <[EMAIL PROTECTED]>; <[EMAIL PROTECTED]>; ; Sent: Thursday, August 1

Re: [PATCH 1/6] IP100A, add end of pci id table

2006-08-17 Thread Jesse Huang
Hi Alexey: I will remove that. Thanks for that. Jesse Huang - Original Message - From: "Alexey Dobriyan" <[EMAIL PROTECTED]> To: "Jesse Huang" <[EMAIL PROTECTED]> Cc: ; ; <[EMAIL PROTECTED]>; <[EMAIL PROTECTED]> Sent: Thursday, August 17, 2006 11:19 PM Subject: Re: [PATCH 1/6] IP100A, a

Re: [PATCH 5/6] IP100A correct init and close step

2006-08-17 Thread Jesse Huang
Hi Jeff: (1)Should I change to : spin_lock_irqsave(&np->lock,flags); reset_tx(dev); spin_lock_irqrestore(&np->lock,flags); (2)I will remove date and author information out of source code comment. - Original Message - From: "Jeff Garzik" <[EMAIL PROTECTED]> To: "Jesse Huang" <[EMAIL PROTE

[PATCH] net: restrict device names from having whitespace

2006-08-17 Thread Stephen Hemminger
Don't allow spaces in network device names because it makes it difficult to provide text interfaces via sysfs. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- net/core/dev.c | 24 1 files changed, 20 insertions(+), 4 deletions(-) diff --git a/net/core/dev.c b/

Re: [RFC][PATCH 2/9] deadlock prevention core

2006-08-17 Thread Andrew Morton
On Thu, 17 Aug 2006 16:53:01 -0700 Daniel Phillips <[EMAIL PROTECTED]> wrote: > Andrew Morton wrote: > > Daniel Phillips <[EMAIL PROTECTED]> wrote: > >>What happened to the case where we just fill memory full of dirty file > >>pages backed by a remote disk? > > > > Processes which are dirtying th

Re: crash in ipt_do_table

2006-08-17 Thread David Miller
From: Patrick McHardy <[EMAIL PROTECTED]> Date: Fri, 18 Aug 2006 07:45:59 +0200 > Thanks, but it seems you applied the first patch I sent, which was > missing the same fix for arp_tables. This patch contains the missing > bits. > > I'm going to send the (combined) patch to -stable as well, this b

Re: [PATCH 1/6] IP100A, add end of pci id table

2006-08-17 Thread Jesse Huang
Hi Jeff: Sorry for that. I will remove those. Am I need to resent all of those patch or send all in one patch? Jesse Huang. - Original Message - From: "Jeff Garzik" <[EMAIL PROTECTED]> To: "Jesse Huang" <[EMAIL PROTECTED]> Cc: ; ; <[EMAIL PROTECTED]> Sent: Thursday, August 17, 2006

Re: [PATCH 1/7] ip1000: update maintainer information

2006-08-17 Thread Jesse Huang
Hi Pekka: OK, I will generate a patch from to your git. And add sign-off-by in the mail. Thanks for that. Jesse Huang - Original Message - From: "Pekka Enberg" <[EMAIL PROTECTED]> To: "Jesse Huang" <[EMAIL PROTECTED]> Cc: <[EMAIL PROTECTED]>; <[EMAIL PROTECTED]>; <[EMAIL PROTECTED]

Re: crash in ipt_do_table

2006-08-17 Thread Patrick McHardy
David Miller wrote: > From: Patrick McHardy <[EMAIL PROTECTED]> > Date: Tue, 15 Aug 2006 16:01:06 +0200 > > >>Any chance you're also changing your ruleset dynamically? If yes >>this patch might help. > > > I've applied this. Thanks, but it seems you applied the first patch I sent, which was mi

Re: time stamps of skb packets in NF_HOOKS callbacks

2006-08-17 Thread John Que
Evgeniy, Sorry ! ; last sentence in my reply was chopped so here is my message again with this last sentence (complete this time) Thnks, I appreciate your (quick) answer; Following your answer I tried adding a call to net_enable_timestamp() in a module I wrote which use NF_HOOKS. This is what i

Re: time stamps of skb packets in NF_HOOKS callbacks

2006-08-17 Thread John Que
Evgeniy, Thnks, I appreciate your (quick) answer; Following your answer I tried adding a call to net_enable_timestamp() in a module I wrote which use NF_HOOKS. This is what is done , for example, in ipq_rcv_skb(struct sk_buff *skb) in linux-2.6.14 in net/ipv4/netfilter/ip_queue.c. After doing so

Re: bonding: cannot remove certain named devices

2006-08-17 Thread Stephen Hemminger
Bill Nottingham wrote: David Miller ([EMAIL PROTECTED]) said: From: Xavier Bestel <[EMAIL PROTECTED]> Date: Thu, 17 Aug 2006 09:29:43 +0200 Why not simply retricting chars to isalnum() ones ? As Bill said that would block things like "-" and "_" which are fine. Bill also menti

Re: [PATCH 1/1] network memory allocator.

2006-08-17 Thread Christoph Lameter
On Wed, 16 Aug 2006, Andi Kleen wrote: > That's not true on all NUMA systems (that they have a slow interconnect) > I think on x86-64 I would prefer if it was distributed evenly or maybe even > on the CPU who is finally going to process it. > > -Andi "not all NUMA is an Altix" The Altix NUMA in

Re: bonding: cannot remove certain named devices

2006-08-17 Thread Bill Nottingham
David Miller ([EMAIL PROTECTED]) said: > From: Xavier Bestel <[EMAIL PROTECTED]> > Date: Thu, 17 Aug 2006 09:29:43 +0200 > > > Why not simply retricting chars to isalnum() ones ? > > As Bill said that would block things like "-" and "_" which are fine. > > Bill also mentioned something about "b

Re: [PATCH] locking bug in fib_semantics.c

2006-08-17 Thread David Miller
From: Alexey Kuznetsov <[EMAIL PROTECTED]> Date: Thu, 17 Aug 2006 13:36:15 +0400 > Found in 2.4 by Yixin Pan <[EMAIL PROTECTED]>. Why do we need lockdep, > when sharp-sighted eyes are available? :-) Lockdep can only tell us about code paths which actually have been run, so it shows that nobody ru

Re: [Bug 6936] BUG: warning at net/core/dev.c:1171/skb_checksum_help()

2006-08-17 Thread David Miller
From: Herbert Xu <[EMAIL PROTECTED]> Date: Wed, 16 Aug 2006 11:29:00 +1000 > On Tue, Aug 15, 2006 at 11:29:59AM -0700, [EMAIL PROTECTED] wrote: > > http://bugzilla.kernel.org/show_bug.cgi?id=6936 > > It's actually a bug in the bridging code :) > > [BRIDGE]: Disable SG/GSO if TX checksum is off

Re: [PATCH] neighbour: reduce exports

2006-08-17 Thread David Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Tue, 15 Aug 2006 12:56:30 -0700 > There are several symbols only used by rtnetlink and since it can > not be a module, there is no reason to export them. > > Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> Applied. > -static __inline__ void

Re: [PATCHSET] IPv4 FIB configuration conversions

2006-08-17 Thread David Miller
From: Thomas Graf <[EMAIL PROTECTED]> Date: Tue, 15 Aug 2006 16:57:23 +0200 > Replaces the rather ugly struct kern_rta + rtmsg with a new > struct fib_config while converting everything to the new netlink > api. Simplifies the FIB module interface quite a bit and allows > changing internals while

Re: [PATCH] eth: indentation and cleanup (revised)

2006-08-17 Thread David Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Tue, 15 Aug 2006 14:05:52 -0700 > Run ethernet support through Lindent and fix up. > Applies after docbook comments patch > > Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> Applied, thanks a lot. - To unsubscribe from this list: send the l

Re: [PATCH] eth: docbook comments

2006-08-17 Thread David Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Tue, 15 Aug 2006 12:57:59 -0700 > Add docbook style comments to ethernet support. > > Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> Applied, thanks Stephen. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body o

Re: [RFC][PATCH 2/9] deadlock prevention core

2006-08-17 Thread Neil Brown
On Thursday August 17, [EMAIL PROTECTED] wrote: > Andrew Morton wrote: > > Daniel Phillips <[EMAIL PROTECTED]> wrote: > >>What happened to the case where we just fill memory full of dirty file > >>pages backed by a remote disk? > > > > Processes which are dirtying those pages throttle at > > /proc

Re: crash in ipt_do_table

2006-08-17 Thread David Miller
From: Patrick McHardy <[EMAIL PROTECTED]> Date: Tue, 15 Aug 2006 16:01:06 +0200 > Any chance you're also changing your ruleset dynamically? If yes > this patch might help. I've applied this. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PRO

Re: bonding: cannot remove certain named devices

2006-08-17 Thread David Miller
From: Alan Cox <[EMAIL PROTECTED]> Date: Fri, 18 Aug 2006 01:34:43 +0100 > Ar Iau, 2006-08-17 am 16:23 -0700, ysgrifennodd David Miller: > > All you "name purists", go rename the block device name that is used > > for your root partition to something with a space in it > > Works fine. It doesn't

Re: [RFC][PATCH 2/9] deadlock prevention core

2006-08-17 Thread Daniel Phillips
Daniel Phillips wrote: Andrew Morton wrote: Processes which are dirtying those pages throttle at /proc/sys/vm/dirty_ratio% of memory dirty. So it is not possible to "fill" memory with dirty pages. If the amount of physical memory which is dirty exceeds 40%: bug. So we make 400 MB of a 1 GB s

Re: [RFC][PATCH 2/9] deadlock prevention core

2006-08-17 Thread Rik van Riel
Daniel Phillips wrote: Andrew Morton wrote: Daniel Phillips <[EMAIL PROTECTED]> wrote: What happened to the case where we just fill memory full of dirty file pages backed by a remote disk? Processes which are dirtying those pages throttle at /proc/sys/vm/dirty_ratio% of memory dirty. So it i

Re: bonding: cannot remove certain named devices

2006-08-17 Thread Alan Cox
Ar Iau, 2006-08-17 am 16:23 -0700, ysgrifennodd David Miller: > Nobody in their right mind puts a space in their network device name. It works fine. Been there done that. I'm probably not in my right mind but it causes no problems. Nor btw does UTF-8 naming which is handy if you want to name your

I/OAT configuration ?

2006-08-17 Thread Ravinandan Arakali
Hi, I am trying to use I/OAT on one of the newer woodcrest boxes. But not sure if things are configured properly since there seems to be no change in performance with I/OAT enabled or disabled. Following are the steps followed. 1. MSI (CONFIG_PCI_MSI) is enabled in kernel(2.6.16.21). 2. In kernel D

Re: [RFC][PATCH 2/9] deadlock prevention core

2006-08-17 Thread Daniel Phillips
Andrew Morton wrote: Daniel Phillips <[EMAIL PROTECTED]> wrote: What happened to the case where we just fill memory full of dirty file pages backed by a remote disk? Processes which are dirtying those pages throttle at /proc/sys/vm/dirty_ratio% of memory dirty. So it is not possible to "fill"

Re: proposal for new wireless configuration API

2006-08-17 Thread Ulrich Kunitz
On 06-08-15 18:38 Michael Buesch wrote: > On Tuesday 15 August 2006 18:29, Dan Williams wrote: > > o Separate attributes for channel and frequency > > No, channel and freq is the same. It's just another name > for the same child. I would say we only want to deal with channel numbers > in the API.

Re: [PATCH] Re: Possible leak of multicast source filter sctructure

2006-08-17 Thread David Miller
From: David Stevens <[EMAIL PROTECTED]> Date: Tue, 15 Aug 2006 17:57:58 -0600 > Here's a patch to fix source filter leakage when a device is removed > and a process leaves the group thereafter. (2nd part of prior discussion) > > This patch also includes corresponding fixes for IPv6 multicast sour

Re: [RFC][PATCH 0/9] Network receive deadlock prevention for NBD

2006-08-17 Thread Daniel Phillips
Evgeniy Polyakov wrote: On Thu, Aug 17, 2006 at 09:15:14PM +0200, Peter Zijlstra ([EMAIL PROTECTED]) wrote: I got openssh as example of situation when system does not know in advance, what sockets must be marked as critical. OpenSSH works with network and unix sockets in parallel, so you need

Re: bonding: cannot remove certain named devices

2006-08-17 Thread David Miller
From: Xavier Bestel <[EMAIL PROTECTED]> Date: Thu, 17 Aug 2006 09:29:43 +0200 > Why not simply retricting chars to isalnum() ones ? As Bill said that would block things like "-" and "_" which are fine. Bill also mentioned something about "breaking configs going back to 2.4.x" which is bogus beca

Re: proposal for new wireless configuration API

2006-08-17 Thread Ulrich Kunitz
On 06-08-17 09:42 Simon Barber wrote: > The spec for RSSI is very loose - RSSI is just a 8 bit unsigned number, > guaranteed to be a monotonically increasing function of signal strength. > You don't get to know anything about the scale, or linearity of the > function. In essence RSSI is a vendor s

Re: proposal for new wireless configuration API

2006-08-17 Thread Michael Buesch
On Thursday 17 August 2006 21:39, Jean Tourrilhes wrote: > On Tue, Aug 15, 2006 at 09:13:23PM +0200, Michael Buesch wrote: > > On Tuesday 15 August 2006 20:14, Dan Williams wrote: > > > On Tue, 2006-08-15 at 18:38 +0200, Michael Buesch wrote: > > > > On Tuesday 15 August 2006 18:29, Dan Williams wr

Re: [RFC][PATCH 50/75] net: drivers/net/wan/pci200syn.c pci_module_init to pci_register_driver conversion

2006-08-17 Thread Krzysztof Halasa
Krzysztof Halasa <[EMAIL PROTECTED]> writes: > Ok. Rozumiem, ze Jeff zrobi to w jednym, duzym batchu? Oops, hit the wrong key. Ok WRT both patches and assume Jeff will apply this all-at-once. -- Krzysztof Halasa - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of

InfiniBand merge plans for 2.6.19

2006-08-17 Thread Roland Dreier
Here's a short summary of what I plan to merge for 2.6.19. Some of this is already in infiniband.git[1], while some still needs to be merged up. Highlights: o iWARP core support[2]. This updates drivers/infiniband to work with devices that do RDMA over IP/ethernet in addition to

Re: [RFC][PATCH 0/9] Network receive deadlock prevention for NBD

2006-08-17 Thread Evgeniy Polyakov
On Thu, Aug 17, 2006 at 09:15:14PM +0200, Peter Zijlstra ([EMAIL PROTECTED]) wrote: > > I got openssh as example of situation when system does not know in > > advance, what sockets must be marked as critical. > > OpenSSH works with network and unix sockets in parallel, so you need to > > hack ope

Re: proposal for new wireless configuration API

2006-08-17 Thread Jean Tourrilhes
On Tue, Aug 15, 2006 at 09:13:23PM +0200, Michael Buesch wrote: > On Tuesday 15 August 2006 20:14, Dan Williams wrote: > > On Tue, 2006-08-15 at 18:38 +0200, Michael Buesch wrote: > > > On Tuesday 15 August 2006 18:29, Dan Williams wrote: > > > > o Separate attributes for channel and frequency > >

Re: [RFC][PATCH 50/75] net: drivers/net/wan/pci200syn.c pci_module_init to pci_register_driver conversion

2006-08-17 Thread Krzysztof Halasa
Michal Piotrowski <[EMAIL PROTECTED]> writes: > +++ linux-work2/drivers/net/wan/wanxl.c > +++ linux-work2/drivers/net/wan/pci200syn.c > - return pci_module_init(&pci200_pci_driver); > + return pci_register_driver(&pci200_pci_driver); Ok. Rozumiem, ze Jeff zrobi to w jednym, duzym batchu?

Re: [RFC][PATCH 0/9] Network receive deadlock prevention for NBD

2006-08-17 Thread Peter Zijlstra
On Thu, 2006-08-17 at 22:42 +0400, Evgeniy Polyakov wrote: > On Thu, Aug 17, 2006 at 11:01:52AM -0700, Daniel Phillips ([EMAIL PROTECTED]) > wrote: > > *** The system is not OOM, it is in reclaim, a transient condition *** > > It does not matter how condition when not every user can get memory is

Re: [RFC][PATCH 0/9] Network receive deadlock prevention for NBD

2006-08-17 Thread Evgeniy Polyakov
On Thu, Aug 17, 2006 at 11:01:52AM -0700, Daniel Phillips ([EMAIL PROTECTED]) wrote: > *** The system is not OOM, it is in reclaim, a transient condition *** It does not matter how condition when not every user can get memory is called. And actually no one can know in advance how long it will be.

Re: d80211 and sta_aid for AP functionality

2006-08-17 Thread Jiri Benc
On Mon, 14 Aug 2006 10:19:24 +0200, Johannes Berg wrote: > Looking through the code, I notice that above (a) and (b) can be > collapsed into just keeping track of the TIM throughout the code. I > suppose that's meant by the comment above? Then we can't add the check > for saying 'hey you stupid

Re: [RFC][PATCH 0/9] Network receive deadlock prevention for NBD

2006-08-17 Thread Daniel Phillips
Evgeniy Polyakov wrote: Just for clarification - it will be completely impossible to login using openssh or some other priveledge separation protocol to the machine due to the nature of unix sockets. So you will be unable to manage your storage system just because it is in OOM - it is not what i

RE: proposal for new wireless configuration API

2006-08-17 Thread Simon Barber
The spec for RSSI is very loose - RSSI is just a 8 bit unsigned number, guaranteed to be a monotonically increasing function of signal strength. You don't get to know anything about the scale, or linearity of the function. In essence RSSI is a vendor specific value, of no known units. Not very usef

Re: [RFC][PATCH 0/75] pci_module_init to pci_register_driver conversion

2006-08-17 Thread Greg KH
On Thu, Aug 17, 2006 at 08:35:12AM -0400, Jeff Garzik wrote: > Greg KH wrote: > >On Thu, Aug 17, 2006 at 04:26:35AM +, Michal Piotrowski wrote: > >>Hi, > >> > >>pci_module_init is obsolete. > >> > >>This patch series converts pci_module_init to pci_register_driver. > >> > >> > >>Can I remove th

Re: time stamps of skb packets in NF_HOOKS callbacks

2006-08-17 Thread Evgeniy Polyakov
On Thu, Aug 17, 2006 at 05:37:15PM +0300, John Que ([EMAIL PROTECTED]) wrote: > Hello, > I am using NF_HOOKS (a "PRE_ROUTING" hook). > When I try to print the time stamps (sec and usec) of skb packets > which I recieve > in the hook callback I get 0. Other skb fileds are correct. > According to my

Re: [RFC] d80211 LED handling

2006-08-17 Thread Jiri Benc
On Fri, 11 Aug 2006 09:55:53 +0200, Johannes Berg wrote: > However, I'm not sure where I should call the _init and _exit functions > and if I really should be using the local struct. It seems I shouldn't > be and should be using the master interface directly or something. Leds are not interface-

[RFC][PATCH 17/75] net: drivers/net/dl2k.c pci_module_init to pci_register_driver conversion

2006-08-17 Thread Michal Piotrowski
Signed-off-by: Michal Piotrowski <[EMAIL PROTECTED]> diff -uprN -X linux-work/Documentation/dontdiff linux-work-clean/drivers/net/dl2k.c linux-work2/drivers/net/dl2k.c --- linux-work-clean/drivers/net/dl2k.c 2006-08-16 22:41:17.0 +0200 +++ linux-work2/drivers/net/dl2k.c 2006-08-17 0

Re: [PATCHv2 2.6.17] net/ipv6/udp.c: remove duplicate udp_get_port code

2006-08-17 Thread James Morris
On Thu, 17 Aug 2006, [EMAIL PROTECTED] wrote: > - if (inet2->num == snum && > - sk2 != sk && > - !ipv6_only_sock(sk2) && > - (!sk2->sk_bound_dev_if || > - !sk->sk_bound_dev_if || >

[RFC][PATCH 9/75] net: drivers/net/b44.c pci_module_init to pci_register_driver conversion

2006-08-17 Thread Michal Piotrowski
Signed-off-by: Michal Piotrowski <[EMAIL PROTECTED]> diff -uprN -X linux-work/Documentation/dontdiff linux-work-clean/drivers/net/b44.c linux-work2/drivers/net/b44.c --- linux-work-clean/drivers/net/b44.c 2006-08-16 22:40:59.0 +0200 +++ linux-work2/drivers/net/b44.c 2006-08-17 05:

[RFC][PATCH 19/75] net: drivers/net/wan/dscc4.c pci_module_init to pci_register_driver conversion

2006-08-17 Thread Michal Piotrowski
Signed-off-by: Michal Piotrowski <[EMAIL PROTECTED]> diff -uprN -X linux-work/Documentation/dontdiff linux-work-clean/drivers/net/wan/dscc4.c linux-work2/drivers/net/wan/dscc4.c --- linux-work-clean/drivers/net/wan/dscc4.c2006-08-16 22:41:00.0 +0200 +++ linux-work2/drivers/net/wan/d

[RFC][PATCH 5/75] net: drivers/net/acenic.c pci_module_init to pci_register_driver conversion

2006-08-17 Thread Michal Piotrowski
Signed-off-by: Michal Piotrowski <[EMAIL PROTECTED]> diff -uprN -X linux-work/Documentation/dontdiff linux-work-clean/drivers/net/acenic.c linux-work2/drivers/net/acenic.c --- linux-work-clean/drivers/net/acenic.c 2006-08-17 00:10:47.0 +0200 +++ linux-work2/drivers/net/acenic.c

[RFC][PATCH 26/75] net: drivers/net/forcedeth.c pci_module_init to pci_register_driver conversion

2006-08-17 Thread Michal Piotrowski
Signed-off-by: Michal Piotrowski <[EMAIL PROTECTED]> diff -uprN -X linux-work/Documentation/dontdiff linux-work-clean/drivers/net/forcedeth.c linux-work2/drivers/net/forcedeth.c --- linux-work-clean/drivers/net/forcedeth.c2006-08-16 22:41:17.0 +0200 +++ linux-work2/drivers/net/force

Re: bonding: cannot remove certain named devices

2006-08-17 Thread Bill Nottingham
Xavier Bestel ([EMAIL PROTECTED]) said: > > I think it's sane to avoid control characters and unicode/iso*, since they > > can interfere with log output or analysis. I only thought about the kernel > > itself and the corresponding userspace tools, which should handle any > > character sequence jus

Re: [PATCHv2 2.6.17] net/ipv6/udp.c: remove duplicate udp_get_port code

2006-08-17 Thread YOSHIFUJI Hideaki / 吉藤英明
Hi, In article <[EMAIL PROTECTED]> (at Thu, 17 Aug 2006 10:56:40 -0400 (EDT)), James Morris <[EMAIL PROTECTED]> says: > On Thu, 17 Aug 2006, [EMAIL PROTECTED] wrote: > > > - if (inet2->num == snum && > > - sk2 != sk && > > - !ipv6_on

[RFC][PATCH 34/75] net: drivers/net/ixgb/ixgb_main.c pci_module_init to pci_register_driver conversion

2006-08-17 Thread Michal Piotrowski
Signed-off-by: Michal Piotrowski <[EMAIL PROTECTED]> diff -uprN -X linux-work/Documentation/dontdiff linux-work-clean/drivers/net/ixgb/ixgb_main.c linux-work2/drivers/net/ixgb/ixgb_main.c --- linux-work-clean/drivers/net/ixgb/ixgb_main.c 2006-08-16 22:41:17.0 +0200 +++ linux-work

Re: [PATCH 1/6] IP100A, add end of pci id table

2006-08-17 Thread Jeff Garzik
Jesse Huang wrote: @@ -212,7 +212,7 @@ static const struct pci_device_id sundan { 0x1186, 0x1002, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 4 }, { 0x13F0, 0x0201, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 5 }, { 0x13F0, 0x0200, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 6 }, - { } + { 0,} }; MOD

[RFC][PATCH 28/75] net: drivers/net/hp100.c pci_module_init to pci_register_driver conversion

2006-08-17 Thread Michal Piotrowski
Signed-off-by: Michal Piotrowski <[EMAIL PROTECTED]> diff -uprN -X linux-work/Documentation/dontdiff linux-work-clean/drivers/net/hp100.c linux-work2/drivers/net/hp100.c --- linux-work-clean/drivers/net/hp100.c2006-08-16 22:41:17.0 +0200 +++ linux-work2/drivers/net/hp100.c 2

[RFC][PATCH 43/75] net: drivers/net/tokenring/olympic.c pci_module_init to pci_register_driver conversion

2006-08-17 Thread Michal Piotrowski
Signed-off-by: Michal Piotrowski <[EMAIL PROTECTED]> diff -uprN -X linux-work/Documentation/dontdiff linux-work-clean/drivers/net/tokenring/olympic.c linux-work2/drivers/net/tokenring/olympic.c --- linux-work-clean/drivers/net/tokenring/olympic.c2006-08-16 22:41:00.0 +0200 +++ linu

Re: Possible leak of multicast source filter sctructure

2006-08-17 Thread David Stevens
"Michal Ruzicka" <[EMAIL PROTECTED]> wrote on 08/17/2006 05:26:35 AM: > I've reviewed your patch (the IPv4 part of it) and I think I can say that > our soulutions are actually quite similar. > But I can come up with one difference that I'd like know your opinion on. If you have a dupli

[RFC][PATCH 10/75] net: drivers/net/bnx2.c pci_module_init to pci_register_driver conversion

2006-08-17 Thread Michal Piotrowski
Signed-off-by: Michal Piotrowski <[EMAIL PROTECTED]> diff -uprN -X linux-work/Documentation/dontdiff linux-work-clean/drivers/net/bnx2.c linux-work2/drivers/net/bnx2.c --- linux-work-clean/drivers/net/bnx2.c 2006-08-16 22:41:17.0 +0200 +++ linux-work2/drivers/net/bnx2.c 2006-08-17 0

Re: [PATCH] mark sk98lin driver for removal

2006-08-17 Thread Michael Stone
On Tue, Aug 15, 2006 at 02:42:32PM -0400, Michael Stone wrote: On Tue, Aug 15, 2006 at 11:03:40AM -0700, Stephen Hemminger wrote: The driver has always supported both ports as separate devices. If you want to use bonding or fail over that is available in generic kernel. ok, I'll test that in

[RFC][PATCH 15/75] net: drivers/net/tulip/de4x5.c pci_module_init to pci_register_driver conversion

2006-08-17 Thread Michal Piotrowski
Signed-off-by: Michal Piotrowski <[EMAIL PROTECTED]> diff -uprN -X linux-work/Documentation/dontdiff linux-work-clean/drivers/net/tulip/de4x5.c linux-work2/drivers/net/tulip/de4x5.c --- linux-work-clean/drivers/net/tulip/de4x5.c 2006-08-16 22:41:17.0 +0200 +++ linux-work2/drivers/net/t

[RFC][PATCH 24/75] net: drivers/net/wan/farsync.c pci_module_init to pci_register_driver conversion

2006-08-17 Thread Michal Piotrowski
Signed-off-by: Michal Piotrowski <[EMAIL PROTECTED]> diff -uprN -X linux-work/Documentation/dontdiff linux-work-clean/drivers/net/wan/farsync.c linux-work2/drivers/net/wan/farsync.c --- linux-work-clean/drivers/net/wan/farsync.c 2006-08-16 22:41:00.0 +0200 +++ linux-work2/drivers/net/w

time stamps of skb packets in NF_HOOKS callbacks

2006-08-17 Thread John Que
Hello, I am using NF_HOOKS (a "PRE_ROUTING" hook). When I try to print the time stamps (sec and usec) of skb packets which I recieve in the hook callback I get 0. Other skb fileds are correct. According to my understanding, the time stamp should be updated when the packet is received. Isn't it so

[RFC][PATCH 40/75] net: drivers/net/natsemi.c pci_module_init to pci_register_driver conversion

2006-08-17 Thread Michal Piotrowski
Signed-off-by: Michal Piotrowski <[EMAIL PROTECTED]> diff -uprN -X linux-work/Documentation/dontdiff linux-work-clean/drivers/net/natsemi.c linux-work2/drivers/net/natsemi.c --- linux-work-clean/drivers/net/natsemi.c 2006-08-16 22:41:17.0 +0200 +++ linux-work2/drivers/net/natsemi.c

Re: [PATCH 1/6] IP100A, add end of pci id table

2006-08-17 Thread Alexey Dobriyan
On Thu, Aug 17, 2006 at 03:00:47PM -0400, Jesse Huang wrote: > Add "0," and "NULL," to sundance_pci_tbl and pci_id_table. > @@ -212,7 +212,7 @@ static const struct pci_device_id sundan > { 0x1186, 0x1002, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 4 }, > { 0x13F0, 0x0201, PCI_ANY_ID, PCI_ANY_ID, 0,

Re: [PATCH 3/6] IP100A Remove CONFIG_SUNDANCE_MMIO, mask of mapping address

2006-08-17 Thread Jeff Garzik
Jesse Huang wrote: -/* Work-around for Kendin chip bugs. */ -#ifndef CONFIG_SUNDANCE_MMIO -#define USE_IO_OPS 1 -#endif Why? This simply eliminates the ability of the user to set the driver configuration at Kconfig time, requiring them to edit the driver to achieve the same functionality.

Re: [PATCH 5/6] IP100A correct init and close step

2006-08-17 Thread Jeff Garzik
Jesse Huang wrote: From: Jesse Huang <[EMAIL PROTECTED]> correct init and close step Change Logs: correct init and close step --- drivers/net/sundance.c | 10 +- 1 files changed, 9 insertions(+), 1 deletions(-) b5e343a17f5d70d1cc9a4ba20d366bab355f64a6 diff --git a/drivers/net/

[RFC][PATCH 2/75] net: drivers/net/3c59x.c pci_module_init to pci_register_driver conversion

2006-08-17 Thread Michal Piotrowski
Signed-off-by: Michal Piotrowski <[EMAIL PROTECTED]> diff -uprN -X linux-work/Documentation/dontdiff linux-work-clean/drivers/net/3c59x.c linux-work2/drivers/net/3c59x.c --- linux-work-clean/drivers/net/3c59x.c2006-08-16 22:41:16.0 +0200 +++ linux-work2/drivers/net/3c59x.c 2

[RFC][PATCH 21/75] net: drivers/net/e100.c pci_module_init to pci_register_driver conversion

2006-08-17 Thread Michal Piotrowski
Signed-off-by: Michal Piotrowski <[EMAIL PROTECTED]> diff -uprN -X linux-work/Documentation/dontdiff linux-work-clean/drivers/net/e100.c linux-work2/drivers/net/e100.c --- linux-work-clean/drivers/net/e100.c 2006-08-16 22:41:17.0 +0200 +++ linux-work2/drivers/net/e100.c 2006-08-17 0

[RFC][PATCH 13/75] net: drivers/net/chelsio/cxgb2.c pci_module_init to pci_register_driver conversion

2006-08-17 Thread Michal Piotrowski
Signed-off-by: Michal Piotrowski <[EMAIL PROTECTED]> diff -uprN -X linux-work/Documentation/dontdiff linux-work-clean/drivers/net/chelsio/cxgb2.c linux-work2/drivers/net/chelsio/cxgb2.c --- linux-work-clean/drivers/net/chelsio/cxgb2.c2006-08-16 22:40:59.0 +0200 +++ linux-work2/

Re: [RFC][PATCH 51/75] net: drivers/net/pci-skeleton.c pci_module_init to pci_register_driver conversion

2006-08-17 Thread Michal Piotrowski
Jeff Garzik wrote: > Please just send one big patch that converts all drivers/net drivers at > once. > > Jeff > > > > Signed-off-by: Michal Piotrowski <[EMAIL PROTECTED]> diff -uprN -X linux-work/Documentation/dontdiff linux-work-clean/drivers/net/3c59x.c linux-work2/drivers/net/3c59x.c

[RFC] nl80211 + packet injection with it and d80211

2006-08-17 Thread Johannes Berg
Hey, This is a patch laying the groundwork for nl80211. I've decided to implement it below net/wireless/ so that when we add further things like configfs support for some things that can just be added there. Currently, it lays the groundwork for netlink userspace communication. None of the attrib

Re: [RFC][PATCH 47/75] net: drivers/net/wireless/orinoco_tmd.c pci_module_init to pci_register_driver conversion

2006-08-17 Thread Joerg Dorchain
> > Signed-off-by: Michal Piotrowski <[EMAIL PROTECTED]> Fine with me. Signed-off-by: Joerg Dorchain <[EMAIL PROTECTED]> > > diff -uprN -X linux-work/Documentation/dontdiff > linux-work-clean/drivers/net/wireless/orinoco_tmd.c > linux-work2/drivers/net/wireless/orinoco_tmd.c > --- linux-work-clea

[RFC][PATCH 16/75] net: drivers/net/defxx.c pci_module_init to pci_register_driver conversion

2006-08-17 Thread Michal Piotrowski
Signed-off-by: Michal Piotrowski <[EMAIL PROTECTED]> diff -uprN -X linux-work/Documentation/dontdiff linux-work-clean/drivers/net/defxx.c linux-work2/drivers/net/defxx.c --- linux-work-clean/drivers/net/defxx.c2006-08-16 22:40:59.0 +0200 +++ linux-work2/drivers/net/defxx.c 2

[RFC][PATCH 18/75] net: drivers/net/tulip/dmfe.c pci_module_init to pci_register_driver conversion

2006-08-17 Thread Michal Piotrowski
Signed-off-by: Michal Piotrowski <[EMAIL PROTECTED]> diff -uprN -X linux-work/Documentation/dontdiff linux-work-clean/drivers/net/tulip/dmfe.c linux-work2/drivers/net/tulip/dmfe.c --- linux-work-clean/drivers/net/tulip/dmfe.c 2006-08-16 22:41:00.0 +0200 +++ linux-work2/drivers/net/tul

[RFC][PATCH 50/75] net: drivers/net/wan/pci200syn.c pci_module_init to pci_register_driver conversion

2006-08-17 Thread Michal Piotrowski
Signed-off-by: Michal Piotrowski <[EMAIL PROTECTED]> diff -uprN -X linux-work/Documentation/dontdiff linux-work-clean/drivers/net/wan/pci200syn.c linux-work2/drivers/net/wan/pci200syn.c --- linux-work-clean/drivers/net/wan/pci200syn.c2006-08-16 22:41:00.0 +0200 +++ linux-work2/

[RFC][PATCH 4/75] net: drivers/net/8139too.c pci_module_init to pci_register_driver conversion

2006-08-17 Thread Michal Piotrowski
Signed-off-by: Michal Piotrowski <[EMAIL PROTECTED]> diff -uprN -X linux-work/Documentation/dontdiff linux-work-clean/drivers/net/8139too.c linux-work2/drivers/net/8139too.c --- linux-work-clean/drivers/net/8139too.c 2006-08-16 22:40:59.0 +0200 +++ linux-work2/drivers/net/8139too.c

[RFC][PATCH 31/75] net: drivers/net/wireless/ipw2100.c pci_module_init to pci_register_driver conversion

2006-08-17 Thread Michal Piotrowski
Signed-off-by: Michal Piotrowski <[EMAIL PROTECTED]> diff -uprN -X linux-work/Documentation/dontdiff linux-work-clean/drivers/net/wireless/ipw2100.c linux-work2/drivers/net/wireless/ipw2100.c --- linux-work-clean/drivers/net/wireless/ipw2100.c 2006-08-16 22:41:00.0 +0200 +++ linux-

[RFC][PATCH 42/75] net: drivers/net/ns83820.c pci_module_init to pci_register_driver conversion

2006-08-17 Thread Michal Piotrowski
Signed-off-by: Michal Piotrowski <[EMAIL PROTECTED]> diff -uprN -X linux-work/Documentation/dontdiff linux-work-clean/drivers/net/ns83820.c linux-work2/drivers/net/ns83820.c --- linux-work-clean/drivers/net/ns83820.c 2006-08-16 22:41:17.0 +0200 +++ linux-work2/drivers/net/ns83820.c

[RFC][PATCH 54/75] net: net/rrunner.c pci_module_init to pci_register_driver conversion

2006-08-17 Thread Michal Piotrowski
Signed-off-by: Michal Piotrowski <[EMAIL PROTECTED]> diff -uprN -X linux-work/Documentation/dontdiff linux-work-clean/drivers/net/rrunner.c linux-work2/drivers/net/rrunner.c --- linux-work-clean/drivers/net/rrunner.c 2006-08-16 22:41:00.0 +0200 +++ linux-work2/drivers/net/rrunner.c

Re: [RFC][PATCH 0/75] pci_module_init to pci_register_driver conversion

2006-08-17 Thread Jeff Garzik
Actually, I stand corrected: netdev-2.6.git#upstream does not contain a pci_register_driver() patch. Send the drivers/net piece along to me and I'll apply it. Jeff - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More

[RFC][PATCH 71/75] net: drivers/net/via-velocity.c pci_module_init to pci_register_driver conversion

2006-08-17 Thread Michal Piotrowski
Signed-off-by: Michal Piotrowski <[EMAIL PROTECTED]> diff -uprN -X linux-work/Documentation/dontdiff linux-work-clean/drivers/net/via-velocity.c linux-work2/drivers/net/via-velocity.c --- linux-work-clean/drivers/net/via-velocity.c 2006-08-16 22:41:17.0 +0200 +++ linux-work2/drivers/ne

[RFC][PATCH 56/75] net: drivers/net/saa9730.c pci_module_init to pci_register_driver conversion

2006-08-17 Thread Michal Piotrowski
Signed-off-by: Michal Piotrowski <[EMAIL PROTECTED]> diff -uprN -X linux-work/Documentation/dontdiff linux-work-clean/drivers/net/saa9730.c linux-work2/drivers/net/saa9730.c --- linux-work-clean/drivers/net/saa9730.c 2006-03-20 06:53:29.0 +0100 +++ linux-work2/drivers/net/saa9730.c

[RFC][PATCH 60/75] net: drivers/net/sk98lin/skge.c pci_module_init to pci_register_driver conversion

2006-08-17 Thread Michal Piotrowski
Signed-off-by: Michal Piotrowski <[EMAIL PROTECTED]> diff -uprN -X linux-work/Documentation/dontdiff linux-work-clean/drivers/net/sk98lin/skge.c linux-work2/drivers/net/sk98lin/skge.c --- linux-work-clean/drivers/net/sk98lin/skge.c 2006-08-16 22:41:17.0 +0200 +++ linux-work2/drivers/ne

[RFC][PATCH 12/75] net: drivers/net/arcnet/com20020-pci.c pci_module_init to pci_register_driver conversion

2006-08-17 Thread Michal Piotrowski
Signed-off-by: Michal Piotrowski <[EMAIL PROTECTED]> diff -uprN -X linux-work/Documentation/dontdiff linux-work-clean/drivers/net/arcnet/com20020-pci.c linux-work2/drivers/net/arcnet/com20020-pci.c --- linux-work-clean/drivers/net/arcnet/com20020-pci.c 2006-08-16 22:41:17.0 +0200 +++

[RFC][PATCH 68/75] net: drivers/net/tulip/tulip_core.c pci_module_init to pci_register_driver conversion

2006-08-17 Thread Michal Piotrowski
Signed-off-by: Michal Piotrowski <[EMAIL PROTECTED]> diff -uprN -X linux-work/Documentation/dontdiff linux-work-clean/drivers/net/tulip/tulip_core.c linux-work2/drivers/net/tulip/tulip_core.c --- linux-work-clean/drivers/net/tulip/tulip_core.c 2006-08-16 22:41:17.0 +0200 +++ linux-

[RFC][PATCH 8/75] net: drivers/net/wireless/atmel_pci.c pci_module_init to pci_register_driver conversion

2006-08-17 Thread Michal Piotrowski
Signed-off-by: Michal Piotrowski <[EMAIL PROTECTED]> diff -uprN -X linux-work/Documentation/dontdiff linux-work-clean/drivers/net/wireless/atmel_pci.c linux-work2/drivers/net/wireless/atmel_pci.c --- linux-work-clean/drivers/net/wireless/atmel_pci.c 2006-08-16 22:41:00.0 +0200 +++ li

[RFC][PATCH 73/75] net: drivers/net/tulip/winbond-840.c pci_module_init to pci_register_driver conversion

2006-08-17 Thread Michal Piotrowski
Signed-off-by: Michal Piotrowski <[EMAIL PROTECTED]> diff -uprN -X linux-work/Documentation/dontdiff linux-work-clean/drivers/net/tulip/winbond-840.c linux-work2/drivers/net/tulip/winbond-840.c --- linux-work-clean/drivers/net/tulip/winbond-840.c2006-08-16 22:41:17.0 +0200 +++ linu

[RFC][PATCH 44/75] net: drivers/net/wireless/orinoco_nortel.c pci_module_init to pci_register_driver conversion

2006-08-17 Thread Michal Piotrowski
Signed-off-by: Michal Piotrowski <[EMAIL PROTECTED]> diff -uprN -X linux-work/Documentation/dontdiff linux-work-clean/drivers/net/wireless/orinoco_nortel.c linux-work2/drivers/net/wireless/orinoco_nortel.c --- linux-work-clean/drivers/net/wireless/orinoco_nortel.c 2006-08-16 22:41:00.

[RFC][PATCH 58/75] net: drivers/net/sis900.c pci_module_init to pci_register_driver conversion

2006-08-17 Thread Michal Piotrowski
Signed-off-by: Michal Piotrowski <[EMAIL PROTECTED]> diff -uprN -X linux-work/Documentation/dontdiff linux-work-clean/drivers/net/sis900.c linux-work2/drivers/net/sis900.c --- linux-work-clean/drivers/net/sis900.c 2006-08-16 22:41:00.0 +0200 +++ linux-work2/drivers/net/sis900.c

[RFC][PATCH 53/75] net: drivers/net/r8169.c pci_module_init to pci_register_driver conversion

2006-08-17 Thread Michal Piotrowski
Signed-off-by: Michal Piotrowski <[EMAIL PROTECTED]> diff -uprN -X linux-work/Documentation/dontdiff linux-work-clean/drivers/net/r8169.c linux-work2/drivers/net/r8169.c --- linux-work-clean/drivers/net/r8169.c2006-08-16 22:41:17.0 +0200 +++ linux-work2/drivers/net/r8169.c 2

[RFC][PATCH 57/75] net: drivers/net/sis190.c pci_module_init to pci_register_driver conversion

2006-08-17 Thread Michal Piotrowski
Signed-off-by: Michal Piotrowski <[EMAIL PROTECTED]> diff -uprN -X linux-work/Documentation/dontdiff linux-work-clean/drivers/net/sis190.c linux-work2/drivers/net/sis190.c --- linux-work-clean/drivers/net/sis190.c 2006-08-16 22:41:00.0 +0200 +++ linux-work2/drivers/net/sis190.c

[RFC][PATCH 55/75] net: drivers/net/s2io.c pci_module_init to pci_register_driver conversion

2006-08-17 Thread Michal Piotrowski
Signed-off-by: Michal Piotrowski <[EMAIL PROTECTED]> diff -uprN -X linux-work/Documentation/dontdiff linux-work-clean/drivers/net/s2io.c linux-work2/drivers/net/s2io.c --- linux-work-clean/drivers/net/s2io.c 2006-08-16 22:41:17.0 +0200 +++ linux-work2/drivers/net/s2io.c 2006-08-17 0

Re: [RFC][PATCH 51/75] net: drivers/net/pci-skeleton.c pci_module_init to pci_register_driver conversion

2006-08-17 Thread Jeff Garzik
Please just send one big patch that converts all drivers/net drivers at once. Jeff - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

[RFC][PATCH 52/75] net: drivers/net/pcnet32.c pci_module_init to pci_register_driver conversion

2006-08-17 Thread Michal Piotrowski
Signed-off-by: Michal Piotrowski <[EMAIL PROTECTED]> diff -uprN -X linux-work/Documentation/dontdiff linux-work-clean/drivers/net/pcnet32.c linux-work2/drivers/net/pcnet32.c --- linux-work-clean/drivers/net/pcnet32.c 2006-08-16 22:41:00.0 +0200 +++ linux-work2/drivers/net/pcnet32.c

[RFC][PATCH 3/75] net: drivers/net/8139cp.c pci_module_init to pci_register_driver conversion

2006-08-17 Thread Michal Piotrowski
Signed-off-by: Michal Piotrowski <[EMAIL PROTECTED]> diff -uprN -X linux-work/Documentation/dontdiff linux-work-clean/drivers/net/8139cp.c linux-work2/drivers/net/8139cp.c --- linux-work-clean/drivers/net/8139cp.c 2006-08-16 22:41:16.0 +0200 +++ linux-work2/drivers/net/8139cp.c

  1   2   >