Re: Hello, We have IP100A Linux driver need to submit to 2.6.x kernel

2006-07-26 Thread Andrew Morton
On Thu, 27 Jul 2006 14:41:29 +0800 "Jesse Huang" <[EMAIL PROTECTED]> wrote: > Dear All: > > I am IC Plus software engineer. We have IP100A 10/100 fast network adapter > driver need to submit to Linux 2.6.x kernel. Thanks! > Please tell me who should I submit to. > Please send it to the four a

Re: [3/4] kevent: AIO, aio_sendfile() implementation.

2006-07-26 Thread Sébastien Dugué
On Wed, 2006-07-26 at 09:22 -0700, Badari Pulavarty wrote: > Ulrich Drepper wrote: > > Christoph Hellwig wrote: > > > >>> My personal opinion on existing AIO is that it is not the right design. > >>> Benjamin LaHaise agree with me (if I understood him right), > >>> > >> I completely agree

Re: async network I/O, event channels, etc

2006-07-26 Thread David Miller
From: Evgeniy Polyakov <[EMAIL PROTECTED]> Date: Wed, 26 Jul 2006 10:28:17 +0400 > I have not created additional DMA memory allocation methods, like > Ulrich described in his article, so I handle it inside NAIO which > has some overhead (I posted get_user_pages() sclability graph some > time ago).

Re: [PATCH 3/5] [NET]: Protocol Independant Policy Routing Rules Framework

2006-07-26 Thread David Miller
From: James Morris <[EMAIL PROTECTED]> Date: Thu, 27 Jul 2006 01:58:58 -0400 (EDT) > On Thu, 27 Jul 2006, Thomas Graf wrote: > > > + rule = kmalloc(ops->rule_size, GFP_KERNEL); > > + if (rule == NULL) { > > + err = -ENOMEM; > > + goto errout; > > + } > > + memset(rule,

Re: Netchannles: first stage has been completed. Further ideas.

2006-07-26 Thread David Miller
From: Rusty Russell <[EMAIL PROTECTED]> Date: Thu, 27 Jul 2006 15:46:12 +1000 > Yes, my first thought back in January was how netfilter would interact > with this in a sane way. One answer is "don't": once someone registers > on any hook we go into slow path. Another is to run the hooks in socke

Re: [PATCH 3/5] [NET]: Protocol Independant Policy Routing Rules Framework

2006-07-26 Thread James Morris
On Thu, 27 Jul 2006, Thomas Graf wrote: > + rule = kmalloc(ops->rule_size, GFP_KERNEL); > + if (rule == NULL) { > + err = -ENOMEM; > + goto errout; > + } > + memset(rule, 0, ops->rule_size); > + kzalloc() ? :-) - James -- James Morris <[EMAIL PROTECTED]

Re: Netchannles: first stage has been completed. Further ideas.

2006-07-26 Thread Rusty Russell
On Wed, 2006-07-26 at 22:17 -0700, David Miller wrote: > I read this as "we will be able to get around the problems" but > no specific answer as to "how". I am an optimist too but I want > to start seeing concrete discussion about the way in which the > problems will be dealt with. > > Alexey has

Re: Netchannles: first stage has been completed. Further ideas.

2006-07-26 Thread David Miller
From: Rusty Russell <[EMAIL PROTECTED]> Date: Thu, 27 Jul 2006 12:17:51 +1000 > On Wed, 2006-07-19 at 03:01 +0400, Alexey Kuznetsov wrote: > > About locks: > > > > > is completely lockless (there is one irq lock when skb > > > is queued/dequeued into netchannels queue in hard/soft irq, > >

Re: Is the qla3xxx driver in the mainline?

2006-07-26 Thread Albert Lee
Michael Tokarev wrote: > Albert Lee wrote: > [] > >>(I am curious to have some performance comparison of >>qla3xxx + open iscsi v.s. qla4xxx + on board TOE/iscsi.) > > > On wich card? I've been told that IPS4010 for example > isn't supported by qla3xxx. I've borrowed an ISP4022 based adapter,

Re: Netchannles: first stage has been completed. Further ideas.

2006-07-26 Thread Rusty Russell
On Wed, 2006-07-19 at 03:01 +0400, Alexey Kuznetsov wrote: > Hello! > > Can I ask couple of questions? Just as a person who looked at VJ's > slides once and was confused. And startled, when found that it is not > considered as another joke of genuis. :-) Hi Alexey! > About locks: > > > is

Re: Netchannel: default, find, add to socket

2006-07-26 Thread David Miller
From: Kelly Daly <[EMAIL PROTECTED]> Date: Thu, 27 Jul 2006 10:50:00 +1000 > Implement finding of correct netchannel for buffer, default netchannel and > attach a netchannel to a socket > > Signed-off-by: Kelly Daly <[EMAIL PROTECTED]> Patch is still corrupted. My tolerance on this matter is

Netchannel: default, find, add to socket

2006-07-26 Thread Kelly Daly
Implement finding of correct netchannel for buffer, default netchannel and attach a netchannel to a socket Signed-off-by: Kelly Daly <[EMAIL PROTECTED]> --- diff -urp davem/include/linux/netchannel.h kelly_new/include/linux/netchannel.h --- davem/include/linux/netchannel.h2006-06-16 15:14

Re: [PATCH 5/5] [IPV4]: Use Protocol Independant Policy Routing Rules Framework

2006-07-26 Thread David Miller
From: Thomas Graf <[EMAIL PROTECTED]> Date: Thu, 27 Jul 2006 00:00:05 +0200 > Index: net-2.6.git/net/ipv4/fib_rules.c > === > --- net-2.6.git.orig/net/ipv4/fib_rules.c > +++ net-2.6.git/net/ipv4/fib_rules.c ... > - new_r = kmallo

Re: [PATCH 4/5] [IPV6]: Policy Routing Rules

2006-07-26 Thread David Miller
From: David Miller <[EMAIL PROTECTED]> Date: Wed, 26 Jul 2006 16:33:43 -0700 (PDT) > Therfore, the better fix seems to be, to change the Makefile > rule to be: > > ipv6-$(CONFIG_IPV6_MULTIPLE_TABLES) += fib6_rules.o > > Ok? And once this is fixed, new problems crop up :-) WARNING: net/ipv6/ipv

Re: [PATCH 1/5] [IPV6]: Remove ndiscs rt6_lock dependency

2006-07-26 Thread David Miller
From: Tushar Gohad <[EMAIL PROTECTED]> Date: Wed, 26 Jul 2006 16:34:03 -0700 > Are these changes scheduled to go into 2.6.18-rcX or 2.6.19? Since the feature freeze is frozen, net-2.6.19 is where it will likely go. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of

Re: [PATCH 4/5] [IPV6]: Policy Routing Rules

2006-07-26 Thread David Miller
From: Thomas Graf <[EMAIL PROTECTED]> Date: Thu, 27 Jul 2006 00:00:04 +0200 > Index: net-2.6.git/include/net/ip6_route.h > === > --- net-2.6.git.orig/include/net/ip6_route.h > +++ net-2.6.git/include/net/ip6_route.h > @@ -41,6 +41,11

Re: [PATCH 1/5] [IPV6]: Remove ndiscs rt6_lock dependency

2006-07-26 Thread Tushar Gohad
Are these changes scheduled to go into 2.6.18-rcX or 2.6.19? Thanks. - Tushar David Miller wrote: From: Thomas Graf <[EMAIL PROTECTED]> Date: Thu, 27 Jul 2006 00:00:01 +0200 (Ab)using rt6_lock wouldn't work anymore if rt6_lock is converted into a per table lock. Signed-off-by: Thomas Graf <

Re: [PATCH 4/5] [IPV6]: Policy Routing Rules

2006-07-26 Thread David Miller
From: Thomas Graf <[EMAIL PROTECTED]> Date: Thu, 27 Jul 2006 00:00:04 +0200 > Index: net-2.6.git/net/ipv6/Makefile > === > --- net-2.6.git.orig/net/ipv6/Makefile > +++ net-2.6.git/net/ipv6/Makefile > @@ -29,3 +29,5 @@ obj-$(CONFIG_IPV

Re: [PATCH 2/5] [IPV6]: Multiple Routing Tables

2006-07-26 Thread David Miller
From: Thomas Graf <[EMAIL PROTECTED]> Date: Thu, 27 Jul 2006 00:48:48 +0200 > Fortunately it's only used read-only when notifying to figure > out the destination pid but that code seems bogus as well and > we can probably remove the netlink cb passing hell throughout > all the code there. Yes, th

Re: RFC: kernel memory leak fix for af_unix datagram getpeersec

2006-07-26 Thread David Miller
From: Stephen Smalley <[EMAIL PROTECTED]> Date: Wed, 26 Jul 2006 16:50:40 -0400 > > diff -puN net/unix/af_unix.c~af_unix-datagram-getpeersec-ml-fix > > net/unix/af_unix.c > > --- linux-2.6.18-rc2/net/unix/af_unix.c~af_unix-datagram-getpeersec-ml-fix > > 2006-07-22 23:01:26.0 -0400 > > +

Re: [PATCH 2/5] [IPV6]: Multiple Routing Tables

2006-07-26 Thread Thomas Graf
* David Miller <[EMAIL PROTECTED]> 2006-07-26 15:39 > Wow, were we corrupting the IP6CB() of input packets on every > route lookup that hit this path? I found that via compile error as passing on skb to this context didn't make sense when I rewrote the code around it :-) Fortunately it's only use

Re: [PATCH 4/5] [IPV6]: Policy Routing Rules

2006-07-26 Thread David Miller
From: Thomas Graf <[EMAIL PROTECTED]> Date: Thu, 27 Jul 2006 00:00:04 +0200 > Adds support for policy routing rules including a new > local table for routes with a local destination. > > Signed-off-by: Thomas Graf <[EMAIL PROTECTED]> With the generic fib_rules this is straightforward, looks good

Re: [PATCH 5/5] [IPV4]: Use Protocol Independant Policy Routing Rules Framework

2006-07-26 Thread David Miller
From: Thomas Graf <[EMAIL PROTECTED]> Date: Thu, 27 Jul 2006 00:00:05 +0200 > Signed-off-by: Thomas Graf <[EMAIL PROTECTED]> Like the ipv6 counterpart, this looks fine too. Signed-off-by: David S. Miller <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "unsubscribe netdev" in t

Re: [PATCH 3/5] [NET]: Protocol Independant Policy Routing Rules Framework

2006-07-26 Thread David Miller
From: Thomas Graf <[EMAIL PROTECTED]> Date: Thu, 27 Jul 2006 00:00:03 +0200 > Derived from net/ipv6/fib_rules.c > > Signed-off-by: Thomas Graf <[EMAIL PROTECTED]> A very nice abstraction, looks great. Signed-off-by: David S. Miller <[EMAIL PROTECTED]> - To unsubscribe from this list: send the l

Re: [PATCH 2/5] [IPV6]: Multiple Routing Tables

2006-07-26 Thread David Miller
From: Thomas Graf <[EMAIL PROTECTED]> Date: Thu, 27 Jul 2006 00:00:02 +0200 > Adds the framework to support multiple IPv6 routing tables. > Currently all automatically generated routes are put into the > same table. This could be changed at a later point after > considering the produced locking ov

Re: [PATCH 1/5] [IPV6]: Remove ndiscs rt6_lock dependency

2006-07-26 Thread David Miller
From: Thomas Graf <[EMAIL PROTECTED]> Date: Thu, 27 Jul 2006 00:00:01 +0200 > (Ab)using rt6_lock wouldn't work anymore if rt6_lock is > converted into a per table lock. > > Signed-off-by: Thomas Graf <[EMAIL PROTECTED]> This one looks great. Signed-off-by: David S. Miller <[EMAIL PROTECTED]> -

Re: [PATCH 1/3] add netdev_alloc_skb

2006-07-26 Thread David Miller
From: Christoph Hellwig <[EMAIL PROTECTED]> Date: Wed, 26 Jul 2006 13:31:36 +0200 > + * %NULL is returned in there is no free memory. Although this function > + * allocates memory it can be called from an interrupt. ... > + * %NULL is returned in there is no free memory. Looks like a typo

[PATCH 5/5] [IPV4]: Use Protocol Independant Policy Routing Rules Framework

2006-07-26 Thread Thomas Graf
Signed-off-by: Thomas Graf <[EMAIL PROTECTED]> Index: net-2.6.git/include/net/ip_fib.h === --- net-2.6.git.orig/include/net/ip_fib.h +++ net-2.6.git/include/net/ip_fib.h @@ -18,6 +18,7 @@ #include #include +#include /* WARNI

[PATCH 3/5] [NET]: Protocol Independant Policy Routing Rules Framework

2006-07-26 Thread Thomas Graf
Derived from net/ipv6/fib_rules.c Signed-off-by: Thomas Graf <[EMAIL PROTECTED]> Index: net-2.6.git/include/linux/fib_rules.h === --- /dev/null +++ net-2.6.git/include/linux/fib_rules.h @@ -0,0 +1,60 @@ +#ifndef __LINUX_FIB_RULES_H +

[RFC] Multiple IPV6 Routing Tables & Policy Routing

2006-07-26 Thread Thomas Graf
Hello, Thought it might be time to go through a round of comments on this work. Even though I've almost rewritten all the code the patches are based on the work found on www.mobile-ipv6.org. I have no idea which code was written by whom so just email me to get the credits right. Main differences

[PATCH 1/5] [IPV6]: Remove ndiscs rt6_lock dependency

2006-07-26 Thread Thomas Graf
(Ab)using rt6_lock wouldn't work anymore if rt6_lock is converted into a per table lock. Signed-off-by: Thomas Graf <[EMAIL PROTECTED]> Index: net-2.6.git/net/ipv6/route.c === --- net-2.6.git.orig/net/ipv6/route.c +++ net-2.6.git/net

[PATCH 4/5] [IPV6]: Policy Routing Rules

2006-07-26 Thread Thomas Graf
Adds support for policy routing rules including a new local table for routes with a local destination. Signed-off-by: Thomas Graf <[EMAIL PROTECTED]> Index: net-2.6.git/net/ipv6/fib6_rules.c === --- /dev/null +++ net-2.6.git/net/ipv6

[PATCH 2/5] [IPV6]: Multiple Routing Tables

2006-07-26 Thread Thomas Graf
Adds the framework to support multiple IPv6 routing tables. Currently all automatically generated routes are put into the same table. This could be changed at a later point after considering the produced locking overhead. When locating routes for redirects only the main table is searched for now.

Re: [XFRM]: Fix protocol field value for outgoing IPv6 GSO packets

2006-07-26 Thread David Miller
From: Herbert Xu <[EMAIL PROTECTED]> Date: Tue, 25 Jul 2006 10:13:26 +1000 > On Tue, Jul 25, 2006 at 02:09:26AM +0200, Patrick McHardy wrote: > > This appears to be a mistake, but I didn't follow the GSO stuff > > very closely, so there could be some non-obvious reason. > > Yes it definitely was

Update of the r8169 branch

2006-07-26 Thread Francois Romieu
The r8169 branch at git://electric-eye.fr.zoreil.com/home/romieu/linux-2.6.git has been replaced by an updated version which should correctly support the 8168 chipset given Boris and David's feedback. The previous version of the r8169 branch has been archived as r8169-20060612. The changes may su

Re: H/W requirements for NETIF_F_HW_CSUM

2006-07-26 Thread David Miller
From: "Ravinandan Arakali" <[EMAIL PROTECTED]> Date: Wed, 26 Jul 2006 12:34:28 -0700 > "You CANNOT use NETIF_F_HW_CSUM, when your hardware does not provide the > checksum value. You must use NETIF_F_IP_CSUM. Your use of > NETIF_F_HW_CSUM + CHECKSUM_UNNECESSARY is flat out incorrect." NETIF_F_

Re: [PATCH Round 4 2/3] Core network changes to support network event notification.

2006-07-26 Thread David Miller
From: Steve Wise <[EMAIL PROTECTED]> Date: Wed, 26 Jul 2006 11:15:43 -0500 > Dave, what do you think about removing the user-space stuff for the > first round of integration? IE: Just add netevents and kernel hooks to > generate them. Sure. - To unsubscribe from this list: send the line "unsubs

Re: RFC: kernel memory leak fix for af_unix datagram getpeersec

2006-07-26 Thread Stephen Smalley
On Wed, 2006-07-26 at 16:19 -0400, Catherine Zhang wrote: > diff -puN include/net/scm.h~af_unix-datagram-getpeersec-ml-fix > include/net/scm.h > --- linux-2.6.18-rc2/include/net/scm.h~af_unix-datagram-getpeersec-ml-fix > 2006-07-22 21:28:21.0 -0400 > +++ linux-2.6.18-rc2-cxzhang/inclu

Re: [3/4] kevent: AIO, aio_sendfile() implementation.

2006-07-26 Thread Phillip Susi
Christoph Hellwig wrote: Networking and disk AIO have significantly different needs. Therefore, I really don't see it as reasonable to expect a merge of these two things. It doesn't make any sense. I'm not sure about that. The current aio interface isn't exactly nice for disk I/O either. I'

RFC: kernel memory leak fix for af_unix datagram getpeersec

2006-07-26 Thread Catherine Zhang
Hi, all, Enclosed please find the new fix for the memory leak problem, incorporating suggestions from Stephen and James. thanks all for your help! Catherine -- From: [EMAIL PROTECTED] This patch implements a cleaner fix for the memory leak problem of the original unix datagram getpeersec pat

Re: [PATCH]NET: Add ECN support for TSO

2006-07-26 Thread Michael Chan
On Fri, 2006-07-14 at 12:12 -0400, Dan Reader wrote: > If we implement the approach you suggest and all data sent uses TSO, the > receiver can easily determine the expected codepoint of almost any > isolated CE packet. It simply has to look at the segment before and the > segment after (which it

RE: H/W requirements for NETIF_F_HW_CSUM

2006-07-26 Thread Ravinandan Arakali
Steve, Thanks for the response. Pls see my comments below. > -Original Message- > From: Stephen Hemminger [mailto:[EMAIL PROTECTED] > Sent: Wednesday, July 26, 2006 12:16 PM > To: [EMAIL PROTECTED] > Cc: netdev@vger.kernel.org; [EMAIL PROTECTED]; > [EMAIL PROTECTED]; [EMAIL PROTECTED]; > [

Re: H/W requirements for NETIF_F_HW_CSUM

2006-07-26 Thread Stephen Hemminger
On Wed, 26 Jul 2006 10:28:00 -0700 "Ravinandan Arakali" <[EMAIL PROTECTED]> wrote: > Hello, > Our current NIC does not provide the actual checksum value on receive path. > Hence we only claim NETIF_F_IP_CSUM instead of the more general > NETIF_F_HW_CSUM. > > To support this in a future adapter, w

[PATCH] via-rhine: NAPI poll enable

2006-07-26 Thread Stephen Hemminger
The poll_enable should be in init_registers before enabling interrupts, not in tx_timeout. Thanks for spotting it Roger. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- sky2.orig/drivers/net/via-rhine.c 2006-07-25 13:43:19.0 -0700 +++ sky2/drivers/net/via-rhine.c2006-0

Re: [PATCH 24/24] RT2x00: Misc. fixes

2006-07-26 Thread Ivo van Doorn
>From Ivo van Doorn <[EMAIL PROTECTED]> Misc. fixes * Compile fixes * Code style fixes previously overlooked * Better check of return values of functions Signed-off-by: Ivo van Doorn <[EMAIL PROTECTED]> diff -rU3 wireless-dev-reginit/drivers/net/wireless/d80211/rt2x00/rt2400pci.c wireless-dev-m

Re: [PATCH 18/24] RT2x00: Make suspend and resume handlers work correctly

2006-07-26 Thread Ivo van Doorn
>From Ivo van Doorn <[EMAIL PROTECTED]> Fix suspend and resume handlers, they should no longer use net_dev->open() and net_dev->stop() since that delivers the wrong behaviour. Signed-off-by: Ivo van Doorn <[EMAIL PROTECTED]> diff -rU3 wireless-dev-init/drivers/net/wireless/d80211/rt2x00/rt2400pc

Re: [PATCH 20/24] RT2x00: Use SET_NETDEV_DEV

2006-07-26 Thread Ivo van Doorn
>From Ivo van Doorn <[EMAIL PROTECTED]> Use SET_NETDEV_DEV to help userspace detect the wireless interfaces. Signed-off-by: Ivo van Doorn <[EMAIL PROTECTED]> diff -rU3 wireless-dev-reset/drivers/net/wireless/d80211/rt2x00/rt2400pci.c wireless-dev-setnetdev/drivers/net/wireless/d80211/rt2x00/rt2

Re: [PATCH 19/24] RT2x00: Simplify *_reset() functions

2006-07-26 Thread Ivo van Doorn
>From Ivo van Doorn <[EMAIL PROTECTED]> The reset function can be greatly simplified. when a reset is required the best thing to do, is to switch the radio off and on again. Signed-off-by: Ivo van Doorn <[EMAIL PROTECTED]> diff -rU3 wireless-dev-suspend/drivers/net/wireless/d80211/rt2x00/rt2400p

Re: [PATCH 22/24] RT2x00: Optimize config handlers

2006-07-26 Thread Ivo van Doorn
>From Ivo van Doorn <[EMAIL PROTECTED]> Optimize the configuration handlers to only run when the current configuration has been changed. This means we need to store the current setting of most configuration options in rt2x00_dev. Signed-off-by: Ivo van Doorn <[EMAIL PROTECTED]> diff -rU3 wireles

Re: [PATCH 16/24] RT2x00: Fix rt61pci interrupt handling

2006-07-26 Thread Ivo van Doorn
>From Ivo van Doorn <[EMAIL PROTECTED]> rt61pci irq is a bit different compared to the others, when the irq is raised, we should read from the register which ring and which entry has been send. And this entry should be processed. Using a for loop to go through all entries is no longer working sinc

Re: [PATCH 23/24] RT2x00: Fix register initialization

2006-07-26 Thread Ivo van Doorn
>From Ivo van Doorn <[EMAIL PROTECTED]> Thanks to ethtool a lot of problems with initialization of the registers has been discovered. This will correctly initialize all registers. Signed-off-by: Ivo van Doorn <[EMAIL PROTECTED]> diff -rU3 wireless-dev-config/drivers/net/wireless/d80211/rt2x00/rt

Re: [PATCH 21/24] RT2x00: Correctly initialize tx_status->control field before packet transmission

2006-07-26 Thread Ivo van Doorn
>From Ivo van Doorn <[EMAIL PROTECTED]> The control field inside the tx_status field of each entry should be correctly initialized when a packet is queued. We can use the same field to pass it to dscape when updating the beacon. Signed-off-by: Ivo van Doorn <[EMAIL PROTECTED]> diff -rU3 wireless

Re: [PATCH 15/24] RT2x00: Merge PCI and USB version of data_entry structure

2006-07-26 Thread Ivo van Doorn
>From Ivo van Doorn <[EMAIL PROTECTED]> Merge the data_entry structure for USB and PCI into a single structure. This means that all access to the data_addr and desc_addr should now be performed through the functions: rt2x00pci_desc_addr() rt2x00pci_data_addr() And for usb: rt2x00usb_urb() rt2x00us

Re: [PATCH 7/24] RT2x00: Add RTS frame creation

2006-07-26 Thread Ivo van Doorn
>From Ivo van Doorn <[EMAIL PROTECTED]> Support RTS. When rts is required, create the frame and send it out before the rest of the frames. Signed-off-by: Ivo van Doorn <[EMAIL PROTECTED]> diff -rU3 wireless-dev-txpower/drivers/net/wireless/d80211/rt2x00/rt2400pci.c wireless-dev-rts/drivers/net/

Re: [PATCH 9/24] RT2x00: Don't use driver_data and driver_info fields

2006-07-26 Thread Ivo van Doorn
>From Ivo van Doorn <[EMAIL PROTECTED]> driver_info and driver_data are not required for rt2x00, neither is there any need to check that field when the probe() function is called. The PCI and USB layers already correctly make the checks. Signed-off-by: Ivo van Doorn <[EMAIL PROTECTED]> diff -rU3

Re: [PATCH 13/24] RT2x00: Allow link tuning while scanning

2006-07-26 Thread Ivo van Doorn
>From Ivo van Doorn <[EMAIL PROTECTED]> rt2x00 does not know when we are scanning, unless passive_scan() is being used. For consistent behaviour we should not block tuning while scanning. We should however not tune the connection when it has been disabled in the hardware. Signed-off-by: Ivo van D

Re: [PATCH 12/24] RT2x00: Add new rt73usb devices

2006-07-26 Thread Ivo van Doorn
>From Ivo van Doorn <[EMAIL PROTECTED]> Add new rt73usb devices. Signed-off-by: Ivo van Doorn <[EMAIL PROTECTED]> diff -rU3 wireless-dev-scan/drivers/net/wireless/d80211/rt2x00/rt73usb.c wireless-dev-newdev/drivers/net/wireless/d80211/rt2x00/rt73usb.c --- wireless-dev-scan/drivers/net/wireless/

Re: [PATCH 14/24] RT2x00: Check if read eeprom words are valid

2006-07-26 Thread Ivo van Doorn
>From Ivo van Doorn <[EMAIL PROTECTED]> Make checks if the EEPROM data read is valid, if it is not, use the default values. Also fix the endian issue when reading the PCI_CONFIG_HEADER. Signed-off-by: Ivo van Doorn <[EMAIL PROTECTED]> diff -rU3 wireless-dev-tuning/drivers/net/wireless/d80211/rt2

Re: [PATCH 11/24] RT2x00: Move scan_work to scanning structure

2006-07-26 Thread Ivo van Doorn
>From Ivo van Doorn <[EMAIL PROTECTED]> Remove scan_work from rt2x00_dev and place it in the scanning structure. Signed-off-by: Ivo van Doorn <[EMAIL PROTECTED]> diff -rU3 wireless-dev-sequence/drivers/net/wireless/d80211/rt2x00/rt2400pci.c wireless-dev-scan/drivers/net/wireless/d80211/rt2x00/r

Re: [PATCH 10/24] RT2x00: Add software and hardware sequence counting

2006-07-26 Thread Ivo van Doorn
>From Ivo van Doorn <[EMAIL PROTECTED]> Add software sequence number counting to rt2400pci and rt2500pci, enable hardware sequence number counting for rt2500usb, rt61pci and rt73usb. Signed-off-by: Ivo van Doorn <[EMAIL PROTECTED]> diff -rU3 wireless-dev-dev/drivers/net/wireless/d80211/rt2x00/rt

Re: [PATCH 8/24] RT2x00: Fix *_set_state() functions

2006-07-26 Thread Ivo van Doorn
>From Ivo van Doorn <[EMAIL PROTECTED]> Fix problems with waking up the device at initialization time. The debug message should be more descriptive of the problem, when the device fails to wake up. Signed-off-by: Ivo van Doorn <[EMAIL PROTECTED]> diff -rU3 wireless-dev-rts/drivers/net/wireless/d

Re: [PATCH 6/24] RT2x00: Add TXPOWER_FROM_DEV and TXPOWER_TO_DEV macros

2006-07-26 Thread Ivo van Doorn
>From Ivo van Doorn <[EMAIL PROTECTED]> Add TXPOWER_FROM_DEV and TXPOWER_TO_DEV macro's to convert the txpower values read from the eeprom to the value dscape expects, and vice versa. Signed-off-by: Ivo van Doorn <[EMAIL PROTECTED]> diff -rU3 wireless-dev-rates/drivers/net/wireless/d80211/rt2x00

Re: [PATCH 5/24] RT2x00: Clean up device specific rate value initialization

2006-07-26 Thread Ivo van Doorn
>From Ivo van Doorn <[EMAIL PROTECTED]> ieee80211_rate structure should be initialized by device_rate_entry And the creation of the device specific rate value can be optimized and made more clearer. Signed-off-by: Ivo van Doorn <[EMAIL PROTECTED]> diff -rU3 wireless-dev-ethtool/drivers/net/wirel

Re: [PATCH 4/24] RT2x00: Add ethtool support

2006-07-26 Thread Ivo van Doorn
>From Ivo van Doorn <[EMAIL PROTECTED]> Add ethtool support. At the moment we support the following features: * read driver info * read registers * read eeprom * enable and disable debug output Signed-off-by: Ivo van Doorn <[EMAIL PROTECTED]> diff -rU3 wireless-dev-pciusb_dev/drivers/net/wirele

Re: [PATCH 2/24] RT2x00: Add interface structure

2006-07-26 Thread Ivo van Doorn
>From Ivo van Doorn <[EMAIL PROTECTED]> Move all settings depending on the current association into a seperate interface structure. Altough we only support 1 association type at a time, we do support multiple monitor devices, keep track of the number using the monitor_count field. Signed-off-by:

[RESEND PATCH 0/24] RT2x00

2006-07-26 Thread Ivo van Doorn
Hi, > Here is a new series of patches to bring rt2x00 in wireless-dev > up to date again. > > I am holding back 2 patches, which will be send later this week, > but they are changes not only to rt2x00, so there is a chance those > patches will be rejected at first. > > Anyway, here are the patch

Re: [PATCH 10/24] RT2x00: Add software and hardware sequence counting

2006-07-26 Thread Jiri Benc
On Wed, 26 Jul 2006 19:48:35 +0200, Ivo van Doorn wrote: > To be the honest the same reason as why I didn't yell about RTS, Yes, another thing that should be in the stack. > I had placed it on my todo list for d80211. ;) Please, if you encounter such thing, speak loudly so everybody interested h

Re: [PATCH 10/24] RT2x00: Add software and hardware sequence counting

2006-07-26 Thread Ivo van Doorn
Hi, > > Add software sequence number counting to rt2400pci and rt2500pci, > > Ah, we don't support sequence numbering in d80211? Why didn't you yell > at me? To be the honest the same reason as why I didn't yell about RTS, I had placed it on my todo list for d80211. ;) But due to limited time I h

Re: [PATCH 10/24] RT2x00: Add software and hardware sequence counting

2006-07-26 Thread Jiri Benc
On Wed, 26 Jul 2006 19:05:08 +0200, Ivo van Doorn wrote: > Add software sequence number counting to rt2400pci and rt2500pci, Ah, we don't support sequence numbering in d80211? Why didn't you yell at me? Jiri -- Jiri Benc SUSE Labs - To unsubscribe from this list: send the line "unsubscribe net

H/W requirements for NETIF_F_HW_CSUM

2006-07-26 Thread Ravinandan Arakali
Hello, Our current NIC does not provide the actual checksum value on receive path. Hence we only claim NETIF_F_IP_CSUM instead of the more general NETIF_F_HW_CSUM. To support this in a future adapter, we would like to know what exactly are the requirements (on both Rx and Tx )to claim NETIF_F_HW_C

[PATCH 12/24] RT2x00: Add new rt73usb devices

2006-07-26 Thread Ivo van Doorn
>From Ivo van Doorn <[EMAIL PROTECTED]> Add new rt73usb devices. Signed-off-by: Ivo van Doorn <[EMAIL PROTECTED]> --- diff -rU3 wireless-dev-scan/drivers/net/wireless/d80211/rt2x00/rt73usb.c wireless-dev-newdev/drivers/net/wireless/d80211/rt2x00/rt73usb.c --- wireless-dev-scan/drivers/net/wire

[PATCH 1/24] RT2x00: Style fix

2006-07-26 Thread Ivo van Doorn
>From Ivo van Doorn <[EMAIL PROTECTED]> Coding style fix. * Reduce the amount of tabs in the code * Put Place function return type and function name on a single line * Replace 'u8 char counter' with 'unsigned int i' * Place '&&', '||' and '|' on the end of a line, instead of at the start. Signed-

Re: [PATCH dscape] d80211: Switch d80211.h to IEEE80211_ style names

2006-07-26 Thread Michael Wu
On Wednesday 26 July 2006 09:53, Jiri Benc wrote: > I just meant running some s/ {8}/\t/ on your patch :-) > > Also, I don't want to fix all of tab issues in d80211 by one big patch. > I always have several patches pending (and other people probably too) > and it leads to unnecessary rejects when a

[PATCH 14/24] RT2x00: Check if read eeprom words are valid

2006-07-26 Thread Ivo van Doorn
>From Ivo van Doorn <[EMAIL PROTECTED]> Make checks if the EEPROM data read is valid, if it is not, use the default values. Also fix the endian issue when reading the PCI_CONFIG_HEADER. Signed-off-by: Ivo van Doorn <[EMAIL PROTECTED]> --- diff -rU3 wireless-dev-tuning/drivers/net/wireless/d8021

[PATCH 11/24] RT2x00: Move scan_work to scanning structure

2006-07-26 Thread Ivo van Doorn
>From Ivo van Doorn <[EMAIL PROTECTED]> Remove scan_work from rt2x00_dev and place it in the scanning structure. Signed-off-by: Ivo van Doorn <[EMAIL PROTECTED]> --- diff -rU3 wireless-dev-sequence/drivers/net/wireless/d80211/rt2x00/rt2400pci.c wireless-dev-scan/drivers/net/wireless/d80211/rt2

[PATCH 20/24] RT2x00: Use SET_NETDEV_DEV

2006-07-26 Thread Ivo van Doorn
>From Ivo van Doorn <[EMAIL PROTECTED]> Use SET_NETDEV_DEV to help userspace detect the wireless interfaces. Signed-off-by: Ivo van Doorn <[EMAIL PROTECTED]> --- diff -rU3 wireless-dev-reset/drivers/net/wireless/d80211/rt2x00/rt2400pci.c wireless-dev-setnetdev/drivers/net/wireless/d80211/rt2x0

[PATCH 15/24] RT2x00: Merge PCI and USB version of data_entry structure

2006-07-26 Thread Ivo van Doorn
>From Ivo van Doorn <[EMAIL PROTECTED]> Merge the data_entry structure for USB and PCI into a single structure. This means that all access to the data_addr and desc_addr should now be performed through the functions: rt2x00pci_desc_addr() rt2x00pci_data_addr() And for usb: rt2x00usb_urb() rt2x00us

[PATCH 3/24] RT2x00: Merge rt2x00_pci and rt2x00_usb

2006-07-26 Thread Ivo van Doorn
>From Ivo van Doorn <[EMAIL PROTECTED]> rt2x00_pci and rt2x00_usb are for 99% equal, the only difference they have are not worth the duplicate code. Merge the structures into rt2x00_dev. Signed-off-by: Ivo van Doorn <[EMAIL PROTECTED]> --- http://www.mendiosus.nl/rt2x00/03_rt2x00_pciusb_dev.dif

[PATCH 2/24] RT2x00: Add interface structure

2006-07-26 Thread Ivo van Doorn
>From Ivo van Doorn <[EMAIL PROTECTED]> Move all settings depending on the current association into a seperate interface structure. Altough we only support 1 association type at a time, we do support multiple monitor devices, keep track of the number using the monitor_count field. Signed-off-by:

[PATCH 0/24] RT2x00

2006-07-26 Thread Ivo van Doorn
Hi, Here is a new series of patches to bring rt2x00 in wireless-dev up to date again. I am holding back 2 patches, which will be send later this week, but they are changes not only to rt2x00, so there is a chance those patches will be rejected at first. Anyway, here are the patches for rt2x00 on

[PATCH 24/24] RT2x00: Misc. fixes

2006-07-26 Thread Ivo van Doorn
>From Ivo van Doorn <[EMAIL PROTECTED]> Misc. fixes * Compile fixes * Code style fixes previously overlooked * Better check of return values of functions Signed-off-by: Ivo van Doorn <[EMAIL PROTECTED]> --- diff -rU3 wireless-dev-reginit/drivers/net/wireless/d80211/rt2x00/rt2400pci.c wireless-

[PATCH 13/24] RT2x00: Allow link tuning while scanning

2006-07-26 Thread Ivo van Doorn
>From Ivo van Doorn <[EMAIL PROTECTED]> rt2x00 does not know when we are scanning, unless passive_scan() is being used. For consistent behaviour we should not block tuning while scanning. We should however not tune the connection when it has been disabled in the hardware. Signed-off-by: Ivo van D

[PATCH 7/24] RT2x00: Add RTS frame creation

2006-07-26 Thread Ivo van Doorn
>From Ivo van Doorn <[EMAIL PROTECTED]> Support RTS. When rts is required, create the frame and send it out before the rest of the frames. Signed-off-by: Ivo van Doorn <[EMAIL PROTECTED]> --- diff -rU3 wireless-dev-txpower/drivers/net/wireless/d80211/rt2x00/rt2400pci.c wireless-dev-rts/drivers

[PATCH 10/24] RT2x00: Add software and hardware sequence counting

2006-07-26 Thread Ivo van Doorn
>From Ivo van Doorn <[EMAIL PROTECTED]> Add software sequence number counting to rt2400pci and rt2500pci, enable hardware sequence number counting for rt2500usb, rt61pci and rt73usb. Signed-off-by: Ivo van Doorn <[EMAIL PROTECTED]> --- diff -rU3 wireless-dev-dev/drivers/net/wireless/d80211/rt2x

[PATCH 8/24] RT2x00: Fix *_set_state() functions

2006-07-26 Thread Ivo van Doorn
>From Ivo van Doorn <[EMAIL PROTECTED]> Fix problems with waking up the device at initialization time. The debug message should be more descriptive of the problem, when the device fails to wake up. Signed-off-by: Ivo van Doorn <[EMAIL PROTECTED]> --- diff -rU3 wireless-dev-rts/drivers/net/wirel

[PATCH 22/24] RT2x00: Optimize config handlers

2006-07-26 Thread Ivo van Doorn
>From Ivo van Doorn <[EMAIL PROTECTED]> Optimize the configuration handlers to only run when the current configuration has been changed. This means we need to store the current setting of most configuration options in rt2x00_dev. Signed-off-by: Ivo van Doorn <[EMAIL PROTECTED]> --- diff -rU3 wi

[PATCH 16/24] RT2x00: Fix rt61pci interrupt handling

2006-07-26 Thread Ivo van Doorn
>From Ivo van Doorn <[EMAIL PROTECTED]> rt61pci irq is a bit different compared to the others, when the irq is raised, we should read from the register which ring and which entry has been send. And this entry should be processed. Using a for loop to go through all entries is no longer working sinc

[PATCH 4/24] RT2x00: Add ethtool support

2006-07-26 Thread Ivo van Doorn
>From Ivo van Doorn <[EMAIL PROTECTED]> Add ethtool support. At the moment we support the following features: * read driver info * read registers * read eeprom * enable and disable debug output Signed-off-by: Ivo van Doorn <[EMAIL PROTECTED]> --- diff -rU3 wireless-dev-pciusb_dev/drivers/net/w

[PATCH 5/24] RT2x00: Clean up device specific rate value initialization

2006-07-26 Thread Ivo van Doorn
>From Ivo van Doorn <[EMAIL PROTECTED]> ieee80211_rate structure should be initialized by device_rate_entry And the creation of the device specific rate value can be optimized and made more clearer. Signed-off-by: Ivo van Doorn <[EMAIL PROTECTED]> --- diff -rU3 wireless-dev-ethtool/drivers/net/

[PATCH 18/24] RT2x00: Make suspend and resume handlers work correctly

2006-07-26 Thread Ivo van Doorn
>From Ivo van Doorn <[EMAIL PROTECTED]> Fix suspend and resume handlers, they should no longer use net_dev->open() and net_dev->stop() since that delivers the wrong behaviour. Signed-off-by: Ivo van Doorn <[EMAIL PROTECTED]> --- diff -rU3 wireless-dev-init/drivers/net/wireless/d80211/rt2x00/rt2

[PATCH 21/24] RT2x00: Correctly initialize tx_status->control field before packet transmission

2006-07-26 Thread Ivo van Doorn
>From Ivo van Doorn <[EMAIL PROTECTED]> The control field inside the tx_status field of each entry should be correctly initialized when a packet is queued. We can use the same field to pass it to dscape when updating the beacon. Signed-off-by: Ivo van Doorn <[EMAIL PROTECTED]> --- diff -rU3 wi

[PATCH 19/24] RT2x00: Simplify *_reset() functions

2006-07-26 Thread Ivo van Doorn
>From Ivo van Doorn <[EMAIL PROTECTED]> The reset function can be greatly simplified. when a reset is required the best thing to do, is to switch the radio off and on again. Signed-off-by: Ivo van Doorn <[EMAIL PROTECTED]> --- diff -rU3 wireless-dev-suspend/drivers/net/wireless/d80211/rt2x00/rt

[PATCH 17/24] RT2x00: reorganize allocation/initialization of ieee80211_hw and rt2x00

2006-07-26 Thread Ivo van Doorn
>From Ivo van Doorn <[EMAIL PROTECTED]> Fix initialization of driver/hardware. Make a clear seperation between allocation and initialization. Remove the open() and stop() functions since they have been deprecated by dscape some time ago. Signed-off-by: Ivo van Doorn <[EMAIL PROTECTED]> --- http

[PATCH 23/24] RT2x00: Fix register initialization

2006-07-26 Thread Ivo van Doorn
>From Ivo van Doorn <[EMAIL PROTECTED]> Thanks to ethtool a lot of problems with initialization of the registers has been discovered. This will correctly initialize all registers. Signed-off-by: Ivo van Doorn <[EMAIL PROTECTED]> --- diff -rU3 wireless-dev-config/drivers/net/wireless/d80211/rt2x

[PATCH 9/24] RT2x00: Don't use driver_data and driver_info fields

2006-07-26 Thread Ivo van Doorn
>From Ivo van Doorn <[EMAIL PROTECTED]> driver_info and driver_data are not required for rt2x00, neither is there any need to check that field when the probe() function is called. The PCI and USB layers already correctly make the checks. Signed-off-by: Ivo van Doorn <[EMAIL PROTECTED]> --- diff

[PATCH 6/24] RT2x00: Add TXPOWER_FROM_DEV and TXPOWER_TO_DEV macros

2006-07-26 Thread Ivo van Doorn
>From Ivo van Doorn <[EMAIL PROTECTED]> Add TXPOWER_FROM_DEV and TXPOWER_TO_DEV macro's to convert the txpower values read from the eeprom to the value dscape expects, and vice versa. Signed-off-by: Ivo van Doorn <[EMAIL PROTECTED]> --- diff -rU3 wireless-dev-rates/drivers/net/wireless/d80211/r

Re: [PATCH dscape] d80211: Switch d80211.h to IEEE80211_ style names

2006-07-26 Thread Jiri Benc
On Wed, 26 Jul 2006 09:43:55 -0700, Michael Wu wrote: > I still want to convert d80211_mgmt.h. Once that's done, I'll look through > for > those tabs/spaces & long lines formatting issues. I won't mind if you start > fixing some of those issues now, however. :) I just meant running some s/ {8}/

Re: Who maintains the website ?

2006-07-26 Thread Stephen Hemminger
On Wed, 26 Jul 2006 12:14:01 +0200 Christophe Devriese <[EMAIL PROTECTED]> wrote: > I have created the http://linux-net.osdl.org/index.php/VLAN page. > What do you think ? I changed the mainpage VLAN to point to that. You might want to move the generic (non-linux stuff) to wikipedia. http

Re: [PATCH dscape] d80211: Switch d80211.h to IEEE80211_ style names

2006-07-26 Thread Michael Wu
On Wednesday 26 July 2006 09:32, Jiri Benc wrote: > One more thing (hopefully the last one), could you try to keep lines > under 80 characters? I understand that with such long identifiers it is > not always possible (it dramatically reduces readability of the code if > you try to force the limit i

Re: [PATCH dscape] d80211: Switch d80211.h to IEEE80211_ style names

2006-07-26 Thread Jiri Benc
On Mon, 24 Jul 2006 23:02:50 -0700, Michael Wu wrote: > These two attached patches also roll in a switch to MAC_FMT and MAC_ARG, and > use IEEE80211_DATA_LEN when possible. Otherwise, it's the same as before > except split into two patches. Nice, thanks a lot. One more thing (hopefully the last

  1   2   >