Re: [-mm patch] remove net/core/skbuff.c:skb_queue_lock_key

2006-07-14 Thread Arjan van de Ven
Adrian Bunk wrote: On Thu, Jul 13, 2006 at 10:48:00PM -0700, Andrew Morton wrote: ... Changes since 2.6.18-rc1-mm1: ... +lockdep-split-the-skb_queue_head_init-lock-class.patch lockdep-versus-net fix. ... skb_queue_lock_key is no longer used. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>

Re: [PATCH 08/10] MLSXFRM: Add security context to acquire messages using PF_KEY

2006-07-14 Thread Herbert Xu
On Fri, Jul 14, 2006 at 09:54:59AM -0400, James Morris wrote: > > Herbert, any review from you on this would be greatly appreciated. OK, I'll try to have a look tomorrow (I'm GMT-4 at the moment). Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECT

Re: [PATCH 3/7] NetLabel: CIPSOv4 engine

2006-07-14 Thread James Morris
On Fri, 14 Jul 2006, [EMAIL PROTECTED] wrote: > + > +/* Label mapping cache */ > +int cipso_v4_cache_enabled = 1; > +int cipso_v4_cache_bucketsize = 10; > +static struct cipso_v4_map_cache_bkt *cipso_v4_cache = NULL; > +#define CIPSO_V4_CACHE_ENABLED (cipso_v4_cache_enabled &&\ > +

Re: [PATCH 3/7] NetLabel: CIPSOv4 engine

2006-07-14 Thread James Morris
On Fri, 14 Jul 2006, [EMAIL PROTECTED] wrote: > +/** > + * cipso_v4_bitmap_walk - Walk a bitmap looking for a bit > + * cipso_v4_bitmap_setbit - Sets a single bit in a bitmap Can you use lib/bitmap.c instead? -- James Morris <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line

Re: [PATCH 0/4] e1000: fixes for 7.1.9-k2

2006-07-14 Thread Matt Mackall
On Fri, Jul 14, 2006 at 05:15:18PM -0700, Jeff Kirsher wrote: > Matt, > The patch you are referring to is in patch set emails that Auke sent out. Doesn't look like it made it here. > I have also copied the patch below: I'm going to assume all the tab damage here is an artifact. Otherwise, looks

[PATCH] Fix slab corruption with netem

2006-07-14 Thread Guillaume Chazarain
Hello, CONFIG_DEBUG_SLAB found the following bug: netem_enqueue() in sch_netem.c gets a pointer inside a slab object: struct netem_skb_cb *cb = (struct netem_skb_cb *)skb->cb; But then, the slab object may be freed: skb = skb_unshare(skb, GFP_ATOMIC) cb is still pointing inside the freed skb, s

[2.6 patch] net/core/user_dma.c should #include

2006-07-14 Thread Adrian Bunk
Every file should #include the headers containing the prototypes for its global functions. Especially in cases like this one where gcc can tell us through a compile error that the prototype was wrong... Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- include/net/netdma.h |2 +- net/co

[-mm patch] remove net/core/skbuff.c:skb_queue_lock_key

2006-07-14 Thread Adrian Bunk
On Thu, Jul 13, 2006 at 10:48:00PM -0700, Andrew Morton wrote: >... > Changes since 2.6.18-rc1-mm1: >... > +lockdep-split-the-skb_queue_head_init-lock-class.patch > > lockdep-versus-net fix. >... skb_queue_lock_key is no longer used. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- include

[2.6 patch] drivers/net/wireless/zd1211rw/: possible cleanups

2006-07-14 Thread Adrian Bunk
This patch contains the following possible cleanups: - make needlessly global functions static - #if 0 unused functions Please review which of these functions do make sense and which do conflict with pending patches. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- This patch was already sen

Re: [PATCH 0/4] e1000: fixes for 7.1.9-k2

2006-07-14 Thread Jeff Kirsher
On 7/14/06, Matt Mackall <[EMAIL PROTECTED]> wrote: On Fri, Jul 14, 2006 at 04:24:52PM -0700, Kok, Auke wrote: > > Jeff, > > Please pull the following patches from > > git://lost.foo-projects.org/~ahkok/git/netdev-2.6 upstream-fixes-jgarzik > (based on 22e1170310ec6afa41e0dc7ac9dfac735d82dcab) >

Re: [NET]: Update frag_list in pskb_trim

2006-07-14 Thread Herbert Xu
On Thu, Jul 13, 2006 at 10:05:26PM -0700, David Miller wrote: > > As I noted already, this is in my tree and will go off to > Linus soon. > > Please toss this over to -stable under seperate cover, if > you haven't done so already. Please add my signoff: > > Signed-off-by: David S. Miller <[EMAI

Re: [PATCH 0/4] e1000: fixes for 7.1.9-k2

2006-07-14 Thread Matt Mackall
On Fri, Jul 14, 2006 at 04:24:52PM -0700, Kok, Auke wrote: > > Jeff, > > Please pull the following patches from > > git://lost.foo-projects.org/~ahkok/git/netdev-2.6 upstream-fixes-jgarzik > (based on 22e1170310ec6afa41e0dc7ac9dfac735d82dcab) > > To receive the following fixes for e1000: > > [

Re: 2.6.18-rc1-mm2

2006-07-14 Thread Herbert Xu
On Fri, Jul 14, 2006 at 12:05:51AM -0700, Andrew Morton wrote: > > > Call Trace: > > [] show_trace+0xae/0x265 > > [] dump_stack+0x15/0x1b > > [] skb_checksum_help+0x61/0x126 > > [] :iptable_nat:ip_nat_fn+0x5f/0x1d2 This is tell you that there is a bug in ip_nat_fn in that it completes the

Re: [PATCH 3/7] NetLabel: CIPSOv4 engine

2006-07-14 Thread James Morris
On Fri, 14 Jul 2006, [EMAIL PROTECTED] wrote: > +int cipso_v4_validate(unsigned char **option) > +{ > + unsigned char *opt = *option; > + unsigned char *tag; > + unsigned char opt_iter; > + unsigned char err_offset = 0; > + unsigned char locked = 0; > + u8 opt_len; > +

Re: [PATCH 2/7] NetLabel: core network changes

2006-07-14 Thread David Miller
From: James Morris <[EMAIL PROTECTED]> Date: Fri, 14 Jul 2006 19:34:20 -0400 (EDT) > On Fri, 14 Jul 2006, [EMAIL PROTECTED] wrote: > > > +static inline void netlbl_put_hdr(unsigned char *buffer, > > + const u32 msg_type, > > + const u16 msg_

Re: [PATCH] VLAN code can use the faster ether_compare_addr

2006-07-14 Thread David Miller
From: Ben Greear <[EMAIL PROTECTED]> Date: Fri, 14 Jul 2006 14:36:17 -0700 > Stephen Hemminger wrote: > > The inline function compare_ether_addr is faster than memcmp. > > Also, don't need to drag in proc_fs.h, the only reference to proc_dir_entry > > is a pointer so the declaration is needed here

Re: [PATCH 2/7] NetLabel: core network changes

2006-07-14 Thread James Morris
On Fri, 14 Jul 2006, [EMAIL PROTECTED] wrote: > +static inline void netlbl_put_hdr(unsigned char *buffer, > + const u32 msg_type, > + const u16 msg_len, > + const u16 msg_flags, > +

Re: [RFC] HTB initialize upper bound properly

2006-07-14 Thread David Miller
From: Jamal Hadi Salim <[EMAIL PROTECTED]> Date: Fri, 14 Jul 2006 18:06:26 -0400 > On Fri, 2006-14-07 at 12:03 -0700, Stephen Hemminger wrote: > > The upper bound for HTB time diff needs to be scaled to PSCHED > > units rather than just assuming usecs. The field mbuffer is used > > in TDIFF_SAFE(

[PATCH 3/4] e1000: fix panic on large frame receive when mtu=default

2006-07-14 Thread Kok, Auke
A panic was reported when receiving 1522 size packets if using the default MTU. we should set the initial rx buffer length to the value that e1000changemtu sets so that we can receive any packet that would not be dropped by LPE=0. Signed-off-by: Jesse Brandeburg <[EMAIL PROTECTED]> Signed-off-by:

[PATCH 0/4] e1000: fixes for 7.1.9-k2

2006-07-14 Thread Kok, Auke
Jeff, Please pull the following patches from git://lost.foo-projects.org/~ahkok/git/netdev-2.6 upstream-fixes-jgarzik (based on 22e1170310ec6afa41e0dc7ac9dfac735d82dcab) To receive the following fixes for e1000: [01]: Redo netpoll fix [02]: remove CRC bytes from measured packet length [03]: fi

[PATCH 1/4] e1000: Redo netpoll fix to address community concerns

2006-07-14 Thread Kok, Auke
The original suggested fix for netpoll was found to be racy on SMP kernels. While it is highly unlikely that this race would ever be seen in the real world due to current netpoll usage models, we implemented this updated fix to address concerns. Signed-off-by: Mitch Williams <[EMAIL PROTECTED]> S

[PATCH 2/4] e1000: remove CRC bytes from measured packet length

2006-07-14 Thread Kok, Auke
After removing the hardware CRC stripping which causes problems with SOL and related issues, we need to compensate for this changed size. Signed-off-by: Jesse Brandeburg <[EMAIL PROTECTED]> Signed-off-by: Auke Kok <[EMAIL PROTECTED]> --- drivers/net/e1000/e1000_main.c | 10 +- 1 files

[PATCH 4/4] e1000: bump version to 7.1.9-k4

2006-07-14 Thread Kok, Auke
Bump the version to 7.1.9-k4 to indicate three extra changes. Signed-off-by: Auke Kok <[EMAIL PROTECTED]> --- drivers/net/e1000/e1000_main.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net/e1000/e1000_main.c b/drivers/net/e1000/e1000_main.c index 154acb2..d

[patch] ieee80211: TKIP requires CRC32

2006-07-14 Thread Chuck Ebbert
ieee80211_crypt_tkip will not work without CRC32. LD .tmp_vmlinux1 net/built-in.o: In function `ieee80211_tkip_encrypt': net/ieee80211/ieee80211_crypt_tkip.c:349: undefined reference to `crc32_le' Reported by Toralf Foerster <[EMAIL PROTECTED]> Signed-off-by: Chuck Ebbert <[EMAIL PROTECTE

Re: [PATCH] remove unused routines from d80211 version of bcm43xx

2006-07-14 Thread Michael Buesch
On Friday 14 July 2006 23:04, you wrote: > This patch removes some unused static inline routines from bcm43xx-d80211 > version of bcm43xx_main.h. > > Signed-Off-By: Larry Finger <[EMAIL PROTECTED]> Signed-off-by: Michael Buesch <[EMAIL PROTECTED]> > =

Re: [RFC] HTB initialize upper bound properly

2006-07-14 Thread Jamal Hadi Salim
On Fri, 2006-14-07 at 12:03 -0700, Stephen Hemminger wrote: > The upper bound for HTB time diff needs to be scaled to PSCHED > units rather than just assuming usecs. The field mbuffer is used > in TDIFF_SAFE(), as an upper bound. Untested... > > Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED

Re: [PATCH] clear skb cb on IP input

2006-07-14 Thread David Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Fri, 14 Jul 2006 11:56:21 -0700 > when data arrives at IP through loopback (and possibly other devices). > So the field needs to be cleared before it confuses the route code. > This was seen when running netem over loopback, but there are probably

Re: [PATCH] VLAN code can use the faster ether_compare_addr

2006-07-14 Thread Ben Greear
Stephen Hemminger wrote: The inline function compare_ether_addr is faster than memcmp. Also, don't need to drag in proc_fs.h, the only reference to proc_dir_entry is a pointer so the declaration is needed here. Looks fine to me. Ben Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> ---

Re: 2.6.18-rc1-mm2: drivers/char/*synclink* compile errors

2006-07-14 Thread David Miller
From: Adrian Bunk <[EMAIL PROTECTED]> Date: Fri, 14 Jul 2006 20:48:25 +0200 > Krzysztof, the following compile errors are caused by your commit > c2ce920468624d87ec5f91f080ea99681dae6d88 in Linus' tree: Yes, we let Krzysztof know about this yesterday. If we don't get a fix over the weekend I wi

[PATCH] VLAN code can use the faster ether_compare_addr

2006-07-14 Thread Stephen Hemminger
The inline function compare_ether_addr is faster than memcmp. Also, don't need to drag in proc_fs.h, the only reference to proc_dir_entry is a pointer so the declaration is needed here. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- include/linux/if_vlan.h |5 +++-- 1 files change

[PATCH] remove unused routines from d80211 version of bcm43xx

2006-07-14 Thread Larry Finger
This patch removes some unused static inline routines from bcm43xx-d80211 version of bcm43xx_main.h. Signed-Off-By: Larry Finger <[EMAIL PROTECTED]> === index e228833..04d8b91 100644 --- a/drivers/net/wireless/d80211/bcm43xx/bcm43xx_main.

[PATCH] Try #2, Improved statistics for bcm43xx-softmac

2006-07-14 Thread Larry Finger
This minor patch for wireless-2.6 (softmac) adjusts the parameters of the wireless statistics to improve the display of programs such as the "Wireless Network Information" applet of KDE. Thanks to Dan Williams and Jean Tourrilhes for valuable help in setting up the return of info in dBm. Signed

[RFC] HTB initialize upper bound properly

2006-07-14 Thread Stephen Hemminger
The upper bound for HTB time diff needs to be scaled to PSCHED units rather than just assuming usecs. The field mbuffer is used in TDIFF_SAFE(), as an upper bound. Untested... Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- netem-2.6.orig/net/sched/sch_htb.c +++ netem-2.6/net/sched/sc

[PATCH 0/7] Latest NetLabel patch for 2.6.19

2006-07-14 Thread paul . moore
I am posting this patchset for consideration and inclusion into the 2.6.19 kernel, it is against 2.6.18-rc1. This patchset introduces NetLabel, a implementation of explicit packet labeling (i.e. CIPSO), to the Linux kernel. NetLabel has been designed to have as minimal an impact on the base netwo

[PATCH 7/7] NetLabel: tie NetLabel into the Kconfig system

2006-07-14 Thread paul . moore
Modify the net/Kconfig file to enable selecting the NetLabel Kconfig options. Signed-off-by: Paul Moore <[EMAIL PROTECTED]> --- net/Kconfig |2 ++ 1 files changed, 2 insertions(+) Index: linux-2.6.18-rc1/net/Kconfig === --- linu

[PATCH 2/7] NetLabel: core network changes

2006-07-14 Thread paul . moore
Changes to the core network stack to support the NetLabel subsystem. This includes changes to the IPv4 option handling to support CIPSO labels, and a new NetLabel hook in inet_accept() to handle NetLabel attributes across accept() calls done by in-kernel daemons. Signed-off-by: Paul Moore <[EMAIL

[PATCH 1/7] NetLabel: documentation

2006-07-14 Thread paul . moore
Documentation for the NetLabel system, this includes a basic overview of how NetLabel works, how LSM developers can integrate it into their favorite LSM, as well as documentation on the CIPSO related sysctl variables. Also, due to the difficulty of finding expired IETF drafts, I am including the I

[PATCH 3/7] NetLabel: CIPSOv4 engine

2006-07-14 Thread paul . moore
Add support for the Commercial IP Security Option (CIPSO) to the IPv4 network stack. CIPSO has become a de-facto standard for trusted/labeled networking amongst existing Trusted Operating Systems such as Trusted Solaris, HP-UX CMW, etc. This implementation is designed to be used with the NetLabel

[PATCH 6/7] NetLabel: SELinux support

2006-07-14 Thread paul . moore
Add NetLabel support to the SELinux LSM and modify the socket_post_create() LSM hook to return an error code. The most significant part of this patch is the addition of NetLabel hooks into the following SELinux LSM hooks: * selinux_file_permission() * selinux_socket_sendmsg() * selinux_socket_

[PATCH 5/7] NetLabel: CIPSOv4 and Unlabeled packet integration

2006-07-14 Thread paul . moore
Add CIPSO/IPv4 and unlabeled packet management to the NetLabel subsystem. The CIPSO/IPv4 changes allow the configuration of CIPSO/IPv4 within the overall NetLabel framework. The unlabeled packet changes allows NetLabel to pass unlabeled packets without error. Signed-off-by: Paul Moore <[EMAIL PR

[PATCH] clear skb cb on IP input

2006-07-14 Thread Stephen Hemminger
when data arrives at IP through loopback (and possibly other devices). So the field needs to be cleared before it confuses the route code. This was seen when running netem over loopback, but there are probably other device cases. Maybe this should go into stable? Signed-off-by: Stephen Hemminger <

Re: smsc911x driver

2006-07-14 Thread Stephen Hemminger
On Fri, 14 Jul 2006 14:11:34 + "Bahadir Balban" <[EMAIL PROTECTED]> wrote: > Attached is a driver patch for SMSC911x family of ethernet chips, > generated against 2.6.18-rc1 sources. There's a similar driver in the > tree; this one has been tested by SMSC on all flavors of the chip and > claim

2.6.18-rc1-mm2: drivers/char/*synclink* compile errors

2006-07-14 Thread Adrian Bunk
Krzysztof, the following compile errors are caused by your commit c2ce920468624d87ec5f91f080ea99681dae6d88 in Linus' tree: <-- snip --> ... CC drivers/char/pcmcia/synclink_cs.o drivers/char/pcmcia/synclink_cs.c: In function ‘dcd_change’: drivers/char/pcmcia/synclink_cs.c:1171: error: im

Re: Netem does not work with loopback

2006-07-14 Thread Guillaume Chazarain
Stephen Hemminger wrote: No, the correct fix is to make IP input not accept any options from the device. OK. Does this work? Yes it does. Thank you very much. -- Guillaume - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] M

Re: Netem does not work with loopback

2006-07-14 Thread Stephen Hemminger
On Fri, 14 Jul 2006 19:04:01 +0200 Guillaume Chazarain <[EMAIL PROTECTED]> wrote: > Stephen Hemminger wrote : > > Isn't the skb owned by netem at that point... > > > Thank you, that makes sense to me. > But then the loopback device reinjects the skb without cleaning skb->cb. > > The attached p

Re: I/O Acceleration Technology Nics

2006-07-14 Thread Andrew Grover
On 7/14/06, Ian Brown <[EMAIL PROTECTED]> wrote: I came across the e1000 download for linux in intel site. I saw that in the readme they talk about Intel(R) I/O Acceleration Technology; According to this readme , there is support for "systems using the Intel(R) 5000 Series Chipsets Integrated D

Re: Error acx-20060215 wireless module

2006-07-14 Thread John W. Linville
On Fri, Jul 14, 2006 at 06:08:46PM +0200, VinX wrote: > Hi, > on my gentoo with kernel 2.6.18-rc1 I had this error: > -- > CC [M] /var/tmp/portage/acx-0.3.35/work/pci.o > /var/tmp/portage/acx-0.3.35/work/pci.c: In function `acxpci_e_probe': > /var/tmp/portage/acx-0.3.35/work/pci.c:1652: error: `

Re: [PATCH] bcm43xx-softmac: Further improvement in wireless statistics

2006-07-14 Thread Larry Finger
Jean, Jean Tourrilhes wrote: I must admit that the original definition was too clever (or too ambiguous, or too original, take your pick). range->max_qual.level is always supposed to have a meaningfull value. People that did not understand that original definition just put 0 there, as i

Re: Netem does not work with loopback

2006-07-14 Thread Guillaume Chazarain
Stephen Hemminger wrote : Isn't the skb owned by netem at that point... Thank you, that makes sense to me. But then the loopback device reinjects the skb without cleaning skb->cb. The attached patch solves the problem for me (netem on lo). Maybe the correct solution would be to make a skb->d

Re: I/O Acceleration Technology Nics

2006-07-14 Thread Rick Jones
Ian Brown wrote: Hello, I came across the e1000 download for linux in intel site. I saw that in the readme they talk about Intel(R) I/O Acceleration Technology; According to this readme , there is support for "systems using the Intel(R) 5000 Series Chipsets Integrated Device - 1A38". see: http

Re: Error acx-20060215 wireless module

2006-07-14 Thread Kyle McMartin
On Fri, Jul 14, 2006 at 06:08:46PM +0200, VinX wrote: > I think that it's missing on this file! > Wow. Why does so much out of tree shite want UTS_RELEASE? I'm (untested) thinking that instead they could just put in their Makefile: CFLAGS += -D KERNVERSION=$(KERNELVERSION) And obtain it from t

Re: [PATCH] bcm43xx-softmac: Further improvement in wireless statistics

2006-07-14 Thread Jean Tourrilhes
On Thu, Jul 13, 2006 at 11:37:45PM -0400, Dan Williams wrote: > On Tue, 2006-07-11 at 23:03 -0500, Larry Finger wrote: > > Dan Williams wrote: > > > > > > NAK... remember, range->max_qual.level must be _0_ if you're in dBm, > > > > I do not think this is right. From the comments in include/linux/

[PATCHv2 2.6.18-rc1-mm2 2/3] net/ipv4: UDP-Lite v4 support

2006-07-14 Thread Gerrit Renker
RFC 3828-compliant kernel support for UDP-Lite over IPv4. Signed-off-by: Gerrit Renker <[EMAIL PROTECTED]> Signed-off-by: William Stanislaus <[EMAIL PROTECTED]> --- include/net/xfrm.h |2 net/ipv4/Makefile |1 net/ipv4/af_inet.c | 17 net/ipv4/proc.c| 33 - net/ipv4/udplite.c |

[PATCHv2 2.6.18-rc1-mm2 1/3] net: UDP-Lite generic support

2006-07-14 Thread Gerrit Renker
Generic support (header files, configuration, and documentation) for the UDP-Lite protocol (RFC 3828). This has been tested successfully on AMD, i386/i686, and SMP architectures (compiles cleanly and works under different configurations). With regard to the previously submitted patch set, no conc

[PATCHv2 2.6.18-rc1-mm2 3/3] net/ipv6: UDP-Lite v6 support

2006-07-14 Thread Gerrit Renker
RFC 3828-compliant kernel support for UDP-Lite over IPv6. Signed-off-by: Gerrit Renker <[EMAIL PROTECTED]> Signed-off-by: William Stanislaus <[EMAIL PROTECTED]> --- net/ipv6/Makefile |1 net/ipv6/af_inet6.c |8 net/ipv6/proc.c | 22 net/ipv6/udplite.c | 1276

RE: [PATCH]NET: Add ECN support for TSO

2006-07-14 Thread Dan Reader
> My take is that the ECT code point should also be replicated on > all TSO segments. When RFC3540 is implemented, the stack will > randomly use ECT(0) or ECT(1) on the TSO super segments. On > each of these super segments, the hardware will replicate the ECT > code point. This will keep every

Error acx-20060215 wireless module

2006-07-14 Thread VinX
Hi, on my gentoo with kernel 2.6.18-rc1 I had this error: -- CC [M] /var/tmp/portage/acx-0.3.35/work/pci.o /var/tmp/portage/acx-0.3.35/work/pci.c: In function `acxpci_e_probe': /var/tmp/portage/acx-0.3.35/work/pci.c:1652: error: `UTS_RELEASE' undeclared (first use in this function) /var/tmp/po

X.25 support on Linux

2006-07-14 Thread Majumder, Rajib
Hi, I am just wondering if there's any kernel support for X.25 on Linux. I can use either RHEL3(2.4.21) or SLES9(2.6.5). Any input would be appreciated. Thanks Rajib == Please access the attached hyperlink for an im

[PATCH] orinoco: fix setting transmit key only

2006-07-14 Thread Dan Williams
When determining whether there's a key to set or not, orinoco should be looking at the key length, not the key data. Otherwise confusion reigns when trying to set TX key only, passing in zero-length key, but non-NULL pointer. Key length takes precedence over non-NULL key data. Signed-off-by: Dan

Re: Netem does not work with loopback

2006-07-14 Thread Stephen Hemminger
On Fri, 14 Jul 2006 16:34:30 +0200 Guillaume Chazarain <[EMAIL PROTECTED]> wrote: > Hello, > > Is it a known problem that the Netem qdisc is very unreliable on the > loopback (unlike on a true NIC)? > > This seems to come from its usage of skb->cb which conflicts with IPCB. > For instance, the

Re: [PATCH 2/2] correct dev_alloc_skb kerneldoc

2006-07-14 Thread chas williams - CONTRACTOR
In message <[EMAIL PROTECTED]>,David Miller writes: >From: Christoph Hellwig <[EMAIL PROTECTED]> >Date: Thu, 13 Jul 2006 22:36:16 +0200 >> - drivers/atm/{idt77252.c, nicstar.c}, drivers/usb/atm/usbatm.c: >> These use private skb queues and do odd things. I can't see >> any point for usi

Bluetooth update for 2.6

2006-07-14 Thread Marcel Holtmann
Hi Dave, here are two more bug fixes for the Bluetooth subsystem. Both are workarounds for either broken implementations or broken hardware. Regards Marcel Please pull from git://git.kernel.org/pub/scm/linux/kernel/git/holtmann/bluetooth-2.6.git This will update the following files:

Netem does not work with loopback

2006-07-14 Thread Guillaume Chazarain
Hello, Is it a known problem that the Netem qdisc is very unreliable on the loopback (unlike on a true NIC)? This seems to come from its usage of skb->cb which conflicts with IPCB. For instance, the field IPCB(skb)->opt.optlen becomes non-null and memory corruption follows. I ``worked aroun

Patch "[PKT_SCHED]: PSCHED_TADD() and PSCHED_TADD2() can result,tv_usec >= 1000000" seems wrong

2006-07-14 Thread Guillaume Chazarain
Hello, This patch: http://www.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=4ee303dfeac6451b402e3d8512723d3a0f861857 looks wrong. In PSCHED_TADD2, if delta is less than tv.tv_usec (so, less than USEC_PER_SEC too) then tv_res will be before tv. The affectation (tv_res

Re: [PATCH 08/10] MLSXFRM: Add security context to acquire messages using PF_KEY

2006-07-14 Thread James Morris
On Thu, 13 Jul 2006, David Miller wrote: > The other changes I'm either OK with, or they are outside my scope of > knowledge (the stuff that lives inside of SELINUX). The security side of things looks ok to me. Herbert, any review from you on this would be greatly appreciated. - James -- Jame

Re: linux 2.6.16 routing problem

2006-07-14 Thread Brian F. G. Bidulock
Mayuresh, On Fri, 14 Jul 2006, Mayuresh Chitale wrote: > > If anyone has solved similar problem or knows what causes this > problem, please let me know. > > Any suggestion is welcome. Configure a static arp entry for the tester on the unit under test. (Or configure the tester to respond to ARP

linux 2.6.16 routing problem

2006-07-14 Thread Mayuresh Chitale
Hi All, I am doing routing performance test using smartbits tester. The traffic is pumped by smartapplications (that runs on smartbits). I see that the routing goes on for some time, then the fps(pps) value starts dropping until it becomes zero. This is for rates less than 10Mb/s and packet size

Re: [DOC]: generic netlink

2006-07-14 Thread Jamal Hadi Salim
On Thu, 2006-13-07 at 10:50 -0700, Randy.Dunlap wrote: > On Mon, 19 Jun 2006 09:41:22 -0400 jamal wrote: > > > > > Folks, > > > > Attached is a document that should help people wishing to use generic > > netlink interface. It is a WIP so a lot more to go if i see interest. > > Hi, > I have a fe

Re: rt2x00/rt2500 support

2006-07-14 Thread Jiri Benc
On Thu, 13 Jul 2006 16:36:29 -0400, Dan Williams wrote: > Ok; this is because d80211 (at least as included in rt2x00 driver) isn't > setting the wireless stats handler, which I believe makes the device > show up in /proc/net/wireless. > (...) > > Jiri, what's involved here? The actual handler for

Re: [SLHC 1/4] Cleanup SLHC configuration

2006-07-14 Thread Ralf Baechle
Convert selection of serial line header compression to use CONFIG_SLHC rather than makefile ifeq uglyness. This makes it easier to select the SLHC module from other code. Signed-off-by: Ralf Baechle <[EMAIL PROTECTED]> --- drivers/isdn/i4l/Kconfig |1 + drivers/net/Kconfig |8 +

[SLHC 1/4] Cleanup SLHC configuration

2006-07-14 Thread Ralf Baechle
On Thu, Jul 13, 2006 at 10:07:18PM -0700, David Miller wrote: > Subject: Re: [SLHC 1/4] Cleanup SLHC configuration > From: David Miller <[EMAIL PROTECTED]> > Content-Type: Text/Plain; charset=us-ascii > > From: Ralf Baechle <[EMAIL PROTECTED]> > Date: Thu, 13 Jul 2006 12:06:15 +0100 > > > Conver

I/O Acceleration Technology Nics

2006-07-14 Thread Ian Brown
Hello, I came across the e1000 download for linux in intel site. I saw that in the readme they talk about Intel(R) I/O Acceleration Technology; According to this readme , there is support for "systems using the Intel(R) 5000 Series Chipsets Integrated Device - 1A38". see: http://downloadmirror.in

Re: 2.6.18-rc1-mm2

2006-07-14 Thread David Miller
From: Reuben Farrelly <[EMAIL PROTECTED]> Date: Fri, 14 Jul 2006 18:55:42 +1200 > Ugh. This on bootup.. > > Starting HAL daemon: BUG: warning at net/core/dev.c:1171/skb_checksum_help() It's perfectly normal, and it's there to remind us that we need to deal with an incremental checksumming issue

Re: michael_mic in crypto api?

2006-07-14 Thread Michael Wu
On Thursday 13 July 2006 23:50, Michael Wu wrote: > Is there really a point to having michael_mic in crypto api? The only users > are 802.11 stacks. I can imagine arc4 being used for other purposes, but > michael_mic is very much wireless only. The only advantage of keeping > michael_mic in crypto

[PATCH dscape] d80211: Add sparse bitwise annotations

2006-07-14 Thread Michael Wu
This patch adds sparse bitwise annotations to d80211. Signed-off-by: Michael Wu <[EMAIL PROTECTED]> --- include/net/d80211.h |6 +++--- include/net/d80211_mgmt.h | 42 +- net/d80211/ieee80211_sta.c |7 +-- 3 files changed, 25 insertion

Re: 2.6.18-rc1-mm2

2006-07-14 Thread Andrew Morton
On Fri, 14 Jul 2006 18:55:42 +1200 Reuben Farrelly <[EMAIL PROTECTED]> wrote: > On 14/07/2006 5:48 p.m., Andrew Morton wrote: > > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.18-rc1/2.6.18-rc1-mm2/ > > > > - Patches were merged, added, dropped and fixed. Nothing particularly