Re: [2.6 patch] net/ipv4/netfilter/: fix SYSCTL=n compile

2006-07-08 Thread Patrick McHardy
Adrian Bunk wrote: > This patch fixes the following compile error with CONFIG_SYSCTL=n > introduced by commit 39a27a35c5c1b5be499a0576a35c45a011788bf8: My fault I guess. > <-- snip --> > > ... > LD .tmp_vmlinux1 > net/built-in.o: In function `tcp_error': > ip_conntrack_proto_tcp.c:(.te

[PATCH] bcm43xx-d80211: opencoded locking

2006-07-08 Thread Michael Buesch
Hi John, please apply to wireless-dev. -- Port of the "opencoded locking" patch from bcm43xx-softmac to bcm43xx-d80211. Signed-off-by: Michael Buesch <[EMAIL PROTECTED]> Index: wireless-dev-dscapeports/drivers/net/wireless/d80211/bcm43xx/bcm43xx.h ==

[PATCH] bcm43xx-d80211: AccessPoint mode

2006-07-08 Thread Michael Buesch
Hi John, Please apply this to wireless-dev. -- This patch adds AP mode support to the bcm43xx-d80211 driver. Initial patch from Alexander Tsvyashchenko. Thanks a lot! Signed-off-by: Michael Buesch <[EMAIL PROTECTED]> Cc: "Francois Barre" <[EMAIL PROTECTED]> Cc: "Alexander Tsvyashchenko" <[EMAI

Re: [PATCH 2/3] [VLAN]: Update iif when receiving via VLAN device

2006-07-08 Thread Thomas Graf
* Thomas Graf <[EMAIL PROTECTED]> 2006-07-09 01:46 > __LINK_STATE_QDISC_RUNNING will prevent an eventual tx deadlock, > it will not prevent the mirred deadlock. BTW, it will also not protect you from deadlocking on dev->queue_lock while enqueueing. - To unsubscribe from this list: send the line "u

Re: [PATCH 2/3] [VLAN]: Update iif when receiving via VLAN device

2006-07-08 Thread Thomas Graf
* Jamal Hadi Salim <[EMAIL PROTECTED]> 2006-07-08 10:14 > I dont know if i tested for the above specific setup. I have to look at > my testcases when i get the opportunity. > The problem is: > There is no easy way to detect such a deadlock. I think it reduces to > the same case as eth0->eth0, i.e:

Re: jumbo frames and memory fragmentation

2006-07-08 Thread Evgeniy Polyakov
On Fri, Jun 30, 2006 at 05:35:34PM -0600, Chris Friesen ([EMAIL PROTECTED]) wrote: > Evgeniy Polyakov wrote: > > >It definitely will. > >Packet split in hardware means separating data and headers into > >different pages in different reads, while software page split means that > >skb has a list o

Re: [NET]: Fix IPv4/DECnet routing rule dumping

2006-07-08 Thread David Miller
Applied, and pushed to -stable. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/2] correct dev_alloc_skb kerneldoc

2006-07-08 Thread David Miller
From: Christoph Hellwig <[EMAIL PROTECTED]> Date: Sat, 8 Jul 2006 12:48:12 +0200 > My plan is to give dev_alloc_skb a struct netdevice * argument and > introduce a alloc_netdev_node so the driver can tell what node the > device is on. This gives a significant speedup for cell. I already > have t

Re: [1/2] [NET] gso: Add skb_is_gso

2006-07-08 Thread David Miller
From: Herbert Xu <[EMAIL PROTECTED]> Date: Sat, 8 Jul 2006 13:53:02 +1000 > These two patches fix the netfilter/checksum/TSO problem where netfilter > destroys the partial checksum which breaks TSO. Both applied, thanks Herbert. - To unsubscribe from this list: send the line "unsubscribe netdev"

Re: [2.6 patch] fix drivers/net/irda/ali-ircc.c:ali_ircc_init()

2006-07-08 Thread David Miller
From: Adrian Bunk <[EMAIL PROTECTED]> Date: Sat, 8 Jul 2006 03:28:05 +0200 > The Coverity checker spotted, that from the changes from commit > 898b1d16f8230fb912a0c2248df685735c6ceda3 the >if (ret) >platform_driver_unregister(&ali_ircc_driver); > was dead code. > > This p

Re: [PATCH]NET: Add ECN support for TSO

2006-07-08 Thread David Miller
From: "Michael Chan" <[EMAIL PROTECTED]> Date: Fri, 7 Jul 2006 18:01:34 -0700 > However, Large Receive Offload will be a different story. If > packets are accumulated in the hardware and presented to the stack > as one large packet, the stack will not be able to calculate the > cumulative NS corr

Re: [PATCH 2/2][ATM]: fix possible recursive locking in skb_migrate()

2006-07-08 Thread David Miller
From: "chas williams - CONTRACTOR" <[EMAIL PROTECTED]> Date: Fri, 07 Jul 2006 20:50:23 -0400 > please consider for 2.6.18 -- thanks! > > [ATM]: fix possible recursive locking in skb_migrate() > > ok this is a real potential deadlock in a way, it takes two locks of 2 > skbuffs without doing any k

Re: [PATCH 1/2][ATM]: Typo in drivers/atm/Kconfig...

2006-07-08 Thread David Miller
From: "chas williams - CONTRACTOR" <[EMAIL PROTECTED]> Date: Fri, 07 Jul 2006 20:50:00 -0400 > please consider for 2.6.18 -- thanks! > > [ATM]: Typo in drivers/atm/Kconfig... > > From: Matt LaPlante <[EMAIL PROTECTED]> > Signed-off-by: Charles Williams <[EMAIL PROTECTED]> Applied, thanks Chas.

Re: [PATCH] tg3: add amd8131 to "write reorder" chipsets

2006-07-08 Thread David Miller
From: "John W. Linville" <[EMAIL PROTECTED]> Date: Fri, 7 Jul 2006 14:58:36 -0400 > Add the AMD 8131 bridge to the list of chipsets that reorder writes. > > Signed-off-by: John W. Linville <[EMAIL PROTECTED]> Applied, thanks John. - To unsubscribe from this list: send the line "unsubscribe netde

[2.6 patch] net/ipv4/netfilter/: fix SYSCTL=n compile

2006-07-08 Thread Adrian Bunk
This patch fixes the following compile error with CONFIG_SYSCTL=n introduced by commit 39a27a35c5c1b5be499a0576a35c45a011788bf8: <-- snip --> ... LD .tmp_vmlinux1 net/built-in.o: In function `tcp_error': ip_conntrack_proto_tcp.c:(.text+0x77af6): undefined reference to `ip_conntrack_che

[2.6 patch] net/atm/clip.c: fix PROC_FS=n compile

2006-07-08 Thread Adrian Bunk
This patch fixes the following compile error with CONFIG_PROC_FS=n by reverting commit dcdb02752ff13a64433c36f2937a58d93ae7a19e: <-- snip --> ... CC net/atm/clip.o net/atm/clip.c: In function ‘atm_clip_init’: net/atm/clip.c:975: error: ‘atm_proc_root’ undeclared (first use in this func

[PATCH] bcm43xx: init routine rewrite

2006-07-08 Thread Michael Buesch
Hi John, Please apply this to wireless-2.6. -- Rewrite of the bcm43xx initialization routines. This fixes several issues: * up-down-up-down-up... stale data issue (May fix some DHCP issues) * Fix the init vs IRQ handler race (and remove the workaround) * Fix init for cards with multiple cores

Re: [patch] work around/fix deadlock in the bcm43xx driver by making netlink irq safe

2006-07-08 Thread Michael Buesch
On Saturday 08 July 2006 19:59, you wrote: > kernel: stack backtrace: > kernel: [] show_trace_log_lvl+0x13d/0x160 > kernel: [] show_trace+0x1b/0x20 > kernel: [] dump_stack+0x26/0x30 > kernel: [] check_usage+0x26d/0x280 > kernel: [] __lock_acquire+0x77f/0xdd0 > kernel: [] lock_acquire+0x68/0x9

Re: [patch] work around/fix deadlock in the bcm43xx driver by making netlink irq safe

2006-07-08 Thread Larry Finger
Arjan van de Ven wrote: Joseph Jezak wrote: Can you provide the details to the list? I'll look into getting SoftMAC fixed if you do. sure the basic issue is that bcm43xx does it's rx processing in a softirq, and holds the bcm->irq_lock during that time. The rx processing calls into the sof

Re: rtl8139: NETDEV WATCHDOG: eth0: transmit timed out

2006-07-08 Thread Thomas Hellström
Hi! Marcus Better wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 (For those haven't followed, this is about http://permalink.gmane.org/gmane.linux.network/38493 ) Francois Romieu wrote: Marcus Better <[EMAIL PROTECTED]> : I'm seeing this problem on my Acer Travelmate 223X la

[PATCH] airo: make debug-like messages printed by airo_print_dbg()

2006-07-08 Thread Robert Schulze
I don't think that messages like airo(eth1): cmd= 111 airo(eth1): status= 7f11 airo(eth1): Rsp0= 2 airo(eth1): Rsp1= 0 airo(eth1): Rsp2= 0 are interesting to normal users, so switch them from airo_print_err() to airo_print_dbg(). Furthermore, remove implicit linefeed in those messages, as t

Re: [PATCH 2/3] [VLAN]: Update iif when receiving via VLAN device

2006-07-08 Thread Jamal Hadi Salim
On Sat, 2006-08-07 at 10:14 -0400, Jamal Hadi Salim wrote: > I have a dated patch to mirred (may not apply cleanly) Sorry forgot to attach the patch. Attached for real this time;-> > that i believe > will fix this specific one. Try to see if it also fixes this case you > have. I meant i know

Re: [PATCH 2/3] [VLAN]: Update iif when receiving via VLAN device

2006-07-08 Thread Jamal Hadi Salim
On Sat, 2006-08-07 at 12:54 +0200, Thomas Graf wrote: > * jamal <[EMAIL PROTECTED]> 2006-07-01 09:35 > It's pretty clear actually, given eth0->ifb0->ifb1 it would look > like: > > dev_queue_xmit(eth0) > tcf_mirred -> ifb0 > dev_queue_xmit(ifb0) > tcf_mirred -> ifb1 > dev_queue_xmit(ifb1) >

Re: starting mc triggers lockdep

2006-07-08 Thread Christoph Hellwig
On Sat, Jul 08, 2006 at 11:53:20AM +0200, Arjan van de Ven wrote: > > Did I miss something? > > is it not possible to nfs export /sys, and then mount it over loopback? No, it's not. A filesystem needs dedicated routines to support nfs exporting and sysfs doesn't have those. - To unsubscribe fro

d80211 sysfs

2006-07-08 Thread Ivo Van Doorn
Hi, I have recently updated the 80211 stack located in the rt2x00 CVS tree to use the latest version of the stack from the dscape#devel git tree. I also added the scanning patch from GertJan that was only available in the dscape#main tree. Since I didn't want to loose any tested because of the n

Re: airo maybe should select crypto_aes

2006-07-08 Thread Robert Schulze
Hi, Herbert Xu schrieb: First of your patch is space-damaged. Please make sure that the original tabs are preserved and resend. Sorry for that, hope it fits this time. Also, wireless patches should be sent to this list with a cc to John W. Linville <[EMAIL PROTECTED]>. Didn't know that.

Re: starting mc triggers lockdep

2006-07-08 Thread Herbert Xu
On Sat, Jul 08, 2006 at 11:53:20AM +0200, Arjan van de Ven wrote: > > > > now for the third part, which involves the nfs client: > > > stat on an nfs file, which ends up taken the i_mutex of a directory in > > > the path (obvious), and then does > > > [] tcp_sendmsg+0x1e/0xb1a > > > []

[NET]: Fix IPv4/DECnet routing rule dumping

2006-07-08 Thread Patrick McHardy
[NET]: Fix IPv4/DECnet routing rule dumping When more rules are present than fit in a single skb, the remaining rules are incorrectly skipped. Signed-off-by: Patrick McHardy <[EMAIL PROTECTED]> --- commit 68fb2d31c9c960fea945f8ed81ba2200cde104d4 tree 603c24a722ebe9834b7ae337ba9f6d69cbb6258f par

Re: [PATCH 2/3] [VLAN]: Update iif when receiving via VLAN device

2006-07-08 Thread Thomas Graf
* jamal <[EMAIL PROTECTED]> 2006-07-01 09:35 > On Sat, 2006-01-07 at 13:28 +0200, Thomas Graf wrote: > > Please enlighten me, I may be making a wrong assumption again. > > > > 1) tc_verd is reset to 0 after dq in ri_tasklet() > > 2) TC_AT is set to AT_EGRESS in dev_queue_xmit() > > 3) TC_FROM bein

Re: 2.6.17-mm3

2006-07-08 Thread Michal Piotrowski
Stephen Hemminger napisał(a): > On Tue, 27 Jun 2006 16:12:42 +0200 > "Michal Piotrowski" <[EMAIL PROTECTED]> wrote: > >> Hi, >> >> On 27/06/06, Andrew Morton <[EMAIL PROTECTED]> wrote: >>> ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.17/2.6.17-mm3/ >>> >>> >> It looks like a s

Re: [PATCH 2/2] correct dev_alloc_skb kerneldoc

2006-07-08 Thread Christoph Hellwig
On Fri, Jul 07, 2006 at 04:55:27PM -0700, David Miller wrote: > From: Stephen Hemminger <[EMAIL PROTECTED]> > Date: Fri, 7 Jul 2006 15:52:55 -0700 > > > What is the point of dev_alloc_skb anyway? all it does is add header space. > > In stone-age times it actually had specific semantics, but yes t

Re: starting mc triggers lockdep

2006-07-08 Thread Arjan van de Ven
On Sat, 2006-07-08 at 13:00 +1000, Herbert Xu wrote: > Arjan van de Ven <[EMAIL PROTECTED]> wrote: > > > > i_mutex is taken within rtln_mutex like this: > > [] create_dir+0x2c/0x1e2 > > [] sysfs_create_dir+0x59/0x78 > > [] kobject_add+0x114/0x1d8 > > [] class_device_add+0xb

Re: skge error; hangs w/ hardware memory hole

2006-07-08 Thread Martin Michlmayr
* Andi Kleen <[EMAIL PROTECTED]> [2006-07-07 23:28]: > Is that a board with VIA chipset? Yes, according to lspci, there's a VIA K8T800Pro and VT8237. :00:00.0 Host bridge: VIA Technologies, Inc. K8T800Pro Host Bridge :00:00.1 Host bridge: VIA Technologies, Inc. K8T800Pro Host Bridge