RE: [PATCH] Gianfar SKB Recycling Support

2006-05-17 Thread Haruki Dai-r35557
> -Original Message- > From: Stephen Hemminger [mailto:[EMAIL PROTECTED] > Sent: Wednesday, May 17, 2006 5:49 PM > To: Haruki Dai-r35557 > Cc: netdev@vger.kernel.org; Fleming Andy-afleming; Kumar > Gala; Haruki Dai-r35557 > Subject: Re: [PATCH] Gianfar SKB Recycling Support > > On Wed, 1

RE: [PATCH] Gianfar SKB Recycling Support

2006-05-17 Thread Haruki Dai-r35557
> -Original Message- > From: Andi Kleen [mailto:[EMAIL PROTECTED] > Sent: Wednesday, May 17, 2006 5:56 PM > To: Haruki Dai-r35557 > Cc: netdev@vger.kernel.org; Fleming Andy-afleming; Kumar Gala > Subject: Re: [PATCH] Gianfar SKB Recycling Support > > On Thursday 18 May 2006 00:45, Haruki

Re: [PATCH 3/4] myri10ge - Driver core

2006-05-17 Thread Arnd Bergmann
Am Thursday 18 May 2006 00:06 schrieb Brice Goglin: > +static char *myri10ge_fw_name = NULL; > +static char *myri10ge_fw_unaligned = "myri10ge_ethp_z8e.dat"; > +static char *myri10ge_fw_aligned = "myri10ge_eth_z8e.dat"; > +static int myri10ge_ecrc_enable = 1; > +static int myri10ge_max_intr_slots

Re: [PATCH] Gianfar SKB Recycling Support

2006-05-17 Thread Andi Kleen
On Thursday 18 May 2006 00:45, Haruki Dai-r35557 wrote: > This patch improves the IP forwarding throughput of > the Freescale TSEC/eTSEC Gianfar driver. By recycling > the Socket buffer and Data buffer, reduce the unnecessary > memory allocation and de-allocation in the forwarding > processing chai

Re: [PATCH] Gianfar SKB Recycling Support

2006-05-17 Thread Stephen Hemminger
On Wed, 17 May 2006 15:45:14 -0700 "Haruki Dai-r35557" <[EMAIL PROTECTED]> wrote: > This patch improves the IP forwarding throughput of > the Freescale TSEC/eTSEC Gianfar driver. By recycling > the Socket buffer and Data buffer, reduce the unnecessary > memory allocation and de-allocation in the f

[PATCH] Gianfar SKB Recycling Support

2006-05-17 Thread Haruki Dai-r35557
This patch improves the IP forwarding throughput of the Freescale TSEC/eTSEC Gianfar driver. By recycling the Socket buffer and Data buffer, reduce the unnecessary memory allocation and de-allocation in the forwarding processing chain. Signed-off-by: Dai Haruki <[EMAIL PROTECTED]> Signed-off-by: A

Re: [PATCH 3/4] myri10ge - Driver core

2006-05-17 Thread Roland Dreier
Still some suspicious uses of volatile here. For example: > +struct myri10ge_priv { ... > + volatile u8 __iomem *sram; as far as I can see this is always used with proper __iomem accessors, often with casts to strip the volatile anyway. So why is volatile needed? I would suggest an audit

Re: [PATCH 2/4] myri10ge - Driver header files

2006-05-17 Thread Randy.Dunlap
On Wed, 17 May 2006 18:04:35 -0400 Brice Goglin wrote: > [PATCH 2/4] myri10ge - Driver header files > > myri10ge_mcp.h| 205 > ++ > myri10ge_mcp_gen_header.h | 58 + Please use "diffstat -p 1 -w 70" is documented in Document

[PATCH 4/4] myri10ge - Kconfig and Makefile

2006-05-17 Thread Brice Goglin
[PATCH 4/4] myri10ge - Kconfig and Makefile Add Kconfig and Makefile support for the myri10ge driver. Signed-off-by: Brice Goglin <[EMAIL PROTECTED]> Signed-off-by: Andrew J. Gallatin <[EMAIL PROTECTED]> Kconfig | 16 Makefile |1 + myri10ge/Makefile |

Re: [PATCH 3/6] new pcmcia IDs for hostap

2006-05-17 Thread Pavel Roskin
On Wed, 2006-05-17 at 10:36 +0200, Marcin Juszkiewicz wrote: > That one I sent to You, lkml over month ago but you had it already in > 24-hostap_cs_id.diff patch (which you told later to ignore). Sorry, I was swamped with other things and didn't have time to recheck all entries. > Signed-off-by:

[PATCH 2/4] myri10ge - Driver header files

2006-05-17 Thread Brice Goglin
[PATCH 2/4] myri10ge - Driver header files myri10ge driver header files. myri10ge_mcp.h is the generic header, while myri10ge_mcp_gen_header.h is automatically generated from our firmware image. Signed-off-by: Brice Goglin <[EMAIL PROTECTED]> Signed-off-by: Andrew J. Gallatin <[EMAIL PROTECTED]>

[PATCH 1/4] myri10ge - Revive pci_find_ext_capability

2006-05-17 Thread Brice Goglin
[PATCH 1/4] myri10ge - Revive pci_find_ext_capability This patch revives pci_find_ext_capability (has been disabled a couple month ago since it was not used anywhere. See http://lkml.org/lkml/2006/1/20/247). It will now be used by the myri10ge driver. Signed-off-by: Brice Goglin <[EMAIL PROTECTED

[PATCH 0/4] myri10ge - Myri-10G Ethernet driver - v2

2006-05-17 Thread Brice Goglin
[PATCH 0/4] myri10ge - Myri-10G Ethernet driver - v2 The following patches introduce the myri10ge driver for Myricom Myri-10G boards in Ethernet mode. The driver is called myri10ge. The patches are against 2.6.17-rc4-mm1. [1/4] revive pci_find_ext_capability [2/4] myri10ge driver header files

[PATCH 1/5] sky2: allow dual port usage

2006-05-17 Thread Stephen Hemminger
If both ports are receiving on the SysKonnect dual port cards, then it appears the bus interface unit can give an interrupt status for frame before DMA has completed. This leads to bogus frames and general confusion. This is why receive checksumming is also messed up on dual port cards. A workaro

[PATCH 5/5] sky2 version 1.4

2006-05-17 Thread Stephen Hemminger
Need to track impact of this group of changes. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- sky2.orig/drivers/net/sky2.c2006-05-16 10:10:13.0 -0700 +++ sky2/drivers/net/sky2.c 2006-05-16 10:10:15.0 -0700 @@ -51,7 +51,7 @@ #include "sky2.h" #define DRV_N

[PATCH 0/5] sky2 bugfixes for 2.6.17

2006-05-17 Thread Stephen Hemminger
Set of bug fixes to address issues on dual port cards, and the new Yukon Ultra used on many vendors new dual core laptops. Since Linus seems to have ignored the last sky2 patch, this set is based on 2.6.17-rc4 latest. -- - To unsubscribe from this list: send the line "unsubscribe netdev" in the

[PATCH 3/5] sky2: more fixes for Yukon Ultra

2006-05-17 Thread Stephen Hemminger
Logic error in the phy initialization code. Also, turn on wake on lan bit in status control. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- sky2.orig/drivers/net/sky2.c2006-05-17 08:55:51.0 -0700 +++ sky2/drivers/net/sky2.c 2006-05-17 08:55:54.0 -0700 @@ -23

[PATCH 2/5] Subjec: sky2, skge: correct PCI id for DGE-560T

2006-05-17 Thread Stephen Hemminger
The Dlink DGE-560T uses Yukon2 chipset so it needs sky2 driver; and the DGE-530T uses Yukon1 so it uses skge driver. Bug: http://bugzilla.kernel.org/show_bug.cgi?id=6544 Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- sky2.orig/drivers/net/skge.c2006-04-27 11:12:39.0 -07

[PATCH 4/5] sky2: force NAPI repoll if busy

2006-05-17 Thread Stephen Hemminger
If the status ring processing can't keep up with the incoming frames, it is more efficient to have NAPI keep scheduling the poll routine rather than causing another interrupt. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- sky2.orig/drivers/net/sky2.c2006-05-17 08:55:54.000

Re: Please pull 'upstream' branch of wireless-2.6

2006-05-17 Thread Daniel Drake
John W. Linville wrote: Daniel Drake: set_security implementation inside softmac If it's not too late, can you drop this one? I didn't receive any feedback on it, and I decided it's not the right approach. The interface isn't great, but when done at the driver level it allows drivers t

Re: dl2k: PCI parity error

2006-05-17 Thread Jon Mason
On Sat, May 13, 2006 at 09:57:15AM -0700, Shane wrote: > Hello list, > > Not sure if this is the best place to report this. I seem > to be having a conflict of sorts and believe it may be a > dl2k issue. The card is a Dlink 550t gigabit pci-64 card. > When connected to the pci-64 slot on the mb

Please pull 'upstream' branch of wireless-2.6

2006-05-17 Thread John W. Linville
The following changes since commit 59d4b684fbe74b25ac8593f39d2aaa86aa485b1f: John W. Linville: Merge branch 'upstream-fixes' into upstream are found in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless-2.6.git upstream Arjan van de Ven: unu

Please pull 'upstream-fixes' branch of wireless-2.6

2006-05-17 Thread John W. Linville
The following changes since commit 0c056c50a6218e0e577817c16ba8851af593d742: Linus Torvalds: Merge master.kernel.org:/.../gregkh/spi-2.6 are found in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless-2.6.git upstream-fixes David Woodhouse:

Re: send(), sendmsg(), sendto() not thread-safe

2006-05-17 Thread Benjamin Reed
These discussions degrade quickly. I'm not proposing using pread() on a socket. I was pointing out that you can do two concurrent pread() invocations on the same file descriptor (for a file) and get consistent results. It would be nice if you can do two concurrent sendmsg() invocations on the same

Re: send(), sendmsg(), sendto() not thread-safe

2006-05-17 Thread Rick Jones
Benjamin Reed wrote: In the case of lseek() and read(), you can use pread(). What is the meaning of the offset parameter of pread() for TCP or UDP etc? rick jones - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo i

Re: [PATCH 3/6] new pcmcia IDs for hostap

2006-05-17 Thread John W. Linville
On Wed, May 17, 2006 at 10:36:03AM +0200, Marcin Juszkiewicz wrote: > Platform: Sharp Zaurus C760 running 2.6.16 and pcmciautils 013. > > [EMAIL PROTECTED]:~# pccardctl ident > Socket 0: > product info: "Pretec", "CompactWLAN Card 802.11b", "2.5" > manfid: 0x0156, 0x0002 > function: 6 (netw

Re: send(), sendmsg(), sendto() not thread-safe

2006-05-17 Thread Benjamin Reed
You are using the wrong examples, which may be why you don't understand the problem Mark identified. --- Christopher Friesen <[EMAIL PROTECTED]> wrote: > There have always been possible issues with > concurrent access to > sockets/fds. > > Or consider calling lseek() from one task, while > doing

Re: send(), sendmsg(), sendto() not thread-safe

2006-05-17 Thread Christopher Friesen
Benjamin Reed wrote: I think Mark's point isn't about "atomic" writes; instead, he was pointing out that when a programmer reads that a call is thread-safe he usually understands that to mean that it does not need to be protected by a lock when used by multiple threads. This thread-safe iss

Re: send(), sendmsg(), sendto() not thread-safe

2006-05-17 Thread Benjamin Reed
David et al, I think you may be missing the point. David S. Miller wrote: > I don't understand why the desire is so high to > ensure that individual threads get "atomic" writes, > you can't even ensure that in the general case. I think Mark's point isn't about "atomic" writes; instead, he was po

max number of subnets/addresses?

2006-05-17 Thread Christopher Friesen
I've been asked a couple of questions by our engineering guys. 1) Is there any inherent limit on the number of IP addresses that can be configured on an interface? 2) Is there any inherent limit on the number of subnets that a linux host can have configured at any given time? If anyone cou

Re: [RFC] SECMARK 1.1

2006-05-17 Thread James Morris
On Wed, 17 May 2006, Thomas Bleher wrote: > This all looks very nice - Thank You! > Just one question: does the code canonicalize the security label? It > would be nice if the same rules could be used on MLS and non-MLS > systems. No, it shouldn't be necessary, as there's no legacy installed base

Re: [RFC] SECMARK 1.1

2006-05-17 Thread Thomas Bleher
* James Morris <[EMAIL PROTECTED]> [2006-05-14 08:03]: > Included below is an incremental patch against the initial secmark posting > last week: http://thread.gmane.org/gmane.linux.network/34927/focus=34927 > > This posting to gather feedback on changes made since then primarily to > address con

Re: [Bug 6421] kernel 2.6.10-2.6.16 on alpha: arch/alpha/kernel/io.c, iowrite16_rep() BUG_ON((unsigned long)src & 0x1) triggered

2006-05-17 Thread Herbert Xu
On Tue, May 16, 2006 at 11:44:17PM -0700, [EMAIL PROTECTED] wrote: > http://bugzilla.kernel.org/show_bug.cgi?id=6421 > > --- Additional Comments From [EMAIL PROTECTED] 2006-05-16 23:43 --- > Another stack trace. skb_padto() is not called. > > May 16 23:50:34 merlin kernel: ei_start_xmit()

a short look at d80211

2006-05-17 Thread Johannes Berg
Hi, I finally decided to familiarise myself with d80211 a bit more :) Here are some questions on the code again. MICHAEL_MIC_HWACCEL seems to be always defined, what is it used for? IEEE80211_LEDS should probably go away, in fact it should be fairly easy to register a led trigger driver for eac

[XEN 1/2] [NET] front: Remove tx_full and unnecessary queue operations

2006-05-17 Thread Herbert Xu
Hi: [NET] front: Remove tx_full and unnecessary queue operations The tx_full variable merely mirrors information already present in the XOFF bit on the net device. The net device architecture itself is quite mature and can be trusted by Xen to maintain its state correctly. Also, it's pointless

[XEN 2/2] [NET] front: Replace user_state with netif_running

2006-05-17 Thread Herbert Xu
Hi: [NET] front: Replace user_state with netif_running The user_state variable is simply replicating information that's already present through netif_running. Signed-off-by: Herbert Xu <[EMAIL PROTECTED]> Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAI

Re: skge driver oops

2006-05-17 Thread Krzysztof Oledzki
On Wed, 17 May 2006, Beschorner Daniel wrote: As David and me are using SMP systems when it's crashing, should I give a non-SMP kernel a try, to see if it's some kind of race conditon? You may also try this, where ethX is your skge driven ethernet device: /usr/sbin/ethtool -K ethX tx off

skge driver oops

2006-05-17 Thread Beschorner Daniel
As David and me are using SMP systems when it's crashing, should I give a non-SMP kernel a try, to see if it's some kind of race conditon? Daniel - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.ke

Re: [PATCH 3/6] new pcmcia IDs for hostap

2006-05-17 Thread Marcin Juszkiewicz
Dnia wtorek, 16 maja 2006 23:15, Pavel Roskin napisaƂ: > On Tue, 2006-05-16 at 17:24 +0200, Marcin Juszkiewicz wrote: > > product info: "D-Link", "DCF-660W", "", "" > > manfid: 0xd601, 0x0005 > This manfid is in the driver already, dropped then > > product info: "NETGEAR", "MA701 Wireless