Re: Initial benchmarks of some VJ ideas [mmap memcpy vs copy_to_user].

2006-05-10 Thread Evgeniy Polyakov
On Wed, May 10, 2006 at 12:58:48PM -0700, David S. Miller ([EMAIL PROTECTED]) wrote: > From: Evgeniy Polyakov <[EMAIL PROTECTED]> > Date: Mon, 8 May 2006 16:24:22 +0400 > > > I hope he does not take offence at name shortening :) > > Perhaps you are still not convinced how truly expensive the cod

Re: [Bugme-new] [Bug 6530] New: MAINLINE

2006-05-10 Thread Andrew Morton
Andy Gay <[EMAIL PROTECTED]> wrote: > > On Wed, 2006-05-10 at 20:27 +1000, Paul Mackerras wrote: > > Andrew Morton writes: > > > > > hm, a PPP fix. We seem to need some of those lately. > > > > > > Paul, does this look sane? > > > > /me pages in 7 year old code... > > > > > @@ -516,6 +516,8 @@

Re: [Bugme-new] [Bug 6530] New: MAINLINE

2006-05-10 Thread Andy Gay
On Wed, 2006-05-10 at 20:27 +1000, Paul Mackerras wrote: > Andrew Morton writes: > > > hm, a PPP fix. We seem to need some of those lately. > > > > Paul, does this look sane? > > /me pages in 7 year old code... > > > @@ -516,6 +516,8 @@ static void ppp_async_process(unsigned l > > /* try t

Re: [Bugme-new] [Bug 6530] New: MAINLINE

2006-05-10 Thread Andrew Morton
Paul Mackerras <[EMAIL PROTECTED]> wrote: > > Andrew Morton writes: > > > xeb has said: > > > > in this construction: > > > > if ((test_bit(XMIT_WAKEUP, &ap->xmit_flags) || > > test_bit(XMIT_FULL, &ap->xmit_flags)) && ppp_async_push(ap)) > > ppp_output_wa

Re: [Bugme-new] [Bug 6530] New: MAINLINE

2006-05-10 Thread Paul Mackerras
Andrew Morton writes: > xeb has said: > > in this construction: > > if ((test_bit(XMIT_WAKEUP, &ap->xmit_flags) || > test_bit(XMIT_FULL, &ap->xmit_flags)) && ppp_async_push(ap)) > ppp_output_wakeup(&ap->chan); > > if ppp_async_push() doesn't send any dat

Re: [PATCH] bonding: fix sparse warnings

2006-05-10 Thread Stephen Hemminger
On Thu, 11 May 2006 00:22:03 +0100 Al Viro <[EMAIL PROTECTED]> wrote: > On Wed, May 10, 2006 at 04:14:05PM -0700, Stephen Hemminger wrote: > > Fix warning from sparse in bonding code about "incorrect type in assignment" > > *snerk* > > Only if you are building without -Wcast-to-as. It _is_ inco

Re: [PATCH] bcm43xx: Fix array overrun in bcm43xx_geo_init

2006-05-10 Thread Andrew Morton
Michael Buesch <[EMAIL PROTECTED]> wrote: > > The problem here is that the bcm34xx driver and the ieee80211 > stack do not agree on what channels are possible for 802.11a. > The ieee80211 stack only wants channels between 34 and 165, while > the bcm43xx driver accepts anything from 0 to 200. I made

Re: [Bugme-new] [Bug 6530] New: MAINLINE

2006-05-10 Thread Andrew Morton
Paul Mackerras <[EMAIL PROTECTED]> wrote: > > Andrew Morton writes: > > > hm, a PPP fix. We seem to need some of those lately. > > > > Paul, does this look sane? > > /me pages in 7 year old code... > > > @@ -516,6 +516,8 @@ static void ppp_async_process(unsigned l > > /* try to push more s

Re: r8169+NAPI soft lockup

2006-05-10 Thread Richard Gregory
Francois Romieu wrote: Richard Gregory <[EMAIL PROTECTED]> : [...] # locked in 1 min. Output in bug5.txt $ for i in `seq 0 26` ; do cat /dev/md1 > /dev/tcp/linuxbox/9 & $ cat /dev/md0 > /dev/tcp/localhost/9 Can you replace /dev/tcp/foo with a simple /dev/null and send the output of 'vmstat 1

Re: [RFC PATCH 34/35] Add the Xen virtual network device driver.

2006-05-10 Thread Herbert Xu
Andi Kleen <[EMAIL PROTECTED]> wrote: > > But if sampling virtual events for randomness is really unsafe (is it > really?) then native guests in Xen would also get bad random numbers > and this would need to be somehow addressed. Good point. I wonder what VMWare does in this situation. -- Visi

[PATCH] sis900 Foxconn 661FX7MI-S PHY support

2006-05-10 Thread James Cameron
This patch is required to get sis900 ethernet working well on a Foxconn 661FX7MI-S motherboard which uses the SiS 661FX chipset. The patch adds an entry to mii_chip_info for the transceiver. Signed-off-by: James Cameron <[EMAIL PROTECTED]> Acked-by: Daniele Venzano <[EMAIL PROTECTED]> --- diff -

Re: [PATCH] dl2k: use explicit DMA_48BIT_MASK

2006-05-10 Thread Jon Mason
On Wed, May 10, 2006 at 08:57:18PM +0200, Francois Romieu wrote: > Typo will be harder with this one. While I agree that a #define is much better than the magic number, I think this is bastardizing the intended use of DMA_*BIT_MASK. DMA_*BIT_MASK is intended to be used in the DMA_API's checking of

Re: [PATCH] bonding: fix sparse warnings

2006-05-10 Thread Al Viro
On Wed, May 10, 2006 at 04:14:05PM -0700, Stephen Hemminger wrote: > Fix warning from sparse in bonding code about "incorrect type in assignment" *snerk* Only if you are building without -Wcast-to-as. It _is_ incorrect type in assignment. And the real fix is to expand the call, killing set_fs()

Re: [PATCH 4/6] myri10ge - First half of the driver

2006-05-10 Thread Francois Romieu
Brice Goglin <[EMAIL PROTECTED]> : > [PATCH 4/6] myri10ge - First half of the driver > > The first half of the myri10ge driver core. > > Signed-off-by: Brice Goglin <[EMAIL PROTECTED]> > Signed-off-by: Andrew J. Gallatin <[EMAIL PROTECTED]> > > myri10ge.c | 1483 > +

[PATCH] bonding: fix sparse warnings

2006-05-10 Thread Stephen Hemminger
Fix warning from sparse in bonding code about "incorrect type in assignment" Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- orig/drivers/net/bonding/bond_main.c2006-05-04 16:22:10.0 -0700 +++ new/drivers/net/bonding/bond_main.c 2006-05-10 16:04:38.0 -0700 @@ -6

[PATCH 2/2] bcm43xx-d80211: add PCI ID for bcm4319. (#2)

2006-05-10 Thread Stefano Brivio
Add PCI ID for bcm4319. Signed-off-by: Stefano Brivio <[EMAIL PROTECTED]> Index: wireless-dev/drivers/net/wireless/d80211/bcm43xx/bcm43xx_main.c === --- wireless-dev.orig/drivers/net/wireless/d80211/bcm43xx/bcm43xx_main.c +++ wireless

[PATCH 1/2] bcm43xx-d80211: check for valid MAC address in SPROM (#2)

2006-05-10 Thread Stefano Brivio
Sorry for the mistake. Now diffed against the right port :). Please apply to wireless-dev. -- Check for valid MAC address in SPROM fields instead of relying on PHY type while setting the MAC address in the networking subsystem, as some devices have multiple PHYs. Signed-off-by: Stefano Brivio <[

Re: address pingable with interface down

2006-05-10 Thread Christopher Friesen
David S. Miller wrote: From: Jon DeVree <[EMAIL PROTECTED]> I've noticed in the past that the address owned by an interface is still pingable after that interface is brought down. People bring this up all the time and this behavior is intentional. This is becoming a serious FAQ and very

Re: [PATCH 5/6] myri10ge - Second half of the driver

2006-05-10 Thread Stephen Hemminger
On Wed, 10 May 2006 14:42:41 -0700 (PDT) Brice Goglin <[EMAIL PROTECTED]> wrote: > [PATCH 5/6] myri10ge - Second half of the driver > > The second half of the myri10ge driver core. > > Signed-off-by: Brice Goglin <[EMAIL PROTECTED]> > Signed-off-by: Andrew J. Gallatin <[EMAIL PROTECTED]> > > m

Re: [PATCH 4/6] myri10ge - First half of the driver

2006-05-10 Thread Roland Dreier
Stephen> Splitting it in half, might help email restrictions, but Stephen> it kills future users of 'git bisect' who expect to have Stephen> every kernel buildable. Not really, since the makefile/kconfig stuff comes in a later patch. But yes, it is cleaner to have drivers go in in san

Re: [PATCH 4/6] myri10ge - First half of the driver

2006-05-10 Thread Roland Dreier
> +typedef struct { > +mcp_kreq_ether_recv_t __iomem *lanai; /* lanai ptr for recv ring */ > +volatile uint8_t __iomem *wc_fifo; /* w/c rx dma addr fifo address > */ > +mcp_kreq_ether_recv_t *shadow; /* host shadow of recv ring */ > +struct myri10ge_rx_buffer_state *i

Re: [PATCH 3/6] myri10ge - Driver header files

2006-05-10 Thread Francois Romieu
Brice Goglin <[EMAIL PROTECTED]> : > [PATCH 3/6] myri10ge - Driver header files > > myri10ge driver header files. > myri10ge_mcp.h is the generic header, while myri10ge_mcp_gen_header.h > is automatically generated from our firmware image. > > Signed-off-by: Brice Goglin <[EMAIL PROTECTED]> > Sig

Re: [PATCH 4/6] myri10ge - First half of the driver

2006-05-10 Thread Stephen Hemminger
On Wed, 10 May 2006 14:40:22 -0700 (PDT) Brice Goglin <[EMAIL PROTECTED]> wrote: > [PATCH 4/6] myri10ge - First half of the driver > > The first half of the myri10ge driver core. > Splitting it in half, might help email restrictions, but it kills future users of 'git bisect' who expect to have

Re: [PATCH 3/6] myri10ge - Driver header files

2006-05-10 Thread Stephen Hemminger
On Wed, 10 May 2006 23:36:18 +0200 Brice Goglin <[EMAIL PROTECTED]> wrote: > [PATCH 3/6] myri10ge - Driver header files > > myri10ge driver header files. > myri10ge_mcp.h is the generic header, while myri10ge_mcp_gen_header.h > is automatically generated from our firmware image. Then clean it up

Re: [PATCH 3/6] myri10ge - Driver header files

2006-05-10 Thread Roland Dreier
A few quick obvious comments: > +#ifdef MYRI10GE_MCP > +typedef signed char int8_t; > +typedef signed shortint16_t; > +typedef signed int int32_t; > +typedef signed long longint64_t; > +typedef unsigned char uint8_t; > +typedef unsigned short uint16_t

please pull upstream branch of netdev-2.6

2006-05-10 Thread Stephen Hemminger
The following changes since commit 6810b548b25114607e0814612d84125abccc0a4f: Andi Kleen: x86_64: Move ondemand timer into own work queue are found in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/shemminger/netdev-2.6.git upstream Francois Romieu: dl2k:

Re: [PATCH 2/6] myri10ge - Add missing PCI IDs

2006-05-10 Thread Andi Kleen
On Wednesday 10 May 2006 23:35, Brice Goglin wrote: > [PATCH 2/6] myri10ge - Add missing PCI IDs > > Add nVidia nForce CK804 PCI-E bridge and > ServerWorks HT2000 PCI-E bridge IDs. > They will be used by the myri10ge driver. That's a bad sign. It means you have code in your driver that should b

Re: r8169+NAPI soft lockup

2006-05-10 Thread Francois Romieu
Richard Gregory <[EMAIL PROTECTED]> : [...] > # locked in 1 min. Output in bug5.txt > $ for i in `seq 0 26` ; do cat /dev/md1 > /dev/tcp/linuxbox/9 & > $ cat /dev/md0 > /dev/tcp/localhost/9 Can you replace /dev/tcp/foo with a simple /dev/null and send the output of 'vmstat 1' during 2 minutes of t

[PATCH 6/6] myri10ge - Kconfig and Makefile

2006-05-10 Thread Brice Goglin
[PATCH 6/6] myri10ge - Kconfig and Makefile Add Kconfig and Makefile support for the myri10ge driver. Signed-off-by: Brice Goglin <[EMAIL PROTECTED]> Signed-off-by: Andrew J. Gallatin <[EMAIL PROTECTED]> Kconfig | 16 Makefile |1 + myri10ge/Makefile |

[PATCH 5/6] myri10ge - Second half of the driver

2006-05-10 Thread Brice Goglin
[PATCH 5/6] myri10ge - Second half of the driver The second half of the myri10ge driver core. Signed-off-by: Brice Goglin <[EMAIL PROTECTED]> Signed-off-by: Andrew J. Gallatin <[EMAIL PROTECTED]> myri10ge.c | 1540 + 1 file changed, 15

[PATCH 4/6] myri10ge - First half of the driver

2006-05-10 Thread Brice Goglin
[PATCH 4/6] myri10ge - First half of the driver The first half of the myri10ge driver core. Signed-off-by: Brice Goglin <[EMAIL PROTECTED]> Signed-off-by: Andrew J. Gallatin <[EMAIL PROTECTED]> myri10ge.c | 1483 + 1 file changed, 1483

[PATCH 1/6] myri10ge - Revive pci_find_ext_capability

2006-05-10 Thread Brice Goglin
[PATCH 1/6] myri10ge - Revive pci_find_ext_capability This patch revives pci_find_ext_capability (has been disabled a couple month ago since it was not used anywhere. See http://lkml.org/lkml/2006/1/20/247). It will now be used by the myri10ge driver. Signed-off-by: Brice Goglin <[EMAIL PROTECTED

[PATCH 2/6] myri10ge - Add missing PCI IDs

2006-05-10 Thread Brice Goglin
[PATCH 2/6] myri10ge - Add missing PCI IDs Add nVidia nForce CK804 PCI-E bridge and ServerWorks HT2000 PCI-E bridge IDs. They will be used by the myri10ge driver. Signed-off-by: Brice Goglin <[EMAIL PROTECTED]> Signed-off-by: Andrew J. Gallatin <[EMAIL PROTECTED]> pci_ids.h |2 ++ 1 file c

[PATCH 3/6] myri10ge - Driver header files

2006-05-10 Thread Brice Goglin
[PATCH 3/6] myri10ge - Driver header files myri10ge driver header files. myri10ge_mcp.h is the generic header, while myri10ge_mcp_gen_header.h is automatically generated from our firmware image. Signed-off-by: Brice Goglin <[EMAIL PROTECTED]> Signed-off-by: Andrew J. Gallatin <[EMAIL PROTECTED]>

[PATCH 0/6] myri10ge - Myri-10G Ethernet driver

2006-05-10 Thread Brice Goglin
[PATCH 0/6] myri10ge - Myri-10G Ethernet driver The following 6 patches introduce the myri10ge driver for Myricom Myri-10G boards in Ethernet mode. The driver is called myri10ge. The patches are against 2.6.17-rc3-mm1. [1/6] Restore pci_find_ext_capability. [2/6] Add nVidia nForce CK804 PCI-E

Re: address pingable with interface down

2006-05-10 Thread Ian McDonald
So where's the linux networking faq? I've been lurking here long enough to know that there's no shortage of faqs, but there's no canonical netdev faq that i'm aware of. Maybe one should be started? Jason http://linux-net.osdl.org/index.php/ is the linux networking canonical wiki. I've added th

Re: [RFC 0/3] [IPSEC]: Add xfrm_mode support

2006-05-10 Thread David S. Miller
From: Herbert Xu <[EMAIL PROTECTED]> Date: Sat, 6 May 2006 21:20:26 +1000 > These patches abstract out the protocol-specific encapsulation parts of > IPsec into what I've termed xfrm_mode objects. This allows us to share > a little bit more code. But more importantly, it allows us to add new > e

Re: possible problem with TSO and ip_queue

2006-05-10 Thread David S. Miller
From: Paul Jakma <[EMAIL PROTECTED]> Date: Wed, 10 May 2006 21:17:33 +0100 (IST) > On Wed, 10 May 2006, David S. Miller wrote: > > > When you have a rule installed that will add MD5, just mark the > > route as not being TSO capable. > > Ah, didn't realise this could be done with netfilter. What

Re: [PATCH] skb leakage in inet6_csk_xmit

2006-05-10 Thread David S. Miller
From: Alexey Kuznetsov <[EMAIL PROTECTED]> Date: Wed, 10 May 2006 13:02:16 +0400 > inet6_csk_xit does not free skb when routing fails. > > Signed-off-by: Alexey Kuznetsov <[EMAIL PROTECTED]> Applied, thanks a lot. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of

Re: [PATCH 0/2] register_netdevice and sysfs changes

2006-05-10 Thread David S. Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Wed, 10 May 2006 10:14:52 -0700 > This is a signed-off version of yesterday's fix, plus the bridge > code no longer needs to be so tricky. I'll apply this stuff, thanks a lot. Although since I have the blocking --> raw notifier fixup in my tree I

Re: possible problem with TSO and ip_queue

2006-05-10 Thread Paul Jakma
On Wed, 10 May 2006, David S. Miller wrote: When you have a rule installed that will add MD5, just mark the route as not being TSO capable. Ah, didn't realise this could be done with netfilter. What's the magic incantation? :) What's the problem? None, that's perfect - we just didn't kno

Re: [PATCH] sis900 Foxconn 661FX7MI-S PHY support

2006-05-10 Thread Daniele Venzano
Il giorno 10/mag/06, alle ore 19:31, Stephen Hemminger ha scritto: On Wed, 10 May 2006 10:04:50 +1000 James Cameron <[EMAIL PROTECTED]> wrote: I'm not sure, but I wonder if it means the default behaviour should be changed, so as to better handle future transceivers. Well, my previous exper

[PATCH] tcpdump may trace some outbound packets twice.

2006-05-10 Thread Ranjit Manomohan
This patch fixes the problem where tcpdump shows duplicate packets while tracing outbound packets on drivers which support lockless transmit. The patch changes the current behaviour to tracing the packets only on a successful transmit. Signed-off-by: Ranjit Manomohan <[EMAIL PROTECTED]> --- linux

Re: possible problem with TSO and ip_queue

2006-05-10 Thread David S. Miller
From: Paul Jakma <[EMAIL PROTECTED]> Date: Wed, 10 May 2006 21:07:31 +0100 (IST) > Is there a better way to deal with TSO besides documenting: > > "disable TSO on all interfaces which /ever/ potentially could be used > to reach TCP-MD5 authenticated BGP peers." > > ? When you have a rule inst

Re: possible problem with TSO and ip_queue

2006-05-10 Thread Paul Jakma
On Wed, 10 May 2006, David S. Miller wrote: This is by design. Netfilter looks at full TSO frames, That explains it. Once you add MD5 checksums to the TCP packet, TSO can no longer be used on that path, so you'll have to disable TSO either in the route or via some other means. Ok. Is th

Re: address pingable with interface down

2006-05-10 Thread David S. Miller
From: Jon DeVree <[EMAIL PROTECTED]> Date: Wed, 10 May 2006 15:48:18 -0400 > I've noticed in the past that the address owned by an interface is > still pingable after that interface is brought down. People bring this up all the time and this behavior is intentional. Linux uses a "host based" add

Re: Initial benchmarks of some VJ ideas [mmap memcpy vs copy_to_user].

2006-05-10 Thread David S. Miller
From: Evgeniy Polyakov <[EMAIL PROTECTED]> Date: Mon, 8 May 2006 16:24:22 +0400 > I hope he does not take offence at name shortening :) Perhaps you are still not convinced how truly expensive the code path from netif_receive_skb() to the protocol receive processing really is. Van's channels elim

address pingable with interface down

2006-05-10 Thread Jon DeVree
I've noticed in the past that the address owned by an interface is still pingable after that interface is brought down. This appears to be because the routing table entry for the address itself is never removed when the interface is brought down. I'm curious if this is desired behavior or if this i

Re: possible problem with TSO and ip_queue

2006-05-10 Thread David S. Miller
From: Chris Caputo <[EMAIL PROTECTED]> Date: Wed, 10 May 2006 18:44:30 + (GMT) > Does this sound like a bug or by design? > > Does it make sense that ip_queue mangled packets be subjected to TSO, > given that the TCP header can be messed with by the user mode code? This is by design. Netfi

[PATCH] dl2k: use explicit DMA_48BIT_MASK

2006-05-10 Thread Francois Romieu
Typo will be harder with this one. Signed-off-by: Francois Romieu <[EMAIL PROTECTED]> --- drivers/net/dl2k.c | 13 ++--- include/linux/dma-mapping.h |1 + 2 files changed, 7 insertions(+), 7 deletions(-) 5019a27a2a4e259f29a7bd03e905764eedfa034c diff --git a/drivers/net/d

possible problem with TSO and ip_queue

2006-05-10 Thread Chris Caputo
Environment is 2.6.16.9 with e1000 NICs. Paul and I (as part of the Quagga project) are working on a user mode method for doing BGP MD5 checksums using ip_queue. All is working except when TSO is enabled I am seeing some problems. It appears that when TSO is enabled, ip_queue can be used to ma

Re: [RFC PATCH 34/35] Add the Xen virtual network device driver.

2006-05-10 Thread Andi Kleen
On Tuesday 09 May 2006 22:46, Roland Dreier wrote: > Keir> Where should we get our entropy from in a VM environment? > Keir> Leaving the pool empty can cause processes to hang. > > You could have something like a virtual HW RNG driver (with a frontend > and backend), which steals from the d

[PATCH -mm] updated dl2k gcc 4.1 warning fix

2006-05-10 Thread Daniel Walker
Fixes the following warning, drivers/net/dl2k.c: In function 'rio_free_tx': drivers/net/dl2k.c:768: warning: integer constant is too large for 'long' type drivers/net/dl2k.c: In function 'receive_packet': drivers/net/dl2k.c:896: warning: integer constant is too large for 'long' type drivers/net/dl

Re: [PATCH -mm] dl2k gcc 4.1 warning fix

2006-05-10 Thread Jon Mason
On Tue, May 09, 2006 at 07:55:57PM -0700, Daniel Walker wrote: > Fixes the following warning, Please CC netdev on networking patches. All the changed lines are over 80 chars. Please fix. Thanks, Jon > drivers/net/dl2k.c: In function 'rio_free_tx': > drivers/net/dl2k.c:768: warning: integer con

[PATCH 1/2] netdev: do sysfs registration as part of register_netdevice

2006-05-10 Thread Stephen Hemminger
The last step of netdevice registration was being done by a delayed call, but because it was delayed, it was impossible to return any error code if the class_device registration failed. Side effects: * one state in registration process is unnecessary. * register_netdevice can sleep inside class_

Re: [PATCH wireless-dev] d80211: Add support for user space clientMLME

2006-05-10 Thread Jouni Malinen
On Thu, May 04, 2006 at 02:26:53PM +0200, Johannes Berg wrote: > On Wed, 2006-05-03 at 09:44 -0700, Jouni Malinen wrote: > > But there is.. I committed changes to the wpa_supplicant devel branch > > for this yesterday. It seems to work fine with net/d80211 and bcm43xx > > with this small patch to d

[PATCH 0/2] register_netdevice and sysfs changes

2006-05-10 Thread Stephen Hemminger
This is a signed-off version of yesterday's fix, plus the bridge code no longer needs to be so tricky. -- - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH 2/2] bridge: do sysfs registration inside rtnl

2006-05-10 Thread Stephen Hemminger
Now that netdevice sysfs registration is done as part of register_netdevice; bridge code no longer has to be tricky when adding it's kobjects to bridges. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- bridge.orig/net/bridge/br_if.c 2006-05-04 16:22:29.0 -0700 +++ bridge/ne

Re: Dscape ieee80211: enabling/disabling the radio

2006-05-10 Thread Jouni Malinen
On Wed, May 10, 2006 at 03:53:48PM +0200, Ivo van Doorn wrote: > I think the problem is what the dscape exactly expects the driver to do when > add_interface() is called by the stack. When that call has finished, does the > stack > expects the radio to be enabled, or should it instruct the driver

[PATCH] phy: mdiobus_register(): initialize all phy_map entries

2006-05-10 Thread Herbert Valerio Riedel
make sure phy_map entries whose PHY address is masked are initialized to NULL, given that other code (such as mdiobus_unregister for instance) assumes that non-NULL phy_map entries are allocated phy_devices Signed-off-by: Herbert Valerio Riedel <[EMAIL PROTECTED]> --- drivers/net/phy/mdio_bus.c

Re: Dscape ieee80211: enabling/disabling the radio

2006-05-10 Thread Jiri Benc
On Wed, 10 May 2006 15:53:48 +0200, Ivo van Doorn wrote: > I think the problem is what the dscape exactly expects the driver to do when > add_interface() is called by the stack. When that call has finished, does the > stack > expects the radio to be enabled, or should it instruct the driver to ena

Re: Dscape ieee80211: enabling/disabling the radio

2006-05-10 Thread Ivo van Doorn
On Wednesday 10 May 2006 12:52, Jiri Benc wrote: > On Wed, 10 May 2006 00:01:16 +0200, Ivo van Doorn wrote: > > Basicly the dscape stack is performing active scanning while the device is > > down, > > but during the active scan it is sending packets out, or at least > > attempting to do so. > > B

Re: Dscape ieee80211: enabling/disabling the radio

2006-05-10 Thread Jiri Benc
On Wed, 10 May 2006 15:37:11 +0200, Ivo van Doorn wrote: > True, I agree here. But when rt2x00 was using the ipw stack a much > requested feature from users was to be able to perform scanning while > interface was down. (The requests did not specify if it they wanted passive > or active scanning)

Re: Dscape ieee80211: enabling/disabling the radio

2006-05-10 Thread Ivo van Doorn
On Wednesday 10 May 2006 12:42, Jiri Benc wrote: > On Sat, 6 May 2006 14:00:58 +0200, Ivo van Doorn wrote: > > In rt2x00 the config() handler schedules all configuration changes by using > > a workqueue, > > this is required since several configuration changes in rt2x00 need > > sleeping and for

Re: Dscape ieee80211: enabling/disabling the radio

2006-05-10 Thread Ivo van Doorn
On Wednesday 10 May 2006 00:36, Michael Wu wrote: > On Tuesday 09 May 2006 18:01, Ivo van Doorn wrote: > > A user on the forums Olivier Cornu (added to the CC list) has done some > > investigation into the scanning behaviour of the dscape stack. > > Basicly the dscape stack is performing active sca

Re: [RFC][SECMARK 03/08] Add xtables SECMARK target

2006-05-10 Thread James Morris
On Wed, 10 May 2006, Patrick McHardy wrote: > The netfilter parts all look fine too me (just one question, > see below). Shall I add the userspace parts to SVN or do you > want to do it yourself? Might be better if you do it, although I'm still looking into one issue at this stage. > I wonder i

Re: Hardware flow control on RTL8169

2006-05-10 Thread s . munaut
Hi Francois, Selon Francois Romieu <[EMAIL PROTECTED]>: > [EMAIL PROTECTED] <[EMAIL PROTECTED]> : > [...] > > I'm using a kurobox (www.kurobox.com) with a 2.6.15 kernel and I'd like to > use > > hardware flow control with it. However it seems the driver doesn't support > it, > > is that correct ?

Re: Dscape ieee80211: enabling/disabling the radio

2006-05-10 Thread Jiri Benc
On Wed, 10 May 2006 00:01:16 +0200, Ivo van Doorn wrote: > Basicly the dscape stack is performing active scanning while the device is > down, > but during the active scan it is sending packets out, or at least attempting > to do so. > Besides the question if active scanning is preferred over pass

Re: Dscape ieee80211: enabling/disabling the radio

2006-05-10 Thread Jiri Benc
On Sat, 6 May 2006 14:00:58 +0200, Ivo van Doorn wrote: > In rt2x00 the config() handler schedules all configuration changes by using a > workqueue, > this is required since several configuration changes in rt2x00 need sleeping > and for > USB devices all register access requires sleeping. And th

Re: [Bugme-new] [Bug 6530] New: MAINLINE

2006-05-10 Thread Paul Mackerras
Andrew Morton writes: > hm, a PPP fix. We seem to need some of those lately. > > Paul, does this look sane? /me pages in 7 year old code... > @@ -516,6 +516,8 @@ static void ppp_async_process(unsigned l > /* try to push more stuff out */ > if (test_bit(XMIT_WAKEUP, &ap->xmit_flags)

Re: tcp compound

2006-05-10 Thread Angelo P. Castellani
On 5/9/06, Stephen Hemminger <[EMAIL PROTECTED]> wrote: Moved discussion over to netdev mailing list.. Could you export symbols in tcp_vegas (and change config dependencies) to allow code reuse rather than having to copy/paste everything from vegas? I hope I've done that properly. tcp_compou

Re: [Bugme-new] [Bug 6530] New: MAINLINE

2006-05-10 Thread Andrew Morton
[EMAIL PROTECTED] wrote: > > http://bugzilla.kernel.org/show_bug.cgi?id=6530 > >Summary: MAINLINE > Kernel Version: 2.6.16 > Status: NEW > Severity: normal > Owner: [EMAIL PROTECTED] > Submitter: [EMAIL PROTECTED] > > > Most recent kern

[PATCH] skb leakage in inet6_csk_xmit

2006-05-10 Thread Alexey Kuznetsov
Hello! inet6_csk_xit does not free skb when routing fails. Signed-off-by: Alexey Kuznetsov <[EMAIL PROTECTED]> diff --git a/net/ipv6/inet6_connection_sock.c b/net/ipv6/inet6_connection_sock.c index f8f3a37..eb2865d 100644 --- a/net/ipv6/inet6_connection_sock.c +++ b/net/ipv6/inet6_connection_soc

Re: [Xen-devel] [RFC PATCH 34/35] Add the Xen virtual network device driver.

2006-05-10 Thread Keir Fraser
On 10 May 2006, at 00:51, Chris Wright wrote: * Herbert Xu ([EMAIL PROTECTED]) wrote: Chris Wright <[EMAIL PROTECTED]> wrote: + netdev->features= NETIF_F_IP_CSUM; Any reason why IP_CSUM was chosen instead of HW_CSUM? Doing the latter would seem to be in fact easier for a virt