From: Herbert Xu <[EMAIL PROTECTED]>
Date: Thu, 20 Apr 2006 15:04:06 +1000
> On Wed, Apr 19, 2006 at 09:55:13PM -0700, David S. Miller wrote:
> > +static inline void skb_truesize_check(struct sk_buff *skb)
> > +{
> > + if (unlikely((int)skb->truesize < sizeof(struct sk_buff)))
> > + sk
> -Original Message-
> From: [EMAIL PROTECTED]
> [mailto:[EMAIL PROTECTED] On Behalf Of Stephen Hemminger
> Sent: Wednesday, April 19, 2006 9:35 PM
> To: Jeff Garzik
> Cc: Netdev List; Linux Kernel; Arnaldo Carvalho de Melo
> Subject: Re: TOE info page
>
> On Wed, 19 Apr 2006 19:22:14
From: [EMAIL PROTECTED]
When the sk_timer function x25_heartbeat_expiry() is called by the kernel
in a running/terminating process, spinlock-recursion and spinlock-lockup
locks up the kernel.
This has happened with testing on some distro's and the patch below fixed it.
Signed-off-by:Shaun Pereir
Hi David:
On Wed, Apr 19, 2006 at 09:55:13PM -0700, David S. Miller wrote:
>
> Herbert what do you think of this?
>
> I know it might be better to check this right where we
> make the manipulations, but this catch-all trap at the
> end points seems to make sense and will catch other kinds
> of e
Herbert what do you think of this?
I know it might be better to check this right where we
make the manipulations, but this catch-all trap at the
end points seems to make sense and will catch other kinds
of errors.
diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h
index c4619a4..60a7c5
On Wed, 19 Apr 2006 19:22:14 -0400
Jeff Garzik <[EMAIL PROTECTED]> wrote:
>
> I created a TOE (TCP Offload Engine) info page for Linux, on the
> linux-net wiki:
>
> http://linux-net.osdl.org/index.php/TOE
>
> As soon as I can find a wiki admin, it will get added to the main page.
> I
From: Herbert Xu <[EMAIL PROTECTED]>
Date: Thu, 20 Apr 2006 13:26:02 +1000
> On Thu, Apr 20, 2006 at 11:01:11AM +1000, herbert wrote:
> > Hi Dave:
> >
> > Since sk_stream_alloc_pskb takes an extra argument that accounts for
> > paged data all we need to do to account sk_buff overhead correctly
>
On 4/19/06, Andi Kleen <[EMAIL PROTECTED]> wrote:
> On Wednesday 19 April 2006 18:39, Grover, Andrew wrote:
>
> > We have posted all the performance data we have gathered so far on the
> > linux-net wiki: http://linux-net.osdl.org/index.php/I/OAT , and listed
> > the overall concerns that have been
On Thu, Apr 20, 2006 at 11:01:11AM +1000, herbert wrote:
> Hi Dave:
>
> Since sk_stream_alloc_pskb takes an extra argument that accounts for
> paged data all we need to do to account sk_buff overhead correctly
> is to use that instead of sk_stream_alloc_skb.
Here is a better version that does not
On 4/20/06, Stephen Hemminger <[EMAIL PROTECTED]> wrote:
> The changes to how hardware receive checksums are handled broke
> the netpoll checksum code (for CHECKSUM_HW). Since this is not at
> all performance critical, try this patch. It changes to always to
> normal software checksum.
>
Hi Stephe
The following changes since commit 0efd9323f32c137b5cf48bc6582cd08556e7cdfc:
Linus Torvalds:
Merge branch 'splice' of git://brick.kernel.dk/data/git/linux-2.6-block
are found in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless-2.6.git
upstream-fi
Hi Dave:
Since sk_stream_alloc_pskb takes an extra argument that accounts for
paged data all we need to do to account sk_buff overhead correctly
is to use that instead of sk_stream_alloc_skb.
This patch does just that for both tcp_fragment and tso_fragment.
Signed-off-by: Herbert Xu <[EMAIL PROT
On Thursday 20 April 2006 00:45, Ravinandan Arakali wrote:
> Andi,
> We would like to explain that this patch is tier-1 of a two
> tiered approach. It implements all the steering
> functionality at driver-only level, and it is fairly Neterion-specific.
That's fine for experiments, but probably not
On Wednesday 19 April 2006 18:39, Grover, Andrew wrote:
> We have posted all the performance data we have gathered so far on the
> linux-net wiki: http://linux-net.osdl.org/index.php/I/OAT , and listed
> the overall concerns that have been expressed in private. I'm hoping you
> will look at the da
I created a TOE (TCP Offload Engine) info page for Linux, on the
linux-net wiki:
http://linux-net.osdl.org/index.php/TOE
As soon as I can find a wiki admin, it will get added to the main page.
I don't seem to have such access.
Jeff
-
To unsubscribe from this list: send
"David S. Miller" <[EMAIL PROTECTED]> wrote:
>
> From: Andrew Morton <[EMAIL PROTECTED]>
> Date: Wed, 19 Apr 2006 15:59:25 -0700
>
> > "David S. Miller" <[EMAIL PROTECTED]> wrote:
> > >
> > > An earlier variant of your patch was applied already, included below.
> > > You'll need to submit the newe
From: Andrew Morton <[EMAIL PROTECTED]>
Date: Wed, 19 Apr 2006 15:59:25 -0700
> "David S. Miller" <[EMAIL PROTECTED]> wrote:
> >
> > An earlier variant of your patch was applied already, included below.
> > You'll need to submit the newer parts relative to the current tree.
>
> This is a similar-
"David S. Miller" <[EMAIL PROTECTED]> wrote:
>
> An earlier variant of your patch was applied already, included below.
> You'll need to submit the newer parts relative to the current tree.
This is a similar-but-different patch. It applies OK.
I reviewed it (mostly - it's somewhat non-trivial to
[EMAIL PROTECTED] wrote:
>
> http://bugzilla.kernel.org/show_bug.cgi?id=6414
>
>Summary: sky2 problem
> Kernel Version: 2.6.15, 2.6.16,2.6.17
> Status: NEW
> Severity: high
> Owner: [EMAIL PROTECTED]
> Submitter: [EMAIL PROTECTED]
>
>
From: James Morris <[EMAIL PROTECTED]>
Date: Sun, 16 Apr 2006 01:10:50 -0400 (EDT)
> So, I propose to introduce a secmark field (per the patch below), which is
> only present when enabled as a sub-feature of LSM. That is, it does not
> have any effect at all for the default kernel. As an integ
Andi,
We would like to explain that this patch is tier-1 of a two
tiered approach. It implements all the steering
functionality at driver-only level, and it is fairly Neterion-specific.
The second upcoming submission will add a generic netlink-based
interface for channel data flow and configuratio
An earlier variant of your patch was applied already, included below.
You'll need to submit the newer parts relative to the current tree.
diff-tree 7ad4d2f6901437ba4717a26d395a73ea362d25c6 (from
b8282dcf0417bbc8a0786c129fdff9cc768f8f3c)
Author: Jayachandran C <[EMAIL PROTECTED]>
Date: Tue Apr
From: Andrew Morton <[EMAIL PROTECTED]>
Date: Wed, 19 Apr 2006 11:38:06 -0700
> Analysis:
> llc_rcv
> does a skb_clone inside skb_share_check
> llc_fixup_skb
> skb_trim
> __skb_trim
> ___pskb_trim(x,x,0) <-- realloc set to 0
> ___pskb_trim BUG on !realloc inside skb_cloned check
I'll fix it li
Michael Buesch <[EMAIL PROTECTED]> :
[...]
> Yes it does, but:
> * We did not release a stable kernel with it in the meantime.
> * There is no software using it at the moment.
> (Well, the bcm43xx-sprom tool is kind of using it,
>but it can handle both binary and hex input anyway)
Ok. Thanks
On Thursday 20 April 2006 00:17, you wrote:
> Michael Buesch <[EMAIL PROTECTED]> :
> [...]
> > the deleted code parses binary input. The
> > new code parses human readable hex input.
>
> No offence intended but it was not clear from the description of
> the patch.
>
>
> Does it imply an user spa
From: Hua Zhong <[EMAIL PROTECTED]>
Date: Wed, 19 Apr 2006 12:01:06 -0700
> There is a missing initialization of err in sockfd_lookup_light() that could
> return random error for an invalid file handle.
>
> Signed-off-by: Hua Zhong <[EMAIL PROTECTED]>
Applied, thanks a lot for this bug fix.
-
T
Michael Buesch <[EMAIL PROTECTED]> :
[...]
> the deleted code parses binary input. The
> new code parses human readable hex input.
No offence intended but it was not clear from the description of
the patch.
Does it imply an user space visible API change ?
--
Ueimor
-
To unsubscribe from this
On Wednesday 19 April 2006 23:50, you wrote:
> [EMAIL PROTECTED] <[EMAIL PROTECTED]> :
> >
> > From: Michael Buesch <[EMAIL PROTECTED]>
> >
> > This cleans up the bcm43xx sysfs code and makes it compliant with the
> > unwritten sysfs rules (at least I hope so).
> >
> > Signed-off-by: Michael Bue
[EMAIL PROTECTED] <[EMAIL PROTECTED]> :
>
> From: Michael Buesch <[EMAIL PROTECTED]>
>
> This cleans up the bcm43xx sysfs code and makes it compliant with the
> unwritten sysfs rules (at least I hope so).
>
> Signed-off-by: Michael Buesch <[EMAIL PROTECTED]>
> Cc: Jeff Garzik <[EMAIL PROTECTED]>
On Wed, Apr 19, 2006 at 10:28:41AM -0700, John Ronciak wrote:
> The hardware is going to generally available in June. There are also
> lots of OEMs, OSVs and hardware vendors that have the system to test
> on today. The early rollout of hardware has been very large.
As a start to get people actu
James Smart wrote:
> Folks,
>
> To take netlink to where we want to use it within the SCSI subsystem (as
> the mechanism of choice to replace ioctls), we're going to need to pass
> user-space buffer pointers.
>
> What is the best, portable manner to pass a pointer between user and kernel
> space
> Date: Thu, 20 Apr 2006 00:22:16 +0800
> From: Aubrey <[EMAIL PROTECTED]>
> Newsgroups: linux.dev.kernel
> Subject: Netpoll checksum issue
>
> I'm porting my network driver from 2.6.12 to 2.6.16. It almostly work
> without any change, except the netpoll mode. When I use kgdb to debug
> kernel, gd
On Wed, Apr 19, 2006 at 10:31:53AM -0700, Stephen Hemminger wrote:
> The changes to how hardware receive checksums are handled broke
> the netpoll checksum code (for CHECKSUM_HW). Since this is not at
> all performance critical, try this patch. It changes to always to
> normal software checksum.
On Wed, 19 Apr 2006, Jesse Brandeburg wrote:
Boris B. Zhmurov wrote:
Hello, Herbert Xu.
On 19.04.2006 03:27 you said the following:
On Tue, Apr 18, 2006 at 01:22:56PM -0700, David S. Miller wrote:
I think it is deserving of some run time assertions, else these bugs
will elude us continua
[EMAIL PROTECTED] wrote:
>
> http://bugzilla.kernel.org/show_bug.cgi?id=6412
>
>Summary: Kernel crashes randomly -- Unable to handle kernel NULL
> pointer dereference ...
> Kernel Version: 2.6.16.5 - mainline, neither out of tree modules loaded
>
From: Christian Borntraeger <[EMAIL PROTECTED]>
Date: Wed, 19 Apr 2006 12:45:48 +0200
> As spinlock debugging still does not work with the qeth driver I
> want to pick up the discussion.
Does something like the patch below work?
But this all begs the question, what happens if you want to
dig int
From: Stephen Hemminger <[EMAIL PROTECTED]>
Date: Wed, 19 Apr 2006 09:53:48 -0700
> Please put this in the next -stable load...
I already sent it to -stable.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at h
On 4/20/06, George Nychis <[EMAIL PROTECTED]> wrote:
> Hey Martin,
>
> I was able to do it with netem and its working great now.
>
> I've actually moved on to another challenge, I would like to drop
> packets at the hardware level such as to see rate control.
>
Have a look at:
http://linux-net.osdl
This applies to 2.6.17-rc2.
There is a missing initialization of err in sockfd_lookup_light() that could
return random error for an invalid file handle.
Signed-off-by: Hua Zhong <[EMAIL PROTECTED]>
diff --git a/net/socket.c b/net/socket.c
index 23898f4..0ce12df 100644
--- a/net/socket.c
+++ b/
Straighten up the AMD Au1xx0 Ethernet probing code, make it print out (and
store in the 'net_device' structure) the physical address of the controller,
not the KSEG1-based virtual. Make the driver also claim/release the 4-byte MAC
enable registers and assign to the Ethernet ports two consecut
Begin forwarded message:
Date: Wed, 19 Apr 2006 11:32:18 -0700
From: [EMAIL PROTECTED]
To: [EMAIL PROTECTED]
Subject: [Bugme-new] [Bug 6409] New: llc_rcv doesn't handle receives using
nr_frags and frags[]
http://bugzilla.kernel.org/show_bug.cgi?id=6409
Summary: llc_rcv doesn't han
The changes to how hardware receive checksums are handled broke
the netpoll checksum code (for CHECKSUM_HW). Since this is not at
all performance critical, try this patch. It changes to always to
normal software checksum.
--- linux-2.6.orig/net/core/netpoll.c 2006-03-22 09:30:56.0 -0800
On 4/19/06, Stephen Hemminger <[EMAIL PROTECTED]> wrote:
> Off list lobbying usually has a negative impact.
The lobbying was for vendor inclusion and not necessarily for upstream
acceptance.
> The biggest barrier at this point seems to be hardware availability.
> People generally don't care unless
James Smart wrote:
>
>
> Patrick McHardy wrote:
>
>> This might be problematic, since there is a shared receive-queue in
>> the kernel netlink message might get processed in the context of
>> a different process. I didn't find any spots where ISCSI passes
>> pointers over netlink, can you point
Begin forwarded message:
Date: Thu, 20 Apr 2006 00:22:16 +0800
From: Aubrey <[EMAIL PROTECTED]>
Newsgroups: linux.dev.kernel
Subject: Netpoll checksum issue
Hi all,
I'm porting my network driver from 2.6.12 to 2.6.16. It almostly work
without any change, except the netpoll mode. When I use kgd
This patch adds the SIOCSIWMLME wext to softmac, this functionality
appears to be used by wpa_supplicant and is softmac-specific.
Signed-off-by: Johannes Berg <[EMAIL PROTECTED]>
--- wireless-2.6.orig/net/ieee80211/softmac/ieee80211softmac_priv.h
2006-04-19 18:44:51.710074158 +0200
+++ wirel
Patrick McHardy wrote:
This might be problematic, since there is a shared receive-queue in
the kernel netlink message might get processed in the context of
a different process. I didn't find any spots where ISCSI passes
pointers over netlink, can you point me to it?
Please explain... Would th
On Wed, 19 Apr 2006 09:39:37 -0700
"Grover, Andrew" <[EMAIL PROTECTED]> wrote:
> Over the past few months, we (the Intel networking group) have been
> working hard, often off-list, to get the I/OAT patches we've posted here
> merged into the mainline kernel branch, as well as Red Hat and SuSE.
> W
Stephen Hemminger wrote:
On Wed, 19 Apr 2006 08:57:25 -0400
James Smart <[EMAIL PROTECTED]> wrote:
Folks,
To take netlink to where we want to use it within the SCSI subsystem (as
the mechanism of choice to replace ioctls), we're going to need to pass
user-space buffer pointers.
This change
On Tue, 18 Apr 2006 22:32:04 +1000
Herbert Xu <[EMAIL PROTECTED]> wrote:
> Hi Dave:
>
> You're absolutely right about there being a problem with the TSO packet
> trimming code. The cause of this lies in the tcp_fragment() function.
>
> When we allocate a fragment for a completely non-linear pac
Over the past few months, we (the Intel networking group) have been
working hard, often off-list, to get the I/OAT patches we've posted here
merged into the mainline kernel branch, as well as Red Hat and SuSE.
We've had some success, but not what's really important: getting it into
the mainline ker
On Wed, 19 Apr 2006 08:57:25 -0400
James Smart <[EMAIL PROTECTED]> wrote:
> Folks,
>
> To take netlink to where we want to use it within the SCSI subsystem (as
> the mechanism of choice to replace ioctls), we're going to need to pass
> user-space buffer pointers.
This changes the design of netli
James Smart wrote:
> To take netlink to where we want to use it within the SCSI subsystem (as
> the mechanism of choice to replace ioctls), we're going to need to pass
> user-space buffer pointers.
>
> What is the best, portable manner to pass a pointer between user and kernel
> space within a net
Boris B. Zhmurov wrote:
Hello, Herbert Xu.
On 19.04.2006 03:27 you said the following:
On Tue, Apr 18, 2006 at 01:22:56PM -0700, David S. Miller wrote:
I think it is deserving of some run time assertions, else these bugs
will elude us continually. Luckily there are only a few places that
wo
Hey Martin,
I was able to do it with netem and its working great now.
I've actually moved on to another challenge, I would like to drop
packets at the hardware level such as to see rate control.
Because when netem drops a packet, TCP responds, however the lower level
card will not interact b
Folks,
To take netlink to where we want to use it within the SCSI subsystem (as
the mechanism of choice to replace ioctls), we're going to need to pass
user-space buffer pointers.
What is the best, portable manner to pass a pointer between user and kernel
space within a netlink message ? The ex
As spinlock debugging still does not work with the qeth driver I want to pick
up the discussion.
On Saturday 08 April 2006 12:12, Andrew Morton wrote:
> Heiko Carstens <[EMAIL PROTECTED]> wrote:
[...]
> > -vmlinux-main := $(core-y) $(libs-y) $(drivers-y) $(net-y)
> > +vmlinux-main := $(core-y)
Hello!
> ipmr_get_route() is the trouble maker. If ipmr_cache_find() cannot
> find an entry, it tries to use the netlink SKB to send out an ipv4
> packet, completely mangling it, via ipmr_cache_unresolved().
It just adds dummy IP header to tail of this skb. Nothing illegal.
The skb is not sent o
58 matches
Mail list logo