Re: [PATCH 6/6] [NETLINK]: Generic netlink family

2005-11-10 Thread Roberto Nibali
Morning guys, Dave - ACK on all 6. Both Thomas and I have tested these and the TIPC folks have been playing with them for sometime now; if we get them in for 2.6.15 it would help to encourage them to change their API on their stable release to use this new changes. I would love to sit down wit

[PATCH 12/10]: [NETFILTER]: Add policy match

2005-11-10 Thread Patrick McHardy
[NETFILTER]: Add policy match Signed-off-by: Patrick McHardy <[EMAIL PROTECTED]> --- commit 84053f60747fa31fc46ccba57df29b639e509130 tree c9f2133a0b5b6df2fce4d15349d7e6ce433fc425 parent f12c4452cdb1b7d0d33a00120145e301507458e4 author Patrick McHardy <[EMAIL PROTECTED]> Fri, 11 Nov 2005 06:16:45

[PATCH 11/10]: [NETFILTER]: Export ip6_masked_addrcmp, don't pass IPv6 addresses on stack

2005-11-10 Thread Patrick McHardy
For completeness, the next two patches contain the policy match. [NETFILTER]: Export ip6_masked_addrcmp, don't pass IPv6 addresses on stack Signed-off-by: Patrick McHardy <[EMAIL PROTECTED]> --- commit f12c4452cdb1b7d0d33a00120145e301507458e4 tree 4762d9addca1746390024fcf437c73759b90955c parent

Re: [PATCH 00/10]: Netfilter IPsec support

2005-11-10 Thread Patrick McHardy
David S. Miller wrote: Note that I consider this stuff 2.6.16 material. We do have a lot of networking changes in 2.6.15 as it is, and also it would be good for these changes to get some review and discussion time. Sure, they will probably also need some changes for nf_conntrack. For now I'm h

Re: [PATCH 00/10]: Netfilter IPsec support

2005-11-10 Thread David S. Miller
From: Patrick McHardy <[EMAIL PROTECTED]> Date: Fri, 11 Nov 2005 04:18:52 +0100 > This is the latest set patches for netfilter IPsec support. > The use of netif_rx for the innermost SA if it used transport > mode has been replaced by explicit NF_HOOK calls in > xfrm{4,6}_input.c. Note that I cons

[PATCH 07/10]: [NETFILTER]: Fix xfrm lookup in ip_route_me_harder

2005-11-10 Thread Patrick McHardy
[NETFILTER]: Fix xfrm lookup in ip_route_me_harder ip_route_me_harder uses ip_route_input for non-local addresses, which doesn't do a xfrm lookup, and doesn't use the port numbers for the lookup for local addresses. Use xfrm_decode_session and do the lookup manually. Signed-off-by: Patrick McHar

[PATCH 09/10]: [NETFILTER]: Redo policy lookups after NAT when neccessary

2005-11-10 Thread Patrick McHardy
[NETFILTER]: Redo policy lookups after NAT when neccessary When NAT changes the key used for the xfrm lookup on the output path the lookup needs to be redone. Signed-off-by: Patrick McHardy <[EMAIL PROTECTED]> --- commit d449eeda76508f14f27d76a84350e4069c968497 tree fa245e3599e04432ee1ef1e046ee

[PATCH 10/10]: [NETFILTER]: Handle NAT in IPsec policy checks

2005-11-10 Thread Patrick McHardy
[NETFILTER]: Handle NAT in IPsec policy checks Handle NAT by reconstructing the struct flowi for the original packet from the conntrack information. Signed-off-by: Patrick McHardy <[EMAIL PROTECTED]> --- commit 536b302ffc8a31170833ca33636e9e66ff9a tree 23c41caf62635ec31f4a6f0f12407de9fcc5d2

[PATCH 06/10]: [IPV4/6]: Make input netfilter IPsec processing symetrical to output

2005-11-10 Thread Patrick McHardy
[IPV4/6]: Make input netfilter IPsec processing symetrical to output When the innermost transform uses transport mode the decapsulated packet is not visible to netfilter. Pass the packet through PRE_ROUTING->LOCAL_IN again before handing it to upper layer protocols. Signed-off-by: Patrick McHard

[PATCH 08/10]: [NETFILTER]: Use conntrack information to determine if packet was NATed

2005-11-10 Thread Patrick McHardy
[NETFILTER]: Use conntrack information to determine if packet was NATed Preparation for full IPsec support for NAT: Use conntrack information instead of saving the saving and comparing the addresses to determine if a packet was NATed and needs to be rerouted to make it easier to extend the key.

[PATCH 02/10]: [NETFILTER]: Defer fragmentation in ip_output when connection tracking is used

2005-11-10 Thread Patrick McHardy
[NETFILTER]: Defer fragmentation in ip_output when connection tracking is used This allows to get rid of the okfn use in ip_refrag and save the useless fragmentation/defragmentation step when NAT is used. Signed-off-by: Patrick McHardy <[EMAIL PROTECTED]> --- commit dc924f62fd0611bb349e398c80ce

[PATCH 03/10]: [IPV4]: Replace dst_output by ip_dst_output

2005-11-10 Thread Patrick McHardy
[IPV4]: Replace dst_output by ip_dst_output Preparation for netfilter IPsec support. Signed-off-by: Patrick McHardy <[EMAIL PROTECTED]> --- commit 9271210c937a55a2e5dcba05df078e1c43b81d6c tree 7f510d89a5245630e33e429c9d690de0aa2b05c9 parent dc924f62fd0611bb349e398c80ce3ffa5c3a9025 author Patric

[PATCH 05/10]: [IPV4/6]: Netfilter IPsec output hooks

2005-11-10 Thread Patrick McHardy
[IPV4/6]: Netfilter IPsec output hooks Add alternative ip_dst_output/ip6_dst_output functions to call netfilter hooks between xfrm transforms. Packets visit FORWARD/LOCAL_OUT->POST_ROUTING before encapsulation and LOCAL_OUT->POST_ROUTING after each tunnel mode transform. Signed-off-by: Patrick M

[PATCH 04/10]: [IPV6]: Replace dst_output by ip6_dst_output

2005-11-10 Thread Patrick McHardy
[IPV6]: Replace dst_output by ip6_dst_output Preparation for netfilter IPsec support. Signed-off-by: Patrick McHardy <[EMAIL PROTECTED]> --- commit acfa963b047cbda6a8350f122da90f1e84bf4938 tree b545b44a3074377283a2b491a5f7ae60b19ed914 parent 9271210c937a55a2e5dcba05df078e1c43b81d6c author Patri

[PATCH 01/10]: [NETFILTER]: Remove okfn usage in ip_vs_core.c

2005-11-10 Thread Patrick McHardy
[NETFILTER]: Remove okfn usage in ip_vs_core.c okfn should only be used from different contexts to avoid deep call stacks, i.e. by nf_queue. Acked-by: Julian Anastasov <[EMAIL PROTECTED]> Signed-off-by: Patrick McHardy <[EMAIL PROTECTED]> --- commit e718fcad3d24ada7b56fdca8dd234c9ba7459219 tree

Re: [PATCH] disable DEBUG in ibmveth

2005-11-10 Thread Anton Blanchard
Any chance we can get this patch in? Anton At the moment ibmveth has DEBUG enabled which is rather verbose. Disable it. Signed-off-by: Anton Blanchard <[EMAIL PROTECTED]> --- Index: foobar2/drivers/net/ibmveth.c === --- foobar2.or

tcp_send_fin - alloc_skb()

2005-11-10 Thread Rajneesh Saini
Just a concern, allocating an skb in tcp_send_fin(), instead of using gfp_mask as GFP_KERNEL, I think it should be sk->sk_allocation. Is there any particular reason for using GFP_KERNEL? Here is the code: if (sk->sk_send_head != NULL) { TCP_SKB_CB(skb)->flags |= TCPCB_FLAG_FIN;

Re: [PATCH 8/8] tcp:

2005-11-10 Thread David S. Miller
From: [EMAIL PROTECTED] Date: Thu, 10 Nov 2005 15:15:15 -0800 > Use hits to speed up the SACK processing. Various forms > of this have been used by TCP developers (Web100, STCP, BIC) > to avoid the 2x linear search of outstanding segments. > > Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]>

Re: [PATCH 7/8] tcp: spelling fixes

2005-11-10 Thread David S. Miller
From: [EMAIL PROTECTED] Date: Thu, 10 Nov 2005 15:15:14 -0800 > Minor spelling fixes for TCP code. > > Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> Applied, thanks. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majo

Re: [PATCH 6/8] tcp: receive buffer growth limiting with mixed MTU

2005-11-10 Thread David S. Miller
From: [EMAIL PROTECTED] Date: Thu, 10 Nov 2005 15:15:13 -0800 > Specifically it addresses the problem of an interaction between rcvbuf > moderation (receiver autotuning) and rcv_ssthresh. The problem occurs when > sending small packets to a receiver with a larger MTU. (A very common case I > hav

Re: [PATCH 5/8] tcp: Appropriate Byte Count support

2005-11-10 Thread David S. Miller
From: [EMAIL PROTECTED] Date: Thu, 10 Nov 2005 15:15:12 -0800 > This is an updated version of the RFC3465 ABC patch originally > for Linux 2.6.11-rc4 by Yee-Ting Li. ABC is a way of counting > bytes ack'd rather than packets when updating congestion control. > > The orignal ABC described in the R

Re: [PATCH 4/8] tcp: add tcp_slow_start helper

2005-11-10 Thread David S. Miller
From: [EMAIL PROTECTED] Date: Thu, 10 Nov 2005 15:15:11 -0800 > Move all the code that does linear TCP slowstart to one > inline function to ease later patch to add ABC support. > > Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> Applied, but one question about this hunk. > --- net-2.6.ori

Re: iproute2 weirdness - fwmark and route pb

2005-11-10 Thread Sandro Dentella
> you may check if /proc/sys/net/ipv4/conf/eth3/rp_filter is 0. thanks a lot it works! I never paid attention to this option and debian sets it by default to 1. sandro *:-) -- Sandro Dentella *:-) e-mail: [EMAIL PROTECTED] http://www.tksql.orgTkSQL Home page - My GPL work

skb_realloc_headroom

2005-11-10 Thread Tony
My interface is a virtual interface which represent a radio connected to the host using ethernet NIC. I designed my own L2 protocol on top of 802.3, which must be used, since the radio and the host are connected by ethernet. Now, my radio_hard_header will only add my L2 header, and my radio_h

Re: [PATCH 3/8] tcp: eliminate packets acked hook in ca_ops

2005-11-10 Thread David S. Miller
From: [EMAIL PROTECTED] Date: Thu, 10 Nov 2005 15:15:10 -0800 > Simplify the TCP congestion infrastructure. Can fold the > packets acked into the cong_avoid hook. > > Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> This patch would break at least BIC. Before this change, the "good_ack" p

Re: [PATCH 2/8] tcp: simplify microsecond rtt sampling

2005-11-10 Thread David S. Miller
From: [EMAIL PROTECTED] Date: Thu, 10 Nov 2005 15:15:09 -0800 > Simplify the code that comuputes microsecond rtt estimate used > by TCP Vegas. Move the callback out of the RTT sampler and into > the end of the ack cleanup. > > Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> Nice cleanup, ap

Re: [PATCH 1/8] tcp: fix congestion window update when using TSO deferal

2005-11-10 Thread David S. Miller
From: [EMAIL PROTECTED] Date: Thu, 10 Nov 2005 15:15:08 -0800 > TCP peformance with TSO over networks with delay is awful. > On a 100Mbit link with 150ms delay, we get 4Mbits/sec with TSO and > 50Mbits/sec without TSO. > > The problem is with TSO, we intentionally do not keep the maximum > number

Re: [PATCH] Generic HDLC WAN drivers - disable netif_carrier_off()

2005-11-10 Thread Greg KH
On Fri, Nov 11, 2005 at 01:10:30AM +0100, Krzysztof Halasa wrote: > Greg KH <[EMAIL PROTECTED]> writes: > > > Is this upstream? I need a Signed-off-by: line. > > Ahh, right. Have to learn it somehow. > > > Care to resend it to > > the stable@ address when it is accepted? > > Not sure what the

Re: Consensus? WAS(RFC 2863)

2005-11-10 Thread Paul Jakma
On Fri, 11 Nov 2005, Thomas Graf wrote: That is a very important point, actually it's the whole truth. If we extend it a little and say, let's give userspace control of all directly connected routes so it can delete/replace/modify/whatever if needed. It may or not be better. However, it /wou

Re: [PATCH] Generic HDLC WAN drivers - disable netif_carrier_off()

2005-11-10 Thread Krzysztof Halasa
Greg KH <[EMAIL PROTECTED]> writes: > Is this upstream? I need a Signed-off-by: line. Ahh, right. Have to learn it somehow. > Care to resend it to > the stable@ address when it is accepted? Not sure what the address is, resending. I have no doubt Jeff will apply this as this is all one can cu

Re: [PATCH] Generic HDLC WAN drivers - disable netif_carrier_off()

2005-11-10 Thread Greg KH
On Thu, Nov 10, 2005 at 02:37:08PM +0100, Krzysztof Halasa wrote: > Hi, > > As we are currently unable to fix the problem with carrier and protocol > state signaling in net core I've to disable netif_carrier_off() calls > used by WAN protocol drivers. The attached patch should make them > working

Re: iproute2 weirdness - fwmark and route pb

2005-11-10 Thread Wolfgang Walter
Hi, you may check if /proc/sys/net/ipv4/conf/eth3/rp_filter is 0. If it is 1 the kernel does a route lookup for an outgoing pseudo packet for every packet arriving on eth3. This pseudo packet is the incoming packet but with src and dst address exchanged. Only if this route goes via the same de

Re: Consensus? WAS(RFC 2863)

2005-11-10 Thread Thomas Graf
* Stefan Rompf <[EMAIL PROTECTED]> 2005-11-10 19:46 > fib_disable_ip() evicts all routes pointing to that interface, including > userspace generated ones, doesn't it? If so, we don't get away that easy. Right, the patch represents Jamal's interpretation. Once in a while I please him by providing

Re: Consensus? WAS(RFC 2863)

2005-11-10 Thread Thomas Graf
* Paul Jakma <[EMAIL PROTECTED]> 2005-11-10 23:10 > Why would an on-demand dialup device go ~IFF_RUNNING? The whole point > of such a device is to /hide/ whether the physical layer is up or > not. The state of an on-demand interface must be visible, typically an on-demand interface is in dormant

[PATCH 2/8] tcp: simplify microsecond rtt sampling

2005-11-10 Thread shemminger
Simplify the code that comuputes microsecond rtt estimate used by TCP Vegas. Move the callback out of the RTT sampler and into the end of the ack cleanup. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- net-2.6.orig/net/ipv4/tcp_input.c +++ net-2.6/net/ipv4/tcp_input.c @@ -548,10 +548,9

[PATCH 4/8] tcp: add tcp_slow_start helper

2005-11-10 Thread shemminger
Move all the code that does linear TCP slowstart to one inline function to ease later patch to add ABC support. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- net-2.6.orig/include/net/tcp.h +++ net-2.6/include/net/tcp.h @@ -762,6 +762,16 @@ static inline __u32 tcp_current_ssthresh

[PATCH 8/8] tcp:

2005-11-10 Thread shemminger
Use hits to speed up the SACK processing. Various forms of this have been used by TCP developers (Web100, STCP, BIC) to avoid the 2x linear search of outstanding segments. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- net-2.6.orig/include/linux/tcp.h +++ net-2.6/include/linux/tcp.h @@

[PATCH 6/8] tcp: receive buffer growth limiting with mixed MTU

2005-11-10 Thread shemminger
This is a patch for discussion addressing some receive buffer growing issues. This is partially related to the thread "Possible BUG in IPv4 TCP window handling..." last week. Specifically it addresses the problem of an interaction between rcvbuf moderation (receiver autotuning) and rcv_ssthresh.

[PATCH 0/8] tcp:

2005-11-10 Thread shemminger
TCP congestion control update including: TSO fix SAC optimization receive autotuning threshold -- Stephen Hemminger <[EMAIL PROTECTED]> OSDL http://developer.osdl.org/~shemminger - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message t

[PATCH 1/8] tcp: fix congestion window update when using TSO deferal

2005-11-10 Thread shemminger
TCP peformance with TSO over networks with delay is awful. On a 100Mbit link with 150ms delay, we get 4Mbits/sec with TSO and 50Mbits/sec without TSO. The problem is with TSO, we intentionally do not keep the maximum number of packets in flight to fill the window, we hold out to until we can send

[PATCH 5/8] tcp: Appropriate Byte Count support

2005-11-10 Thread shemminger
This is an updated version of the RFC3465 ABC patch originally for Linux 2.6.11-rc4 by Yee-Ting Li. ABC is a way of counting bytes ack'd rather than packets when updating congestion control. The orignal ABC described in the RFC applied to a Reno style algorithm. For advanced congestion control the

[PATCH 7/8] tcp: spelling fixes

2005-11-10 Thread shemminger
Minor spelling fixes for TCP code. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- net-2.6.orig/include/net/tcp.h +++ net-2.6/include/net/tcp.h @@ -88,10 +88,10 @@ extern void tcp_time_wait(struct sock *s */ #define TCP_SYN_RETRIES 5 /* n

[PATCH 3/8] tcp: eliminate packets acked hook in ca_ops

2005-11-10 Thread shemminger
Simplify the TCP congestion infrastructure. Can fold the packets acked into the cong_avoid hook. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- net-2.6.orig/include/net/tcp.h +++ net-2.6/include/net/tcp.h @@ -679,7 +679,7 @@ struct tcp_congestion_ops { u32 (*min_cwnd)(struct

Re: Consensus? WAS(RFC 2863)

2005-11-10 Thread Paul Jakma
On Thu, 10 Nov 2005, Krzysztof Halasa wrote: Seems inactive routes are really the way to go. But it should behave as active in every aspect except being ignored for actual routing (i.e., indistinguishable from userspace, normally added and removed). Yep: Userspace can clean up its own routes

Re: Consensus? WAS(RFC 2863)

2005-11-10 Thread Paul Jakma
On Thu, 10 Nov 2005, Thomas Graf wrote: This is not only about dial on demand but about "on demand" interfaces. We need to have a route to the device so the driver/manager/whatever can see the demand. If we disable routes on !IFF_RUNNING we don't have this route and we never see the demand. T

Re: Consensus? WAS(RFC 2863)

2005-11-10 Thread Stefan Rompf
Am Donnerstag 10 November 2005 01:02 schrieb Thomas Graf: > Assuming we use the overwrite schema you propose, right. The actual > representation would no longer be atomic though, e.g. when the bonding > master access the oper state from its slave you will suffer the exactly > same issues as with t

Re: Consensus? WAS(RFC 2863)

2005-11-10 Thread Stefan Rompf
Am Donnerstag 10 November 2005 00:49 schrieb Jamal Hadi Salim: > > If we drop the OPER_DORMANTL3*-states, we might later define a flag that > > marks a route as permanent (stays when interface is !OPER_UP), as opposed > > to a transient route that is removed/deactivated during !OPER_UP. > > Howeve

Re: [PATCH 1/2] [DCCP] Create Documentation/dccp.txt

2005-11-10 Thread David S. Miller
From: Ian McDonald <[EMAIL PROTECTED]> Date: Thu, 10 Nov 2005 15:39:41 +1300 > This patch is a first go at some documentation. Please advise if gmail > has mangled patch and I will revert to an attachment: > > Signed-off-by: Ian McDonald <[EMAIL PROTECTED]> Patch applied, thanks Ian. - To unsubs

Re: [PATCH 2/2] [DCCP]: Alter website for DCCP in MAINTAINERS

2005-11-10 Thread David S. Miller
From: Ian McDonald <[EMAIL PROTECTED]> Date: Thu, 10 Nov 2005 15:41:39 +1300 > Website for DCCP is now hosted at OSDL > > Signed-off-by: Ian McDonald <[EMAIL PROTECTED]> Also applied, thanks Ian. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMA

Re: [PATCH] Annotate h_proto in struct ethhdr

2005-11-10 Thread David S. Miller
From: Pavel Roskin <[EMAIL PROTECTED]> Date: Tue, 08 Nov 2005 14:10:36 -0500 > The protocol field in ethernet headers is big-endian and should be > annotated as such. This patch allows detection of missing ntohs() calls > on the ethernet protocol field when sparse is run with __CHECK_ENDIAN__ > d

Re: [patch 0/3] bnx2: minor fixes (take #2)

2005-11-10 Thread David S. Miller
From: "John W. Linville" <[EMAIL PROTECTED]> Date: Wed, 09 Nov 2005 22:10:00 -0500 > Still just a trio of minor fixes for bnx2. The third patch in this > series is based on a suggested fix from Michael Chan. Individual > patches to follow. All 3 patches applied, thanks John. - To unsubscribe fr

Re: [NET] Detect hardware rx checksum faults correctly

2005-11-10 Thread David S. Miller
From: Herbert Xu <[EMAIL PROTECTED]> Date: Sat, 5 Nov 2005 15:47:21 +1100 > [NET] Detect hardware rx checksum faults correctly Applied, thanks for following up on this Herbert. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More m

Re: motivation for TCP's cwnd clamp?

2005-11-10 Thread Armando L. Caro, Jr.
David S. Miller wrote: > Only when the metric is explicitly loaded into a route by hand > by the administrator, can it be locked. Ah, I see. That explains dst->mxlock in 2.4 and dst_metric_locked in 2.6. > So if the metric is merely rememberd by TCP for a routing cache > entry, that isn't enough

Re: motivation for TCP's cwnd clamp?

2005-11-10 Thread Stephen Hemminger
On Thu, 10 Nov 2005 14:17:14 -0500 "Armando L. Caro, Jr." <[EMAIL PROTECTED]> wrote: > Stephen Hemminger wrote: > > Network discussions like this are on netdev@vger.kernel.org not LKML > > Oops. Sorry about that. I tried finding a list focusing on Linux net > development, but somehow missed this

Re: motivation for TCP's cwnd clamp?

2005-11-10 Thread David S. Miller
From: "Armando L. Caro, Jr." <[EMAIL PROTECTED]> Date: Thu, 10 Nov 2005 14:17:14 -0500 > Stephen Hemminger wrote: > > It sets cwnd_clamp for the new connection only if the congestion window > > has been set as part of a route entry. A normal connection will store > > the last cwnd in the route me

Re: [PATCH 6/6] [NETLINK]: Generic netlink family

2005-11-10 Thread James Morris
On Thu, 10 Nov 2005, Thomas Graf wrote: > > void security_netlink_genl_event(int event, unsigned int id, const char > > *name); > > Couldn't we have SELinux ask the controller to resolve the ID to > the name? The assignments are already stored in family_ht[], we'd > just have to export genl_fami

Re: motivation for TCP's cwnd clamp?

2005-11-10 Thread Armando L. Caro, Jr.
Stephen Hemminger wrote: > Network discussions like this are on netdev@vger.kernel.org not LKML Oops. Sorry about that. I tried finding a list focusing on Linux net development, but somehow missed this one. > You are probably talking about this code in tcp_init_metrics > > if (dst_metri

Re: Consensus? WAS(RFC 2863)

2005-11-10 Thread Krzysztof Halasa
Stefan Rompf <[EMAIL PROTECTED]> writes: > fib_disable_ip() evicts all routes pointing to that interface, including > userspace generated ones, doesn't it? If so, we don't get away that easy. Right. I'm no longer sure we should remove the direct route. It would be crazy if we remove direct rout

Re: [Fwd: TSO and 2.6.13.2]

2005-11-10 Thread Ben Greear
Stephen Hemminger wrote: On It is not necessarily the most efficient way to generate bulk traffic, but I think it is a valid test. I use non-blocking IO and poll(). It is true that both sides may have full TX and/or RX buffers, but the code still works fine. I can adjust my tool to request a

Re: [Fwd: TSO and 2.6.13.2]

2005-11-10 Thread Rick Jones
I can say that "stock" netperf has no _single-connection_ bidirectional tests, As I think more about it, that statement of mine is slightly incorrect. If one configures netperf2 with --enable-burst, and are careful about the product of the burst size and request/response sizes wrt the size of

Re: [Fwd: TSO and 2.6.13.2]

2005-11-10 Thread Stephen Hemminger
On > It is not necessarily the most efficient way to generate bulk traffic, > but I think it is a valid test. > > I use non-blocking IO and poll(). It is true that both sides may have > full TX and/or RX buffers, but the code still works fine. I can adjust > my tool to request any speed any eith

Re: Consensus? WAS(RFC 2863)

2005-11-10 Thread Stefan Rompf
Am Mittwoch 09 November 2005 22:12 schrieb Thomas Graf: > Something like this should do the job, although it doesn't take care > of taking things up again for now. Now all supporters of this should > tell me how to implement any case of on demand interface after taking > the routes down. > [...] >

Re: motivation for TCP's cwnd clamp?

2005-11-10 Thread Stephen Hemminger
On Thu, 10 Nov 2005 12:35:16 -0500 "Armando L. Caro, Jr." <[EMAIL PROTECTED]> wrote: > I have been reading through the TCP code for kernel versions 2.4 and > 2.6, and have noticed that both versions not only cache cwnd state, but > also use the cached state to clamp the cwnd of subsquent TCP conne

Re: [Fwd: TSO and 2.6.13.2]

2005-11-10 Thread Ben Greear
Rick Jones wrote: Ben, as for your test I think something is messed up in your patches, as no one else seems to be reporting your freezes. I will run some tests on standard kernels if I can still reproduce on 2.6.14. If it is bugs in my patches, it's subtle..since turning off TSO fixes it.

Re: Consensus? WAS(RFC 2863)

2005-11-10 Thread Thomas Graf
* Jamal Hadi Salim <[EMAIL PROTECTED]> 2005-11-10 10:45 > from inspection: Whats wrong with what netif_carrier_ok() tells you? > i.e to extrapolate what you have (it seems to be out > fib_netdev_event())- something along: > > case NETDEV_CHANGE: > rt_cache_flush(0); >

Re: [Fwd: TSO and 2.6.13.2]

2005-11-10 Thread Rick Jones
Ben, as for your test I think something is messed up in your patches, as no one else seems to be reporting your freezes. I will run some tests on standard kernels if I can still reproduce on 2.6.14. If it is bugs in my patches, it's subtle..since turning off TSO fixes it. IIRC you said you h

Re: [PATCH 6/6] [NETLINK]: Generic netlink family

2005-11-10 Thread Thomas Graf
* James Morris <[EMAIL PROTECTED]> 2005-11-10 10:15 > For SELinux, we'll need to track genl ID assignment and deletion, so we > can determine what the Netlink family number means when we see a Netlink > message. We'll have to assume that the sysadmin has not changed the > module name. > > Forgo

[PATCH] fs_enet: fix compilation

2005-11-10 Thread Vitaly Bordug
Fs_enet was compile-broken due to recent platform code update (a number of platform stuff has been moved to the separate header). This fixes the compile issue. Signed-off-by: Vitaly Bordug <[EMAIL PROTECTED]> --- diff --git a/drivers/net/fs_enet/fs_enet-main.c b/drivers/net/fs_enet/fs_enet-m

Re: Consensus? WAS(RFC 2863)

2005-11-10 Thread Krzysztof Halasa
Jamal Hadi Salim <[EMAIL PROTECTED]> writes: > Well, the arguement goes both ways actually ;-> > By adding those routes the kernel _is_ making policy decisions. > In the case of standard dial on demand (any that i have seen on linux at > least), they typically have something along the lines of scr

Re: Consensus? WAS(RFC 2863)

2005-11-10 Thread Krzysztof Halasa
Jamal Hadi Salim <[EMAIL PROTECTED]> writes: > Folks: Is this a first time where we have a violent agreement? > Shall we say we are making progress? Not sure, looks like we've agreement WRT more obvious things and we haven't WRT to kernel-internal netdev state representation :-( But I think we'

Re: [PATCH 6/6] [NETLINK]: Generic netlink family

2005-11-10 Thread Thomas Graf
* Jamal Hadi Salim <[EMAIL PROTECTED]> 2005-11-10 11:00 > Dave - ACK on all 6. Both Thomas and I have tested these and the TIPC > folks have been playing with them for sometime now; if we get them in > for 2.6.15 it would help to encourage them to change their API on their > stable release to use t

Re: [PATCH 6/6] [NETLINK]: Generic netlink family

2005-11-10 Thread Jamal Hadi Salim
On Thu, 2005-10-11 at 02:25 +0100, Thomas Graf wrote: > plain text document attachment (nl_generic) > The generic netlink family builds on top of netlink and provides > simplifies access for the less demanding netlink users. It solves > the problem of protocol numbers running out by introducing a s

Re: Consensus? WAS(RFC 2863)

2005-11-10 Thread Jamal Hadi Salim
On Thu, 2005-10-11 at 14:17 +0100, Krzysztof Halasa wrote: > Stefan Rompf <[EMAIL PROTECTED]> writes: > > > ACK. We really should not be forced to modify all ethernet drivers in > > order to > > allow userspace changing dormant for 802.1X and friends. > > ACK too. In fact we are at all unable to

Re: Consensus? WAS(RFC 2863)

2005-11-10 Thread Jamal Hadi Salim
On Thu, 2005-10-11 at 01:10 +0100, Thomas Graf wrote: > * Jamal Hadi Salim <[EMAIL PROTECTED]> 2005-11-09 18:49 > > Historically we point such routes to the dummy device. Remember diald > > and good ole SLIP dial on demand? I would suspect it should still work > > the same way. > > Actually, probab

Re: Consensus? WAS(RFC 2863)

2005-11-10 Thread Jamal Hadi Salim
On Thu, 2005-10-11 at 01:03 +0100, Thomas Graf wrote: > > > Index: linux-2.6/net/ipv4/fib_frontend.c > > Is the opposite case missing? i.e what happens when a link goes down > > then up? i.e parrot what NETDEV_UP does? > > Yes, I haven't figured out how to uniquely identify a carrier up event > w

Re: [PATCH 6/6] [NETLINK]: Generic netlink family

2005-11-10 Thread James Morris
On Thu, 10 Nov 2005, James Morris wrote: > For SELinux, we'll need to track genl ID assignment and deletion, so we > can determine what the Netlink family number means when we see a Netlink > message. We'll have to assume that the sysadmin has not changed the > module name. Forgot to add that

Re: [PATCH 6/6] [NETLINK]: Generic netlink family

2005-11-10 Thread James Morris
On Thu, 10 Nov 2005, Thomas Graf wrote: > Although generic netlink modules can request static identifiers, > it is recommended to use GENL_ID_GENERATE and to let the controller > assign a unique identifier to the module. Userspace applications > will then ask the controller and lookup the idenfier

[PATCH] Generic HDLC WAN drivers - disable netif_carrier_off()

2005-11-10 Thread Krzysztof Halasa
Hi, As we are currently unable to fix the problem with carrier and protocol state signaling in net core I've to disable netif_carrier_off() calls used by WAN protocol drivers. The attached patch should make them working again. Not tested, but the patch is trivial and it applies to 2.6.14 cleanly :

Re: Consensus? WAS(RFC 2863)

2005-11-10 Thread Krzysztof Halasa
Stefan Rompf <[EMAIL PROTECTED]> writes: > ACK. We really should not be forced to modify all ethernet drivers in > order to > allow userspace changing dormant for 802.1X and friends. ACK too. In fact we are at all unable to modify them all without causing chaos. -- Krzysztof Halasa - To unsubsc

Re: iproute2 weirdness - fwmark and route pb

2005-11-10 Thread Sandro Dentella
I really believe this is a BUG, tell me if I'm wrong please. If I add a routing info in adsl table that forces *all* packets for test_ip to go throught isdn router I do see icmp reply. If I don't add 'ip route add host IP ...' the packets go the same way (becouse of 'ip rule fwmark staff' + ip

[patch 7/7] s390: mail address changed

2005-11-10 Thread Frank Pavlic
[patch 7/7] s390: mail address changed From: Frank Pavlic <[EMAIL PROTECTED]> - mail address changed to [EMAIL PROTECTED] Signed-off-by: Frank Pavlic <[EMAIL PROTECTED]> diffstat: lcs.c |4 ++-- qeth_main.c |4 ++-- qeth_mpc.c |2 +- qeth_mpc.h |2 +- qe

[patch 1/7] s390: synthax checking for VIPA addresses fixed

2005-11-10 Thread Frank Pavlic
[patch 1/7] s390: synthax checking for VIPA addresses fixed From: Peter Tiedemann <[EMAIL PROTECTED]> - synthax checking for VIPA addresses fixed Signed-off-by: Frank Pavlic <[EMAIL PROTECTED]> diffstat: qeth.h | 65 - qe

[patch 5/7] s390: fix recovery failure of non-guestLAN devices

2005-11-10 Thread Frank Pavlic
[patch 5/7] s390: fix recovery failure of non-guestLAN devices From: Frank Pavlic <[EMAIL PROTECTED]> - Recovery of non-guestLAN Layer 2 device failed due to trying to register the real MAC address we got from the READ_MAC adapter parameters command. We have

[patch 2/7] s390: minor modification in qeth layer2 code

2005-11-10 Thread Frank Pavlic
[patch 2/7] s390: minor modification in qeth layer2 code From: Frank Pavlic <[EMAIL PROTECTED]> - use qeth_layer2_send_setdelvlan_cb to check return code of a SET/DELVLAN IP Assist command. It fits better in qeth's design and mechanism of IP Assist command han

[patch 4/7] s390: some more qeth fixes

2005-11-10 Thread Frank Pavlic
[patch 4/7] s390: some more qeth fixes From: Frank Pavlic <[EMAIL PROTECTED]> From: Peter Tiedemann <[EMAIL PROTECTED]> - possible race on list fixed by reset list processing after every operation - traffic hang fixed Signed-off-by: Frank Pavlic <[EMAIL PROTECTED]>

[patch 6/7] s390: introduce guestLan sniffer support in qeth

2005-11-10 Thread Frank Pavlic
[patch 6/7] s390: introduce guestLan sniffer support in qeth From: Peter Tiedemann <[EMAIL PROTECTED]> - introduce guestLan sniffer support in qeth feature allows a linux in a virtual machine guest to become a network LAN sniffer, monitoring and recordi

does routing performance degrade from 2.4.20 to 2.4.31 ?

2005-11-10 Thread Mayuresh Chitale
Hi All, We are working on kernel version 2.4.20 and are trying to migrate to version 2.4.31. We are doing some performance related tests to see the impact of migration. The routing throughput seems to degrade from 2.4.20 to 2.4.31. We have a Malta board with mips 4kc processor and are using iperf

Re: [patch 0/3] bnx2: minor fixes (take #2)

2005-11-10 Thread David S. Miller
From: Jeff Garzik <[EMAIL PROTECTED]> Date: Thu, 10 Nov 2005 02:42:19 -0500 > Seems OK to me (though not pulled, since you didn't request such; also, > I dunno if DaveM has started being bnx2 merge master again) I can take care of these bnx2 changes tomorrow. - To unsubscribe from this list: sen