[Nepomuk] Re: [nepomuk-kde] Crystal moved to Git

Hi Sebas, while this is very nice you are writing to the wrong list. Please use nepomuk@kde.org in the future. :) Cheers, Sebastian On 03/16/2011 10:59 PM, Sebastian Kügler wrote: > Hey, > > The Crystal Destop Search widget has moved to Git. > > git clone kde:plasma-crystal > > Also here, if

[Nepomuk] Automatic Resize of Columns

I have added the feature of automatic resize of columns, it works for me on 2-3 queries i have tried. - Smit Shah (My Real Name :) ) P.S. We must find a good way end parenthetical statements with emotions or mankind maybe doomed forever. diff --git a/resourcequerywidget.cpp b/resourceq

[Nepomuk] Re: Improving the "Stop Button"

On Wed, Mar 16, 2011 at 9:28 PM, Sebastian Trüg wrote: > A note about git usage: actually we just used git like we used svn. > That was totally wrong. We should have created a branch and figured the > feature out in there. Then either merge it or even create one patch from > the branch and apply

[Nepomuk] Re: Improving the "Stop Button"

A note about git usage: actually we just used git like we used svn. That was totally wrong. We should have created a branch and figured the feature out in there. Then either merge it or even create one patch from the branch and apply that to master. Cheers, Sebastian On 03/16/2011 03:43 PM, Vishe

[Nepomuk] Re: Improving the "Stop Button"

On 03/16/2011 03:43 PM, Vishesh Handa wrote: > > > On Wed, Mar 16, 2011 at 8:01 PM, Sebastian Trüg > wrote: > > On 03/16/2011 03:20 PM, Vishesh Handa wrote: > > > > > > On Wed, Mar 16, 2011 at 7:37 PM, Sebastian Trüg > >

[Nepomuk] Re: Improving the "Stop Button"

On Wed, Mar 16, 2011 at 8:01 PM, Sebastian Trüg wrote: > On 03/16/2011 03:20 PM, Vishesh Handa wrote: > > > > > > On Wed, Mar 16, 2011 at 7:37 PM, Sebastian Trüg > > wrote: > > > > OK, so we only need a stopQuery() in the setQuery method, right? IMHO > > that is muc

[Nepomuk] Re: Improving the "Stop Button"

the attached patch should do it... On 03/16/2011 03:20 PM, Vishesh Handa wrote: > > > On Wed, Mar 16, 2011 at 7:37 PM, Sebastian Trüg > wrote: > > OK, so we only need a stopQuery() in the setQuery method, right? IMHO > that is much cleaner and easier to understand

[Nepomuk] Re: Improving the "Stop Button"

On 03/16/2011 03:20 PM, Vishesh Handa wrote: > > > On Wed, Mar 16, 2011 at 7:37 PM, Sebastian Trüg > wrote: > > OK, so we only need a stopQuery() in the setQuery method, right? IMHO > that is much cleaner and easier to understand than setting current query > to

[Nepomuk] Re: Improving the "Stop Button"

On Wed, Mar 16, 2011 at 7:37 PM, Sebastian Trüg wrote: > OK, so we only need a stopQuery() in the setQuery method, right? IMHO > that is much cleaner and easier to understand than setting current query > to 0. > That too won't work. Here is why - You run a query A, it finishes executing itself

[Nepomuk] Re: Improving the "Stop Button"

OK, so we only need a stopQuery() in the setQuery method, right? IMHO that is much cleaner and easier to understand than setting current query to 0. On 03/16/2011 02:58 PM, Vishesh Handa wrote: > This patch ( now committed ) is not that useful. > > The only thing it does is sets the time elapsed

[Nepomuk] Re: Improving the "Stop Button"

This patch ( now committed ) is not that useful. The only thing it does is sets the time elapsed when you click the "Stop Query" button. And it removes the old code which allowed you to automatically stop the old query if you ran a new one. When a query finishes execution, or is closed, it automa

[Nepomuk] Improving the "Stop Button"

The previous patch affected the copyright somehow so i am sending a new one. - Smit Shah (My real name) diff --git a/querymodel.cpp b/querymodel.cpp index d78a865..5679e56 100644 --- a/querymodel.cpp +++ b/querymodel.cpp @@ -37,13 +37,13 @@ namespace { -void splitUri( const QUrl& uri, QUrl

[Nepomuk] Improving the "Stop Button"

This patch aims to improve the "Stop Button" as current one just sets current query to 0. - Smit Shah (My real name) diff --git a/querymodel.cpp b/querymodel.cpp index d78a865..6c7c82e 100644 --- a/querymodel.cpp +++ b/querymodel.cpp @@ -1,20 +1,4 @@ /* - Copyright (c) 2010 Sebastian Trueg

[Nepomuk] Re: The "Stop Query" Button (Right Way)

very good. This is exactly right. I will commit it to git master. :) On 03/16/2011 10:51 AM, Who Knows wrote: > I realized my mistake, i have solved the problem all thanks to trueg > and vHanda, this patch works for me for 2-3 queries i tried but you can > check out for anymore > > - Smit Shah

[Nepomuk] The "Stop Query" Button (Right Way)

I realized my mistake, i have solved the problem all thanks to trueg and vHanda, this patch works for me for 2-3 queries i tried but you can check out for anymore - Smit Shah (my real name for future references.) diff --git a/querymodel.cpp b/querymodel.cpp index d78a865..4a1d0bb 100644 --- a/q

[Nepomuk] The "Stop Query" Button (Right Way)

I am sorry for the earlier version as it had mistakes and did not get the job done, i have fixed it but since i am not able to run the query to check it myself, i request you guys to inform me if there are any irregularities, i will get them sorted ASAP, again sorry for the blunder earlier . Als

[Nepomuk] Re: The "Stop Query" Button

Exactly, that is what I meant. The button has a method called "setEnabled(bool enabled)". You can use that to enable the button when the query was started in slotQueryButtonClicked() and disable it again in slotQueryStopButtonClicked() and slotQueryFinished(). Cheers, Sebastian On 03/16/2011 07:4