Re: [9, 8u40] RFR (M): 8057020: LambdaForm caches should support eviction

2014-12-03 Thread Vladimir Ivanov
Paul, John, thanks! Best regards, Vladimir Ivanov On 12/3/14, 10:38 AM, John Rose wrote: Reviewed. I sympathize with Paul's "gnarly" comment. Nice bit of stream-ology (rheology) in the test code. Regarding: On Dec 2, 2014, at 8:20 AM, Vladimir Ivanov wrote: In src/java.base/share/class

Re: [9, 8u40] RFR (M): 8057020: LambdaForm caches should support eviction

2014-12-03 Thread Aleksey Shipilev
On 12/01/2014 07:58 PM, Vladimir Ivanov wrote: > http://cr.openjdk.java.net/~vlivanov/8057020/webrev.00/ > https://bugs.openjdk.java.net/browse/JDK-8057020 Looks okay, although the cache management logic gives me a headache after the vacation. I thought I spotted a few bugs, but those were only fa

Re: [9, 8u40] RFR (M): 8057020: LambdaForm caches should support eviction

2014-12-03 Thread Remi Forax
On 12/03/2014 07:38 AM, John Rose wrote: Reviewed. I sympathize with Paul's "gnarly" comment. Nice bit of stream-ology (rheology) in the test code. The test code is unctuous ? Rémi Regarding: On Dec 2, 2014, at 8:20 AM, Vladimir Ivanov wrote: In src/java.base/share/classes/java/lang

Re: [9, 8u40] RFR (M): 8057020: LambdaForm caches should support eviction

2014-12-03 Thread Vladimir Ivanov
Aleksey, thanks for the review. I haven't tried -XX:SoftRefLRUPolicyMSPerMB=0, but I did extensive testing on Octane/Nashorn with multiple low -Xmx levels + frequent Full GCs (8060147 [1] was the result of those experiments) and stress tested cache eviction with jdk/java/lang/invoke/LFCache te