[9] RFR (S): 8058291: Missing some checks during parameter validation

2014-09-15 Thread Vladimir Ivanov
http://cr.openjdk.java.net/~vlivanov/8058291/webrev.00/ https://bugs.openjdk.java.net/browse/JDK-8058291 8057656 & 8050166 changes accidentally removed some checks during argument validation in MHs.dropArguments() and MHs.explicitCastArguments(). The fix is to restore them. Testing: jck (api/

[9] RFR (S): 8058293: Bit set computation in MHs.findFirstDupOrDrop/findFirstDrop is broken

2014-09-15 Thread Vladimir Ivanov
https://bugs.openjdk.java.net/browse/JDK-8058293 http://cr.openjdk.java.net/~vlivanov/8058293/webrev.00 Bit set computation in MHs.findFirstDupOrDrop/findFirstDrop is incorrect due to widening primitive conversions (int -> long) taking place. The fix is to explicitly use long where needed. Al

Re: [9] RFR (S): 8058293: Bit set computation in MHs.findFirstDupOrDrop/findFirstDrop is broken

2014-09-15 Thread John Rose
On Sep 15, 2014, at 9:48 AM, Vladimir Ivanov wrote: > https://bugs.openjdk.java.net/browse/JDK-8058293 > http://cr.openjdk.java.net/~vlivanov/8058293/webrev.00 > > Bit set computation in MHs.findFirstDupOrDrop/findFirstDrop is incorrect due > to widening primitive conversions (int -> long) tak

Re: [9] RFR (S): 8058291: Missing some checks during parameter validation

2014-09-15 Thread John Rose
Reviewed. Nice tuning of the asserts. — John On Sep 15, 2014, at 9:03 AM, Vladimir Ivanov wrote: > http://cr.openjdk.java.net/~vlivanov/8058291/webrev.00/ > https://bugs.openjdk.java.net/browse/JDK-8058291 > > 8057656 & 8050166 changes accidentally removed some checks during argument > vali