Re: [9] Review request : JDK-8057719: Develop new tests for LambdaForm Reduction and Caching feature

2014-09-11 Thread Vladimir Ivanov
Konstantin, Looks good! Thank you for working on the tests. Best regards, Vladimir Ivanov On 9/5/14, 9:52 PM, Konstantin Shefov wrote: Hello, Please review the new tests for the feature "Lambda Form Reduction and Caching" https://bugs.openjdk.java.net/browse/JDK-8046703 JBS task: https://bug

Re: [9] Review request : JDK-8057719: Develop new tests for LambdaForm Reduction and Caching feature

2014-09-11 Thread Paul Sandoz
On Sep 5, 2014, at 7:52 PM, Konstantin Shefov wrote: > Hello, > > Please review the new tests for the feature "Lambda Form Reduction and > Caching" https://bugs.openjdk.java.net/browse/JDK-8046703 > > JBS task: https://bugs.openjdk.java.net/browse/JDK-8057719 > > Webrev: http://cr.openjdk.j

Re: [9] Review request : JDK-8057707: TEST library enhancement: copy sun.hotspot.whitebox classes from hotspot repo and enhance lib/testlibrary/jsr292/com/oracle/testlibrary/jsr292/Helper.java

2014-09-11 Thread Vladimir Ivanov
Looks ok. I don't like the idea of having 2 copies of WB API for hotspot and jdk. But that's tolerable unless we have shared location for test libraries in top repository. Having reliable tests is more important IMO. Best regards, Vladimir Ivanov On 9/5/14, 9:57 PM, Konstantin Shefov wrote: