On 09/02/2014 03:59 PM, Vladimir Ivanov wrote:
Webrev: http://cr.openjdk.java.net/~vlivanov/8057042/webrev.00
Best regards,
Vladimir Ivanov
Hi Vladimir,
In LambdaFormEditor, where Transform[] is promoted into
ConcurrentHashMap:
339 ConcurrentHashMap m = new
Concurrent
Hi Vladimir,
I'm sure you and John have thought about it through, but I'll ask
anyway. Are cached LambdaForms going to stay around forever? What about
using a WeakReference (LambdaFormEditor.Transform could
extend WeakReference). This way unused LambdaForms would get GCed.
Regards, Peter
On
Peter,
Thanks for the feedback.
> In LambdaFormEditor, where Transform[] is promoted into
ConcurrentHashMap:
339 ConcurrentHashMap m =
new ConcurrentHashMap<>(MAX_CACHE_ARRAY_SIZE * 2);
340 for (Transform k : ta) {
341 if (k
Peter,
Yes, it's a known problem [1].
There are other caches (in MethodTypeForm, for example), which shouldn't
retain their elements.
Best regards,
Vladimir Ivanov
[1] https://bugs.openjdk.java.net/browse/JDK-8057020
On 9/3/14, 3:43 PM, Peter Levart wrote:
Hi Vladimir,
I'm sure you and Joh
src/share/classes/java/lang/invoke/BoundMethodHandle.java
Could we keep /* */ comment style consistent throughout?
@Override // there is a default binder in the super class, for
'L' types only
/*non-public*/
src/share/classes/java/lang/invoke/LambdaForm.java
! Object t
>From Morris
All that assert laden code is nice to see.
I just finished watching a video from Doug Lea where he mentioned that
having asserts can
inhibit inlining due to the additional byte codes. So he sadly does not
use them due to
performance issues.
Does anyone have any insights
On Sep 3, 2014, at 10:35 AM, Mark Roos wrote:
> From Morris
>
> All that assert laden code is nice to see.
>
> I just finished watching a video from Doug Lea where he mentioned that having
> asserts can
> inhibit inlining due to the additional byte codes. So he sadly does not use
On Sep 3, 2014, at 8:46 AM, Morris Meyer wrote:
> src/share/classes/java/lang/invoke/BoundMethodHandle.java
>
> Could we keep /* */ comment style consistent throughout?
>
> @Override // there is a default binder in the super class, for 'L'
> types only
> /*non-public*/
Most co
