Re: [Mingw-w64-public] winpthreads and MSVC

2025-02-04 Thread LIU Hao
在 2025-01-31 15:31, LIU Hao 写道: 在 2025-01-31 15:02, Kirill Makurin 写道: I think `"pthread_time.h"` makes more sense when including headers from the source tree? Hmm, that's true in general. I think the updated patch is acceptable. I have pushed patch1 and t_nanosleep now. -- Best regards,

Re: [Mingw-w64-public] winpthreads and MSVC

2025-01-30 Thread LIU Hao
在 2025-01-31 15:02, Kirill Makurin 写道: I think `"pthread_time.h"` makes more sense when including headers from the source tree? Hmm, that's true in general. I think the updated patch is acceptable. -- Best regards, LIU Hao OpenPGP_signature.asc Description: OpenPGP digital signature __

Re: [Mingw-w64-public] winpthreads and MSVC

2025-01-30 Thread Kirill Makurin
public@lists.sourceforge.net Subject: Re: [Mingw-w64-public] winpthreads and MSVC On 1/30/25 3:02 AM, Kirill Makurin wrote: > Yes, no problem. > > I also had a patch for Makefile.am which tried to solve the alias issue by > copying `[lib]winpthreads[.dll].{lib|a}` as `[lib]pthread[.dll].

Re: [Mingw-w64-public] winpthreads and MSVC

2025-01-30 Thread Kirill Makurin
I think `"pthread_time.h"` makes more sense when including headers from the source tree? From: LIU Hao Sent: Friday, January 31, 2025 3:57 PM To: Kirill Makurin; mingw-w64-public@lists.sourceforge.net Subject: Re: [Mingw-w64-public] winpthreads and MS

Re: [Mingw-w64-public] winpthreads and MSVC

2025-01-30 Thread LIU Hao
在 2025-01-31 14:48, Kirill Makurin 写道: I assume `getntptimeofday` is provided by mingw-w64 runtime. Maybe author of the test did not want to use winpthreads' `clock_gettime` for the test? Anyway, I attached a patch which replaces calls to `getntptimeofday` with calls to `clock_gettime`. I thin

Re: [Mingw-w64-public] winpthreads and MSVC

2025-01-30 Thread Kirill Makurin
using `clock_gettime` is that if it somehow breaks, it will also make this test to fail. From: LIU Hao Sent: Friday, January 31, 2025 3:07 PM To: mingw-w64-public@lists.sourceforge.net; Jonathan Yong; Kirill Makurin Subject: Re: [Mingw-w64-public] winpthreads and MSVC 在 2025-

Re: [Mingw-w64-public] winpthreads and MSVC

2025-01-30 Thread LIU Hao
在 2025-01-30 19:20, Jonathan Yong 写道: The 2 patches look OK to me, I'll wait for feed back from the others. The second patch introduces a private implementation of `getntptimeofday()` that does not write anything into `*tz`. Although all calls to this function in that file pass null pointers f

Re: [Mingw-w64-public] winpthreads and MSVC

2025-01-30 Thread Jonathan Yong
On 1/30/25 3:02 AM, Kirill Makurin wrote: Yes, no problem. I also had a patch for Makefile.am which tried to solve the alias issue by copying `[lib]winpthreads[.dll].{lib|a}` as `[lib]pthread[.dll].{lib|a}` during installation. I can send it again. I see. I could maintain a GitHub repository

Re: [Mingw-w64-public] winpthreads and MSVC

2025-01-29 Thread Kirill Makurin
and possibly CMake build systems. I think this could be useful. From: Jonathan Yong <10wa...@gmail.com> Sent: Thursday, January 30, 2025 10:38 AM To: mingw-w64-public@lists.sourceforge.net Subject: Re: [Mingw-w64-public] winpthreads and MSVC On 1/29/25 9

Re: [Mingw-w64-public] winpthreads and MSVC

2025-01-29 Thread Jonathan Yong
On 1/29/25 9:58 PM, Kirill Makurin wrote: Hi, I was writing to the list a few months ago regarding building of winpthreads with MSVC tools. I also sent a few patches back then, none of which were pushed. The first two patches were fixing a syntax error in `src/thread.h` and linking of `tests/

[Mingw-w64-public] winpthreads and MSVC

2025-01-29 Thread Kirill Makurin
Hi, I was writing to the list a few months ago regarding building of winpthreads with MSVC tools. I also sent a few patches back then, none of which were pushed. The first two patches were fixing a syntax error in `src/thread.h` and linking of `tests/t_nanosleep.c`. Other patches tried to fix i