Re: [Mingw-w64-public] readdir_r support

2015-06-29 Thread Jacek Caban
Hi Martell, On 06/29/15 12:45, Martell Malone wrote: > > It shouldn't be based on readdir, because it can't be made > reentrant this way. I'd suggest changing the existing > implementation to > have reentrant semantic and reimplement readdit on top of that. > > > Forgive my ignoran

Re: [Mingw-w64-public] readdir_r support

2015-06-29 Thread Martell Malone
> > I'm not fun of adding more extensions like that. However I can see that > we already provide readdir that is not present in MSVC, so it may make > sense to provide _r variant as well. Yes this is the reason I added it Please compile test your code before asking for review :P > Anyway, beside

Re: [Mingw-w64-public] readdir_r support

2015-06-29 Thread Jacek Caban
Hi Martell, On 06/27/15 18:02, Martell Malone wrote: > Attached is a patch for adding readdir_r > > I would like to ask should I make this __forceinline ? > like the localtime_r and gmtime_r functions? I'm not fun of adding more extensions like that. However I can see that we already provide read

[Mingw-w64-public] readdir_r support

2015-06-27 Thread Martell Malone
Attached is a patch for adding readdir_r I would like to ask should I make this __forceinline ? like the localtime_r and gmtime_r functions? Please Review :) From 22d04235c9e4e04442f2f93c53e84d95bff331a1 Mon Sep 17 00:00:00 2001 From: Martell Malone Date: Sat, 27 Jun 2015 17:00:01 +0100 Subject: