Re: [Mingw-w64-public] _CRTIMP

2016-08-22 Thread Kai Tietz
Hmm, as all of those are functions, and we get those warnings during crt build. So we could simply take care that within crt build (and it helper libraries) those prototypes using a _CRTIMP variant without dllimport. This should work in all scenarios well, as linker will resolve such functions. R

Re: [Mingw-w64-public] _CRTIMP

2016-08-22 Thread David Wohlferd
On 8/18/2016 11:27 PM, David Wohlferd wrote: > My next patch is very small, but it affects a bunch of code. Ponder > it a bit before approving. The goal is to fix all the warnings like > this: > > warning: '_unlock_file' redeclared without dllimport attribute: > previous dllimport ignored [-W

[Mingw-w64-public] _CRTIMP

2016-08-18 Thread David Wohlferd
My next patch is very small, but it affects a bunch of code. Ponder it a bit before approving. The goal is to fix all the warnings like this: warning: '_unlock_file' redeclared without dllimport attribute: previous dllimport ignored [-Wattributes] This occurs because our headers use: _C

Re: [Mingw-w64-public] _CRTIMP

2013-08-26 Thread dw
> we are capable to handle dll-imports without the proper > decoration of the symbol. I understand why you want to have the stubs. This made more sense to me once I saw that __builtin_memset ends up using them to call __imp_memset. > If a symbol is marked as dllimport, it means it becomes part

Re: [Mingw-w64-public] _CRTIMP

2013-08-26 Thread Kai Tietz
2013/8/26 dw : > >>> Is this intentional? Or a bug? >> I'll leave this for Kai to decide whether to put in dllimport. > > Actually, it may not be as simple as it appears. > > Looking back at when stdio.h was first added to the project, everything > WAS marked with _CRTIMP. The attribute was remov

Re: [Mingw-w64-public] _CRTIMP

2013-08-25 Thread dw
>> Is this intentional? Or a bug? > I'll leave this for Kai to decide whether to put in dllimport. Actually, it may not be as simple as it appears. Looking back at when stdio.h was first added to the project, everything WAS marked with _CRTIMP. The attribute was removed as part of 127 & 129

Re: [Mingw-w64-public] _CRTIMP

2013-08-25 Thread JonY
On 8/25/2013 16:06, dw wrote: > (Hopefully) I've got an easy question this time: Why doesn't feof() > (from stdio.h) use _CRTIMP? > > If there is no _CRTIMP (aka dllimport) on the definition for feof, you > get this when you call it: > >402cef:call 402b90 > > Note that this does NOT

[Mingw-w64-public] _CRTIMP

2013-08-25 Thread dw
(Hopefully) I've got an easy question this time: Why doesn't feof() (from stdio.h) use _CRTIMP? If there is no _CRTIMP (aka dllimport) on the definition for feof, you get this when you call it: 402cef:call 402b90 Note that this does NOT call the import. Instead it calls this stub w