Re: [Mingw-w64-public] Fix def file generation during parallel build

2015-11-18 Thread NightStrike
On Nov 18, 2015 4:39 AM, "JonY" wrote: > > On 11/17/2015 22:13, NightStrike wrote: > > This is a bad change. Make should be managing dependencies. It's bad > > form to force a call to mkdir for every iteration, when it only needs > > to be called once (especially on msys/cygwin, where that extra

Re: [Mingw-w64-public] Fix def file generation during parallel build

2015-11-18 Thread JonY
On 11/17/2015 22:13, NightStrike wrote: > This is a bad change. Make should be managing dependencies. It's bad > form to force a call to mkdir for every iteration, when it only needs > to be called once (especially on msys/cygwin, where that extra call is > non-trivial.) The correct way to do it

Re: [Mingw-w64-public] Fix def file generation during parallel build

2015-11-17 Thread NightStrike
This is a bad change. Make should be managing dependencies. It's bad form to force a call to mkdir for every iteration, when it only needs to be called once (especially on msys/cygwin, where that extra call is non-trivial.) The correct way to do it is to set the destination directory as a depend

Re: [Mingw-w64-public] Fix def file generation during parallel build

2015-11-15 Thread JonY
On 11/15/2015 12:22, JonY wrote: > Patch OK? > > diff --git a/mingw-w64-crt/Makefile.am b/mingw-w64-crt/Makefile.am > index a137750..48bdfd3 100644 > --- a/mingw-w64-crt/Makefile.am > +++ b/mingw-w64-crt/Makefile.am > @@ -1416,7 +1416,7 @@ endif > # ## > > %.def: %.def.in > - $(CP

[Mingw-w64-public] Fix def file generation during parallel build

2015-11-14 Thread JonY
Patch OK? diff --git a/mingw-w64-crt/Makefile.am b/mingw-w64-crt/Makefile.am index a137750..48bdfd3 100644 --- a/mingw-w64-crt/Makefile.am +++ b/mingw-w64-crt/Makefile.am @@ -1416,7 +1416,7 @@ endif # ## %.def: %.def.in - $(CPP) -x c $< -Wp,-w -I$(top_srcdir)/def-include | $(SED)