Re: [Mingw-w64-public] Fix compile error in commctrl.h

2014-09-03 Thread Dongsheng Song
Thanks, pushed without _WIN32 guard. On Wed, Sep 3, 2014 at 6:18 PM, Kai Tietz wrote: > Sure, it has to. > > Kai > > 2014-09-03 12:06 GMT+02:00 Dongsheng Song : >> Did ARM target support these features or defined _WIN32 ? >> >> On Wed, Sep 3, 2014 at 3:27 PM, Kai Tietz wrote: >>> Hi, >>> >>> To

Re: [Mingw-w64-public] Fix compile error in commctrl.h

2014-09-03 Thread Kai Tietz
Sure, it has to. Kai 2014-09-03 12:06 GMT+02:00 Dongsheng Song : > Did ARM target support these features or defined _WIN32 ? > > On Wed, Sep 3, 2014 at 3:27 PM, Kai Tietz wrote: >> Hi, >> >> To move code up is ok. Patch is ok, but one nit. Why do you check >> here _WIN32 as guard. Do we have

Re: [Mingw-w64-public] Fix compile error in commctrl.h

2014-09-03 Thread Dongsheng Song
Did ARM target support these features or defined _WIN32 ? On Wed, Sep 3, 2014 at 3:27 PM, Kai Tietz wrote: > Hi, > > To move code up is ok. Patch is ok, but one nit. Why do you check > here _WIN32 as guard. Do we have targets where _WIN32 isn't defined? > > Cheers, > Kai > > 2014-09-03 5:33 GM

Re: [Mingw-w64-public] Fix compile error in commctrl.h

2014-09-03 Thread Kai Tietz
Hi, To move code up is ok. Patch is ok, but one nit. Why do you check here _WIN32 as guard. Do we have targets where _WIN32 isn't defined? Cheers, Kai 2014-09-03 5:33 GMT+02:00 Dongsheng Song : > Hi, > > This patch fix compile error in commctrl.h > > Ok for apply? > > Regards, > Dongsheng > >

[Mingw-w64-public] Fix compile error in commctrl.h

2014-09-02 Thread Dongsheng Song
Hi, This patch fix compile error in commctrl.h Ok for apply? Regards, Dongsheng From 8b0831b0a5b778379f50023e6c8e16c8851f8a43 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E5=AE=8B=E5=86=AC=E7=94=9F?= Date: Wed, 3 Sep 2014 10:57:19 +0800 Subject: [PATCH] Fix compile error in commctrl.h --- ming