Re: [Mingw-w64-public] Add some more missing declaration of dwrite_1.h

On 03/15/2018 02:54 PM, Ebrahim Byagowi wrote: > Oh, I see, done. Looks good to me. I pushed that to Git. Thanks, Jacek -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org

Re: [Mingw-w64-public] Add some more missing declaration of dwrite_1.h

Oh, I see, done. On Thu, Mar 15, 2018 at 2:09 PM, Jacek Caban wrote: > Hi Ebrahim, > > > #ifndef __cplusplus inside IDWriteTextAnalyzer1 should be around all > parent interfaces' methods (IDWriteTextAnalyzer in this case), not just > IUnknown. > > > Thanks, > > Jacek > > > On 3/14/18 12:19 AM, E

Re: [Mingw-w64-public] Add some more missing declaration of dwrite_1.h

Hi Ebrahim, #ifndef __cplusplus inside IDWriteTextAnalyzer1 should be around all parent interfaces' methods (IDWriteTextAnalyzer in this case), not just IUnknown. Thanks, Jacek On 3/14/18 12:19 AM, Ebrahim Byagowi wrote: Spotted one minor issue on the patch, here is another On Wed, Mar

Re: [Mingw-w64-public] Add some more missing declaration of dwrite_1.h

Spotted one minor issue on the patch, here is another On Wed, Mar 14, 2018 at 12:29 AM, Ebrahim Byagowi wrote: > Hi there. Following https://github.com/Alexpux/mingw-w64/pull/5 I am > sending my work here, this patch allows harfbuzz's hb-directwrite >

[Mingw-w64-public] Add some more missing declaration of dwrite_1.h

Hi there. Following https://github.com/Alexpux/mingw-w64/pull/5 I am sending my work here, this patch allows harfbuzz's hb-directwrite build on msys2, I hope this change can be applied to both "/msys2/usr/Include/win32api/dwri