Well,
the inline variant seems fine to me. I would prefer to have here
instead an implementation file. As later allows us to provide such a
function from import-library too.
Cheers,
Kai
2017-06-04 2:10 GMT+02:00 Martell Malone :
> Following up with an initial patch
> Not sure if this is ideal
Following up with an initial patch
Not sure if this is ideal because this will be used over the MSVC version.
I can add it to a c source as an emulation if that suits better
diff --git a/mingw-w64-headers/crt/time.h b/mingw-w64-headers/crt/time.h
index 7f5bbb78..405a9f1d 100644
--- a/mingw-w64-hea
Thanks for spotting that strangely MSDN seems to think it does exist.
https://docs.microsoft.com/en-gb/cpp/c-runtime-library/reference/strftime-wcsftime-strftime-l-wcsftime-l
I have no problem in doing an emulation for "strftime_l".
I would rather not use random msvcrt versions :)
On Mon, May 22,
On 2017/5/22 18:43, JonY wrote:
> On 05/22/2017 07:57 AM, Liu Hao wrote:
>> On 2017/5/22 2:05, Martell Malone wrote:
>>> Context: libc++ uses strftime_l now
>>>
>>> Please Review
>> The DEF files are generated from DLLs. I don't have Win10 at hand so I
>> have asked jon_y on IRC to update them.
>>
hmm okay.
It does have strftime however so that should at least be fine right?
On Mon, May 22, 2017 at 11:43 AM, JonY wrote:
> On 05/22/2017 07:57 AM, Liu Hao wrote:
> > On 2017/5/22 2:05, Martell Malone wrote:
> >> Context: libc++ uses strftime_l now
> >>
> >> Please Review
> > The DEF files
On 05/22/2017 07:57 AM, Liu Hao wrote:
> On 2017/5/22 2:05, Martell Malone wrote:
>> Context: libc++ uses strftime_l now
>>
>> Please Review
> The DEF files are generated from DLLs. I don't have Win10 at hand so I
> have asked jon_y on IRC to update them.
>
Win10 msvcrt doesn't have strftime_l,
On 2017/5/22 2:05, Martell Malone wrote:
> Context: libc++ uses strftime_l now
>
> Please Review
The DEF files are generated from DLLs. I don't have Win10 at hand so I
have asked jon_y on IRC to update them.
--
Best regards,
LH_Mouse
---
Context: libc++ uses strftime_l now
Please Review
Kind Regards
Martell
diff --git a/mingw-w64-crt/lib32/msvcrt.def.in b/mingw-w64-crt/lib32/
msvcrt.def.in
index 51f62cb6..f22a79a9 100644
--- a/mingw-w64-crt/lib32/msvcrt.def.in
+++ b/mingw-w64-crt/lib32/msvcrt.def.in
@@ -1210,6 +1210,8 @@ mbstowc
