Re: [Mingw-w64-public] [Patch] Move inline asm from conio.h to intrin-impl.h

2013-08-04 Thread Kai Tietz
2013/8/5 dw : > >> In general this patch looks fair. But there seems to be a bug here >> about readcr(1|2|...) function and none-64-bit mode. The signature is >> different for that and this seems not to be reflected in that patch. > > It's there, it just isn't as obvious as how it was done in > i

Re: [Mingw-w64-public] [Patch] Move inline asm from conio.h to intrin-impl.h

2013-08-04 Thread dw
> In general this patch looks fair. But there seems to be a bug here > about readcr(1|2|...) function and none-64-bit mode. The signature is > different for that and this seems not to be reflected in that patch. It's there, it just isn't as obvious as how it was done in intrincs\readcr*.c. Lo

Re: [Mingw-w64-public] [Patch] Move inline asm from conio.h to intrin-impl.h

2013-08-04 Thread Kai Tietz
2013/8/4 dw : > - Move intrinsics from conio.h to intrin-impl.h to be consistent with msdn. > - Update related files in intrincs\*.c to share code with intrin-impl.h. > - Updated the asm to support both att/intel. > - Use macros to ensure consistent definitions. > > Note that most of these function