Re: [Mingw-w64-public] [PATCH v3 05/10] winstorecompat: provide GetUserName

2020-05-07 Thread Martin Storsjö
On Thu, 7 May 2020, Steve Lhomme wrote: On 2020-05-06 15:27, Martin Storsjö wrote: On Wed, 6 May 2020, Jacek Caban wrote: On 06.05.2020 15:09, Martin Storsjö wrote: Or call directly GetEnvironment directly? If it works on all relevant Windows versions, that sounds good. MSDN says it's s

Re: [Mingw-w64-public] [PATCH v3 05/10] winstorecompat: provide GetUserName

2020-05-07 Thread Steve Lhomme
On 2020-05-06 15:27, Martin Storsjö wrote: On Wed, 6 May 2020, Jacek Caban wrote: On 06.05.2020 15:09, Martin Storsjö wrote: Or call directly GetEnvironment directly? If it works on all relevant Windows versions, that sounds good. MSDN says it's supported since XP so I suppose so, but I c

Re: [Mingw-w64-public] [PATCH v3 05/10] winstorecompat: provide GetUserName

2020-05-06 Thread Martin Storsjö
On Wed, 6 May 2020, Jacek Caban wrote: On 06.05.2020 15:09, Martin Storsjö wrote: Or call directly GetEnvironment directly? If it works on all relevant Windows versions, that sounds good. MSDN says it's supported since XP so I suppose so, but I can't guarantee it. I can only test on windo

Re: [Mingw-w64-public] [PATCH v3 05/10] winstorecompat: provide GetUserName

2020-05-06 Thread Jacek Caban
On 06.05.2020 15:09, Martin Storsjö wrote: Or call directly GetEnvironment directly? If it works on all relevant Windows versions, that sounds good. MSDN says it's supported since XP so I suppose so, but I can't guarantee it. I can only test on windows 10 at the moment. Did I understand i

Re: [Mingw-w64-public] [PATCH v3 05/10] winstorecompat: provide GetUserName

2020-05-06 Thread Martin Storsjö
On Tue, 28 Apr 2020, Steve Lhomme wrote: On 2020-04-27 19:59, Jacek Caban wrote: On 27.04.2020 19:55, Jean-Baptiste Kempf wrote: On Mon, Apr 27, 2020, at 19:40, Jacek Caban wrote: On 27.04.2020 16:31, Steve Lhomme wrote: It's needed by: - getlogin() in mingwex Could we prohibit getlogin()

Re: [Mingw-w64-public] [PATCH v3 05/10] winstorecompat: provide GetUserName

2020-04-28 Thread Martin Storsjö
On Mon, 27 Apr 2020, Jacek Caban wrote: On 27.04.2020 19:55, Jean-Baptiste Kempf wrote: On Mon, Apr 27, 2020, at 19:40, Jacek Caban wrote: On 27.04.2020 16:31, Steve Lhomme wrote: It's needed by: - getlogin() in mingwex Could we prohibit getlogin() on non-desktop in headers instead? Or ca

Re: [Mingw-w64-public] [PATCH v3 05/10] winstorecompat: provide GetUserName

2020-04-28 Thread Steve Lhomme
On 2020-04-27 19:59, Jacek Caban wrote: On 27.04.2020 19:55, Jean-Baptiste Kempf wrote: On Mon, Apr 27, 2020, at 19:40, Jacek Caban wrote: On 27.04.2020 16:31, Steve Lhomme wrote: It's needed by: - getlogin() in mingwex Could we prohibit getlogin() on non-desktop in headers instead? It's

Re: [Mingw-w64-public] [PATCH v3 05/10] winstorecompat: provide GetUserName

2020-04-27 Thread Jacek Caban
On 27.04.2020 19:55, Jean-Baptiste Kempf wrote: On Mon, Apr 27, 2020, at 19:40, Jacek Caban wrote: On 27.04.2020 16:31, Steve Lhomme wrote: It's needed by: - getlogin() in mingwex Could we prohibit getlogin() on non-desktop in headers instead? Or call directly GetEnvironment directly? If

Re: [Mingw-w64-public] [PATCH v3 05/10] winstorecompat: provide GetUserName

2020-04-27 Thread Jean-Baptiste Kempf
On Mon, Apr 27, 2020, at 19:40, Jacek Caban wrote: > On 27.04.2020 16:31, Steve Lhomme wrote: > > It's needed by: > > - getlogin() in mingwex > > > Could we prohibit getlogin() on non-desktop in headers instead? Or call directly GetEnvironment directly? -- Jean-Baptiste Kempf - President +

Re: [Mingw-w64-public] [PATCH v3 05/10] winstorecompat: provide GetUserName

2020-04-27 Thread Jacek Caban
On 27.04.2020 16:31, Steve Lhomme wrote: It's needed by: - getlogin() in mingwex Could we prohibit getlogin() on non-desktop in headers instead? Thanks, Jacek ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://list

[Mingw-w64-public] [PATCH v3 05/10] winstorecompat: provide GetUserName

2020-04-27 Thread Steve Lhomme
It's needed by: - getlogin() in mingwex GetEnvironmentVariableA("USERNAME") gives the same information (tested on win10 in cmd.exe and PowerShell). No implementation provided when building winstorecompat for win8 as GetEnvironmentVariableA is not allowed and GetUserNameEx requires -lsecur32. ---