Re: [Mingw-w64-public] [PATCH 1/9] crt: use GetEnvironmentVariableA in getopt

2020-04-24 Thread Steve Lhomme
On 2020-04-24 15:28, Jacek Caban wrote: On 24.04.2020 15:14, Steve Lhomme wrote: On 2020-04-24 15:11, Jacek Caban wrote: On 24.04.2020 14:35, Steve Lhomme wrote: On 2020-04-24 14:30, Jacek Caban wrote: On 24.04.2020 14:26, Steve Lhomme wrote: On 2020-04-24 14:24, Jacek Caban wrote: On

Re: [Mingw-w64-public] [PATCH 1/9] crt: use GetEnvironmentVariableA in getopt

2020-04-24 Thread Jacek Caban
On 24.04.2020 15:14, Steve Lhomme wrote: On 2020-04-24 15:11, Jacek Caban wrote: On 24.04.2020 14:35, Steve Lhomme wrote: On 2020-04-24 14:30, Jacek Caban wrote: On 24.04.2020 14:26, Steve Lhomme wrote: On 2020-04-24 14:24, Jacek Caban wrote: On 24.04.2020 13:43, Steve Lhomme wrote: This a

Re: [Mingw-w64-public] [PATCH 1/9] crt: use GetEnvironmentVariableA in getopt

2020-04-24 Thread Steve Lhomme
On 2020-04-24 15:11, Jacek Caban wrote: On 24.04.2020 14:35, Steve Lhomme wrote: On 2020-04-24 14:30, Jacek Caban wrote: On 24.04.2020 14:26, Steve Lhomme wrote: On 2020-04-24 14:24, Jacek Caban wrote: On 24.04.2020 13:43, Steve Lhomme wrote: This avoids relying on getenv() from winstoreco

Re: [Mingw-w64-public] [PATCH 1/9] crt: use GetEnvironmentVariableA in getopt

2020-04-24 Thread Jacek Caban
On 24.04.2020 14:35, Steve Lhomme wrote: On 2020-04-24 14:30, Jacek Caban wrote: On 24.04.2020 14:26, Steve Lhomme wrote: On 2020-04-24 14:24, Jacek Caban wrote: On 24.04.2020 13:43, Steve Lhomme wrote: This avoids relying on getenv() from winstorecompat that returns NULL and can't be reimpl

Re: [Mingw-w64-public] [PATCH 1/9] crt: use GetEnvironmentVariableA in getopt

2020-04-24 Thread Steve Lhomme
On 2020-04-24 14:30, Jacek Caban wrote: On 24.04.2020 14:26, Steve Lhomme wrote: On 2020-04-24 14:24, Jacek Caban wrote: On 24.04.2020 13:43, Steve Lhomme wrote: This avoids relying on getenv() from winstorecompat that returns NULL and can't be reimplemented in a clean way. What's the prob

Re: [Mingw-w64-public] [PATCH 1/9] crt: use GetEnvironmentVariableA in getopt

2020-04-24 Thread Jacek Caban
On 24.04.2020 14:26, Steve Lhomme wrote: On 2020-04-24 14:24, Jacek Caban wrote: On 24.04.2020 13:43, Steve Lhomme wrote: This avoids relying on getenv() from winstorecompat that returns NULL and can't be reimplemented in a clean way. What's the problem with getenv()? Would using _wgetenv i

Re: [Mingw-w64-public] [PATCH 1/9] crt: use GetEnvironmentVariableA in getopt

2020-04-24 Thread Steve Lhomme
On 2020-04-24 14:24, Jacek Caban wrote: On 24.04.2020 13:43, Steve Lhomme wrote: This avoids relying on getenv() from winstorecompat that returns NULL and can't be reimplemented in a clean way. What's the problem with getenv()? Would using _wgetenv instead help? According to this page it's

Re: [Mingw-w64-public] [PATCH 1/9] crt: use GetEnvironmentVariableA in getopt

2020-04-24 Thread Jacek Caban
On 24.04.2020 13:43, Steve Lhomme wrote: This avoids relying on getenv() from winstorecompat that returns NULL and can't be reimplemented in a clean way. What's the problem with getenv()? Would using _wgetenv instead help? Jacek ___ Mingw-w64-pu

[Mingw-w64-public] [PATCH 1/9] crt: use GetEnvironmentVariableA in getopt

2020-04-24 Thread Steve Lhomme
The API is available since Windows XP and available in UWP for win8 and win10. This avoids relying on getenv() from winstorecompat that returns NULL and can't be reimplemented in a clean way. --- mingw-w64-crt/misc/getopt.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git