Re: [Mingw-w64-public] [PATCH] stdio/math: Various implementations and more for ARM (v2)

2014-09-22 Thread André Hentschel
Am 21.09.2014 um 23:41 schrieb dw: > > On 9/20/2014 8:07 AM, André Hentschel wrote: >> Am 19.09.2014 um 17:30 schrieb Kai Tietz: >>> 2014-09-19 1:34 GMT+02:00 dw : For the parts that are "working around a compiler bug": - Does it make sense to list the bug number in the comment? >>>

Re: [Mingw-w64-public] [PATCH] stdio/math: Various implementations and more for ARM (v2)

2014-09-21 Thread dw
On 9/20/2014 8:07 AM, André Hentschel wrote: > Am 19.09.2014 um 17:30 schrieb Kai Tietz: >> 2014-09-19 1:34 GMT+02:00 dw : >>> For the parts that are "working around a compiler bug": >>> >>> - Does it make sense to list the bug number in the comment? >> I think it makes sense in general. Only imp

Re: [Mingw-w64-public] [PATCH] stdio/math: Various implementations and more for ARM (v2)

2014-09-20 Thread André Hentschel
Am 19.09.2014 um 17:30 schrieb Kai Tietz: > 2014-09-19 1:34 GMT+02:00 dw : >> For the parts that are "working around a compiler bug": >> >> - Does it make sense to list the bug number in the comment? > I think it makes sense in general. Only important thing should be to > mark bug-number, that it

Re: [Mingw-w64-public] [PATCH] stdio/math: Various implementations and more for ARM (v2)

2014-09-19 Thread Kai Tietz
2014-09-19 1:34 GMT+02:00 dw : > For the parts that are "working around a compiler bug": > > - Does it make sense to list the bug number in the comment? I think it makes sense in general. Only important thing should be to mark bug-number, that it belongs to SF bug-tracker. We might want to change

Re: [Mingw-w64-public] [PATCH] stdio/math: Various implementations and more for ARM (v2)

2014-09-18 Thread dw
For the parts that are "working around a compiler bug": - Does it make sense to list the bug number in the comment? - If the bug has been fixed, what about using __GNUC__ and __GNUC_MINOR__ to limit the code? dw On 9/18/2014 3:23 PM, André Hentschel wrote: Please review, i'll commit it, just

Re: [Mingw-w64-public] [PATCH] stdio/math: Various implementations and more for ARM (v2)

2014-09-18 Thread Kai Tietz
Looks ok. Please apply Thanks, Kai -- Slashdot TV. Video for Nerds. Stuff that Matters. http://pubads.g.doubleclick.net/gampad/clk?id=160591471&iu=/4140/ostg.clktrk ___ Mingw

[Mingw-w64-public] [PATCH] stdio/math: Various implementations and more for ARM (v2)

2014-09-18 Thread André Hentschel
Please review, i'll commit it, just need an OK. v2 adds llrint functions, removes hidden attribute diff --git a/mingw-w64-crt/Makefile.am b/mingw-w64-crt/Makefile.am index 7245956..9731aa9 100644 --- a/mingw-w64-crt/Makefile.am +++ b/mingw-w64-crt/Makefile.am @@ -233,7 +233,7 @@ src_libmingwe

Re: [Mingw-w64-public] [PATCH] stdio/math: Various implementations and more for ARM

2014-09-18 Thread Kai Tietz
Patch looks ok, but a the use of '__attribute__((visibility ("hidden")))'. Actually the visibility stuff isn't supported by pe-coff, so is it really necessary here? Kai -- Slashdot TV. Video for Nerds. Stuff that Matte

[Mingw-w64-public] [PATCH] stdio/math: Various implementations and more for ARM

2014-09-18 Thread André Hentschel
Please review, i'll commit it, just need an OK. diff --git a/mingw-w64-crt/Makefile.am b/mingw-w64-crt/Makefile.am index 7245956..9731aa9 100644 --- a/mingw-w64-crt/Makefile.am +++ b/mingw-w64-crt/Makefile.am @@ -233,7 +233,7 @@ src_libmingwex=\ math/fabs.c math/fabsf.c mat