Re: [Mingw-w64-public] [PATCH] math: Fix rounding in llrint(f) on ARM

2016-08-19 Thread Kai Tietz
Yeah, this looks to me more sane. Patches (both) are ok. Well, we might should go the same route like llvm too. Thanks, Kai Am 18.08.2016 23:32 schrieb "Martin Storsjö" : --- Updated to check with fegetround to see which rounding mode to use, fixed the way the mode is checked (by using == inste

[Mingw-w64-public] [PATCH] math: Fix rounding in llrint(f) on ARM

2016-08-18 Thread Martin Storsjö
--- Updated to check with fegetround to see which rounding mode to use, fixed the way the mode is checked (by using == instead of &). --- mingw-w64-crt/math/llrint.c | 11 ++- mingw-w64-crt/math/llrintf.c | 11 ++- 2 files changed, 20 insertions(+), 2 deletions(-) diff --git a/mi

Re: [Mingw-w64-public] [PATCH] math: Fix rounding in llrint(f) on ARM

2016-08-18 Thread Martin Storsjö
On Thu, 18 Aug 2016, Martin Storsjö wrote: --- Updated to check with fegetround to see which rounding mode to use. --- mingw-w64-crt/math/llrint.c | 11 ++- mingw-w64-crt/math/llrintf.c | 11 ++- 2 files changed, 20 insertions(+), 2 deletions(-) diff --git a/mingw-w64-crt/math/ll

[Mingw-w64-public] [PATCH] math: Fix rounding in llrint(f) on ARM

2016-08-18 Thread Martin Storsjö
--- Updated to check with fegetround to see which rounding mode to use. --- mingw-w64-crt/math/llrint.c | 11 ++- mingw-w64-crt/math/llrintf.c | 11 ++- 2 files changed, 20 insertions(+), 2 deletions(-) diff --git a/mingw-w64-crt/math/llrint.c b/mingw-w64-crt/math/llrint.c index

Re: [Mingw-w64-public] [PATCH] math: Fix rounding in llrint(f) on ARM

2016-08-18 Thread Martin Storsjö
On Thu, 18 Aug 2016, Martin Storsjö wrote: On Thu, 18 Aug 2016, Kai Tietz wrote: Hello Martin, 2016-08-18 15:31 GMT+02:00 Martin Storsjö : --- The (l)rint(f) functions call an inline assembly snippet to do the rounding - that does seem to round in the right way, but I'm not sure if that reli

Re: [Mingw-w64-public] [PATCH] math: Fix rounding in llrint(f) on ARM

2016-08-18 Thread Martin Storsjö
On Thu, 18 Aug 2016, Kai Tietz wrote: Hello Martin, 2016-08-18 15:31 GMT+02:00 Martin Storsjö : --- The (l)rint(f) functions call an inline assembly snippet to do the rounding - that does seem to round in the right way, but I'm not sure if that relies on the fpscr being set in the right mode?

Re: [Mingw-w64-public] [PATCH] math: Fix rounding in llrint(f) on ARM

2016-08-18 Thread Kai Tietz
Hello Martin, 2016-08-18 15:31 GMT+02:00 Martin Storsjö : > --- > The (l)rint(f) functions call an inline assembly snippet to > do the rounding - that does seem to round in the right way, but I'm > not sure if that relies on the fpscr being set in the right mode? > --- > mingw-w64-crt/math/llrint

[Mingw-w64-public] [PATCH] math: Fix rounding in llrint(f) on ARM

2016-08-18 Thread Martin Storsjö
--- The (l)rint(f) functions call an inline assembly snippet to do the rounding - that does seem to round in the right way, but I'm not sure if that relies on the fpscr being set in the right mode? --- mingw-w64-crt/math/llrint.c | 2 +- mingw-w64-crt/math/llrintf.c | 2 +- 2 files changed, 2 ins