Re: [Mingw-w64-public] [PATCH] headers: memoryapi add Windows 10 functions

2020-04-04 Thread Liu Hao
在 2020/4/5 3:52, Martin Storsjö 写道: > > In this case - I hadn't expected you to verify it before pushing, I had > expected the patch author to try to use it - but if you do such checks > before pushing, it's really commendable! > > In this case, it turns out that it didn't pick up the issue, beca

Re: [Mingw-w64-public] [PATCH] headers: memoryapi add Windows 10 functions

2020-04-04 Thread Martin Storsjö
On Sat, 4 Apr 2020, Liu Hao wrote: 在 2020/4/4 16:28, Martin Storsjö 写道: Did you actually test this at all, in any way, whatsoever? Because the newly added function declarations use the types MEM_EXTENDED_PARAMETER and PCFG_CALL_TARGET_INFO, that aren't declared anywhere in mingw-w64 headers.

Re: [Mingw-w64-public] [PATCH] headers: memoryapi add Windows 10 functions

2020-04-04 Thread Liu Hao
在 2020/4/4 16:28, Martin Storsjö 写道: > > Did you actually test this at all, in any way, whatsoever? > > Because the newly added function declarations use the types > MEM_EXTENDED_PARAMETER and PCFG_CALL_TARGET_INFO, that aren't declared > anywhere in mingw-w64 headers. > Hmm.. how could this c

Re: [Mingw-w64-public] [PATCH] headers: memoryapi add Windows 10 functions

2020-04-04 Thread Martin Storsjö
On Sat, 4 Apr 2020, Biswapriyo Nath wrote: Yes, I have a patch for it. I am doing it one by one. I thought it will be easier to patch one header at a time. Apology for any inconvenience. Patching headers one at a time is ok in itself, but you have to make sure the tree actually works after ea

Re: [Mingw-w64-public] [PATCH] headers: memoryapi add Windows 10 functions

2020-04-04 Thread Biswapriyo Nath
Yes, I have a patch for it. I am doing it one by one. I thought it will be easier to patch one header at a time. Apology for any inconvenience. ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/l

Re: [Mingw-w64-public] [PATCH] headers: memoryapi add Windows 10 functions

2020-04-04 Thread Martin Storsjö
On Thu, 2 Apr 2020, Biswapriyo Nath wrote: ... Did you actually test this at all, in any way, whatsoever? Because the newly added function declarations use the types MEM_EXTENDED_PARAMETER and PCFG_CALL_TARGET_INFO, that aren't declared anywhere in mingw-w64 headers. This breaks building

Re: [Mingw-w64-public] [PATCH] headers: memoryapi add Windows 10 functions

2020-04-03 Thread Liu Hao
在 2020/4/3 1:40, Biswapriyo Nath 写道: > Updated. > > Thanks. I pushed this patch. -- Best regards, LH_Mouse signature.asc Description: OpenPGP digital signature ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists

Re: [Mingw-w64-public] [PATCH] headers: memoryapi add Windows 10 functions

2020-04-02 Thread Biswapriyo Nath
Updated. From 811619f2d0e4179afbd66fcedaabb3f52f0664a7 Mon Sep 17 00:00:00 2001 From: Biswapriyo Nath Date: Thu, 2 Apr 2020 21:32:23 +0530 Subject: [PATCH] headers: memoryapi add Windows 10 functions replace _WIN32_WINNT constant values with its defined names Signed-off-by: Biswapriyo Nath ---

Re: [Mingw-w64-public] [PATCH] headers: memoryapi add Windows 10 functions

2020-04-02 Thread Liu Hao
在 2020/4/3 0:05, Biswapriyo Nath 写道: > ... > > > + WINBASEAPI HANDLE WINAPI OpenFileMappingFromApp(ULONG DesiredAccess, BOOL > InheritHandle, PCWSTR Name); Would it be better to have `WINBOOL` in place of this `BOOL`? -- Best regards, LH_Mouse signature.asc Description: OpenPGP digital s

[Mingw-w64-public] [PATCH] headers: memoryapi add Windows 10 functions

2020-04-02 Thread Biswapriyo Nath
... From 811619f2d0e4179afbd66fcedaabb3f52f0664a7 Mon Sep 17 00:00:00 2001 From: Biswapriyo Nath Date: Thu, 2 Apr 2020 21:32:23 +0530 Subject: [PATCH] headers: memoryapi add Windows 10 functions replace _WIN32_WINNT constant values with its defined names Signed-off-by: Biswapriyo Nath --- ming