Re: [Mingw-w64-public] [PATCH] headers: Add missing marco in synchapi.h

2022-11-19 Thread LIU Hao
在 2022-11-19 03:14, Biswapriyo Nath 写道: I think there should not be any #if condition to mimic the behavior of WinSDK. As _NT_TARGET_VERSION_WIN10_RS4 is not defined, CREATE_WAITABLE_TIMER_HIGH_RESOLUTION exists for all Windows versions. Yeah this is also fair enough. Thanks for the patch. Push

Re: [Mingw-w64-public] [PATCH] headers: Add missing marco in synchapi.h

2022-11-18 Thread Biswapriyo Nath
I think there should not be any #if condition to mimic the behavior of WinSDK. As _NT_TARGET_VERSION_WIN10_RS4 is not defined, CREATE_WAITABLE_TIMER_HIGH_RESOLUTION exists for all Windows versions. ___ Mingw-w64-public mailing list Mingw-w64-public@list

Re: [Mingw-w64-public] [PATCH] headers: Add missing marco in synchapi.h

2022-11-17 Thread LIU Hao
在 2022/11/17 01:44, Biswapriyo Nath 写道: WInSDK checks for _NT_TARGET_VERSION_WIN10_RS4 but it is not defined or used anywhere. So, I think removing that cpp check would not harm the use cases. Tested with pywin32 project. It's because undefined macros are implicit zeroes in an #if condition.

[Mingw-w64-public] [PATCH] headers: Add missing marco in synchapi.h

2022-11-16 Thread Biswapriyo Nath
WInSDK checks for _NT_TARGET_VERSION_WIN10_RS4 but it is not defined or used anywhere. So, I think removing that cpp check would not harm the use cases. Tested with pywin32 project. From 55ce5c0e8bad90b11181e26a5d992d0cceff2913 Mon Sep 17 00:00:00 2001 From: Biswapriyo Nath Date: Wed, 16 Nov 2022