Re: [Mingw-w64-public] [PATCH] crt: Use importlibs for more time functions.

2019-04-08 Thread Liu Hao
在 2019/4/8 下午7:18, Jacek Caban 写道: > > Sure, but what does it have to do with __forceinline? __forceinline is > for functions that are really meant to be inlined and thus I think it > should not try to preserve single pointer value. With removed extern, we > leave the choice for user, one could st

Re: [Mingw-w64-public] [PATCH] crt: Use importlibs for more time functions.

2019-04-08 Thread Jacek Caban
On 4/5/19 3:43 PM, Martin Storsjö wrote: How about doing things in msvc ucrt compatible way? Like the patch I attached as an example (not yet tested)? This looks good to me (but didn't test it yet). This approach of modernizing small areas at a time seems good also, wrt finding out what regre

Re: [Mingw-w64-public] [PATCH] crt: Use importlibs for more time functions.

2019-04-08 Thread Jacek Caban
On 4/8/19 4:33 AM, Liu Hao wrote: 在 2019/4/5 下午8:07, Jacek Caban 写道: On 4/5/19 9:15 AM, Martin Storsjö wrote: It would be great to have __forceinline fixed. I've seen a problems in code using static __forceinline multiple times. I also recall that attempts to change that had their problems, so

Re: [Mingw-w64-public] [PATCH] crt: Use importlibs for more time functions.

2019-04-07 Thread Liu Hao
在 2019/4/5 下午8:07, Jacek Caban 写道: > On 4/5/19 9:15 AM, Martin Storsjö wrote: > > It would be great to have __forceinline fixed. I've seen a problems in > code using static __forceinline multiple times. I also recall that > attempts to change that had their problems, so it's more tricky than it >

Re: [Mingw-w64-public] [PATCH] crt: Use importlibs for more time functions.

2019-04-05 Thread Martin Storsjö
On Fri, 5 Apr 2019, Jacek Caban wrote: On 4/5/19 9:15 AM, Martin Storsjö wrote: On Thu, 4 Apr 2019, Jacek Caban wrote: On 4/4/19 3:07 PM, Martin Storsjö wrote: On Thu, 4 Apr 2019, Jacek Caban wrote: Signed-off-by: Jacek Caban --- mingw-w64-crt/Makefile.am  |  2 +- mingw-w64-cr

Re: [Mingw-w64-public] [PATCH] crt: Use importlibs for more time functions.

2019-04-05 Thread Jacek Caban
On 4/5/19 9:15 AM, Martin Storsjö wrote: On Thu, 4 Apr 2019, Jacek Caban wrote: On 4/4/19 3:07 PM, Martin Storsjö wrote: On Thu, 4 Apr 2019, Jacek Caban wrote: Signed-off-by: Jacek Caban --- mingw-w64-crt/Makefile.am  |  2 +- mingw-w64-crt/lib-common/msvcrt.def.in |  4 +- mingw-

Re: [Mingw-w64-public] [PATCH] crt: Use importlibs for more time functions.

2019-04-05 Thread Martin Storsjö
On Thu, 4 Apr 2019, Jacek Caban wrote: On 4/4/19 3:07 PM, Martin Storsjö wrote: On Thu, 4 Apr 2019, Jacek Caban wrote: Signed-off-by: Jacek Caban --- mingw-w64-crt/Makefile.am  |  2 +- mingw-w64-crt/lib-common/msvcrt.def.in |  4 +- mingw-w64-crt/lib32/msvcr100.def.in    |  4 +- m

Re: [Mingw-w64-public] [PATCH] crt: Use importlibs for more time functions.

2019-04-04 Thread Jacek Caban
On 4/4/19 3:07 PM, Martin Storsjö wrote: On Thu, 4 Apr 2019, Jacek Caban wrote: Signed-off-by: Jacek Caban --- mingw-w64-crt/Makefile.am  |  2 +- mingw-w64-crt/lib-common/msvcrt.def.in |  4 +- mingw-w64-crt/lib32/msvcr100.def.in    |  4 +- mingw-w64-crt/lib32/msvcr80.def.in | 

Re: [Mingw-w64-public] [PATCH] crt: Use importlibs for more time functions.

2019-04-04 Thread Martin Storsjö
On Thu, 4 Apr 2019, Jacek Caban wrote: Signed-off-by: Jacek Caban --- mingw-w64-crt/Makefile.am | 2 +- mingw-w64-crt/lib-common/msvcrt.def.in | 4 +- mingw-w64-crt/lib32/msvcr100.def.in| 4 +- mingw-w64-crt/lib32/msvcr80.def.in | 2 + mingw-w64-crt/lib32/msvcr90.def.in

[Mingw-w64-public] [PATCH] crt: Use importlibs for more time functions.

2019-04-04 Thread Jacek Caban
Signed-off-by: Jacek Caban --- mingw-w64-crt/Makefile.am | 2 +- mingw-w64-crt/lib-common/msvcrt.def.in | 4 +- mingw-w64-crt/lib32/msvcr100.def.in| 4 +- mingw-w64-crt/lib32/msvcr80.def.in | 2 + mingw-w64-crt/lib32/msvcr90.def.in | 4 +- mingw-w64-crt/lib64/msvcr1