Re: [Mingw-w64-public] [PATCH] crt: Fix v*scanf functions

2022-02-06 Thread Pali Rohár
On Wednesday 26 January 2022 14:45:58 LIU Hao wrote: > 在 1/26/22 04:05, Pali Rohár 写道: > > > > Yes, this is truth. However amd64 asm code already reads more pointers > > from stack (when number of them is smaller then number of arguments > > needed to pass via registers when doing function call),

Re: [Mingw-w64-public] [PATCH] crt: Fix v*scanf functions

2022-01-25 Thread LIU Hao
在 1/26/22 04:05, Pali Rohár 写道: Yes, this is truth. However amd64 asm code already reads more pointers from stack (when number of them is smaller then number of arguments needed to pass via registers when doing function call), so I think that this function can be documented that returns "minimal

Re: [Mingw-w64-public] [PATCH] crt: Fix v*scanf functions

2022-01-25 Thread Pali Rohár
On Wednesday 26 January 2022 00:23:49 LIU Hao wrote: > 在 2022-01-16 22:44, Pali Rohár 写道: > > diff --git a/mingw-w64-crt/stdio/scanf2-argcount-template.c > > b/mingw-w64-crt/stdio/scanf2-argcount-template.c > > new file mode 100644 > > index ..c07e11797c39 > > --- /dev/null > > +++ b/m

Re: [Mingw-w64-public] [PATCH] crt: Fix v*scanf functions

2022-01-25 Thread LIU Hao
在 2022-01-16 22:44, Pali Rohár 写道: diff --git a/mingw-w64-crt/stdio/scanf2-argcount-template.c b/mingw-w64-crt/stdio/scanf2-argcount-template.c new file mode 100644 index ..c07e11797c39 --- /dev/null +++ b/mingw-w64-crt/stdio/scanf2-argcount-template.c @@ -0,0 +1,22 @@ +/** + * This

Re: [Mingw-w64-public] [PATCH] crt: Fix v*scanf functions

2022-01-25 Thread Pali Rohár
On Monday 24 January 2022 13:41:27 Martin Storsjö wrote: > On Sun, 16 Jan 2022, Pali Rohár wrote: > > > Currently v*scanf functions are broken and crash when are called with more > > than 30 arguments in va_list. This is because va_list v*scanf functions are > > redirected to variadic *scanf funct

Re: [Mingw-w64-public] [PATCH] crt: Fix v*scanf functions

2022-01-24 Thread Martin Storsjö
On Sun, 16 Jan 2022, Pali Rohár wrote: Currently v*scanf functions are broken and crash when are called with more than 30 arguments in va_list. This is because va_list v*scanf functions are redirected to variadic *scanf functions and this redirect implemented in scanf.S file has fixed limit for

[Mingw-w64-public] [PATCH] crt: Fix v*scanf functions

2022-01-16 Thread Pali Rohár
Currently v*scanf functions are broken and crash when are called with more than 30 arguments in va_list. This is because va_list v*scanf functions are redirected to variadic *scanf functions and this redirect implemented in scanf.S file has fixed limit for 30 arguments. Number of arguments for msv