Re: [Mingw-w64-public] [PATCH] crt: Add symbols for POSIX time functions and find{first, next} functions

2021-04-06 Thread Liu Hao
在 2021/4/6 下午10:04, Martin Storsjö 写道: (I guess it's not entirely unconditional - the user can still set the _USE_32BIT_TIME_T - but that's a technicality.) Yeah I was thinking about phrases such as 'both default' but mistook 'unconditional'... Anyway this word doesn't appear in the commit

Re: [Mingw-w64-public] [PATCH] crt: Add symbols for POSIX time functions and find{first, next} functions

2021-04-06 Thread Martin Storsjö
On Tue, 6 Apr 2021, Liu Hao wrote: 在 2021-03-31 21:45, Liu Hao 写道: Side note: This patch is not meant to address the issue about default size of `time_t`, due to possibility of ABI break. And here is the second patch that makes `time_t` unconditionally 64-bit for UCRT. (I guess it's not

Re: [Mingw-w64-public] [PATCH] crt: Add symbols for POSIX time functions and find{first, next} functions

2021-04-06 Thread Liu Hao
在 2021-03-31 21:45, Liu Hao 写道: Side note: This patch is not meant to address the issue about default size of `time_t`, due to possibility of ABI break. And here is the second patch that makes `time_t` unconditionally 64-bit for UCRT. -- Best regards, Liu Hao From 00e93ac9d535f4f7e285e706b

Re: [Mingw-w64-public] [PATCH] crt: Add symbols for POSIX time functions

2021-03-31 Thread Jacek Caban
On 31.03.2021 15:12, Martin Storsjö wrote: On Wed, 31 Mar 2021, Liu Hao wrote: 在 2021/3/31 下午7:46, Martin Storsjö 写道: Hmm, if MSVC defaults to a 64 bit time_t in 32 bit mode these days, I think we should too, for UCRT. (Technically I guess it's an ABI break, but I'd be quite comfortable doi

[Mingw-w64-public] [PATCH] crt: Add symbols for POSIX time functions and find{first, next} functions

2021-03-31 Thread Liu Hao
Side note: This patch is not meant to address the issue about default size of `time_t`, due to possibility of ABI break. -- Best regards, Liu Hao From 6ffd67853efba37f7bdd1664e99dd26d3a6da5c1 Mon Sep 17 00:00:00 2001 From: Liu Hao Date: Tue, 30 Mar 2021 22:19:33 +0800 Subject: [PATCH] crt: Add

Re: [Mingw-w64-public] [PATCH] crt: Add symbols for POSIX time functions

2021-03-31 Thread Martin Storsjö
On Wed, 31 Mar 2021, Liu Hao wrote: 在 2021/3/31 下午7:46, Martin Storsjö 写道: Hmm, if MSVC defaults to a 64 bit time_t in 32 bit mode these days, I think we should too, for UCRT. (Technically I guess it's an ABI break, but I'd be quite comfortable doing it, while I'd be less comfortable changin

Re: [Mingw-w64-public] [PATCH] crt: Add symbols for POSIX time functions

2021-03-31 Thread Liu Hao
在 2021/3/31 下午7:46, Martin Storsjö 写道: Hmm, if MSVC defaults to a 64 bit time_t in 32 bit mode these days, I think we should too, for UCRT. (Technically I guess it's an ABI break, but I'd be quite comfortable doing it, while I'd be less comfortable changing any defaults for msvcrt.dll targets.

Re: [Mingw-w64-public] [PATCH] crt: Add symbols for POSIX time functions

2021-03-31 Thread Martin Storsjö
On Wed, 31 Mar 2021, Liu Hao wrote: 在 2021/3/30 下午11:26, Martin Storsjö 写道: On Tue, 30 Mar 2021, Liu Hao wrote: The patch looks sensible to me (and good that you added a comment!). For 32 bit mode, I'd say default to whatever the headers default to. However, please add the corresponding ali

Re: [Mingw-w64-public] [PATCH] crt: Add symbols for POSIX time functions

2021-03-30 Thread Liu Hao
在 2021/3/30 下午11:26, Martin Storsjö 写道: On Tue, 30 Mar 2021, Liu Hao wrote: The patch looks sensible to me (and good that you added a comment!). For 32 bit mode, I'd say default to whatever the headers default to. However, please add the corresponding aliases to api-ms-win-crt*.def too; the s

Re: [Mingw-w64-public] [PATCH] crt: Add symbols for POSIX time functions

2021-03-30 Thread Martin Storsjö
On Tue, 30 Mar 2021, Liu Hao wrote: 在 2021-03-30 01:45, Jeremy Drake via Mingw-w64-public 写道: Which is why I don't know that mingw-w64 is wrong here, it is doing exactly what MS says. However, it could provide aliases in ucrtbase.def.in for the 'base' functions to make configure happy. I

[Mingw-w64-public] [PATCH] crt: Add symbols for POSIX time functions

2021-03-30 Thread Liu Hao
在 2021-03-30 01:45, Jeremy Drake via Mingw-w64-public 写道: Which is why I don't know that mingw-w64 is wrong here, it is doing exactly what MS says. However, it could provide aliases in ucrtbase.def.in for the 'base' functions to make configure happy. It appears that other time functions are al