Re: [Mingw-w64-public] [PATCH] VirtualProtect problem in pseudo-reloc.c

2017-07-11 Thread Liu Hao
On 2017/7/10 22:34, Kai Tietz via Mingw-w64-public wrote: Hi, yes, the patch looks fine to me. Your changes looking fine to me. Nevertheless we should just put this code change just in master, as we need to let people test new code. Please go ahead and commit to master. Thanks, Kai Done. --

Re: [Mingw-w64-public] [PATCH] VirtualProtect problem in pseudo-reloc.c

2017-07-10 Thread Kai Tietz via Mingw-w64-public
Hi, yes, the patch looks fine to me. Your changes looking fine to me. Nevertheless we should just put this code change just in master, as we need to let people test new code. Please go ahead and commit to master. Thanks, Kai 2017-07-09 21:25 GMT+02:00 Arthur D. Edelstein : > Turns out I could r

Re: [Mingw-w64-public] [PATCH] VirtualProtect problem in pseudo-reloc.c

2017-07-09 Thread Arthur D. Edelstein
Turns out I could remove one more line, because a local variable becomes unused. Here is a revised patch. On Sat, Jul 8, 2017 at 11:18 PM, Arthur D. Edelstein wrote: > It seems my patch attachment was maybe blocked. Here it is again with > a .txt extension. > > On Sat, Jul 8, 2017 at 11:06 PM, Ar

Re: [Mingw-w64-public] [PATCH] VirtualProtect problem in pseudo-reloc.c

2017-07-09 Thread Liu Hao
On 2017/7/9 14:06, Arthur D. Edelstein wrote: Hi, I am proposing a patch here to deal with a problem found in a cross-compiled Tor Browser and Tor Expert Bundle. Using VMMap on Windows, we observed Execute/Read/Write (XRW) and Execute/Copy-on-Write pages (X/COW) in some DLLs and the Tor executabl

Re: [Mingw-w64-public] [PATCH] VirtualProtect problem in pseudo-reloc.c

2017-07-08 Thread Arthur D. Edelstein
It seems my patch attachment was maybe blocked. Here it is again with a .txt extension. On Sat, Jul 8, 2017 at 11:06 PM, Arthur D. Edelstein wrote: > Hi, I am proposing a patch here to deal with a problem found in a > cross-compiled Tor Browser and Tor Expert Bundle. Using VMMap on > Windows, we

[Mingw-w64-public] [PATCH] VirtualProtect problem in pseudo-reloc.c

2017-07-08 Thread Arthur D. Edelstein
Hi, I am proposing a patch here to deal with a problem found in a cross-compiled Tor Browser and Tor Expert Bundle. Using VMMap on Windows, we observed Execute/Read/Write (XRW) and Execute/Copy-on-Write pages (X/COW) in some DLLs and the Tor executable, even though the .text sections for these bina