Re: [Mingw-w64-public] [PATCH] Fix bug in __stosb - Part2

2013-05-23 Thread Rafaël Carré
Le 23/05/2013 10:04, Kai Tietz a écrit : > 2013/5/23 dw : >> Attached is part 2 of the __stosb patch. It takes the changes part 1 made >> to winnt.h and applies them to the identical code in the crt. >> >> Specifically: >> >> 1) The __buildstos macro has been removed from winnt.h >> 2) __buildstos

Re: [Mingw-w64-public] [PATCH] Fix bug in __stosb - Part2

2013-05-23 Thread Kai Tietz
2013/5/23 dw : > Attached is part 2 of the __stosb patch. It takes the changes part 1 made > to winnt.h and applies them to the identical code in the crt. > > Specifically: > > 1) The __buildstos macro has been removed from winnt.h > 2) __buildstos has been put in the new file > mingw-w64-headers/

[Mingw-w64-public] [PATCH] Fix bug in __stosb - Part2

2013-05-22 Thread dw
Attached is part 2 of the __stosb patch. It takes the changes part 1 made to winnt.h and applies them to the identical code in the crt. Specifically: 1) The __buildstos macro has been removed from winnt.h 2) __buildstos has been put in the new file mingw-w64-headers/include/psdk_inc/intrin-ma

Re: [Mingw-w64-public] [PATCH] Fix bug in __stosb

2013-05-19 Thread Rafaël Carré
Le 19/05/2013 21:53, Kai Tietz a écrit : > thanks for the patch. please apply. > > Kai > Am 19.05.2013 21:44 schrieb "dw" : Committed as r5867 -- AlienVault Unified Security Management (USM) platform delivers complete se

Re: [Mingw-w64-public] [PATCH] Fix bug in __stosb

2013-05-19 Thread Kai Tietz
thanks for the patch. please apply. Kai Am 19.05.2013 21:44 schrieb "dw" : > > > "memory" clobber is missing (I agree that this is not obvious!) > Sorry, it's my first 'patch' post and I wasn't sure what was appropriate > to include. Didn't want the thing to be too cluttered. > > There are actua

Re: [Mingw-w64-public] [PATCH] Fix bug in __stosb

2013-05-19 Thread dw
> "memory" clobber is missing (I agree that this is not obvious!) Sorry, it's my first 'patch' post and I wasn't sure what was appropriate to include. Didn't want the thing to be too cluttered. There are actually 4 things changed: 1) The memory clobber. This is the key change. There is an no

Re: [Mingw-w64-public] [PATCH] Fix bug in __stosb

2013-05-19 Thread Rafaël Carré
Le 19/05/2013 08:55, Václav Zeman a écrit : > On 19 May 2013 05:17, dw wrote: >> There is a bug in __stosb (as well as the other __stos* functions), as >> illustrated by this code (compile with -Os for 64bit): >> >> #include >> #include >> >> #ifndef _AMD64_ >> #error Must be compiled for 64 bit

Re: [Mingw-w64-public] [PATCH] Fix bug in __stosb

2013-05-18 Thread Václav Zeman
On 19 May 2013 05:17, dw wrote: > There is a bug in __stosb (as well as the other __stos* functions), as > illustrated by this code (compile with -Os for 64bit): > > #include > #include > > #ifndef _AMD64_ > #error Must be compiled for 64 bit > #endif > > int main(int argc, char* argv[]) > { >

[Mingw-w64-public] [PATCH] Fix bug in __stosb

2013-05-18 Thread dw
There is a bug in __stosb (as well as the other __stos* functions), as illustrated by this code (compile with -Os for 64bit): #include #include #ifndef _AMD64_ #error Must be compiled for 64 bit #endif int main(int argc, char* argv[]) { struct { int a; int b; } c; c.a = 1;