Re: [Mingw-w64-public] [PATCH] Don't use __stdcall on ARM

2014-05-07 Thread Kai Tietz
2014-05-07 14:11 GMT+02:00 Corinna Vinschen : > On May 7 00:59, Kai Tietz wrote: >> Yes, magic wording here is that compiler accepts it and ignores it. >> So it means not in headers. > > Sorry, but I don't get this. So per MSDN, x64 and ARM are identical > with respect to __stdcall. > > If so, wh

Re: [Mingw-w64-public] [PATCH] Don't use __stdcall on ARM

2014-05-07 Thread Corinna Vinschen
On May 7 00:59, Kai Tietz wrote: > Yes, magic wording here is that compiler accepts it and ignores it. > So it means not in headers. Sorry, but I don't get this. So per MSDN, x64 and ARM are identical with respect to __stdcall. If so, why is it the right thing to #define __stdcall for x64, b

Re: [Mingw-w64-public] [PATCH] Don't use __stdcall on ARM

2014-05-06 Thread Kai Tietz
Yes, magic wording here is that compiler accepts it and ignores it. So it means not in headers. Cheers Kai Am 07.05.2014 00:51 schrieb "Yaakov (Cygwin/X)" < yselkow...@users.sourceforge.net>: > On 2014-05-06 16:37, Kai Tietz wrote: > > 2014-05-06 21:15 GMT+02:00 André Hentschel: > >> Am 06.05.201

Re: [Mingw-w64-public] [PATCH] Don't use __stdcall on ARM

2014-05-06 Thread Yaakov (Cygwin/X)
On 2014-05-06 16:37, Kai Tietz wrote: > 2014-05-06 21:15 GMT+02:00 André Hentschel: >> Am 06.05.2014 21:01, schrieb Yaakov (Cygwin/X): >>> On 2014-05-05 16:32, André Hentschel wrote: Am 05.05.2014 23:29, schrieb André Hentschel: > Please review, i'll commit it. Again the right pa

Re: [Mingw-w64-public] [PATCH] Don't use __stdcall on ARM

2014-05-06 Thread Kai Tietz
2014-05-06 21:15 GMT+02:00 André Hentschel : > Am 06.05.2014 21:01, schrieb Yaakov (Cygwin/X): >> On 2014-05-05 16:32, André Hentschel wrote: >>> Am 05.05.2014 23:29, schrieb André Hentschel: Please review, i'll commit it. >>> >>> Again the right patch attached now, it's getting late, sorry. >

Re: [Mingw-w64-public] [PATCH] Don't use __stdcall on ARM

2014-05-06 Thread André Hentschel
Am 06.05.2014 21:01, schrieb Yaakov (Cygwin/X): > On 2014-05-05 16:32, André Hentschel wrote: >> Am 05.05.2014 23:29, schrieb André Hentschel: >>> Please review, i'll commit it. >> >> Again the right patch attached now, it's getting late, sorry. > > Since stdcall isn't used on x64 either, wouldn't

Re: [Mingw-w64-public] [PATCH] Don't use __stdcall on ARM

2014-05-06 Thread Yaakov (Cygwin/X)
On 2014-05-05 16:32, André Hentschel wrote: > Am 05.05.2014 23:29, schrieb André Hentschel: >> Please review, i'll commit it. > > Again the right patch attached now, it's getting late, sorry. Since stdcall isn't used on x64 either, wouldn't it make more sense to just do the following in _mingw.h:

Re: [Mingw-w64-public] [PATCH] Don't use __stdcall on ARM

2014-05-05 Thread Kai Tietz
Patch is ok for apply. Thanks, Kai -- Is your legacy SCM system holding you back? Join Perforce May 7 to find out: • 3 signs your SCM is hindering your productivity • Requirements for releasing software faster • Expert ti

Re: [Mingw-w64-public] [PATCH] Don't use __stdcall on ARM

2014-05-05 Thread André Hentschel
Am 05.05.2014 23:29, schrieb André Hentschel: > Please review, i'll commit it. Again the right patch attached now, it's getting late, sorry. Index: ddk/include/ddk/usbbusif.h === --- ddk/include/ddk/usbbusif.h (Revision 6609) +++ ddk

[Mingw-w64-public] [PATCH] Don't use __stdcall on ARM

2014-05-05 Thread André Hentschel
Please review, i'll commit it. Index: mingw-w64-headers/include/winnt.h === --- mingw-w64-headers/include/winnt.h (Revision 6596) +++ mingw-w64-headers/include/winnt.h (Arbeitskopie) @@ -32,6 +32,13 @@ #endif #endif /* _AMD64_ */