Re: [Mingw-w64-public] [PATCH] Copy getpid declaration in process.h to unistd.h

2014-11-07 Thread Dongsheng Song
On Fri, Nov 7, 2014 at 9:48 PM, Ruben Van Boxem wrote: > 2014-11-07 14:45 GMT+01:00 Dongsheng Song : >> >> On Fri, Nov 7, 2014 at 4:44 PM, lh_mouse wrote: >> > Minor suggestion: use the word `DECLARED` instead `DEFINED` please. >> > >> >> I don't known which is better:-) >> Here is some stats: >>

Re: [Mingw-w64-public] [PATCH] Copy getpid declaration in process.h to unistd.h

2014-11-07 Thread Ruben Van Boxem
2014-11-07 14:45 GMT+01:00 Dongsheng Song : > On Fri, Nov 7, 2014 at 4:44 PM, lh_mouse wrote: > > Minor suggestion: use the word `DECLARED` instead `DEFINED` please. > > > > I don't known which is better:-) > Here is some stats: > > $ grep -r "_DEFINED[^A-Z0-9]" . | wc -l > 26145 > > $ grep -r "_

Re: [Mingw-w64-public] [PATCH] Copy getpid declaration in process.h to unistd.h

2014-11-07 Thread Dongsheng Song
On Fri, Nov 7, 2014 at 4:44 PM, lh_mouse wrote: > Minor suggestion: use the word `DECLARED` instead `DEFINED` please. > I don't known which is better:-) Here is some stats: $ grep -r "_DEFINED[^A-Z0-9]" . | wc -l 26145 $ grep -r "_DECLARED[^A-Z0-9]" . | wc -l 15 ---

Re: [Mingw-w64-public] [PATCH] Copy getpid declaration in process.h to unistd.h

2014-11-07 Thread lh_mouse
] [PATCH] Copy getpid declaration in process.h to unistd.h OK for apply ? --- mingw-w64-headers/crt/process.h | 3 +++ mingw-w64-headers/crt/unistd.h | 5 + 2 files changed, 8 insertions(+) diff --git a/mingw-w64-headers/crt/process.h b/mingw-w64-headers/crt/process.h index f43befb

Re: [Mingw-w64-public] [PATCH] Copy getpid declaration in process.h to unistd.h

2014-11-07 Thread Kai Tietz
Hi, 2014-11-07 9:01 GMT+01:00 Dongsheng Song : > OK for apply ? Patch is ok. Thanks, Kai -- ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://li

[Mingw-w64-public] [PATCH] Copy getpid declaration in process.h to unistd.h

2014-11-07 Thread Dongsheng Song
OK for apply ? --- mingw-w64-headers/crt/process.h | 3 +++ mingw-w64-headers/crt/unistd.h | 5 + 2 files changed, 8 insertions(+) diff --git a/mingw-w64-headers/crt/process.h b/mingw-w64-headers/crt/process.h index f43befb..5f635c8 100644 --- a/mingw-w64-headers/crt/process.h +++ b/mingw-w