Re: [Mingw-w64-public] [PATCH] ctime inline wrapper is also needed for msvcrt 0x1200

2019-03-08 Thread Johannes Pfau
Am 08.03.19 um 22:27 schrieb Johannes Pfau: Am 07.03.19 um 15:48 schrieb Liu Hao: 在 2019/3/7 17:45, Jacek Caban 写道: Note that when doing 32-bit builds, _USE_32BIT_TIME_T will be most likely defined so this code path will not be used. Currently (although it might be improved in the future

[Mingw-w64-public] [PATCH] ctime inline wrapper is also needed for msvcrt 0x1200

2019-03-03 Thread Johannes Pfau
When building GCC for msvcrt120, there's a undefined reference to ctime. It needs to be defined as a wrapper for msvcrt120 as well. The if condition is slightly complex, but I do not know if I can modify the if !defined(__CRT__NO_INLINE) || __MSVCRT_VERSION__ >= 0x1400 block instead: This would als

[Mingw-w64-public] [PATCH] Also provide _utime32 inline definition for 32 bit systems

2019-03-03 Thread Johannes Pfau
When bootstrapping GCC with msvcrt120 for 32 bit windows, the build fails as _utime is missing. Define in the same way as for 64 bit systems. Best regards, Johannes --- mingw-w64-headers/crt/sys/utime.h | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/mingw-w64-he

Re: [Mingw-w64-public] [PATCH] GCC: Introduce xaccess function in libiberty

2019-01-05 Thread Johannes Pfau
Am 05.01.19 um 18:56 schrieb Mateusz: ucrtbase.dll is affected too (msvcr100 works OK), so maybe it is better to add your access() function to msvcr110/120 and ucrtbase (as a replacement) instead of patching GCC. Regards, Mateusz Maybe it would make sense to add this in crt/io.h? There's alr

[Mingw-w64-public] [PATCH] GCC: Introduce xaccess function in libiberty

2019-01-05 Thread Johannes Pfau
Liu Hao: > There are a few resolution to this at different levels. The most ideal > solution would be providing an `access()` function that behaves > expectedly in gnulib or libiberty, so this recipe can be ported > elsewhere. Modifying GCC source should be considered the least preferred > and last

Re: [Mingw-w64-public] [RFC/PATCH] gcc.c: access does not work in new msvcr for nul file

2019-01-04 Thread Johannes Pfau
Am 04.01.19 um 15:08 schrieb Liu Hao: 在 2019/1/4 21:14, Johannes Pfau 写道: When building GCC against msvcr120, I found another problem. The build fails here: (... snip ...) This prints 0 with msvcrt, -1 with msvcr120 (tested using a spec file & setting -D__MSVCRT_VERSION__=0x1200). GCC

Re: [Mingw-w64-public] [RFC/PATCH] gcc.c: access does not work in new msvcr for nul file

2019-01-04 Thread Johannes Pfau
've send a RFC to the gcc-patches list with a patch to use GetFileAttributes on windows instead, but I've been told to first ask here for advice. Best regards, Johannes Am 03.01.19 um 13:34 schrieb Alexander Monakov: On Thu, 3 Jan 2019, Johannes Pfau wrote: Debugging shows that the

Re: [Mingw-w64-public] [PATCH] Add _ftime aliases for all msvcr versions

2019-01-03 Thread Johannes Pfau
Am 03.01.19 um 07:46 schrieb Liu Hao: 在 2019/1/3 3:27, Johannes Pfau 写道: Am 02.01.19 um 18:02 schrieb Mateusz: W dniu 02.01.2019 o 14:10, Johannes Pfau pisze: BTW: How do you handle branches for the patches? The attached patch is against the v6.x branch. I didn't read this, sorry for

Re: [Mingw-w64-public] [PATCH] Add _ftime aliases for all msvcr versions

2019-01-02 Thread Johannes Pfau
Am 02.01.19 um 18:02 schrieb Mateusz: W dniu 02.01.2019 o 14:10, Johannes Pfau pisze: BTW: How do you handle branches for the patches? The attached patch is against the v6.x branch. I didn't read this, sorry for noise in previous mail. The problem was solved in master branch by

[Mingw-w64-public] [PATCH] Add _ftime aliases for all msvcr versions

2019-01-02 Thread Johannes Pfau
nch. Best regards, Johannes Signed-off-by: Johannes Pfau --- mingw-w64-crt/lib32/msvcr100.def.in | 1 + mingw-w64-crt/lib32/msvcr110.def.in | 1 + mingw-w64-crt/lib32/msvcr120.def.in | 1 + mingw-w64-crt/lib32/msvcr120_app.def.in | 1 + mingw-w64-crt/lib32/msvcr120d