Re: [Mingw-w64-public] [PATCH] headers/wintrust: Add forward declarations for structs

2025-07-19 Thread Jacek Caban via Mingw-w64-public
On 19.07.2025 15:47, LIU Hao wrote: +  struct _CRYPT_PROVIDER_DATA; +  struct _CRYPT_PROVIDER_SGNR; +  struct _CRYPT_PROVIDER_PRIVDATA; +  struct _CRYPT_PROVIDER_DEFUSAGE; We could also reorder declarations to define those structs earlier, but the patch looks fine to me too. Thanks, Jace

Re: [Mingw-w64-public] widl build error on Cygwin

2025-07-12 Thread Jacek Caban via Mingw-w64-public
On 15.06.2025 19:36, Jeremy Drake via Mingw-w64-public wrote: I just tried to build llvm-mingw on Cygwin, as part of testing builds of llvm/clang/lld on Cygwin, and got a new error building widl: In file included from /usr/include/limits.h:13, from /usr/lib/gcc/x86_64-pc-cygwin

Re: [Mingw-w64-public] Deduplicate lib32 and lib-common def files

2025-05-26 Thread Jacek Caban via Mingw-w64-public
On 26.05.2025 06:54, LIU Hao wrote: 在 2025-5-26 02:58, Martin Storsjö 写道: On Sun, 25 May 2025, Jacek Caban wrote: I think that kind of massive duplication just doesn't scale. For example, when adding a new target like ARM64EC, are you suggesting we duplicate all the .def files for a fifth tim

Re: [Mingw-w64-public] [PATCH] headers: Don't mark RtlUnwind functions as noreturn*

2025-05-25 Thread Jacek Caban via Mingw-w64-public
On 25.05.2025 18:10, Martin Storsjö wrote: On Sun, 25 May 2025, Jacek Caban via Mingw-w64-public wrote: This reverts commit 8c2c00ef898f36d51613b45c2cab4f4448d35f0b. These functions can unwind to the current frame, in which case they effectively return. Therefore, they should not be marked

Re: [Mingw-w64-public] Deduplicate lib32 and lib-common def files

2025-05-25 Thread Jacek Caban via Mingw-w64-public
On 24.05.2025 12:25, LIU Hao wrote: 在 2025-5-24 18:12, Pali Rohár 写道: And it deduplicated 496 def files. What do you think about it? Just a robotic change and can decrease number of def files which needs to be maintained. I don't have a specific opinion on this change. Frankly speaking, I am

Re: [Mingw-w64-public] [PATCH] headers: Don't mark RtlUnwind functions as noreturn*

2025-05-25 Thread Jacek Caban via Mingw-w64-public
'*' in the commit message is a typo, I will remove it. Jacek ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public

[Mingw-w64-public] [PATCH] headers: Don't mark RtlUnwind functions as noreturn*

2025-05-25 Thread Jacek Caban via Mingw-w64-public
This reverts commit 8c2c00ef898f36d51613b45c2cab4f4448d35f0b. These functions can unwind to the current frame, in which case they effectively return. Therefore, they should not be marked as noreturn. Use __builtin_unreachable in the ARM64EC longjmp implementation instead. Fixes https://gitlab.w

Re: [Mingw-w64-public] [PATCH 1/2] crt: Introduce F_ARM_NATIVE

2025-05-24 Thread Jacek Caban via Mingw-w64-public
On 23.05.2025 19:12, Martin Storsjö wrote: On Fri, 23 May 2025, Jacek Caban via Mingw-w64-public wrote: And use it for exports not available on ARM64EC. --- mingw-w64-crt/def-include/func.def.in    | 9 ++--- .../lib-common/api-ms-win-crt-math-l1-1-0.def.in | 2

[Mingw-w64-public] [PATCH 2/2] crt: Use fabsf.c in ARM64EC CRT importlibs

2025-05-23 Thread Jacek Caban via Mingw-w64-public
--- mingw-w64-crt/Makefile.am | 5 + 1 file changed, 5 insertions(+) diff --git a/mingw-w64-crt/Makefile.am b/mingw-w64-crt/Makefile.am index e5ca242db..e08173d9f 100644 --- a/mingw-w64-crt/Makefile.am +++ b/mingw-w64-crt/Makefile.am @@ -520,6 +520,10 @@ src_ucrtbasearm32=\ src_ucrtbasearm64

[Mingw-w64-public] [PATCH 1/2] crt: Introduce F_ARM_NATIVE

2025-05-23 Thread Jacek Caban via Mingw-w64-public
And use it for exports not available on ARM64EC. --- mingw-w64-crt/def-include/func.def.in| 9 ++--- .../lib-common/api-ms-win-crt-math-l1-1-0.def.in | 2 +- mingw-w64-crt/lib-common/msvcrt.def.in | 2 +- mingw-w64-crt/lib-common/ntdll.def.in

Re: [Mingw-w64-public] [PATCH 2/2] crt: Define F_ARM_ANY on ARM64EC

2025-05-22 Thread Jacek Caban via Mingw-w64-public
On 18.05.2025 21:08, Martin Storsjö wrote: On Sat, 17 May 2025, Jacek Caban via Mingw-w64-public wrote: --- mingw-w64-crt/def-include/func.def.in | 3 +++ 1 file changed, 3 insertions(+) diff --git a/mingw-w64-crt/def-include/func.def.in b/mingw-w64-crt/def-include/func.def.in index

Re: [Mingw-w64-public] [PATCH] crt: Regenerate oleacc.def from Windows 11 DLL

2025-05-17 Thread Jacek Caban via Mingw-w64-public
On 17.05.2025 12:15, LIU Hao wrote: Private exports are commented out. Signed-off-by: LIU Hao ---  mingw-w64-crt/lib-common/oleacc.def | 15 ++-  mingw-w64-crt/lib32/oleacc.def  | 15 ++-  2 files changed, 20 insertions(+), 10 deletions(-) Looks good to me. Thanks

[Mingw-w64-public] [PATCH 2/2] crt: Define F_ARM_ANY on ARM64EC

2025-05-17 Thread Jacek Caban via Mingw-w64-public
--- mingw-w64-crt/def-include/func.def.in | 3 +++ 1 file changed, 3 insertions(+) diff --git a/mingw-w64-crt/def-include/func.def.in b/mingw-w64-crt/def-include/func.def.in index 1d542a1f4..f180b9ce7 100644 --- a/mingw-w64-crt/def-include/func.def.in +++ b/mingw-w64-crt/def-include/func.def.in

[Mingw-w64-public] [PATCH 1/2] crt: Remove F_ARM_ANY from entries in ntdll.def.in that also apply to x86

2025-05-17 Thread Jacek Caban via Mingw-w64-public
--- mingw-w64-crt/lib-common/ntdll.def.in | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/mingw-w64-crt/lib-common/ntdll.def.in b/mingw-w64-crt/lib-common/ntdll.def.in index ee002c868..efa6145b6 100644 --- a/mingw-w64-crt/lib-common/ntdll.def.in +++ b/mingw-w64-crt/lib

Re: [Mingw-w64-public] [PATCH] winpthreads: change LoadLibrary calls to GetModuleHandle after cb7f42e.

2023-10-30 Thread Jacek Caban via Mingw-w64-public
On 30.10.2023 22:09, Martin Storsjö wrote: On Mon, 30 Oct 2023, Jacek Caban wrote: GetTickCount64 is used only for _pthread_wait_for_*_objects wrappers, where the timeout is 32-bit anyway, so it should be possible to use GetTickCount unconditionally and avoid the whole problem. It would need

Re: [Mingw-w64-public] [PATCH] winpthreads: change LoadLibrary calls to GetModuleHandle after cb7f42e.

2023-10-30 Thread Jacek Caban via Mingw-w64-public
On 30.10.2023 16:39, Martin Storsjö wrote: On Mon, 30 Oct 2023, LIU Hao wrote: 在 2023-10-30 18:54, Martin Storsjö 写道: FWIW, this is what we already had before cb7f42e05b94cbb1d94edcebdbfb47b652a45484; we used GetTickCount64 unconditionally if _WIN32_WINNT was set to target vista or above. S

Re: [Mingw-w64-public] [PATCH 6/8] crt: Move fabsf and nexttowardf to libmsvcr*.a for all archs, and to libucrt*.a for x86

2023-10-27 Thread Jacek Caban via Mingw-w64-public
On 27/10/2023 16:51, LIU Hao wrote: 在 2023-10-26 19:15, Martin Storsjö 写道: fabsf is available in UCRT on arm32/arm64, but not on x86. nexttowardf is available in UCRT on all architectures, but this functions takes two parameters, and the second parameter is a long   ^ There is a typo

Re: [Mingw-w64-public] [PATCH] headers: Restore syncing d3d12.idl from Wine again

2023-09-21 Thread Jacek Caban via Mingw-w64-public
On 9/21/23 16:50, LIU Hao wrote: 在 2023-09-20 04:57, Martin Storsjö 写道: The version of d3d12.idl in vkd3d has been completed further now, and has been synced back to Wine; restore mingw-w64-headers to include this header in future syncs from wine. This synchronizes the d3d12.idl header from Win

Re: [Mingw-w64-public] [PATCH 4/4] headers: Add d2d1_2helper.h

2023-09-17 Thread Jacek Caban via Mingw-w64-public
Patches look good to me, I pushed to master. Thanks, Jacek ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public

Re: [Mingw-w64-public] [PATCH 2/2] headers: Manually import d3d12.idl from vkd3d

2023-09-09 Thread Jacek Caban via Mingw-w64-public
On 9/8/23 13:48, Martin Storsjö wrote: Ideally the d3d12.idl in wine will be brought up to sync at some point, but for now, exclude this header and sync it manually from vkd3d instead. Yes, we will want to re-sync all of that and I'm happy to help with that if needed. The patch itself looks g

Re: [Mingw-w64-public] [PATCH 1/2] headers: Add the D3D12 shader compiler interface dxcapi.h

2023-09-09 Thread Jacek Caban via Mingw-w64-public
On 9/8/23 13:48, Martin Storsjö wrote: This header is appropriately licensed with a compatible open source license, the University of Illinois Open Source License (a BSD-like license). It looks good to me. It's nice to see Microsoft open sourcing at least parts of their SDK. Thanks, Jacek

Re: [Mingw-w64-public] [PATCH] propkeydef.h: Drop include once guards.

2023-08-08 Thread Jacek Caban via Mingw-w64-public
On 8/8/23 16:30, LIU Hao wrote: 在 2023-08-08 20:40, Jacek Caban via Mingw-w64-public 写道: Fixes regression from 3638d5e9a6f2 reported: https://bugzilla.mozilla.org/show_bug.cgi?id=1847683 Those guards are not present in Wine and Windows SDK for a reason: if INITGUID is changed, it should be

[Mingw-w64-public] [PATCH] propkeydef.h: Drop include once guards.

2023-08-08 Thread Jacek Caban via Mingw-w64-public
Fixes regression from 3638d5e9a6f2 reported: https://bugzilla.mozilla.org/show_bug.cgi?id=1847683 Those guards are not present in Wine and Windows SDK for a reason: if INITGUID is changed, it should be reflected in DEFINE_PROPERTYKEY macro. --- mingw-w64-headers/include/propkeydef.h | 9 --

Re: [Mingw-w64-public] [PATCH 3/3] headers: Define D2D1FORCEINLINE where needed

2023-07-23 Thread Jacek Caban via Mingw-w64-public
On 7/23/23 13:04, LIU Hao wrote: 在 2023-07-23 18:43, Jacek Caban via Mingw-w64-public 写道: The commit is missing some files generated from IDLs, so current tree doesn't build. I tried building headers and regenerated all of them from IDL. It was necessary to use an up-to-date WIDL,

Re: [Mingw-w64-public] [PATCH 3/3] headers: Define D2D1FORCEINLINE where needed

2023-07-23 Thread Jacek Caban via Mingw-w64-public
On 7/23/23 11:58, LIU Hao wrote: 在 2023-07-23 13:57, Biswapriyo Nath 写道:  From 2a64bfe452a92a5197b2e102f5d46c28d14a7631 Mon Sep 17 00:00:00 2001 From: Biswapriyo Nath Date: Sun, 23 Jul 2023 11:17:05 +0530 Subject: [PATCH 3/3] headers: Define D2D1FORCEINLINE where needed Signed-off-by: Biswapriy

[Mingw-w64-public] mingw-w64 uses UCRT by default now.

2023-06-25 Thread Jacek Caban via Mingw-w64-public
Hi all, I just pushed a change to out build system to use UCRT by default. Bellow is a copy of more detailed informations, it can be also found in git in mingw-w64-doc/howto-build/ucrt-vs-msvcrt.txt. Thanks, Jacek == Summary == Starting from mingw-w64 version 12 and onwards, UCRT (Unive

Re: [Mingw-w64-public] [PATCH v3] configure: Use ucrt for msvcrt by default.

2023-06-25 Thread Jacek Caban via Mingw-w64-public
On 6/25/23 16:32, LIU Hao wrote: 在 2023-06-19 20:43, Jacek Caban via Mingw-w64-public 写道: ---   mingw-w64-crt/configure.ac   |  4 +-   mingw-w64-doc/howto-build/ucrt-vs-msvcrt.txt | 58   mingw-w64-headers/configure.ac   | 12 ++--   3 files

Re: [Mingw-w64-public] [PATCH 1/2] headers: Add wia.idl

2023-06-21 Thread Jacek Caban via Mingw-w64-public
On 6/20/23 20:27, Biswapriyo Nath wrote: Is it possible to provide any hit why the widl crashed? Or is there any way to troubleshoot the issue? You may incrementally revert parts of your changes until it works. It should give a good idea where to look. Please file a bug if you need more assi

Re: [Mingw-w64-public] [PATCH 1/2] headers: Add wia.idl

2023-06-20 Thread Jacek Caban via Mingw-w64-public
On 6/20/23 19:39, Biswapriyo Nath wrote: Is it possible to add the file in mingw-w64? It has been a week and I get no response in wine merge request. It crashes widl during the build, so it's pretty obvious why it's not merged. Jacek ___ Mingw

[Mingw-w64-public] [PATCH v3] configure: Use ucrt for msvcrt by default.

2023-06-19 Thread Jacek Caban via Mingw-w64-public
--- mingw-w64-crt/configure.ac | 4 +- mingw-w64-doc/howto-build/ucrt-vs-msvcrt.txt | 58 mingw-w64-headers/configure.ac | 12 ++-- 3 files changed, 66 insertions(+), 8 deletions(-) create mode 100644 mingw-w64-doc/howto-build/ucrt-vs-msvcrt.

Re: [Mingw-w64-public] [PATCH v2] configure: Use ucrt for msvcrt by default.

2023-06-19 Thread Jacek Caban via Mingw-w64-public
On 6/19/23 14:20, Martin Storsjö wrote: On Mon, 19 Jun 2023, Jacek Caban via Mingw-w64-public wrote: v2 includes changes suggested by Martin. It also includes a documentation change to clarify the situation. --- mingw-w64-crt/configure.ac   |  4 +- mingw-w64-doc/howto-build

[Mingw-w64-public] [PATCH v2] configure: Use ucrt for msvcrt by default.

2023-06-19 Thread Jacek Caban via Mingw-w64-public
v2 includes changes suggested by Martin. It also includes a documentation change to clarify the situation. --- mingw-w64-crt/configure.ac | 4 +- mingw-w64-doc/howto-build/ucrt-vs-msvcrt.txt | 58 mingw-w64-headers/configure.ac | 12 ++-- 3

Re: [Mingw-w64-public] [PATCH] configure: Use ucrt for msvcrt by default.

2023-06-11 Thread Jacek Caban via Mingw-w64-public
On 6/8/23 06:18, LIU Hao wrote: I agree that those are valid concerns. However, there is little we can do about it and it's unlikely to change over time. Do we want msvcrt-os to remain the default forever? For your information, this is a non-exhaustive list of distributions that do not specif

Re: [Mingw-w64-public] [PATCH 1/2] headers: Add wia.idl

2023-06-07 Thread Jacek Caban via Mingw-w64-public
On 6/7/23 19:46, Biswapriyo Nath wrote: Do we need to reimplement 'wia.idl', instead of importing 'wia_lh.idl' and 'wia_xp.idl' from Wine? wia_lh.idl and wia_xp.idl in wine are missing many declarations. It should be easy to add them to Wine. Besides, wia_xp.h is just a stripped down vers

Re: [Mingw-w64-public] [PATCH] configure: Use ucrt for msvcrt by default.

2023-06-05 Thread Jacek Caban via Mingw-w64-public
On 6/5/23 10:59, Martin Storsjö wrote: On Sun, 4 Jun 2023, Jacek Caban via Mingw-w64-public wrote: We're early in release cycle again, so it feels like a good time to consider defaulting to ucrt. At this point, ucrt support seems generally mature enough and I'm not aware of an

[Mingw-w64-public] [PATCH] configure: Use ucrt for msvcrt by default.

2023-06-04 Thread Jacek Caban via Mingw-w64-public
Hi all, We're early in release cycle again, so it feels like a good time to consider defaulting to ucrt. At this point, ucrt support seems generally mature enough and I'm not aware of any blockers. Thanks, Jacek --- mingw-w64-crt/configure.ac | 4 ++-- mingw-w64-headers/configure.ac |

Re: [Mingw-w64-public] [PATCH] crt: Remove conversion functions between UTF-{16, 32} characters from MSVCRT

2023-04-27 Thread Jacek Caban via Mingw-w64-public
On 4/22/23 14:46, LIU Hao wrote: 在 2023-03-30 16:38, LIU Hao 写道: Ping on this patch. A blank line got deleted by accident. I can fix that locally. Removal of stuff could be bad, but given that `mbstoc16()` has never been working, it might not be a big loss. Ping again? It has been almost

Re: [Mingw-w64-public] clang shows compiler error with windows.ui.composition.h

2023-04-27 Thread Jacek Caban via Mingw-w64-public
On 4/26/23 22:30, Biswapriyo Nath wrote: The compiler error can be solved if DirectXAlphaMode is replaced with ABI::Windows::Graphics::DirectX::DirectXAlphaMode. I am not sure if this is an issue with widl generated header or an issue with clang and C++ standards. How can I troubleshoot this issu

Re: [Mingw-w64-public] [PATCH] headers: Import textstor.idl from wine

2023-04-10 Thread Jacek Caban via Mingw-w64-public
Pushed, thanks. Jacek ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public

Re: [Mingw-w64-public] Migration from SF and port from Autotools

2023-04-04 Thread Jacek Caban via Mingw-w64-public
On 3/31/23 18:24, NightStrike wrote: On Thu, Mar 30, 2023, 06:45 Jacek Caban via Mingw-w64-public wrote: On 3/20/23 16:44, مهدي شينون wrote: > Hi everyone, > > > Could you please consider migrating your project to another host other > than s

Re: [Mingw-w64-public] Migration from SF and port from Autotools

2023-03-30 Thread Jacek Caban via Mingw-w64-public
On 3/20/23 16:44, مهدي شينون wrote: Hi everyone, Could you please consider migrating your project to another host other than sourcefoge where people could file bugs, propose changes and discuss things (like GitHub ot GitLab). Using mailing-list for that is a way that's not suitable for youn

Re: [Mingw-w64-public] [PATCH] crt: Make CRT buildable with `-masm=intel`

2023-03-23 Thread Jacek Caban via Mingw-w64-public
On 3/23/23 07:03, Martin Storsjö wrote: On Wed, 22 Mar 2023, Jacek Caban wrote: On 3/22/23 15:21, LIU Hao wrote: 在 2023-03-22 21:07, Jacek Caban 写道: That's the motivation for this? I can see a point in supporting both syntaxes in headers (which may be included by users with various compiler

Re: [Mingw-w64-public] [PATCH] crt: Make CRT buildable with `-masm=intel`

2023-03-22 Thread Jacek Caban via Mingw-w64-public
On 3/22/23 15:21, LIU Hao wrote: 在 2023-03-22 21:07, Jacek Caban 写道: That's the motivation for this? I can see a point in supporting both syntaxes in headers (which may be included by users with various compiler options), but for crt, why isn't supporting a single syntax understood by all supp

Re: [Mingw-w64-public] [PATCH] crt: Make CRT buildable with `-masm=intel`

2023-03-22 Thread Jacek Caban via Mingw-w64-public
On 3/22/23 04:08, LIU Hao wrote: This is the first attempt to allow the CRT to be built with `-masm=intel`. This patch itself may look messy because it contains a lot of inline changes. It should be examined with `git show --color-words='\S'`. I have only verified that the CRT actually builds

Re: [Mingw-w64-public] [PATCH] headers: explicitly define Reserved bits in DXVAHD_BLT_STATE, structures

2023-03-17 Thread Jacek Caban via Mingw-w64-public
On 3/17/23 15:39, Steve Lhomme wrote: On 2023-03-17 15:28, Biswapriyo Nath wrote: 1. You missed the Reserved member in DXVAHD_STREAM_STATE_INPUT_COLOR_SPACE_DATA. 2. There should be __C89_NAMELESS before the struct and union keywords. Indeed, good catch. Here is v2 of the patch. This does

Re: [Mingw-w64-public] [PATCH] headers: Don't use __mingw_wcstod/wcstof on UCRT

2023-01-20 Thread Jacek Caban via Mingw-w64-public
On 1/20/23 13:49, Martin Storsjö wrote: The UCRT provided versions should be fully C99 compliant. This matches what was done for strtod/strtof for the initial configuration for UCRT in 265d0a5e3f087ed6bd68412cceed5e27e3ef62ae. Also clarify the endif comment, and make the condition in wchar.h co

Re: [Mingw-w64-public] [PATCH] genstubdll: Remove

2022-12-21 Thread Jacek Caban via Mingw-w64-public
On 12/21/22 15:12, LIU Hao wrote: 在 2022-12-20 02:49, Pali Rohár 写道: And I think that this decision is independent of tool itself if should be removed too or not. My point is that if this should be removed then we shouldn't behave as if it was being actively maintained. Patch attached. Thou

Re: [Mingw-w64-public] [PATCH] widl: Avoid conflicting definitions of fastfail from Wine's winnt.h

2022-12-21 Thread Jacek Caban via Mingw-w64-public
Hi Martin, On 12/21/22 10:37, Martin Storsjö wrote: Widl uses a subset of Wine headers, on top of the host's platform headers (either Unix or Windows ones). When building widl for a Windows target, the included Wine headers end up being preferred over the toolchain's own platform headers. Wine