Re: [Mingw-w64-public] [PATCH 2/2] crt: Fix LTO compile warning for main and wmain functions

2025-07-19 Thread LIU Hao
在 2025-7-18 04:08, Pali Rohár 写道: Function main is somehow special that it can take from zero to three parameters. So define it in internal.h file without parameters. This will mute the gcc LTO warning which is printed by default. I don't think this is correct. Standard C only allows zero or tw

Re: [Mingw-w64-public] [PATCH] headers/wintrust: Add forward declarations for structs

2025-07-19 Thread LIU Hao
在 2025-7-19 21:54, Jacek Caban 写道: On 19.07.2025 15:47, LIU Hao wrote: +  struct _CRYPT_PROVIDER_DATA; +  struct _CRYPT_PROVIDER_SGNR; +  struct _CRYPT_PROVIDER_PRIVDATA; +  struct _CRYPT_PROVIDER_DEFUSAGE; We could also reorder declarations to define those structs earlier, but the patch lo

Re: [Mingw-w64-public] [PATCH] headers/wintrust: Add forward declarations for structs

2025-07-19 Thread Jacek Caban via Mingw-w64-public
On 19.07.2025 15:47, LIU Hao wrote: +  struct _CRYPT_PROVIDER_DATA; +  struct _CRYPT_PROVIDER_SGNR; +  struct _CRYPT_PROVIDER_PRIVDATA; +  struct _CRYPT_PROVIDER_DEFUSAGE; We could also reorder declarations to define those structs earlier, but the patch looks fine to me too. Thanks, Jace

[Mingw-w64-public] [PATCH] headers/wintrust: Add forward declarations for structs

2025-07-19 Thread LIU Hao
Like in 0028c5c24f84750b5a53131c69e5f69fb51d8a7c, this solves warnings like mingw-w64-headers/include/wintrust.h:245:47: warning: 'struct _CRYPT_PROVIDER_DATA' declared inside parameter list will not be visible outside of this definition or declaration 245 | typedef WINBOOL (*PFN_CPD_A

Re: [Mingw-w64-public] [PATCH] headers: Add new symbols in wintrust.h

2025-07-19 Thread LIU Hao
在 2025-7-19 02:12, Biswapriyo Nath 写道: From c34b6e71774c973e95a9b8661d0fcd9cd5caa1bd Mon Sep 17 00:00:00 2001 From: Biswapriyo Nath Date: Fri, 18 Jul 2025 18:10:13 + Subject: [PATCH] headers: Add new symbols in wintrust.h Required forhttps://github.com/chromiumembedded/cef/commit/ce365d498

Re: [Mingw-w64-public] [PATCH] crt: Add link to _pei386_runtime_relocator GNU LD bug

2025-07-19 Thread LIU Hao
在 2025-7-19 05:30, Pali Rohár 写道: --- mingw-w64-crt/crt/pseudo-reloc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Thanks for the patch. Pushed now. -- Best regards, LIU Hao OpenPGP_signature.asc Description: OpenPGP digital signature _