Re: [Mingw-w64-public] [PATCH] headers: Add PF_MOVDIR64B_INSTRUCTION_AVAILABLE

2025-06-19 Thread LIU Hao
在 2025-6-19 20:39, Martin Storsjö 写道: This exists in newer revisions of the 10.0.26100.0 WinSDK, but wasn't present in an earlier revision I used as basis for f97814b9602d62cec180aae9e0a0bb5198e7289d. Signed-off-by: Martin Storsjö --- mingw-w64-headers/include/winnt.h | 1 + 1 file changed,

Re: [Mingw-w64-public] [PATCH] github: Use "check-runtimes" rather than individual "check-cxx" for test-libcxx

2025-06-19 Thread LIU Hao
在 2025-6-19 22:22, Martin Storsjö 写道: This makes sure to run all three testsuites, even if there are failures in one of them, making it clearer to see all potential issues with one run. Signed-off-by: Martin Storsjö --- .github/workflows/build.yml | 2 +- 1 file changed, 1 insertion(+), 1 de

Re: [Mingw-w64-public] Fix header paths

2025-06-19 Thread LIU Hao
在 2025-6-18 21:36, Egor Pugin 写道: Hi, These two headers are missing directory prefix. --- diff --git a/mingw-w64-crt/Makefile.am b/mingw-w64-crt/Makefile.am index e0924b470..4216efbd6 100644 --- a/mingw-w64-crt/Makefile.am +++ b/mingw-w64-crt/Makefile.am This change is reasonable, however th

[Mingw-w64-public] Missing Microsoft printf behavior in mingw_pformat.c and OutOfBound in emu__vscwprintf()

2025-06-19 Thread Julien Vary
{ Copy-paste of https://github.com/mingw-w64/mingw-w64/issues/102 } Hello all! I found two issues when digging in the mingw crt/stdio code, and I wonder if this is something you would like a patch for. First issue : emu__vscwprintf (in mingw-w64-crt/stdio/_vscwprintf.c) _vsnwprintf expects to r

Re: [Mingw-w64-public] [PATCH 04/10] crt: Define fseeko64 symbol as alias to _fseeki64

2025-06-19 Thread Martin Storsjö
On Sun, 15 Jun 2025, Pali Rohár wrote: mingw-w64 implementation of fseeko64() and _fseeki64() functions in files mingw-w64-crt/stdio/_fseeki64.c and mingw-w64-crt/stdio/fseeko64.c are exactly same. Also both both fseeko64() and _fseeki64() functions have C fseek() ABI with 64-bit offset type.

Re: [Mingw-w64-public] [PATCH] crt: Deinline mbsinit() function

2025-06-19 Thread Martin Storsjö
On Sun, 15 Jun 2025, Pali Rohár wrote: This simplify header declaration for mbsinit() function. --- mingw-w64-crt/Makefile.am | 1 + mingw-w64-crt/misc/mbsinit.c | 1 - mingw-w64-crt/misc/ucrt_mbsinit.c | 14 ++ mingw-w64-headers/crt/wchar.h | 10 +- 4 files ch

Re: [Mingw-w64-public] [PATCH 1/4] crt: Provide mingw-w64 emulation of getenv_s function for all CRT import libraries

2025-06-19 Thread Martin Storsjö
On Thu, 19 Jun 2025, Pali Rohár wrote: On Thursday 19 June 2025 16:14:34 Martin Storsjö wrote: On Sat, 24 May 2025, Pali Rohár wrote: --- mingw-w64-crt/Makefile.am | 2 + mingw-w64-crt/lib-common/msvcrt.def.in | 2 +- mingw-w64-crt/secapi/getenv_s.c| 61 ++

Re: [Mingw-w64-public] [PATCH 07/10] crt: Provide _lseeki64() function for pre-msvcrt40 builds

2025-06-19 Thread Martin Storsjö
On Mon, 16 Jun 2025, Pali Rohár wrote: On Monday 16 June 2025 19:32:40 Lasse Collin wrote: On 2025-06-15 Pali Rohár wrote: > +/* Define 64-bit _lseeki64() function via 32-bit _lseek() function */ > +__int64 __cdecl _lseeki64(int fd, __int64 offset, int whence) > +{ > + if (offset > LONG_MAX) >

Re: [Mingw-w64-public] [PATCH 02/10] crt: Define fseeko and ftello symbols as aliases to fseek and ftell

2025-06-19 Thread Martin Storsjö
On Sun, 15 Jun 2025, Pali Rohár wrote: Both msvcrt and UCRT ABI uses for off_t-based function without any suffix in their name the 32-bit long off_t type for both 32-bit and 64-bit architectures. The non-English word order makes this sentence very hard to parse. Right now, this sentence reads

Re: [Mingw-w64-public] [PATCH v2 00/13] Fix stat functions

2025-06-19 Thread Pali Rohár
On Thursday 19 June 2025 15:36:34 Martin Storsjö wrote: > On Mon, 5 May 2025, Martin Storsjö wrote: > > > On Mon, 5 May 2025, Pali Rohár wrote: > > > > > On Monday 05 May 2025 16:10:54 Martin Storsjö wrote: > > > > On Sun, 13 Apr 2025, Pali Rohár wrote: > > > > > > > > > This patch series is fix

Re: [Mingw-w64-public] [PATCH 1/4] crt: Provide mingw-w64 emulation of getenv_s function for all CRT import libraries

2025-06-19 Thread Pali Rohár
On Thursday 19 June 2025 16:14:34 Martin Storsjö wrote: > On Sat, 24 May 2025, Pali Rohár wrote: > > > --- > > mingw-w64-crt/Makefile.am | 2 + > > mingw-w64-crt/lib-common/msvcrt.def.in | 2 +- > > mingw-w64-crt/secapi/getenv_s.c| 61 ++ > > 3 files cha

[Mingw-w64-public] [PATCH] github: Use "check-runtimes" rather than individual "check-cxx" for test-libcxx

2025-06-19 Thread Martin Storsjö
This makes sure to run all three testsuites, even if there are failures in one of them, making it clearer to see all potential issues with one run. Signed-off-by: Martin Storsjö --- .github/workflows/build.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/

Re: [Mingw-w64-public] [PATCH 4/4] crt: getopt: Use getenv_s() instead of getenv()

2025-06-19 Thread Martin Storsjö
On Sat, 24 May 2025, Pali Rohár wrote: mingw-w64's winstorecompat provides just dummy getenv() implementation which always returns NULL. So it is not very usable for winstorecompat UWP builds. But mingw-w64's winstorecompat provides getenv_s() which returns the real environment variable content

Re: [Mingw-w64-public] [PATCH 1/4] crt: Provide mingw-w64 emulation of getenv_s function for all CRT import libraries

2025-06-19 Thread Martin Storsjö
On Sat, 24 May 2025, Pali Rohár wrote: --- mingw-w64-crt/Makefile.am | 2 + mingw-w64-crt/lib-common/msvcrt.def.in | 2 +- mingw-w64-crt/secapi/getenv_s.c| 61 ++ 3 files changed, 64 insertions(+), 1 deletion(-) create mode 100644 mingw-w64-crt/secapi/

Re: [Mingw-w64-public] [PATCH 1/7] crt: stat: Move internal function declarations to stdio/__mingw_fix_stat.h

2025-06-19 Thread Martin Storsjö
On Sat, 10 May 2025, Pali Rohár wrote: I'm fine with the whole patch series. I wrote about one small cosmetic issue which could be adjusted during applying series to git. It looks fine to me as well; I can push it if it passes through CI without issues. // Martin __

Re: [Mingw-w64-public] [PATCH 6/7] crt: stat: Don't remove a trailing '\' if it is a DBCS trail byte

2025-06-19 Thread Martin Storsjö
On Thu, 8 May 2025, Lasse Collin wrote: In double-byte character sets, the trail byte of a two-byte character can be a backslash. If such a two-byte character was at the end of the pathname, the trailing backslash was incorrectly removed. The code still removes only one trailing directory separ

[Mingw-w64-public] [PATCH] headers: Add PF_MOVDIR64B_INSTRUCTION_AVAILABLE

2025-06-19 Thread Martin Storsjö
This exists in newer revisions of the 10.0.26100.0 WinSDK, but wasn't present in an earlier revision I used as basis for f97814b9602d62cec180aae9e0a0bb5198e7289d. Signed-off-by: Martin Storsjö --- mingw-w64-headers/include/winnt.h | 1 + 1 file changed, 1 insertion(+) diff --git a/mingw-w64-hea

Re: [Mingw-w64-public] [PATCH v2 00/13] Fix stat functions

2025-06-19 Thread Martin Storsjö
On Mon, 5 May 2025, Martin Storsjö wrote: On Mon, 5 May 2025, Pali Rohár wrote: On Monday 05 May 2025 16:10:54 Martin Storsjö wrote: On Sun, 13 Apr 2025, Pali Rohár wrote: This patch series is fixing stat functions as was discussed in the long email thread "stat, _stat, and _stat64i32 issue