Re: [Mingw-w64-public] winpthreads: make testing shared library work

2025-06-03 Thread LIU Hao
在 2025-6-3 23:46, Kirill Makurin 写道: You are right. `libtool --mode=execute` is no longer needed. I forgot that libtool creates wrapper executables which handle search path. I attached update patch. Thanks for the patch. Looks good to me. Pushed now. -- Best regards, LIU Hao OpenPGP_sig

Re: [Mingw-w64-public] winpthreads: make testing shared library work

2025-06-03 Thread Kirill Makurin
You are right. `libtool --mode=execute` is no longer needed. I forgot that libtool creates wrapper executables which handle search path. I attached update patch. - Kirill Makurin From: LIU Hao Sent: Tuesday, June 3, 2025 7:11 PM To: Kirill Makurin; mingw-w64-pub

Re: [Mingw-w64-public] winpthreads: make testing shared library work

2025-06-03 Thread LIU Hao
在 2025-6-3 17:44, Kirill Makurin 写道: This is a good idea. Plain `LDADD` (not `LIBADD`) is used to add libraries to all programs in current Makefile.am. Oh thank you. I keep forgetting that. From 2347a4099e1340a2789ac9f11001c25548463e69 Mon Sep 17 00:00:00 2001 From: Kirill Makurin Date: Tue

Re: [Mingw-w64-public] Inconsistent behavior of btowc with "C" locale

2025-06-03 Thread Kirill Makurin
Ah, so UCRT does the right thing? I was not aware of this behavior for "POSIX" locale. I still wonder whether MSVCRT's btowc succeeds when GetACP() != CP_UTF8. If it converts using code page retuned by GetACP(), this means that replacement has the same behavior. Otherwise, we might need to che

Re: [Mingw-w64-public] winpthreads: make testing shared library work

2025-06-03 Thread Kirill Makurin
This is a good idea. Plain `LDADD` (not `LIBADD`) is used to add libraries to all programs in current Makefile.am. I have attached updated patch. - Kirill Makurin From: LIU Hao Sent: Tuesday, June 3, 2025 12:47 PM To: mingw-w64-public@lists.sourceforge.net; Kir

Re: [Mingw-w64-public] Inconsistent behavior of btowc with "C" locale

2025-06-03 Thread LIU Hao
在 2025-6-3 19:11, Kirill Makurin 写道: Oh, my bad. I was thinking I was calling MSVCRT's `btowc`, not the replacement. I tried calling real `btowc` and its behavior matches UCRT. I also tried loading msvcr100.dll, it has the same behavior. So, I think we could check return value of `___lc_codep

Re: [Mingw-w64-public] Inconsistent behavior of btowc with "C" locale

2025-06-03 Thread Kirill Makurin
I think glibc just did not implement this behavior yet. There have been nearly zero real changes to its `btowc` since like 2007. https://sourceware.org/git/?p=glibc.git;a=history;f=wcsmbs/btowc.c;h=7be040ff6688d31da585d9075bdee54d231550d1;hb=refs/heads/master I think it should be ok for replacem

Re: [Mingw-w64-public] Inconsistent behavior of btowc with "C" locale

2025-06-03 Thread Kirill Makurin
Oh, my bad. I was thinking I was calling MSVCRT's `btowc`, not the replacement. I tried calling real `btowc` and its behavior matches UCRT. I also tried loading msvcr100.dll, it has the same behavior. So, I think we could check return value of `___lc_codepage_func()` and for "C" locale, return

Re: [Mingw-w64-public] Inconsistent behavior of btowc with "C" locale

2025-06-03 Thread LIU Hao
在 2025-6-3 18:02, Kirill Makurin 写道: Ah, so UCRT does the right thing? I was not aware of this behavior for "POSIX" locale. I still wonder whether MSVCRT's btowc succeeds when GetACP() != CP_UTF8. If it converts using code page retuned by GetACP(), this means that replacement has the same beha