Re: [Mingw-w64-public] [PATCH] crt: Make .CRT section read only

2025-05-25 Thread LIU Hao
在 2025-5-17 16:16, Yang Kun 写道: .CRT section is combined into .rdata which doesn't have shared attribute but read only. If we declare it with shared, it will causes LNK4254 warning. Also remove the read and write attribute in .tls as this is default. Signed-off-by: Yang Kun ---  mingw-w64-crt

Re: [Mingw-w64-public] Deduplicate lib32 and lib-common def files

2025-05-25 Thread LIU Hao
在 2025-5-26 02:58, Martin Storsjö 写道: On Sun, 25 May 2025, Jacek Caban wrote: I think that kind of massive duplication just doesn't scale. For example, when adding a new target like ARM64EC, are you suggesting we duplicate all the .def files for a fifth time, rather than just adjusting a few a

Re: [Mingw-w64-public] Deduplicate lib32 and lib-common def files

2025-05-25 Thread Martin Storsjö
On Sun, 25 May 2025, Jacek Caban wrote: On 24.05.2025 12:25, LIU Hao wrote: 在 2025-5-24 18:12, Pali Rohár 写道: And it deduplicated 496 def files. What do you think about it? Just a robotic change and can decrease number of def files which needs to be maintained. I don't have a specific opinio

Re: [Mingw-w64-public] [PATCH] headers: Don't mark RtlUnwind functions as noreturn*

2025-05-25 Thread Jacek Caban via Mingw-w64-public
On 25.05.2025 18:10, Martin Storsjö wrote: On Sun, 25 May 2025, Jacek Caban via Mingw-w64-public wrote: This reverts commit 8c2c00ef898f36d51613b45c2cab4f4448d35f0b. These functions can unwind to the current frame, in which case they effectively return. Therefore, they should not be marked as

Re: [Mingw-w64-public] Deduplicate lib32 and lib-common def files

2025-05-25 Thread Jacek Caban via Mingw-w64-public
On 24.05.2025 12:25, LIU Hao wrote: 在 2025-5-24 18:12, Pali Rohár 写道: And it deduplicated 496 def files. What do you think about it? Just a robotic change and can decrease number of def files which needs to be maintained. I don't have a specific opinion on this change. Frankly speaking, I am

[Mingw-w64-public] [PATCH] crt: Make .CRT section read only

2025-05-25 Thread Yang Kun
.CRT section is combined into .rdata which doesn't have shared attribute but read only. If we declare it with shared, it will causes LNK4254 warning. Also remove the read and write attribute in .tls as this is default. Signed-off-by: Yang Kun ---  mingw-w64-crt/include/sect_attribs.h | 93 +

Re: [Mingw-w64-public] [PATCH] Always correctly #define NULL __null if available, like stddef.h

2025-05-25 Thread наб
On Fri, May 09, 2025 at 10:31:38AM +0800, LIU Hao wrote: > 在 2025-5-4 22:24, наб 写道: > > Consider the following program, reduced from Lensfun: > >#include > >extern char *f(const char *first_element, ...) > > __attribute__((__sentinel__)); > >static auto N = f("a", "b", NULL); > >

Re: [Mingw-w64-public] [PATCH] headers: Don't mark RtlUnwind functions as noreturn*

2025-05-25 Thread Martin Storsjö
On Sun, 25 May 2025, Jacek Caban via Mingw-w64-public wrote: This reverts commit 8c2c00ef898f36d51613b45c2cab4f4448d35f0b. These functions can unwind to the current frame, in which case they effectively return. Therefore, they should not be marked as noreturn. Use __builtin_unreachable in the

Re: [Mingw-w64-public] [PATCH] headers: Don't mark RtlUnwind functions as noreturn*

2025-05-25 Thread Jacek Caban via Mingw-w64-public
'*' in the commit message is a typo, I will remove it. Jacek ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public

[Mingw-w64-public] [PATCH] headers: Don't mark RtlUnwind functions as noreturn*

2025-05-25 Thread Jacek Caban via Mingw-w64-public
This reverts commit 8c2c00ef898f36d51613b45c2cab4f4448d35f0b. These functions can unwind to the current frame, in which case they effectively return. Therefore, they should not be marked as noreturn. Use __builtin_unreachable in the ARM64EC longjmp implementation instead. Fixes https://gitlab.w

Re: [Mingw-w64-public] [PATCH 3/9] crt: exe: Invoke gcc c++ constructors after msvc c++ constructors

2025-05-25 Thread Martin Storsjö
On Sat, 24 May 2025, Pali Rohár wrote: On Sunday 18 May 2025 14:57:12 Martin Storsjö wrote: On Sun, 18 May 2025, Pali Rohár wrote: On Friday 09 May 2025 18:07:22 Pali Rohár wrote: On Tuesday 06 May 2025 19:59:31 Martin Storsjö wrote: On Thu, 17 Apr 2025, Pali Rohár wrote: Function __main(

Re: [Mingw-w64-public] [PATCH 8/8] headers: Fix non-standard C++ two-argument swprintf() function

2025-05-25 Thread Martin Storsjö
On Wed, 7 May 2025, Pali Rohár wrote: This was in builds with UCRT; builds with msvcrt seem to pass this stage - see https://github.com/mstorsjo/mingw-w64/actions/runs/14869105161/job/41753135722 for the full log. The same thing also show up in GCC builds with UCRT. For patchsets like these, i

Re: [Mingw-w64-public] Deduplicate lib32 and lib-common def files

2025-05-25 Thread Pali Rohár
On Sunday 25 May 2025 12:41:08 Martin Storsjö wrote: > On Sun, 18 May 2025, Pali Rohár wrote: > > > Hello, what do you think about doing one-time automatic deduplication of > > lib32 and lib-common def files? > > > > Since commit cf211ae90565ff02e78c93d93a913501d100f30f ("crt: Remove > > @ stdcal

Re: [Mingw-w64-public] Deduplicate lib32 and lib-common def files

2025-05-25 Thread Martin Storsjö
On Sun, 18 May 2025, Pali Rohár wrote: Hello, what do you think about doing one-time automatic deduplication of lib32 and lib-common def files? Since commit cf211ae90565ff02e78c93d93a913501d100f30f ("crt: Remove @ stdcall mangling when processing lib-common/*.def.in files for non-I386 builds")