Re: [Mingw-w64-public] [PATCH 1/7] crt: stat: Move internal function declarations to stdio/__mingw_fix_stat.h

2025-05-10 Thread Pali Rohár
I'm fine with the whole patch series. I wrote about one small cosmetic issue which could be adjusted during applying series to git. ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/min

Re: [Mingw-w64-public] [PATCH 6/7] crt: stat: Don't remove a trailing '\' if it is a DBCS trail byte

2025-05-10 Thread Pali Rohár
On Thursday 08 May 2025 16:40:47 Lasse Collin wrote: > In double-byte character sets, the trail byte of a two-byte character > can be a backslash. If such a two-byte character was at the end of > the pathname, the trailing backslash was incorrectly removed. > > The code still removes only one trai

Re: [Mingw-w64-public] [PATCH 08/10] headers: Fix declaration of POSIX stat/fstat and LFS stat64/fstat64 functions

2025-05-10 Thread Christoph Reiter
This change seems to break the 64bit msvcrt build for gcc: x86_64-w64-mingw32\bin\ld.exe: ada/adaint.o:adaint.c:(.text+0x4375): undefined reference to `fstat64' Here a smaller reproducer: $ cat x.c #include int main( void ) { struct stat64 something; fstat64(0, &something); return 0;