Re: [Mingw-w64-public] [PATCH] crt: Implement exp2/exp2f/exp2l in C on ARM targets.

2025-03-31 Thread Martin Storsjö
On Mon, 31 Mar 2025, Jacek Caban wrote: --- mingw-w64-crt/Makefile.am | 10 ++ .../math/{arm64/exp2f.S => arm-common/exp2.c} | 16 ++-- .../math/{arm/exp2f.S => arm-common/exp2f.c} | 16 ++-- mingw-w64-crt/math/arm-common/exp2l.c | 12 +++

[Mingw-w64-public] [PATCH] crt: Implement exp2/exp2f/exp2l in C on ARM targets.

2025-03-31 Thread Jacek Caban
--- mingw-w64-crt/Makefile.am | 10 ++ .../math/{arm64/exp2f.S => arm-common/exp2.c} | 16 ++-- .../math/{arm/exp2f.S => arm-common/exp2f.c} | 16 ++-- mingw-w64-crt/math/arm-common/exp2l.c | 12 mingw-w64-crt/math/arm/exp2.

[Mingw-w64-public] [PATCH] crt: Move definitions of `__mingw_fe_dfl_env` to 'fesetenv.c'

2025-03-31 Thread LIU Hao
These macros are to be used with `fesetenv()`, so they belong there. Having these `selectany` variables in 'fenv.h' causes them to be defined with external linkage in every source file which includes 'fenv.h'. They can also be exported inappropriately from a DLL, which either is built with `--exp

Re: [Mingw-w64-public] [PATCH v2 6/7] crt: Build with -fno-builtin.

2025-03-31 Thread Jacek Caban
On 26.03.2025 14:07, Martin Storsjö wrote: On Sat, 22 Mar 2025, Jacek Caban wrote: mingw-w64-crt implements a number of functions that the compiler considers built-in. Currently, we must be cautious about compiler optimizations, as they may not align with our intentions. In theory, the compile

Re: [Mingw-w64-public] [PATCH] crt: Move definitions of `__mingw_fe_dfl_env` to 'fesetenv.c'

2025-03-31 Thread Martin Storsjö
On Mon, 31 Mar 2025, Jacek Caban wrote: On 31.03.2025 03:35, LIU Hao wrote: The effect that `__mingw_fe_dfl_env` etc. are defined everywhere is probably not good. Jacek, do you agree with this change? I can adjust the patch if we agree on that. Yes, I agree, but with Martin's comment addres

Re: [Mingw-w64-public] [PATCH] crt: Move definitions of `__mingw_fe_dfl_env` to 'fesetenv.c'

2025-03-31 Thread Jacek Caban
On 31.03.2025 03:35, LIU Hao wrote: The effect that `__mingw_fe_dfl_env` etc. are defined everywhere is probably not good. Jacek, do you agree with this change? I can adjust the patch if we agree on that. Yes, I agree, but with Martin's comment addressed and x86-specific declarations #ifdefe