Re: [Mingw-w64-public] [PATCH 1/2] crt: Build with -fno-builtin.

2025-03-21 Thread LIU Hao
在 2025-3-22 06:03, Jacek Caban 写道: On 21.03.2025 18:39, LIU Hao wrote: While this change might be safe, we have code that calls `memset()` to clear small structures such as `mbstate_t` (stdio/mingw_pformat.c) or `struct tm` (secapi/_gmtime32_s.c). If we mean to disable all builts, these operati

Re: [Mingw-w64-public] [PATCH] winpthreads: fix typo pthread_attr_setgaurdsize->pthread_attr_setguardsize

2025-03-21 Thread LIU Hao
在 2025-3-22 06:05, Martin Storsjö 写道: From: Alexander Argentakis <38327951+mfdgam...@users.noreply.github.com> --- Forwarding this fix from https://github.com/mingw-w64/mingw-w64/pull/82; it looks trivial enough to not require the submitter to subscribe for posting the patch themselves. --- mi

Re: [Mingw-w64-public] [PATCH 2/2] crt: Implement sincos in C.

2025-03-21 Thread Jacek Caban
On 21.03.2025 22:52, Martin Storsjö wrote: On Fri, 21 Mar 2025, Jacek Caban wrote: --- mingw-w64-crt/Makefile.am   | 20 +- mingw-w64-crt/math/arm-common/sincosl.c | 13 +++ mingw-w64-crt/math/arm/sincos.S | 32 mingw-w64-crt/math/arm/sincosf.S 

Re: [Mingw-w64-public] [PATCH] crt: Use .def file aliases for _chgsignl on ARM targets.

2025-03-21 Thread Jacek Caban
On 21.03.2025 22:43, Martin Storsjö wrote: On Fri, 21 Mar 2025, Jacek Caban wrote: --- mingw-w64-crt/Makefile.am    |  2 -- mingw-w64-crt/def-include/crt-aliases.def.in |  2 ++ .../lib-common/api-ms-win-crt-math-l1-1-0.def.in |  1 + mingw-w64-crt/math/arm/_chgsignl.S

Re: [Mingw-w64-public] [PATCH v2] crt: Use .def file aliases for _chgsignl on ARM targets.

2025-03-21 Thread Martin Storsjö
On Fri, 21 Mar 2025, Jacek Caban wrote: --- mingw-w64-crt/Makefile.am| 2 -- mingw-w64-crt/def-include/crt-aliases.def.in | 1 + .../lib-common/api-ms-win-crt-math-l1-1-0.def.in | 1 + mingw-w64-crt/math/arm/_chgsignl.S | 16 mingw-w64-cr

[Mingw-w64-public] [PATCH] winpthreads: fix typo pthread_attr_setgaurdsize->pthread_attr_setguardsize

2025-03-21 Thread Martin Storsjö
From: Alexander Argentakis <38327951+mfdgam...@users.noreply.github.com> --- Forwarding this fix from https://github.com/mingw-w64/mingw-w64/pull/82; it looks trivial enough to not require the submitter to subscribe for posting the patch themselves. --- mingw-w64-libraries/winpthreads/include/pth

Re: [Mingw-w64-public] [PATCH 1/2] crt: Build with -fno-builtin.

2025-03-21 Thread Jacek Caban
On 21.03.2025 18:39, LIU Hao wrote: 在 2025-3-21 23:25, Jacek Caban 写道: mingw-w64-crt implements a number of functions that the compiler considers built-in. Currently, we must be cautious about compiler optimizations, as they may not align with our intentions. In theory, the compiler could opti

Re: [Mingw-w64-public] [PATCH 2/2] crt: Implement sincos in C.

2025-03-21 Thread Martin Storsjö
On Fri, 21 Mar 2025, Jacek Caban wrote: --- mingw-w64-crt/Makefile.am | 20 +- mingw-w64-crt/math/arm-common/sincosl.c | 13 +++ mingw-w64-crt/math/arm/sincos.S | 32 mingw-w64-crt/math/arm/sincosf.S| 29 -- mingw-w64-crt/math/ar

Re: [Mingw-w64-public] [PATCH 07/11] crt, headers: Convert the UCRT *wprintf functions to non-inline

2025-03-21 Thread Martin Storsjö
On Fri, 21 Mar 2025, Martin Storsjö wrote: On Thu, 20 Mar 2025, Jacek Caban wrote: On 20.03.2025 18:54, Martin Storsjö wrote: +int __cdecl (*__MINGW_IMP_SYMBOL(snwprintf))(wchar_t *__restrict__, size_t, const wchar_t *__restrict__, ...) = snwprintf; Do we need those |__imp_| symbols in the

Re: [Mingw-w64-public] [PATCH 1/2] crt: Build with -fno-builtin.

2025-03-21 Thread LIU Hao
在 2025-3-21 23:25, Jacek Caban 写道: mingw-w64-crt implements a number of functions that the compiler considers built-in. Currently, we must be cautious about compiler optimizations, as they may not align with our intentions. In theory, the compiler could optimize an implementation of such a functi

Re: [Mingw-w64-public] [PATCH] Revert "ucrtbase: Make sure that compat symbols aren't autoexported"

2025-03-21 Thread Martin Storsjö
On Fri, 21 Mar 2025, Jacek Caban wrote: On 20.03.2025 23:24, Martin Storsjö wrote: This reverts commit 91459ac35276522b0e4405c76795d91822bb395a. That commit was a workaround for older binutils or LLD versions, that would otherwise autoexport symbols from the CRT libraries. Since 9d9c67b06c1bf