Re: [Mingw-w64-public] [PATCH] crt/delayimp: Make an IAT entry writeable before modifying it

2025-03-06 Thread Jeremy Drake via Mingw-w64-public
On Fri, 7 Mar 2025, LIU Hao wrote: > Ahh right. I have found my issue now. I was using a patched binutils like in > Wine [1]. It produced delay-import data which somehow worked if passed to > `ResolveDelayLoadedAPI()`, but the mingw-w64 implementation didn't like it. It > was not modifying the IAT

Re: [Mingw-w64-public] [PATCH] crt/delayimp: Make an IAT entry writeable before modifying it

2025-03-06 Thread LIU Hao
在 2025-3-7 06:51, Jeremy Drake via Mingw-w64-public 写道: Actaully, the test case I was starting with was delay loading from a non-existant module, and using the failure hook to load it. In the case of the ResolveDelayLoadedAPI function, it does not seem to save the function returned from the fail

Re: [Mingw-w64-public] stat, _stat, and _stat64i32 issues (was: dirent changes)

2025-03-06 Thread Pali Rohár
On Thursday 06 March 2025 21:40:55 Lasse Collin wrote: > On 2025-03-05 Pali Rohár wrote: > > As the discussion started, I decided to I looked at these issues. I > > have some WIP changes which defines 4 variants of each > > fstat/stat/wstat function, then provides also fstat, stat and wstat > > fun

Re: [Mingw-w64-public] [PATCH] crt/delayimp: Make an IAT entry writeable before modifying it

2025-03-06 Thread Jeremy Drake via Mingw-w64-public
On Thu, 6 Mar 2025, Jeremy Drake via Mingw-w64-public wrote: > On Thu, 6 Mar 2025, Jacek Caban wrote: > > > Relying on __delayLoadHelper2 behavior specific to mingw-w64 comes with > > drawbacks. As I mentioned earlier, an application can forward the call > > to ResolveDelayLoadedAPI, which will by

Re: [Mingw-w64-public] [PATCH] crt/delayimp: Make an IAT entry writeable before modifying it

2025-03-06 Thread Jeremy Drake via Mingw-w64-public
On Thu, 6 Mar 2025, Jacek Caban wrote: > Relying on __delayLoadHelper2 behavior specific to mingw-w64 comes with > drawbacks. As I mentioned earlier, an application can forward the call > to ResolveDelayLoadedAPI, which will bypass this change and fail to > work, while it previously worked with ea

Re: [Mingw-w64-public] stat, _stat, and _stat64i32 issues (was: dirent changes)

2025-03-06 Thread Lasse Collin
On 2025-03-05 Pali Rohár wrote: > As the discussion started, I decided to I looked at these issues. I > have some WIP changes which defines 4 variants of each > fstat/stat/wstat function, then provides also fstat, stat and wstat > function declaration in header file via __MINGW_ASM_CALL redirect an

Re: [Mingw-w64-public] [PATCH] headers: fix mpeg2data.h methods orders

2025-03-06 Thread Steve Lhomme
This seems to compile fine with that mpeg2struct.h On 05/03/2025 21:04, Biswapriyo Nath wrote: I have sent patch to wine to add the IDL files. Merge request link https://gitlab.winehq.org/wine/wine/-/merge_requests/7508. Please test those header files. The structures are defined in mpeg2data.h[1

Re: [Mingw-w64-public] [PATCH] crt/delayimp: Make an IAT entry writeable before modifying it

2025-03-06 Thread LIU Hao
在 2025-3-6 17:51, Jacek Caban 写道: On 5.03.2025 03:25, LIU Hao wrote: Second, in the future, if `IMAGE_GUARD_PROTECT_DELAYLOAD_IAT` is specified in `GuardFlags` of the load config directory of an image, the delay-load IAT can also be made read-only, which may also require this change. I think