Re: [Mingw-w64-public] stat, _stat, and _stat64i32 issues (was: dirent changes)

2025-02-27 Thread Pali Rohár
On Thursday 27 February 2025 22:36:20 Lasse Collin wrote: > On 2025-02-27 Vincent Torri wrote: > > maybe GetFileInformationByHandle instead of stat ? > > There are valid reasons to use a completely different implementation of > stat. My post wasn't about creating a new one, it's about correctly >

Re: [Mingw-w64-public] stat, _stat, and _stat64i32 issues (was: dirent changes)

2025-02-27 Thread Lasse Collin
On 2025-02-27 Vincent Torri wrote: > maybe GetFileInformationByHandle instead of stat ? There are valid reasons to use a completely different implementation of stat. My post wasn't about creating a new one, it's about correctly supporting the existing CRT functions in mingw-w64. Currently mingw-w6

Re: [Mingw-w64-public] stat, _stat, and _stat64i32 issues (was: dirent changes)

2025-02-27 Thread Pali Rohár
On Thursday 27 February 2025 20:58:40 Vincent Torri wrote: > maybe GetFileInformationByHandle instead of stat ? *ByHandle function is supposed to be for *f*stat. Handle represents the opened file, in the state way as C/POSIX file descriptor. Moreover once we have the opened handle, we can convert

Re: [Mingw-w64-public] stat, _stat, and _stat64i32 issues (was: dirent changes)

2025-02-27 Thread Pali Rohár
On Thursday 27 February 2025 21:45:51 Lasse Collin wrote: > On 2025-02-25 Pali Rohár wrote: > > On Tuesday 25 February 2025 20:11:12 Lasse Collin wrote: > > > MSVCRT's _stat() fails with "directory/", but in POSIX a trailing > > > slash should work for directories (and only for directories). > > >

Re: [Mingw-w64-public] [PATCH] Add missing comparison operators for Microsoft::WRL::ComPtr

2025-02-27 Thread Jøger Hansegård via Mingw-w64-public
Thank you for letting me know! See patch below and hopefully attached. Jøger From 846b0e09a9b48396eabe86a688d56e85906fe212 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?J=C3=B8ger=20Hanseg=C3=A5rd?= mailto:joger.hanseg...@qt.io Date: Thu, 27 Feb 2025 17:12:09 +0100 Subject: [PATCH] Add missing compari

Re: [Mingw-w64-public] stat, _stat, and _stat64i32 issues (was: dirent changes)

2025-02-27 Thread Vincent Torri
maybe GetFileInformationByHandle instead of stat ? Vincent Torri On Thu, Feb 27, 2025 at 8:47 PM Lasse Collin wrote: > > On 2025-02-25 Pali Rohár wrote: > > On Tuesday 25 February 2025 20:11:12 Lasse Collin wrote: > > > MSVCRT's _stat() fails with "directory/", but in POSIX a trailing > > > sla

[Mingw-w64-public] stat, _stat, and _stat64i32 issues (was: dirent changes)

2025-02-27 Thread Lasse Collin
On 2025-02-25 Pali Rohár wrote: > On Tuesday 25 February 2025 20:11:12 Lasse Collin wrote: > > MSVCRT's _stat() fails with "directory/", but in POSIX a trailing > > slash should work for directories (and only for directories). > > mingw-w64-crt/stdio/_stat.c provides stat() that, with some > > exce

Re: [Mingw-w64-public] [PATCH] Add missing comparison operators for Microsoft::WRL::ComPtr

2025-02-27 Thread Zach Bacon
You forgot to attach the patch On Thu, Feb 27, 2025, 12:53 p.m. Jøger Hansegård via Mingw-w64-public < mingw-w64-public@lists.sourceforge.net> wrote: > The current MinGW implementation of Microsoft::WRL::ComPtr does not have > comparison operators. Attempting to compare two ComPtr instances will

[Mingw-w64-public] [PATCH] Add missing comparison operators for Microsoft::WRL::ComPtr

2025-02-27 Thread Jøger Hansegård via Mingw-w64-public
The current MinGW implementation of Microsoft::WRL::ComPtr does not have comparison operators. Attempting to compare two ComPtr instances will implicitly convert the ComPtr to bool, and comparison is performed against the resulting two bool values. This means that any two non-null ComPtr instances