Re: [Mingw-w64-public] dirent changes

2025-02-16 Thread Pali Rohár
On Sunday 16 February 2025 19:32:24 Lasse Collin wrote: > On 2025-02-16 Pali Rohár wrote: > > On Sunday 16 February 2025 12:23:56 Lasse Collin wrote: > > > On 2025-02-15 Pali Rohár wrote: > > > > IMHO, we should not use FILE_ATTRIBUTE_* for determining d_type > > > > (except the FILE_ATTRIBUTE_DI

Re: [Mingw-w64-public] dirent changes

2025-02-16 Thread Lasse Collin
On 2025-02-16 Pali Rohár wrote: > On Sunday 16 February 2025 12:23:56 Lasse Collin wrote: > > On 2025-02-15 Pali Rohár wrote: > > > IMHO, we should not use FILE_ATTRIBUTE_* for determining d_type > > > (except the FILE_ATTRIBUTE_DIRECTORY which defines directory). > > > Those are basically attrib

[Mingw-w64-public] missing _isblank_l and _iswblank_l symbols

2025-02-16 Thread Kirill Makurin
Hi, mingw-w64's `ctype.c` and `wchar.h` are respectively missing declaration of `_isblank_l` and `_iswblank_l` symbols. - Kirill Makurin ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listi

[Mingw-w64-public] winpthreads: remove include of sys/timeb.h from public header files

2025-02-16 Thread Kirill Makurin
The `pthread.h`, `pthread_time.h` and `sched.h` include `sys/timeb.h`. The `ftime` function was marked obsolete and later removed in POSIX 2008. I don't see any reason to include this header file unless some legacy projects rely on `ftime` being available when including `pthread.h`, which seems

Re: [Mingw-w64-public] [RFC PATCH 2/2] crt: Merge lib32/ws2_32.def into lib-common/ws2_32.def.in

2025-02-16 Thread Pali Rohár
On Wednesday 12 February 2025 22:31:03 Martin Storsjö wrote: > On Wed, 29 Jan 2025, Pali Rohár wrote: > > > On Monday 30 December 2024 22:48:25 Pali Rohár wrote: > > > On Sunday 29 December 2024 17:46:22 Martin Storsjö wrote: > > > > On Sat, 14 Dec 2024, Pali Rohár wrote: > > > > > > > > > Now al

[Mingw-w64-public] [PATCH v2 2/2] crt: Merge lib32/ws2_32.def into lib-common/ws2_32.def.in

2025-02-16 Thread Pali Rohár
Now all I386 symbols in lib-common/ws2_32.def.in file are defined with stdcall @ suffixes. These suffixes are automatically removed for non-I386 builds by Makefile.am rule during processing of lib-common/*.def.in files. During merging of lib32/ws2_32.def and lib-common/ws2_32.def.in files, all sym

[Mingw-w64-public] [PATCH v2 1/2] crt: Remove @ stdcall mangling when processing lib-common/*.def.in files for non-I386 builds

2025-02-16 Thread Pali Rohár
This allows to define in lib-common/*.def.in files symbols with I386 stdcall @ suffixes and therefore have one common def file for all platforms. Removal of @ suffixes is done by following sed regex: sed -E 's/^([^ ]+)@[0-9]+( |$)/\1\2/' Note that dollar character in Makefile is duplicated t

Re: [Mingw-w64-public] dirent changes

2025-02-16 Thread Pali Rohár
On Sunday 16 February 2025 12:23:56 Lasse Collin wrote: > On 2025-02-15 Pali Rohár wrote: > > IMHO, we should not use FILE_ATTRIBUTE_* for determining d_type > > (except the FILE_ATTRIBUTE_DIRECTORY which defines directory). Those > > are basically attributes which do not define file type in POSIX

Re: [Mingw-w64-public] make sure WINPTHREAD_API is correctly defined in pthread_time.h

2025-02-16 Thread Kirill Makurin
Here's the updated patch. I also used `$(INSTALL_DATA)` instead of `$(LN_S)` which I think makes more sense. - Kirill Makurin From: LIU Hao Sent: Sunday, February 16, 2025 8:46 PM To: Kirill Makurin; mingw-w64-public@lists.sourceforge.net Subject: Re: [Mingw-w64-

Re: [Mingw-w64-public] make sure WINPTHREAD_API is correctly defined in pthread_time.h

2025-02-16 Thread Kirill Makurin
What do you think about usage of `$(LN_S)` in install-exec-hook? I'm not fan of it because if the library will be built from Cygwin environment it'll create actual symbolic links which cannot be read by native applications. - Kirill Makurin From: LIU Hao Sent: S

Re: [Mingw-w64-public] make sure WINPTHREAD_API is correctly defined in pthread_time.h

2025-02-16 Thread LIU Hao
在 2025-02-16 19:38, Kirill Makurin 写道: If you're good with that patch, I would like to update it to also remove lines in `configure.ac` which define `COPY_STATIC` and `COPY_SHARED` Automake conditionals. Let me know what you decide. Yes it makes sense. `LT_OBJDIR` also seems unused thereafte

Re: [Mingw-w64-public] make sure WINPTHREAD_API is correctly defined in pthread_time.h

2025-02-16 Thread Kirill Makurin
If you're good with that patch, I would like to update it to also remove lines in `configure.ac` which define `COPY_STATIC` and `COPY_SHARED` Automake conditionals. Let me know what you decide. - Kirill Makurin From: Kirill Makurin Sent: Sunday, February 16, 202

Re: [Mingw-w64-public] dirent changes

2025-02-16 Thread Lasse Collin
On 2025-02-15 Pali Rohár wrote: > IMHO, we should not use FILE_ATTRIBUTE_* for determining d_type > (except the FILE_ATTRIBUTE_DIRECTORY which defines directory). Those > are basically attributes which do not define file type in POSIX sense > at all. There are still few attributes not defined yet,