Re: [Mingw-w64-public] winpthreads and MSVC

2025-01-30 Thread LIU Hao
在 2025-01-31 15:02, Kirill Makurin 写道: I think `"pthread_time.h"` makes more sense when including headers from the source tree? Hmm, that's true in general. I think the updated patch is acceptable. -- Best regards, LIU Hao OpenPGP_signature.asc Description: OpenPGP digital signature __

Re: [Mingw-w64-public] winpthreads and MSVC

2025-01-30 Thread Kirill Makurin
I would like to mention that `WINPTHREAD_API` for `__pth_gpointer_locked` does not make sense to me. The `WINPTHREAD_API` expands into `declspec(dllexport)` when building the shared library, however `__pth_gpointer_locked` seems to be an internal function. Also, the `__pth_gpointer_locked` is a

Re: [Mingw-w64-public] winpthreads and MSVC

2025-01-30 Thread Kirill Makurin
I think `"pthread_time.h"` makes more sense when including headers from the source tree? From: LIU Hao Sent: Friday, January 31, 2025 3:57 PM To: Kirill Makurin; mingw-w64-public@lists.sourceforge.net Subject: Re: [Mingw-w64-public] winpthreads and MSVC 在 2025-0

Re: [Mingw-w64-public] winpthreads and MSVC

2025-01-30 Thread LIU Hao
在 2025-01-31 14:48, Kirill Makurin 写道: I assume `getntptimeofday` is provided by mingw-w64 runtime. Maybe author of the test did not want to use winpthreads' `clock_gettime` for the test? Anyway, I attached a patch which replaces calls to `getntptimeofday` with calls to `clock_gettime`. I thin

Re: [Mingw-w64-public] winpthreads and MSVC

2025-01-30 Thread Kirill Makurin
I assume `getntptimeofday` is provided by mingw-w64 runtime. Maybe author of the test did not want to use winpthreads' `clock_gettime` for the test? Anyway, I attached a patch which replaces calls to `getntptimeofday` with calls to `clock_gettime`. I think the only downside of using `clock_getti

Re: [Mingw-w64-public] winpthreads and MSVC

2025-01-30 Thread LIU Hao
在 2025-01-30 19:20, Jonathan Yong 写道: The 2 patches look OK to me, I'll wait for feed back from the others. The second patch introduces a private implementation of `getntptimeofday()` that does not write anything into `*tz`. Although all calls to this function in that file pass null pointers f

Re: [Mingw-w64-public] winpthreads and MSVC

2025-01-30 Thread Jonathan Yong
On 1/30/25 3:02 AM, Kirill Makurin wrote: Yes, no problem. I also had a patch for Makefile.am which tried to solve the alias issue by copying `[lib]winpthreads[.dll].{lib|a}` as `[lib]pthread[.dll].{lib|a}` during installation. I can send it again. I see. I could maintain a GitHub repository

[Mingw-w64-public] [PATCH] headers/dxvahd: Add missing WINAPI on DXVAHD_CreateDevice()

2025-01-30 Thread Steve Lhomme
--- mingw-w64-headers/include/dxvahd.idl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mingw-w64-headers/include/dxvahd.idl b/mingw-w64-headers/include/dxvahd.idl index 607f3778e..519e9ed3c 100644 --- a/mingw-w64-headers/include/dxvahd.idl +++ b/mingw-w64-headers/include/dxv