Re: [Mingw-w64-public] getmainargs changes

2024-11-09 Thread Pali Rohár
On Saturday 09 November 2024 21:30:53 Lasse Collin wrote: > On 2024-11-09 LIU Hao wrote: > > Really, I don't think this should be fixed in the CRT. It should be > > fixed by sanitizing the result in `GetCommandLineA()`. Reverting the > > commit makes sense if Microsoft will fix it sooner or latter.

Re: [Mingw-w64-public] getmainargs changes

2024-11-09 Thread Pali Rohár
On Saturday 09 November 2024 22:39:08 LIU Hao wrote: > 在 2024-11-09 02:23, Pali Rohár 写道: > > On Friday 08 November 2024 19:49:24 Lasse Collin wrote: > > > Hello! > > > > > > I apologize for the hassle. :-( It's a security issue that (I think) is > > > only half-public, so I didn't want to post to

Re: [Mingw-w64-public] getmainargs changes

2024-11-09 Thread Pali Rohár
On Saturday 09 November 2024 22:39:08 LIU Hao wrote: > 在 2024-11-09 02:23, Pali Rohár 写道: > > On Friday 08 November 2024 19:49:24 Lasse Collin wrote: > > > Hello! > > > > > > I apologize for the hassle. :-( It's a security issue that (I think) is > > > only half-public, so I didn't want to post to

Re: [Mingw-w64-public] getmainargs changes

2024-11-09 Thread Pali Rohár
Hello, now, when looking at this issue, I have figured out that in mingw-w64 is declaration of __getmainargs() and __wgetmainargs() functions incompatible with msvcrt.dll library. In header file mingw-w64-crt/include/internal.h is: _CRTIMP int __cdecl __getmainargs(int * _Argc, char *** _Argv, ch

Re: [Mingw-w64-public] getmainargs changes

2024-11-09 Thread LIU Hao
在 2024-11-09 02:23, Pali Rohár 写道: On Friday 08 November 2024 19:49:24 Lasse Collin wrote: Hello! I apologize for the hassle. :-( It's a security issue that (I think) is only half-public, so I didn't want to post to the public mailing list. Apparently the tiny group of people I discussed this w