Re: [Mingw-w64-public] [PATCH 2/2] crt: Define few UCRT symbols for msvcrt builds

2024-10-10 Thread Pali Rohár
On Thursday 10 October 2024 20:45:11 Martin Storsjö wrote: > On Thu, 10 Oct 2024, Pali Rohár wrote: > > > On Thursday 10 October 2024 15:14:22 Martin Storsjö wrote: > > > On Sat, 28 Sep 2024, Pali Rohár wrote: > > > > > > > Add symbols __initialize_lconv_for_unsigned_char, _query_app_type and > >

Re: [Mingw-w64-public] [PATCH 2/2] crt: Define few UCRT symbols for msvcrt builds

2024-10-10 Thread Martin Storsjö
On Thu, 10 Oct 2024, Pali Rohár wrote: On Thursday 10 October 2024 15:14:22 Martin Storsjö wrote: On Sat, 28 Sep 2024, Pali Rohár wrote: Add symbols __initialize_lconv_for_unsigned_char, _query_app_type and _set_app_type into msvcrt import libs. --- mingw-w64-crt/def-include/crt-aliases.def.i

Re: [Mingw-w64-public] [PATCH 2/2] crt: Define few UCRT symbols for msvcrt builds

2024-10-10 Thread Pali Rohár
On Thursday 10 October 2024 15:14:22 Martin Storsjö wrote: > On Sat, 28 Sep 2024, Pali Rohár wrote: > > > Add symbols __initialize_lconv_for_unsigned_char, _query_app_type and > > _set_app_type into msvcrt import libs. > > --- > > mingw-w64-crt/def-include/crt-aliases.def.in | 13 + > >

Re: [Mingw-w64-public] [PATCH 1/2] crt: Define msvcrt __get_app_type symbol for UCRT builds

2024-10-10 Thread Pali Rohár
On Thursday 10 October 2024 15:08:09 Martin Storsjö wrote: > On Sat, 28 Sep 2024, Pali Rohár wrote: > > > msvcr80.dll and msvcr90.dll provides __get_app_type() function which > > returns the application type set by the __set_app_type() function. > > > > UCRT has this symbol named _query_app_type.

Re: [Mingw-w64-public] [PATCH] headers: Add new symbols in tbs.h

2024-10-10 Thread Biswapriyo Nath
I have attached the patch file with WINBOOL. From 5aa4585aa6e76d6806fc03a7ac9bd59cd90c67d6 Mon Sep 17 00:00:00 2001 From: Biswapriyo Nath Date: Thu, 10 Oct 2024 16:05:10 + Subject: [PATCH] headers: Add new symbols in tbs.h Fixes https://github.com/mingw-w64/mingw-w64/issues/62 Signed-off-by:

Re: [Mingw-w64-public] [PATCH] crt: Add new APIs in cfgmgr32 import library

2024-10-10 Thread Biswapriyo Nath
I just copied the generated DEF. Should I create another commit to comment out those CMP_ functions? The 'P' in CMP_ probably means private. ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/lis

Re: [Mingw-w64-public] [PATCH] headers: Add new symbols in tbs.h

2024-10-10 Thread Biswapriyo Nath
> `BOOL` should be `WINBOOL` I think? Would not that cause any compiler warning or error if those functions are called with BOOL typed arguments? ___ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lis

Re: [Mingw-w64-public] [PATCH] headers: Add new symbols in tbs.h

2024-10-10 Thread LIU Hao
在 2024-10-10 14:24, Biswapriyo Nath 写道: +typedef INT32 BOOL, *PBOOL; +typedef const BOOL *PCBOOL; + +typedef UINT8 BYTE, *PBYTE; +typedef const BYTE *PCBYTE; + +typedef BOOL TBS_BOOL; `BOOL` should be `WINBOOL` I think? -- Best regards, LIU Hao OpenPGP_signature.asc Description: OpenPGP dig

Re: [Mingw-w64-public] [PATCH] crt: Add new APIs in cfgmgr32 import library

2024-10-10 Thread LIU Hao
在 2024-10-10 00:20, Biswapriyo Nath 写道: diff --git a/mingw-w64-crt/lib-common/cfgmgr32.def b/mingw-w64-crt/lib-common/cfgmgr32.def index 2d81a70..71e1226 100644 --- a/mingw-w64-crt/lib-common/cfgmgr32.def +++ b/mingw-w64-crt/lib-common/cfgmgr32.def @@ -7,8 +7,9 @@ LIBRARY "CFGMGR32.dll" EXPORT

Re: [Mingw-w64-public] [PATCH] headers/{ctype, wchar}: Only declare `_*_l` for MSVCRT >= 0x800 and UCRT

2024-10-10 Thread LIU Hao
在 2024-10-10 20:27, Martin Storsjö 写道: So I guess this is fine, as a consistency extension on what we already have. It's a bit unclear to me what the real issue in https://github.com/mingw-w64/mingw-w64/issues/60 is though, and how this fixes it, because those macros are still going to be unava

Re: [Mingw-w64-public] [PATCH] headers: Do not include pthread headers when the threading model is not POSIX

2024-10-10 Thread Martin Storsjö
On Thu, 10 Oct 2024, Jacek Caban wrote: On 10.10.2024 13:15, Martin Storsjö wrote: On Thu, 10 Oct 2024, Julian Waters wrote: That said - for a non-pthreads thread model GCC, or with Clang, one has to manually link against winpthread to practically use nanosleep() or clock_gettime(), as that'

Re: [Mingw-w64-public] [PATCH] headers: Do not include pthread headers when the threading model is not POSIX

2024-10-10 Thread Jacek Caban
On 10.10.2024 13:15, Martin Storsjö wrote: On Thu, 10 Oct 2024, Julian Waters wrote: Ah, you're right. It is indeed the PKGBUILD that deletes the pthread headers wheninstallinghttps://github.com/msys2/MINGW-packages/blob/16721b39ef3cd7089d73 04324d6afc051008772a/mingw-w64-headers-git/PKGBUIL

Re: [Mingw-w64-public] [PATCH] headers/{ctype, wchar}: Only declare `_*_l` for MSVCRT >= 0x800 and UCRT

2024-10-10 Thread Martin Storsjö
On Mon, 30 Sep 2024, LIU Hao wrote: These functions and macros were added in MSVCR80.DLL and were not available in MSVCRT.DLL from Windows XP. This closes https://github.com/mingw-w64/mingw-w64/issues/60. It's worth pointing out that the msvcrt.dll that is shipped along with the OS does not

Re: [Mingw-w64-public] [PATCH 2/2] crt: Define few UCRT symbols for msvcrt builds

2024-10-10 Thread Martin Storsjö
On Sat, 28 Sep 2024, Pali Rohár wrote: Add symbols __initialize_lconv_for_unsigned_char, _query_app_type and _set_app_type into msvcrt import libs. --- mingw-w64-crt/def-include/crt-aliases.def.in | 13 + mingw-w64-crt/lib32/crtdll.def.in| 2 ++ mingw-w64-crt/lib32/msvcr80

Re: [Mingw-w64-public] [PATCH 1/2] crt: Define msvcrt __get_app_type symbol for UCRT builds

2024-10-10 Thread Martin Storsjö
On Sat, 28 Sep 2024, Pali Rohár wrote: msvcr80.dll and msvcr90.dll provides __get_app_type() function which returns the application type set by the __set_app_type() function. UCRT has this symbol named _query_app_type. So add alias into UCRT def files for compatibility. --- mingw-w64-crt/def-in

Re: [Mingw-w64-public] [PATCH 5/5] crt: Rename file ucrt_compat.c to ucrt_tzset.c

2024-10-10 Thread LIU Hao
在 2024-10-10 19:58, Martin Storsjö 写道: On Sat, 28 Sep 2024, Pali Rohár wrote: Now this file contains only tzset() and _tzset() functions and tzname/timezone/daylight global variables. --- mingw-w64-crt/Makefile.am  | 2 +- mingw-w64-crt/def-include/crt-aliases.def.in 

Re: [Mingw-w64-public] [PATCH 5/5] crt: Rename file ucrt_compat.c to ucrt_tzset.c

2024-10-10 Thread Martin Storsjö
On Sat, 28 Sep 2024, Pali Rohár wrote: Now this file contains only tzset() and _tzset() functions and tzname/timezone/daylight global variables. --- mingw-w64-crt/Makefile.am | 2 +- mingw-w64-crt/def-include/crt-aliases.def.in | 8 mingw-w64-crt/misc/{ucrt_

Re: [Mingw-w64-public] [PATCH] headers: Do not include pthread headers when the threading model is not POSIX

2024-10-10 Thread Martin Storsjö
On Thu, 10 Oct 2024, Julian Waters wrote: Ah, you're right. It is indeed the PKGBUILD that deletes the pthread headers wheninstallinghttps://github.com/msys2/MINGW-packages/blob/16721b39ef3cd7089d73 04324d6afc051008772a/mingw-w64-headers-git/PKGBUILD#L60 I do wonder if winpthreads and the mingw

Re: [Mingw-w64-public] [PATCH] headers: Do not include pthread headers when the threading model is not POSIX

2024-10-10 Thread Julian Waters
Ah, you're right. It is indeed the PKGBUILD that deletes the pthread headers when installing https://github.com/msys2/MINGW-packages/blob/16721b39ef3cd7089d7304324d6afc051008772a/mingw-w64-headers-git/PKGBUILD#L60 I do wonder if winpthreads and the mingw-w64-headers do install the headers in the e

Re: [Mingw-w64-public] [PATCH] headers: Do not include pthread headers when the threading model is not POSIX

2024-10-10 Thread Martin Storsjö
On Thu, 10 Oct 2024, Julian Waters wrote: This allows for gcc with other thread models to use certain standard library headers without needing to install winpthreads headers to avoid compilation errors. That this sounds like a packaging issue to me. I'm not (yet) saying that we should or sho

Re: [Mingw-w64-public] [PATCH] Use gitattributes to force LF line endings on shell scripts

2024-10-10 Thread Antonin Décimo
> Frankly speaking, I don't agree with that. Are you disagreeing about the default autocrlf setting, or about forcing LF on shell scripts? I don't have a strong opinion on the autocrlf setting. I do have a strong opinion on forcing LF on shell scripts. I think this helps when dealing with unconfig

[Mingw-w64-public] [PATCH] headers: Do not include pthread headers when the threading model is not POSIX

2024-10-10 Thread Julian Waters
I added the ability to check if the thread model is POSIX to gcc a while back. This means our headers can now check for it and not include winpthreads specific headers if they are not required for the current thread model. This allows for gcc with other thread models to use certain standard libr

[Mingw-w64-public] [PATCH] crt: Add new API in tbs import library

2024-10-10 Thread Biswapriyo Nath
From c564796e5adef031a6656db09bb2ed0c8a418414 Mon Sep 17 00:00:00 2001 From: Biswapriyo Nath Date: Thu, 10 Oct 2024 07:33:29 + Subject: [PATCH] crt: Add new API in tbs import library Signed-off-by: Biswapriyo Nath --- mingw-w64-crt/lib-common/tbs.def | 1 + mingw-w64-crt/lib32/tbs.def